)]}'
{"cyborg/common/constants.py":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"c35b2d0a1b341b38d45a5f2d0fe9c7b44ca385a6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"DEVICE_GPU \u003d \u0027GPU\u0027"},{"line_number":20,"context_line":"DEVICE_FPGA \u003d \u0027FPGA\u0027"},{"line_number":21,"context_line":"DEVICE_NPU \u003d \u0027NPU\u0027"},{"line_number":22,"context_line":"DEVICE_GENERIC \u003d \u0027GENERIC\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ARQ_STATES \u003d (ARQINITIAL, ARQBOUND, ARQUNBOUND, ARQBINDFAILED) \u003d \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_d8d372d4","line":22,"updated":"2019-05-24 16:49:17.000000000","message":"I don\u0027t follow this concept of a \u0027generic device\u0027. Every device that we support will have specific properties (like vendor, model name, PCI IDs, etc.). \n\nThe generic driver is only a base driver and doesn\u0027t correspond to a device.","commit_id":"f563b7e32e13d32ed262a3fbbc9f519815a75132"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"23c6dcbbe4f046e44723fb54ca37317d157c695a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"DEVICE_GPU \u003d \u0027GPU\u0027"},{"line_number":20,"context_line":"DEVICE_FPGA \u003d \u0027FPGA\u0027"},{"line_number":21,"context_line":"DEVICE_NPU \u003d \u0027NPU\u0027"},{"line_number":22,"context_line":"DEVICE_GENERIC \u003d \u0027GENERIC\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ARQ_STATES \u003d (ARQINITIAL, ARQBOUND, ARQUNBOUND, ARQBINDFAILED) \u003d \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_9045ca45","line":22,"in_reply_to":"bfb3d3c7_d8d372d4","updated":"2019-05-25 02:18:34.000000000","message":"OK, I will remove this GENERIC","commit_id":"f563b7e32e13d32ed262a3fbbc9f519815a75132"}],"cyborg/db/sqlalchemy/models.py":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"c35b2d0a1b341b38d45a5f2d0fe9c7b44ca385a6","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":77,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":78,"context_line":"    type \u003d Column(Enum(\u0027GPU\u0027, \u0027FPGA\u0027, \u0027NPU\u0027, \u0027GENERIC\u0027,"},{"line_number":79,"context_line":"                       name\u003d\u0027device_type\u0027), nullable\u003dFalse)"},{"line_number":80,"context_line":"    vendor \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":81,"context_line":"    model \u003d Column(String(255), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_587b02bd","line":78,"updated":"2019-05-24 16:49:17.000000000","message":"The name NPU seems generic. It can stand for \u0027Network Processing Unit\u0027 [1][2] or \u0027Numeric Processing Unit\u0027 [2]. Some people call it a \u0027Neural Network Processor\u0027. Maybe we can call it Neural_NPU to cover everybody? \n\nAlso, we should reuse the constants instead of duplicating code.\n\n[1] https://www.techopedia.com/definition/8556/network-processor-npu\n[2] https://en.wikipedia.org/wiki/NPU","commit_id":"f563b7e32e13d32ed262a3fbbc9f519815a75132"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"23c6dcbbe4f046e44723fb54ca37317d157c695a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":77,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":78,"context_line":"    type \u003d Column(Enum(\u0027GPU\u0027, \u0027FPGA\u0027, \u0027NPU\u0027, \u0027GENERIC\u0027,"},{"line_number":79,"context_line":"                       name\u003d\u0027device_type\u0027), nullable\u003dFalse)"},{"line_number":80,"context_line":"    vendor \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":81,"context_line":"    model \u003d Column(String(255), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_f06d26cc","line":78,"in_reply_to":"bfb3d3c7_587b02bd","updated":"2019-05-25 02:18:34.000000000","message":"Yes, agree. and after consideration, I think maybe \"AICHIP\" in here is more suitable.","commit_id":"f563b7e32e13d32ed262a3fbbc9f519815a75132"}],"cyborg/objects/device.py":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"c35b2d0a1b341b38d45a5f2d0fe9c7b44ca385a6","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DEVICE_TYPE \u003d [\"GPU\", \"FPGA\", \"NPU\", \"GENERIC\"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@base.CyborgObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_f81bd67d","line":27,"updated":"2019-05-24 16:49:17.000000000","message":"I understand you are only adding to a pre-existing line. But this is a duplicate of the constants defined elsewehre. I suggest we should define DEVICE_TYPE in common/constants.py and re-use it everywhere.","commit_id":"f563b7e32e13d32ed262a3fbbc9f519815a75132"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"23c6dcbbe4f046e44723fb54ca37317d157c695a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DEVICE_TYPE \u003d [\"GPU\", \"FPGA\", \"NPU\", \"GENERIC\"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@base.CyborgObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_10731ab3","line":27,"in_reply_to":"bfb3d3c7_f81bd67d","updated":"2019-05-25 02:18:34.000000000","message":"OK, good suggestion, and I will do it in follow up.","commit_id":"f563b7e32e13d32ed262a3fbbc9f519815a75132"}]}