)]}'
{"id":"openstack%2Fcyborg~674536","triplet_id":"openstack%2Fcyborg~master~If8eca0bcc187aed9fb2ef6794171a1acbc202079","project":"openstack/cyborg","branch":"master","topic":"ascend","hashtags":[],"change_id":"If8eca0bcc187aed9fb2ef6794171a1acbc202079","subject":"Add bindep support","status":"MERGED","created":"2019-08-05 06:38:47.000000000","updated":"2019-08-09 08:27:04.000000000","submitted":"2019-08-09 08:27:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674536-1565339224619-eb0b3e6e","meta_rev_id":"f83c76c86e47f88325ead94654a82f09ec72f470","_number":674536,"virtual_id_number":674536,"owner":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-09 08:27:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"date":"2019-08-06 03:32:25.000000000","_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-09 07:22:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-09 08:15:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-09 08:15:37.000000000","updated_by":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"reviewer":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"state":"REVIEWER"},{"updated":"2019-08-09 08:27:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fab5b5697ae14874dd9aa0f9965dbeadb315b4b9","author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"date":"2019-08-05 06:38:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"884843e550de45cf69851ae8fbec8f4d692c4ddd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-05 07:14:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://logs.opendev.org/36/674536/1/check/build-openstack-api-ref/f93d577/html/ : SUCCESS in 3m 32s\n- openstack-tox-pep8 https://logs.opendev.org/36/674536/1/check/openstack-tox-pep8/a75daec/ : SUCCESS in 4m 44s\n- openstack-tox-py27 https://logs.opendev.org/36/674536/1/check/openstack-tox-py27/8f78754/ : SUCCESS in 4m 10s\n- build-openstack-releasenotes https://logs.opendev.org/36/674536/1/check/build-openstack-releasenotes/3db0252/html/ : SUCCESS in 3m 33s\n- openstack-tox-docs https://logs.opendev.org/36/674536/1/check/openstack-tox-docs/d07facb/html/ : SUCCESS in 4m 21s\n- cyborg-devstack https://logs.opendev.org/36/674536/1/check/cyborg-devstack/53b003b/ : SUCCESS in 32m 54s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6af2de7950b8562d3f554627d608c9324a35e890","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2019-08-05 21:02:50.000000000","message":"Patch Set 1: Code-Review-1\n\nThis is broadly a good idea. However, lspci is needed by specific drivers, which may be disabled in the config file. Not sure if we want to put all those dependencies here.","accounts_in_message":[],"_revision_number":1},{"id":"daaae20b81113e1e6a0f1049c1bc947f54e35a63","author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"date":"2019-08-06 03:32:25.000000000","message":"Patch Set 1:\n\n\u003e This is broadly a good idea. However, lspci is needed by specific\n \u003e drivers, which may be disabled in the config file. Not sure if we\n \u003e want to put all those dependencies here.\n\nIMO, the bindep can make sure that the final package contains the lspci, and the zun project do the same thing, and lspci is the generic cmd, which would be used in any pci device, so I think it\u0027s okay in here. And your thoughts? Maybe I can raise it in weekly meeting to get more idea from team.\n\n[1]https://github.com/openstack/zun/blob/master/bindep.txt#L40","accounts_in_message":[],"_revision_number":1},{"id":"7c6408f65e4f458cac53cf5b72721b2c7176c3d7","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2019-08-09 07:22:33.000000000","message":"Patch Set 1: Code-Review+2\n\nFollowing IRC discussion [1], we have agreed on this approach.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-cyborg/%23openstack-cyborg.2019-08-07.log.html#t2019-08-07T03:34:10","accounts_in_message":[],"_revision_number":1},{"id":"e908a43ce0d5a50caf374ca6bb153490412f3671","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2019-08-09 08:15:37.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"609fdad2c2e36c35b4f4a193d807456d57333aa6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 08:15:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"80ab7bf295e6bd0745af0c48dfba156eac6573aa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 08:27:04.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"c58c252e7c550df5d470e22c7b7544e03e6f61b3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 08:27:04.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-api-ref https://logs.opendev.org/36/674536/1/gate/build-openstack-api-ref/4afea90/html/ : SUCCESS in 4m 15s\n- openstack-tox-pep8 https://logs.opendev.org/36/674536/1/gate/openstack-tox-pep8/8bca563/ : SUCCESS in 4m 41s\n- openstack-tox-py27 https://logs.opendev.org/36/674536/1/gate/openstack-tox-py27/73de634/ : SUCCESS in 3m 50s\n- build-openstack-releasenotes https://logs.opendev.org/36/674536/1/gate/build-openstack-releasenotes/7aa3d34/html/ : SUCCESS in 3m 06s\n- openstack-tox-docs https://logs.opendev.org/36/674536/1/gate/openstack-tox-docs/7061681/html/ : SUCCESS in 3m 14s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7a4c80e7e2507e8bdf5b76f29eb7e13d13e78140","revisions":{"7a4c80e7e2507e8bdf5b76f29eb7e13d13e78140":{"kind":"REWORK","_number":1,"created":"2019-08-05 06:38:47.000000000","uploader":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"ref":"refs/changes/36/674536/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/36/674536/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/36/674536/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/36/674536/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/36/674536/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/36/674536/1"}}},"commit":{"parents":[{"commit":"d88068f3c2a15527eda0859a7d96ab4530e58d63","subject":"Merge \"P2: Changes for db layer, constants and exceptions.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/d88068f3c2a15527eda0859a7d96ab4530e58d63"}]}],"author":{"name":"Yikun Jiang","email":"yikunkero@gmail.com","date":"2019-08-05 06:30:14.000000000","tz":480},"committer":{"name":"Yikun Jiang","email":"yikunkero@gmail.com","date":"2019-08-05 06:31:35.000000000","tz":480},"subject":"Add bindep support","message":"Add bindep support\n\nAdd an bindep.txt file containing a cross-platform list of\ndependencies needed for running included tox-based tests. Also include a\ntox environment for convenience calling the bindep[*] utility to list\nany missing system requirements.\n\nCyborg requires package \u0027pciutils\u0027 because it is required for running\n\u0027lspci\u0027 command, this patch also add it.\n\n[*] http://docs.openstack.org/infra/bindep/\n\nChange-Id: If8eca0bcc187aed9fb2ef6794171a1acbc202079\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/7a4c80e7e2507e8bdf5b76f29eb7e13d13e78140"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/7a4c80e7e2507e8bdf5b76f29eb7e13d13e78140"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}