)]}'
{"cyborg/accelerator/drivers/fpga/intel/sysinfo.py":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"993e50829bb36d36c86513edf4a59021325d514d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \"fpga\": RC_FPGA"},{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"VENDOR_MAPS \u003d {\"0x8086\": \"intel\"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def read_line(filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6c2faf3e","line":58,"updated":"2019-08-22 11:03:03.000000000","message":"Why do we need this? This is the Cyborg driver for Intel OPAE/FPGA. So, we can just set the driver name to intel.","commit_id":"c0a97bbc075bd5fe9189fcbd88d85388742e74fc"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"1a8b30f2256516eabf6167a54e348716864be35e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \"fpga\": RC_FPGA"},{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"VENDOR_MAPS \u003d {\"0x8086\": \"intel\"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def read_line(filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d9a3ae42","line":58,"in_reply_to":"7faddb67_22e730af","updated":"2019-08-28 02:03:51.000000000","message":"0x8086 is discovered from sysfs, we should convert it to \"intel\" here. I think it is better than hard code \"intel\" here.","commit_id":"c0a97bbc075bd5fe9189fcbd88d85388742e74fc"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"6597fd8874c94dd3b92fb2b612e70dedc7f4570a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \"fpga\": RC_FPGA"},{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"VENDOR_MAPS \u003d {\"0x8086\": \"intel\"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def read_line(filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_22e730af","line":58,"in_reply_to":"7faddb67_283511dc","updated":"2019-08-27 17:18:27.000000000","message":"It will be simpler to just set DRIVER_NAME\u003d\"intel\" and use that. This seems to obscure the change and the intent.","commit_id":"c0a97bbc075bd5fe9189fcbd88d85388742e74fc"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"9783be114a0317b170ab9d50dcce6d2a967e3770","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \"fpga\": RC_FPGA"},{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"VENDOR_MAPS \u003d {\"0x8086\": \"intel\"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def read_line(filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_283511dc","line":58,"in_reply_to":"7faddb67_6c2faf3e","updated":"2019-08-23 02:29:11.000000000","message":"Just for easy change when we want change the name in the future. Cause there are several assignment of driver_name.","commit_id":"c0a97bbc075bd5fe9189fcbd88d85388742e74fc"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"cc91d6b91663327f19f7885e705ce4aca99a8e52","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \"fpga\": RC_FPGA"},{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"VENDOR_MAPS \u003d {\"0x8086\": \"intel\"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def read_line(filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_92142ba1","line":58,"in_reply_to":"7faddb67_d9a3ae42","updated":"2019-08-28 06:48:55.000000000","message":"FYI, 8086 is always Intel -- Intel\u0027s first microprocessor was 8086. Intel devices generally should have that vendor ID of 8086 but it is possible/conceivable that some cores from former Altera may get shipped with a different PCI ID. Even then the driver name should be Intel.\n\nDo you see this driver being used with any vendor other than Intel? That is not the intent.","commit_id":"c0a97bbc075bd5fe9189fcbd88d85388742e74fc"}],"cyborg/objects/deployable.py":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"993e50829bb36d36c86513edf4a59021325d514d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # number of accelerators spawned by this deployable"},{"line_number":47,"context_line":"        \u0027device_id\u0027: object_fields.IntegerField(nullable\u003dFalse),"},{"line_number":48,"context_line":"        # Foreign key constrain to reference device table"},{"line_number":49,"context_line":"        \u0027driver_name\u0027: object_fields.StringField(nullable\u003dTrue)"},{"line_number":50,"context_line":"        # Will change it to non-nullable after other driver report it."},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2c5bf7f6","line":49,"updated":"2019-08-22 11:03:03.000000000","message":"I have this and other changes in:\nhttps://review.opendev.org/#/c/670468/14/cyborg/objects/deployable.py@52","commit_id":"c0a97bbc075bd5fe9189fcbd88d85388742e74fc"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"9783be114a0317b170ab9d50dcce6d2a967e3770","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # number of accelerators spawned by this deployable"},{"line_number":47,"context_line":"        \u0027device_id\u0027: object_fields.IntegerField(nullable\u003dFalse),"},{"line_number":48,"context_line":"        # Foreign key constrain to reference device table"},{"line_number":49,"context_line":"        \u0027driver_name\u0027: object_fields.StringField(nullable\u003dTrue)"},{"line_number":50,"context_line":"        # Will change it to non-nullable after other driver report it."},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e82e198b","line":49,"in_reply_to":"7faddb67_2c5bf7f6","updated":"2019-08-23 02:29:11.000000000","message":"Yes, we should merge this, and you can rebase on it. This patch does not work without this definition. Always the dependency issues......","commit_id":"c0a97bbc075bd5fe9189fcbd88d85388742e74fc"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"f6468e3355899401a9601d6b783c8df58168df68","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # number of accelerators spawned by this deployable"},{"line_number":47,"context_line":"        \u0027device_id\u0027: object_fields.IntegerField(nullable\u003dFalse),"},{"line_number":48,"context_line":"        # Foreign key constrain to reference device table"},{"line_number":49,"context_line":"        \u0027driver_name\u0027: object_fields.StringField(nullable\u003dTrue)"},{"line_number":50,"context_line":"        # Will change it to non-nullable after other driver report it."},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_7574f6fe","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":22},"updated":"2019-08-28 11:21:19.000000000","message":"Hi, Xinran. Soft -1 beacuse I think the unittest should also add this field[1]. \n[1]. https://github.com/openstack/cyborg/blob/master/cyborg/tests/unit/fake_deployable.py#L33","commit_id":"d204ee393a56f6d476444fa366fdd9dc9bef3eab"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"5395d3792ca7bfa51b677cc8645c4534d60bd12d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # number of accelerators spawned by this deployable"},{"line_number":47,"context_line":"        \u0027device_id\u0027: object_fields.IntegerField(nullable\u003dFalse),"},{"line_number":48,"context_line":"        # Foreign key constrain to reference device table"},{"line_number":49,"context_line":"        \u0027driver_name\u0027: object_fields.StringField(nullable\u003dTrue)"},{"line_number":50,"context_line":"        # Will change it to non-nullable after other driver report it."},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_3e2c1200","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":22},"in_reply_to":"7faddb67_7574f6fe","updated":"2019-08-29 02:18:48.000000000","message":"Yes, agree with you.","commit_id":"d204ee393a56f6d476444fa366fdd9dc9bef3eab"}],"cyborg/objects/driver_objects/driver_deployable.py":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"993e50829bb36d36c86513edf4a59021325d514d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # attribute list?"},{"line_number":39,"context_line":"        \u0027attach_handle_list\u0027: object_fields.ListOfObjectsField("},{"line_number":40,"context_line":"            \u0027DriverAttachHandle\u0027, default\u003d[], nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027driver_name\u0027: object_fields.StringField(nullable\u003dTrue)"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def create(self, context, device_id, cpid_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ecf15fe0","line":41,"updated":"2019-08-22 11:03:03.000000000","message":"This is needed for sure. Other fields like bitstream_id in objects.deployable, need not be here. So +1.","commit_id":"c0a97bbc075bd5fe9189fcbd88d85388742e74fc"}]}