)]}'
{"cyborg/api/controllers/v1/accelerators.py":[{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"6cc8abae0d780aa6b07653dc30776eca0e463f4a","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        :param uuid: UUID of an accelerator."},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        LOG.warning(\"v1 APIs for accelerator objects are deprecated.\")"},{"line_number":194,"context_line":"        # obj_acc \u003d self._resource or self._get_resource(uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_401a486f","line":194,"range":{"start_line":194,"start_character":8,"end_line":194,"end_character":9},"updated":"2019-08-29 03:03:23.000000000","message":"why add # here?","commit_id":"4809245049faa3af1e8d687400fc3dea7926d9c6"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"a1b687618f9fbbd1b182c3fafd348d6c067895e4","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        :param uuid: UUID of an accelerator."},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        LOG.warning(\"v1 APIs for accelerator objects are deprecated.\")"},{"line_number":194,"context_line":"        # obj_acc \u003d self._resource or self._get_resource(uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c325e25d","line":194,"range":{"start_line":194,"start_character":8,"end_line":194,"end_character":9},"in_reply_to":"7faddb67_230636cf","updated":"2019-08-29 06:19:04.000000000","message":"maybe we can just delete the line and left \u0027pass\u0027","commit_id":"4809245049faa3af1e8d687400fc3dea7926d9c6"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"78317c7223b9d6c403d6f4c5efcb23b12ca89870","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        :param uuid: UUID of an accelerator."},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        LOG.warning(\"v1 APIs for accelerator objects are deprecated.\")"},{"line_number":194,"context_line":"        # obj_acc \u003d self._resource or self._get_resource(uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_230636cf","line":194,"range":{"start_line":194,"start_character":8,"end_line":194,"end_character":9},"in_reply_to":"7faddb67_401a486f","updated":"2019-08-29 06:12:57.000000000","message":"One solution is to delete this line directly otherwise the pep8 will report an error because obj_acc defined but not used. \nThe advantage of adding comments is that we can remind some programmers. But the v1 api is being deprecated, I am not sure if it is necessary to keep a note on this line. What do you think?","commit_id":"4809245049faa3af1e8d687400fc3dea7926d9c6"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"412d0b5494822f68fcca79d0ea7f3ee2718a829d","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        :param uuid: UUID of an accelerator."},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        LOG.warning(\"v1 APIs for accelerator objects are deprecated.\")"},{"line_number":194,"context_line":"        # obj_acc \u003d self._resource or self._get_resource(uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e3ab3e85","line":194,"range":{"start_line":194,"start_character":8,"end_line":194,"end_character":9},"in_reply_to":"7faddb67_63e98ee1","updated":"2019-08-29 06:28:18.000000000","message":"Done","commit_id":"4809245049faa3af1e8d687400fc3dea7926d9c6"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"397f6e5cf4c3618a22d783b53fd020bf7c1e48a7","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        :param uuid: UUID of an accelerator."},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        LOG.warning(\"v1 APIs for accelerator objects are deprecated.\")"},{"line_number":194,"context_line":"        # obj_acc \u003d self._resource or self._get_resource(uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_63e98ee1","line":194,"range":{"start_line":194,"start_character":8,"end_line":194,"end_character":9},"in_reply_to":"7faddb67_c325e25d","updated":"2019-08-29 06:22:51.000000000","message":"Well. \u0027pass\u0027 is also a good method.","commit_id":"4809245049faa3af1e8d687400fc3dea7926d9c6"}],"cyborg/api/controllers/v1/types.py":[{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"dcd6fc25ad4e2f5aff7c4eb9210d550cd13e44bd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import inspect"},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_utils import strutils"},{"line_number":20,"context_line":"from oslo_utils import uuidutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_238b961e","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":11},"updated":"2019-08-29 06:31:24.000000000","message":"please use oslo_serialization\u0027s jsonutils instead, I saw many commits replace this.","commit_id":"ec5e6ac21a985892e4355249e2ccf559d4d9db2a"}]}