)]}'
{"cyborg/db/sqlalchemy/api.py":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"ba7f15cc17a644a7d3c4148c97c25725c9a7c053","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            query \u003d model_query(context, models.AttachHandle)"},{"line_number":253,"context_line":"            query \u003d add_identity_filter(query, uuid)"},{"line_number":254,"context_line":"            try:"},{"line_number":255,"context_line":"                query.with_lockmode(\u0027update\u0027).update(values)"},{"line_number":256,"context_line":"            except NoResultFound:"},{"line_number":257,"context_line":"                raise exception.AttachHandleNotFound(uuid\u003duuid)"},{"line_number":258,"context_line":"        return query.first()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_517bf127","line":255,"range":{"start_line":255,"start_character":22,"end_line":255,"end_character":45},"updated":"2019-08-29 18:36:48.000000000","message":"also we do not need this lock.","commit_id":"10bafbe2a7c74a9a49c5b2ae507067a7e8bb93ef"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"c11a0c13e6560797ada164dff6d14fdaebff9edd","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        return ref"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @oslo_db_api.retry_on_deadlock"},{"line_number":262,"context_line":"    def _do_allocate_attach_handle(self, context, deployable_id, values):"},{"line_number":263,"context_line":"        \"\"\"Atomically get a set of attach handles that match the query"},{"line_number":264,"context_line":"           and mark one of those as in_use."},{"line_number":265,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_5545ef6d","line":262,"updated":"2019-09-03 07:17:34.000000000","message":"I think we should also add attach_type here. L268 use it","commit_id":"97e08d387c05e1394bc52741429e9874f02277a1"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"08a9844698ea2e52103c2dc161f5e235a5296508","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        return ref"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @oslo_db_api.retry_on_deadlock"},{"line_number":262,"context_line":"    def _do_allocate_attach_handle(self, context, deployable_id, values):"},{"line_number":263,"context_line":"        \"\"\"Atomically get a set of attach handles that match the query"},{"line_number":264,"context_line":"           and mark one of those as in_use."},{"line_number":265,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_f0c3c988","line":262,"in_reply_to":"7faddb67_5545ef6d","updated":"2019-09-03 07:47:42.000000000","message":"Done","commit_id":"97e08d387c05e1394bc52741429e9874f02277a1"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"c11a0c13e6560797ada164dff6d14fdaebff9edd","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            values \u003d {\"in_use\": True}"},{"line_number":272,"context_line":"            ref \u003d query.with_lockmode(\u0027update\u0027).one()"},{"line_number":273,"context_line":"            ref.update(values)"},{"line_number":274,"context_line":"            # FIXME The in_use field doesn\u0027t get updated in db."},{"line_number":275,"context_line":"            session.flush()"},{"line_number":276,"context_line":"        return ref"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_d550ff2e","line":274,"range":{"start_line":274,"start_character":14,"end_line":274,"end_character":19},"updated":"2019-09-03 07:17:34.000000000","message":"And should we remove this line, atfer this bugfix?","commit_id":"97e08d387c05e1394bc52741429e9874f02277a1"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"08a9844698ea2e52103c2dc161f5e235a5296508","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            values \u003d {\"in_use\": True}"},{"line_number":272,"context_line":"            ref \u003d query.with_lockmode(\u0027update\u0027).one()"},{"line_number":273,"context_line":"            ref.update(values)"},{"line_number":274,"context_line":"            # FIXME The in_use field doesn\u0027t get updated in db."},{"line_number":275,"context_line":"            session.flush()"},{"line_number":276,"context_line":"        return ref"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_10c1c580","line":274,"range":{"start_line":274,"start_character":14,"end_line":274,"end_character":19},"in_reply_to":"7faddb67_d550ff2e","updated":"2019-09-03 07:47:42.000000000","message":"Done","commit_id":"97e08d387c05e1394bc52741429e9874f02277a1"}]}