)]}'
{"id":"openstack%2Fcyborg~694856","triplet_id":"openstack%2Fcyborg~master~I6a1ee1a282d15441fcd9d27300c4f60d52c2b8a6","project":"openstack/cyborg","branch":"master","topic":"set-nova-microversion","hashtags":[],"change_id":"I6a1ee1a282d15441fcd9d27300c4f60d52c2b8a6","subject":"Set compute API microversion to \u0027latest\u0027 when calling Nova.","status":"MERGED","created":"2019-11-18 23:42:47.000000000","updated":"2019-11-21 21:00:35.000000000","submitted":"2019-11-21 08:07:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"694856-1574323620879-64a7fc44","meta_rev_id":"98184573d4b569107d86ac29f1a8451407b31f8b","_number":694856,"virtual_id_number":694856,"owner":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-21 08:07:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-11-19 07:01:56.000000000","_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},{"value":0,"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"all":[{"value":2,"date":"2019-11-21 05:19:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},{"value":0,"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},{"value":2,"date":"2019-11-21 07:35:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"all":[{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"date":"2019-11-18 23:43:40.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"date":"2019-11-19 07:51:58.000000000","_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"date":"2019-11-19 07:52:03.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2019-11-18 23:43:11.000000000","_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},{"value":0,"date":"2019-11-18 23:43:27.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"date":"2019-11-19 07:51:43.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},{"value":1,"date":"2019-11-21 07:35:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},{"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-18 23:43:11.000000000","updated_by":{"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},"reviewer":{"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},"state":"REVIEWER"},{"updated":"2019-11-18 23:43:27.000000000","updated_by":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"reviewer":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"state":"REVIEWER"},{"updated":"2019-11-18 23:43:40.000000000","updated_by":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"reviewer":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"state":"REVIEWER"},{"updated":"2019-11-19 07:51:43.000000000","updated_by":{"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},"reviewer":{"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},"state":"REVIEWER"},{"updated":"2019-11-19 07:51:58.000000000","updated_by":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"reviewer":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"state":"REVIEWER"},{"updated":"2019-11-19 07:52:03.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-11-21 05:19:28.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-11-21 07:35:53.000000000","updated_by":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"reviewer":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"state":"REVIEWER"},{"updated":"2019-11-21 08:07:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dd9a116ab1dd95f11cc8aef77958c6f5c6304d11","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2019-11-18 23:42:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8a86430cde1a0a15a4dd67de436d51b1f4265c6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-19 00:16:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0c5b853ee22c4bd59b9a560552bb1807 : SUCCESS in 2m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/41213a66fe1247398a18034acd8c4960 : SUCCESS in 3m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4f517b8c6f2a4ecdaf034375bd24b638 : SUCCESS in 3m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5745eb04ea964e07b3395aa9924552a6 : SUCCESS in 3m 01s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5171392080a54108ae4533771dcee960 : SUCCESS in 9m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6909cbfc6f454405985e8d3efcae4964 : SUCCESS in 4m 11s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/bcbdf264f1d44c3f9eeb8b1bc5ddb848 : FAILURE in 25m 01s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6708de17fe744fe4a67b84da149f6172 : SUCCESS in 32m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"93785ed386d8b6169633ae1cdf8429dc809c8383","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2019-11-19 07:01:56.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"3989d3abcbb3f02e15ef0c1e7527884ab7d65973","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-19 07:41:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/843aa10fbb7a4d45b166b51a584fd301 : SUCCESS in 3m 32s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/bf8503d51b7f48a99826a1a694f2099f : SUCCESS in 5m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0775923e4e7c4dcda9325d02923caea6 : SUCCESS in 5m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f501a60918f647c08d885db0fda3e8c2 : SUCCESS in 4m 49s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/48a0985143d94c9b8af2e501f042ea85 : SUCCESS in 4m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b8ecd3e88f8948e9b08423c6d1c61001 : SUCCESS in 4m 11s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/763fb9e27ca54d70bc456ef249b35546 : SUCCESS in 33m 44s (non-voting)\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6a9b587926a343558d5dc5fdf9e7e77f : SUCCESS in 34m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5cee9a11a6766b3e9040353f0d36462172cf5769","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-11-21 05:19:28.000000000","message":"Patch Set 1: Code-Review+2\n\nAfter discussion at our irc meeting, I think +2 is appropriate, and if there is a need later, we can consider setting this to be configurable.","accounts_in_message":[],"_revision_number":1},{"id":"b135f16a64d071fdcf14fb44100d04010699faf6","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2019-11-21 07:35:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nOK, hard code default_microversion as \u0027latest\u0027.\nAnd we can improve it later if needed.","accounts_in_message":[],"_revision_number":1},{"id":"6f75f3a9ade0f5872148b87c752a130775fa9211","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-21 07:36:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"85b830f4ecbbf625d6c76166f468dc1ab17959cd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-21 08:07:00.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/95341a04590d4d1682235db3fa9c5d5f : SUCCESS in 3m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b8e7e0eaabf04056a268994a660c02d8 : SUCCESS in 3m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/679b053fcca547278540d72ae880b151 : SUCCESS in 3m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5f771318eabd47e09fc3e0a9c4856527 : SUCCESS in 3m 53s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/a4bf50e701ef4cbc89f1d646329f63c0 : SUCCESS in 30m 23s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f1f386f1cf23062bf360eb60c898d0b6eab14f8e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-21 08:07:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"1b21ee883638820be2f1520a74e4efa61e79fcf9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-21 08:08:08.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ab85fd741492459c9d2eb8c77cebc8af : SUCCESS in 50s","accounts_in_message":[],"_revision_number":1},{"id":"e0d85d6a44e736945e0be586d2814bb8364897c0","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-21 18:03:23.000000000","message":"Patch Set 1:\n\nSorry I didn\u0027t catch this review earlier, but it is bad practice to use \u0027latest\u0027 as the default microversion.\n\nIf what you\u0027re trying to do is chase whatever microversion ends up exposing the new notification, and you have a chicken/egg dependency such that you can\u0027t actually wait until the nova side lands, then you should use \u0027latest\u0027 only on the *specific* call(s) that involve that notification, with a big fat TODO on those lines to cut over to the specific microversion when $patch lands.","accounts_in_message":[],"_revision_number":1},{"id":"97075d46e86680285d1f810a4cbd046936d5bf8b","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2019-11-21 21:00:35.000000000","message":"Patch Set 1:\n\n\u003e you should use \u0027latest\u0027 only on the *specific* call(s)\n\nWe have only one Nova API call, i.e., /os-server-external-events. I have created a new task: https://storyboard.openstack.org/#!/story/2006921","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f0d3326f1bb87db6ede9655bc7103d8329b83fbf","revisions":{"f0d3326f1bb87db6ede9655bc7103d8329b83fbf":{"kind":"REWORK","_number":1,"created":"2019-11-18 23:42:47.000000000","uploader":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"ref":"refs/changes/56/694856/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/56/694856/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/56/694856/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/56/694856/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/56/694856/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/56/694856/1"}}},"commit":{"parents":[{"commit":"0f737580c94225cee0af4925c12f2fb20a6ebe0a","subject":"Merge \"Exclude cyborg tests dir in UT cover report\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/0f737580c94225cee0af4925c12f2fb20a6ebe0a"}]}],"author":{"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","date":"2019-11-18 23:38:14.000000000","tz":-480},"committer":{"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","date":"2019-11-18 23:38:14.000000000","tz":-480},"subject":"Set compute API microversion to \u0027latest\u0027 when calling Nova.","message":"Set compute API microversion to \u0027latest\u0027 when calling Nova.\n\nThis is needed because the compute API microversion will\nneed to change to enable the Cyborg ARQ notification event.\n(See https://review.opendev.org/#/c/692707 .)\n\nChange-Id: I6a1ee1a282d15441fcd9d27300c4f60d52c2b8a6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/f0d3326f1bb87db6ede9655bc7103d8329b83fbf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/f0d3326f1bb87db6ede9655bc7103d8329b83fbf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}