)]}'
{"cyborg/agent/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1e74fc26191ea0072d01775cc31adb30662c979a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def __init__(self, topic, host\u003dNone):"},{"line_number":39,"context_line":"        super(AgentManager, self).__init__(CONF)"},{"line_number":40,"context_line":"        self.topic \u003d topic"},{"line_number":41,"context_line":"        self.host \u003d host or socket.gethostname()"},{"line_number":42,"context_line":"        self.fpga_driver \u003d FPGADriver()"},{"line_number":43,"context_line":"        self.cond_api \u003d cond_api.ConductorAPI()"},{"line_number":44,"context_line":"        self.agent_api \u003d AgentAPI()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e4640fe9","line":41,"range":{"start_line":41,"start_character":28,"end_line":41,"end_character":48},"updated":"2019-11-26 18:54:35.000000000","message":"this is not correct this should still be CONF.host\nsee my comment on https://review.opendev.org/#/c/696014/2/cyborg/conf/default.py@37","commit_id":"834d04e37e55029561521616ee169e7472b3901d"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"7660ee8aed68df404cc9757f7a602d635b16c30a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def __init__(self, topic, host\u003dNone):"},{"line_number":39,"context_line":"        super(AgentManager, self).__init__(CONF)"},{"line_number":40,"context_line":"        self.topic \u003d topic"},{"line_number":41,"context_line":"        self.host \u003d host or socket.gethostname()"},{"line_number":42,"context_line":"        self.fpga_driver \u003d FPGADriver()"},{"line_number":43,"context_line":"        self.cond_api \u003d cond_api.ConductorAPI()"},{"line_number":44,"context_line":"        self.agent_api \u003d AgentAPI()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b6d2c65a","line":41,"range":{"start_line":41,"start_character":28,"end_line":41,"end_character":48},"in_reply_to":"3fa7e38b_e4640fe9","updated":"2019-11-27 01:44:02.000000000","message":"Sean, that sounds correct. However, this is the host name that gets propagated to the Cyborg conductor which uses it to locate the compute node RP on which to hang the nested RP. That name should be the hypervisor hostname, which is obtained via gethostname() -- agreed? If so, see next comment.","commit_id":"834d04e37e55029561521616ee169e7472b3901d"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"7660ee8aed68df404cc9757f7a602d635b16c30a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.cond_api \u003d cond_api.ConductorAPI()"},{"line_number":44,"context_line":"        self.agent_api \u003d AgentAPI()"},{"line_number":45,"context_line":"        self.image_api \u003d ImageAPI()"},{"line_number":46,"context_line":"        self._rt \u003d ResourceTracker(host, self.cond_api)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def periodic_tasks(self, context, raise_on_error\u003dFalse):"},{"line_number":49,"context_line":"        return self.run_periodic_tasks(context, raise_on_error\u003draise_on_error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b63726b0","line":46,"updated":"2019-11-27 01:44:02.000000000","message":"The resource tracker is the component that actually sends the device report to the conductor, with the host name used to locate the CN RP [1]. It should be initialized here with host \u003d gethostname(), I think.\n\nAs a bonus, it will fix the bug that the \u0027host\u0027 passed to ResourceTracker() here can be None, while the ResourceTracker never checks for that.\n\n[1] https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/resource_tracker.py#L75","commit_id":"834d04e37e55029561521616ee169e7472b3901d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8f43bd19123b6ceeb517834b001213fe64c9ae57","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"import oslo_messaging as messaging"},{"line_number":18,"context_line":"from oslo_service import periodic_task"},{"line_number":19,"context_line":"import socket"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cyborg.accelerator.drivers.fpga.base import FPGADriver"},{"line_number":22,"context_line":"from cyborg.agent.resource_tracker import ResourceTracker"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_c83abfe5","line":19,"updated":"2020-04-07 10:59:33.000000000","message":"pep8: F401 \u0027socket\u0027 imported but unused","commit_id":"6513003dff3d23e7d98f7ff8ddc23994536c77af"}],"cyborg/conf/default.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1e74fc26191ea0072d01775cc31adb30662c979a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"service_opts \u003d ["},{"line_number":36,"context_line":"    cfg.HostAddressOpt(\u0027host\u0027,"},{"line_number":37,"context_line":"                       default\u003dsocket.getfqdn(),"},{"line_number":38,"context_line":"                       sample_default\u003d\u0027localhost\u0027,"},{"line_number":39,"context_line":"                       help\u003d_(\u0027Name of this node. This can be an opaque \u0027"},{"line_number":40,"context_line":"                              \u0027identifier. It is not necessarily a hostname, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_04a7eb0b","line":37,"range":{"start_line":37,"start_character":38,"end_line":37,"end_character":47},"updated":"2019-11-26 18:54:35.000000000","message":"this should be gethostname()","commit_id":"834d04e37e55029561521616ee169e7472b3901d"}]}