)]}'
{"id":"openstack%2Fcyborg~696065","triplet_id":"openstack%2Fcyborg~master~I0aac84a1fc6b00b5523927bee27f7491daecd786","project":"openstack/cyborg","branch":"master","topic":"fix_max_unit_error","hashtags":[],"change_id":"I0aac84a1fc6b00b5523927bee27f7491daecd786","subject":"BugFix: modify the max allocation limit of acceleration resources","status":"MERGED","created":"2019-11-26 11:22:32.000000000","updated":"2019-12-16 08:49:19.000000000","submitted":"2019-12-16 08:47:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"696065-1576486038299-19300d8e","meta_rev_id":"4d40840700099ccdd80b7173cdbba06d2d62a2ee","_number":696065,"virtual_id_number":696065,"owner":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"date":"2019-12-16 05:42:22.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-16 08:47:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"all":[{"value":0,"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-12-16 07:36:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":2,"date":"2019-12-16 05:40:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"all":[{"value":0,"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-12-16 08:14:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-26 11:23:14.000000000","updated_by":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"reviewer":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"state":"REVIEWER"},{"updated":"2019-11-26 11:23:44.000000000","updated_by":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"reviewer":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"state":"REVIEWER"},{"updated":"2019-11-26 11:23:50.000000000","updated_by":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"reviewer":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"state":"REVIEWER"},{"updated":"2019-11-26 11:26:24.000000000","updated_by":{"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},"reviewer":{"_account_id":22899,"name":"coco-Gao","email":"419546439@qq.com","username":"Coco"},"state":"REVIEWER"},{"updated":"2019-11-26 16:31:23.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-11-27 19:07:07.000000000","updated_by":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"reviewer":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"state":"REVIEWER"},{"updated":"2019-12-16 05:40:19.000000000","updated_by":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"reviewer":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"state":"REVIEWER"},{"updated":"2019-12-16 08:14:23.000000000","updated_by":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"reviewer":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"state":"REVIEWER"},{"updated":"2019-12-16 08:47:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1f720fff8665b383ff5e9793838fe7c7d11740a6","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-11-26 11:22:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6372fa9b5abc2cec03ae0b4c09347a15d8efd712","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-26 12:09:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6878c786ab5146709a7cdf56b0c2e9b5 : SUCCESS in 5m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b5d4ea59fc304ff49c19a968d88b68de : SUCCESS in 3m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d6124ffe31e8487a96b27f78e099fe1a : SUCCESS in 3m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/055844ddcaf44e0195859366d71aae0d : SUCCESS in 5m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4fb723eba4e24ce295b4c955ca1034cc : SUCCESS in 4m 31s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/39ad228508de4d308364c79248afa220 : SUCCESS in 36m 33s (non-voting)\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e5afc43a4be449d282b4ee85da3a3407 : SUCCESS in 43m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8b6a5eaded0fd9dba0558b102ca824cd6e4d6501","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-11-26 12:16:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"156ecb6d0391ef5ef409034ddeeb728b0167fedf","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-11-26 12:46:32.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"c3371f0586f165be6bdf7e28378618c411d18d49","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-26 13:30:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/320aa0c26bd24a3da6eda4388c517728 : SUCCESS in 4m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eb1ffbff02bf475bb35e2c1ece007418 : SUCCESS in 3m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/681664334c68498b8cfc18adcb1e2640 : SUCCESS in 4m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3d5b91ab67f044528c2fdd569a7376c8 : SUCCESS in 4m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/892b9916a44043ae9ca7c74e060fc004 : SUCCESS in 4m 15s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/597abd3fed65405cab2c21efee7102f8 : SUCCESS in 37m 46s (non-voting)\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7b6499c91d86477491dc42bbeae32fe1 : SUCCESS in 37m 26s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"44d901cce113c7a83632bf5bf9241b8ed0ed2332","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-26 16:31:23.000000000","message":"Patch Set 3: Code-Review-1\n\nI agree this is the correct thing to do.\n\nThis patch needs test coverage. Except in extreme circumstances, unit test should be a minimum criterion for acceptance of any patch. Functional testing would be ideal, but I understand if you don\u0027t have the framework for that yet.\n\nI would also suggest taking this opportunity to refactor and simplify _gen_resource_inventory, which provides little value as it stands. Since it\u0027s only used one way in one code path (albeit twice) you could embed the max\u003d\u003dtotal logic in the method itself and get rid of the unnecessary kwargs and explicit defaults, e.g.:\n\n def _gen_resource_inventory(name, total):\n     # reserved, min_unit, step_size, and allocation_ratio get sane defaults from placement\n     return {name: {\n         \u0027total\u0027: total,\n         \u0027max_unit\u0027: total,\n     }}\n\nThat\u0027s just a suggestion, but it\u0027ll reduce your unit test surface, which is significant given that you\u0027ll be building it from scratch.\n\nTo be clear, the fix is correct; the -1 is for lack of test coverage.","accounts_in_message":[],"_revision_number":3},{"id":"f958a864b78e448f62031920d4453bea543f9ab7","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-26 16:32:36.000000000","message":"Patch Set 3:\n\nBy the way, the default max_unit in placement is MAX_INT, which would work fine for your purposes, since scheduling will be limited by `total` anyway. So you could just omit it from the inventory dict and make this even simpler.","accounts_in_message":[],"_revision_number":3},{"id":"735b7e3d6463bb1e5856b2d2b49ce0868c7df753","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-11-27 02:45:06.000000000","message":"Patch Set 3:\n\n\u003e I agree this is the correct thing to do.\n \u003e \n \u003e This patch needs test coverage. Except in extreme circumstances,\n \u003e unit test should be a minimum criterion for acceptance of any\n \u003e patch. Functional testing would be ideal, but I understand if you\n \u003e don\u0027t have the framework for that yet.\n \u003e \n \u003e I would also suggest taking this opportunity to refactor and\n \u003e simplify _gen_resource_inventory, which provides little value as it\n \u003e stands. Since it\u0027s only used one way in one code path (albeit\n \u003e twice) you could embed the max\u003d\u003dtotal logic in the method itself\n \u003e and get rid of the unnecessary kwargs and explicit defaults, e.g.:\n \u003e \n \u003e def _gen_resource_inventory(name, total):\n \u003e # reserved, min_unit, step_size, and allocation_ratio get sane\n \u003e defaults from placement\n \u003e return {name: {\n \u003e \u0027total\u0027: total,\n \u003e \u0027max_unit\u0027: total,\n \u003e }}\n \u003e \n \u003e That\u0027s just a suggestion, but it\u0027ll reduce your unit test surface,\n \u003e which is significant given that you\u0027ll be building it from scratch.\n \u003e \n \u003e To be clear, the fix is correct; the -1 is for lack of test\n \u003e coverage.\n\nThanks Eric. I agree with you. Unit tests are necessary. But currently there is no unit test for the entire cyborg/conductor directory. In the discussion of ptg, we put unit testing at a relatively high priority, and I believe it will be better soon.\nAgree, we just need to set total.","accounts_in_message":[],"_revision_number":3},{"id":"94970760956fca5d4b3675f5383ce95f81035783","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-11-27 03:03:16.000000000","message":"Patch Set 3:\n\n\u003e By the way, the default max_unit in placement is MAX_INT, which\n \u003e would work fine for your purposes, since scheduling will be limited\n \u003e by `total` anyway. So you could just omit it from the inventory\n \u003e dict and make this even simpler.\n\nBecause this patch is for bugfix. About the refactor, I will use a new patch for this. Thanks.","accounts_in_message":[],"_revision_number":3},{"id":"a2caaabf132e369ec8499376303379084f3a9378","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2019-11-27 19:07:07.000000000","message":"Patch Set 3: Code-Review-1\n\nThis change LGTM.\n\n \u003e Because this patch is for bugfix. About the refactor, I will use a\n \u003e new patch for this.\n\nHi Chenke, generally UT goes with the patch. If you prefer to add a separate patch for conductor UT (since there is much to do there), please add it as a patch series on top of this one. Then we can review both together.","accounts_in_message":[],"_revision_number":3},{"id":"f9f5095b3f288c834513004b1a19978711eec531","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-27 19:36:16.000000000","message":"Patch Set 3:\n\nI worked up the refactor in a patch on top of this one [1]. It includes introducing the test suite for conductor/manager.\n\n[1] https://review.opendev.org/#/c/696393/","accounts_in_message":[],"_revision_number":3},{"id":"000473e19ccd7c4a076b7eaa4f096f7e3b13cb3d","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-11-28 01:54:17.000000000","message":"Patch Set 3:\n\n\u003e I worked up the refactor in a patch on top of this one [1]. It\n \u003e includes introducing the test suite for conductor/manager.\n \u003e \n \u003e [1] https://review.opendev.org/#/c/696393/\n\nThanks to Eric for helping us put cond/manager UT work.","accounts_in_message":[],"_revision_number":3},{"id":"6b951c21a72678aa0a918cc727aa61889d13856d","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-12-15 06:18:22.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":4},{"id":"30c8a04468570770bd57c3703bc0babfaac8ca85","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-15 07:04:21.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/56138715a8e0470480aa36d85498a6b8 : SUCCESS in 6m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/21ee4156d90241839ecb6f66ecbb91e7 : SUCCESS in 6m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/85fb036966ce4c06b56d07d8c5e4ae06 : SUCCESS in 5m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7cd906fa3fb646da9159c190d9a05864 : SUCCESS in 6m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8676de4ffcc744ff95c0f46c43700370 : SUCCESS in 7m 54s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/e34a5a2c840a4bdca0e4b8637b2aaee1 : SUCCESS in 36m 32s (non-voting)\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/cbce8923c33e41f0adb07566a2859685 : SUCCESS in 40m 02s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"dc368a62cf7e7096b170b41abe6c17aa6787d85a","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-12-15 08:58:30.000000000","message":"Patch Set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"147dc4373585ce2734fbbf8cce82adb5d2ccaab7","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-12-15 09:03:51.000000000","message":"Patch Set 5:\n\n\u003e This change LGTM.\n \u003e \n \u003e \u003e Because this patch is for bugfix. About the refactor, I will use\n \u003e a\n \u003e \u003e new patch for this.\n \u003e \n \u003e Hi Chenke, generally UT goes with the patch. If you prefer to add a\n \u003e separate patch for conductor UT (since there is much to do there),\n \u003e please add it as a patch series on top of this one. Then we can\n \u003e review both together.\n\nThanks. Done.","accounts_in_message":[],"_revision_number":5},{"id":"be4c5b4e1f1fa24e4520accbd19fdb53178e6cc3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-15 09:11:08.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/01cf0185976d4f24ade0afadd5ae7b5b : SUCCESS in 4m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a4c0afdf075a4b70bb12b2432981c21b : SUCCESS in 3m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0766a338807d4001b0757635b983458f : SUCCESS in 4m 09s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b41f0c37c64a4cb1b3d7c66984d127b1 : SUCCESS in 3m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5023100fa3844d9d9ff213ffd8dd785d : SUCCESS in 3m 56s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/8f0c29a9bdaf4793b781192c6597df31 : FAILURE in 10m 51s (non-voting)\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2320b15f073a43d38aa3d19b736c901f : FAILURE in 10m 44s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"67fd02e99fbe2f615fede9c8cd0fd49caa47d466","author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"date":"2019-12-16 05:40:19.000000000","message":"Patch Set 5: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":5},{"id":"dca6d5ac17dd3be1b859f12b37301d9088152b85","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-12-16 05:42:22.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"6155a5cd6a6dfd67f620b792fae41072b98f006d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 07:10:29.000000000","message":"Patch Set 5:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5c9d7f131dee4b7e9dbdb932e8175c6a : SUCCESS in 4m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c48143be51f94805acbd9fd07a6abecd : SUCCESS in 3m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b7a5499d6ad748669f1513187e137b5d : SUCCESS in 4m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4222bfcb29b34bbd800abd4001aaad13 : SUCCESS in 3m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a28fe9df6d2a435e915687c2abff482b : SUCCESS in 3m 52s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/5e9a5c75377b442588703ec7c0f6e9d9 : SUCCESS in 33m 19s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/699f8cdd42ba4b7d8d073718b626d71f : SUCCESS in 44m 17s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"f58f83b8e1acc4367858644e59b3d6e60c7fda84","author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"date":"2019-12-16 07:36:41.000000000","message":"Patch Set 5: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":5},{"id":"b8f3a0bd8e76b0ab3278b356b61f59e5938cc7c0","author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"date":"2019-12-16 08:14:23.000000000","message":"Patch Set 5: Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"1e8204daf5bda8a617867ec24b6950f41ab4de2f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 08:14:34.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"091e8ac3ac6d19a03c1c415504f14a54a17b3027","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 08:47:18.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4248d9a481c94df0b5041f757a547c75 : SUCCESS in 6m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/032285ffb49a4b05947dea426020fb14 : SUCCESS in 5m 31s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1f1295231f1f4d2aa270567d8169795c : SUCCESS in 6m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/160d1d7baa8f4609be5068187aac4368 : SUCCESS in 5m 17s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/dc58effc614542529c8b0add52e0914a : SUCCESS in 31m 13s","accounts_in_message":[],"_revision_number":5},{"id":"a34ee22b5f4fbfda0f70d10be3d97945d9472800","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 08:47:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"46897aba05e5392507e956bbed302c6e6f771849","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 08:49:19.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a678b6084da942bcb9fbc3e277989865 : SUCCESS in 1m 36s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"b77df15bd322efa52345602fcc9cf0b7ffa6cb47","revisions":{"e0419030d6130b2d74dcc1c0b0a9d5f27c85954c":{"kind":"REWORK","_number":1,"created":"2019-11-26 11:22:32.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/65/696065/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/65/696065/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/65/696065/1"}}},"commit":{"parents":[{"commit":"f6470592152224f45ca62abe55d09e75b56c3b2f","subject":"Merge \"Set compute API microversion to \u0027latest\u0027 when calling Nova.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/f6470592152224f45ca62abe55d09e75b56c3b2f"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-11-26 11:16:24.000000000","tz":480},"committer":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-11-26 11:16:24.000000000","tz":480},"subject":"Fix report the max limit of acceleration resources to the placement","message":"Fix report the max limit of acceleration resources to the placement\n\nThe max unit of acceleration resources should be set to maximum\ninstead of min(1).\n\nlike nova:\nhttps://github.com/openstack/nova/blob/9316976946c04573bbd18128bbb0674937c4eaf1/nova/virt/hyperv/hostops.py#L265\n\nChange-Id: I0aac84a1fc6b00b5523927bee27f7491daecd786\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/e0419030d6130b2d74dcc1c0b0a9d5f27c85954c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/e0419030d6130b2d74dcc1c0b0a9d5f27c85954c"}]},"branch":"refs/heads/master"},"fb989fea867c89d8dd900453aec88b9b40a4ebf9":{"kind":"REWORK","_number":2,"created":"2019-11-26 12:16:44.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/65/696065/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/65/696065/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/65/696065/2"}}},"commit":{"parents":[{"commit":"f6470592152224f45ca62abe55d09e75b56c3b2f","subject":"Merge \"Set compute API microversion to \u0027latest\u0027 when calling Nova.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/f6470592152224f45ca62abe55d09e75b56c3b2f"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-11-26 11:16:24.000000000","tz":480},"committer":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-11-26 12:16:09.000000000","tz":480},"subject":"Fix report the max limit of acceleration resources to the placement","message":"Fix report the max limit of acceleration resources to the placement\n\nThe max unit of acceleration resources should be set to maximum\ninstead of min(1).\n\nlike nova:\nhttps://github.com/openstack/nova/blob/9316976946c04573bbd18128bbb0674937c4eaf1/nova/virt/hyperv/hostops.py#L265\n\nChange-Id: I0aac84a1fc6b00b5523927bee27f7491daecd786\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/fb989fea867c89d8dd900453aec88b9b40a4ebf9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/fb989fea867c89d8dd900453aec88b9b40a4ebf9"}]},"branch":"refs/heads/master"},"86f52c6fccebd08f2529bae1c29e114e8c69be53":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2019-11-26 12:46:32.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/65/696065/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/65/696065/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/65/696065/3"}}},"commit":{"parents":[{"commit":"f6470592152224f45ca62abe55d09e75b56c3b2f","subject":"Merge \"Set compute API microversion to \u0027latest\u0027 when calling Nova.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/f6470592152224f45ca62abe55d09e75b56c3b2f"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-11-26 11:16:24.000000000","tz":480},"committer":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-11-26 12:44:20.000000000","tz":480},"subject":"BugFix: modify the max allocation limit of acceleration resources","message":"BugFix: modify the max allocation limit of acceleration resources\n\nThe max unit of acceleration resources should be set to maximum\ninstead of min(1).\n\nlike nova:\nhttps://github.com/openstack/nova/blob/9316976946c04573bbd18128bbb0674937c4eaf1/nova/virt/hyperv/hostops.py#L265\n\nFor the reason, pls see the Story.\n\nStory: 2006947\n\nChange-Id: I0aac84a1fc6b00b5523927bee27f7491daecd786\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/86f52c6fccebd08f2529bae1c29e114e8c69be53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/86f52c6fccebd08f2529bae1c29e114e8c69be53"}]},"branch":"refs/heads/master"},"4a5f70fea0bb8945474149d55715d62c63bc79b0":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2019-12-15 06:18:22.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/65/696065/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/65/696065/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/65/696065/4"}}},"commit":{"parents":[{"commit":"46ff7ded71bc8e36104dae6917b84d15b83f1586","subject":"Merge \"Add 5 placeholder db migration scripts for Train\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/46ff7ded71bc8e36104dae6917b84d15b83f1586"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-11-26 11:16:24.000000000","tz":480},"committer":{"name":"chenker","email":"chen.ke14@zte.com.cn","date":"2019-12-15 06:18:22.000000000","tz":0},"subject":"BugFix: modify the max allocation limit of acceleration resources","message":"BugFix: modify the max allocation limit of acceleration resources\n\nThe max unit of acceleration resources should be set to maximum\ninstead of min(1).\n\nlike nova:\nhttps://github.com/openstack/nova/blob/9316976946c04573bbd18128bbb0674937c4eaf1/nova/virt/hyperv/hostops.py#L265\n\nFor the reason, pls see the Story.\n\nStory: 2006947\n\nChange-Id: I0aac84a1fc6b00b5523927bee27f7491daecd786\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/4a5f70fea0bb8945474149d55715d62c63bc79b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/4a5f70fea0bb8945474149d55715d62c63bc79b0"}]},"branch":"refs/heads/master"},"b77df15bd322efa52345602fcc9cf0b7ffa6cb47":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2019-12-15 08:58:30.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/65/696065/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/65/696065/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/65/696065/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/65/696065/5"}}},"commit":{"parents":[{"commit":"46ff7ded71bc8e36104dae6917b84d15b83f1586","subject":"Merge \"Add 5 placeholder db migration scripts for Train\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/46ff7ded71bc8e36104dae6917b84d15b83f1586"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-11-26 11:16:24.000000000","tz":480},"committer":{"name":"chenker","email":"chen.ke14@zte.com.cn","date":"2019-12-15 08:58:14.000000000","tz":0},"subject":"BugFix: modify the max allocation limit of acceleration resources","message":"BugFix: modify the max allocation limit of acceleration resources\n\nThe max unit of acceleration resources should be set to maximum\ninstead of min(1).\n\nlike nova:\nhttps://github.com/openstack/nova/blob/9316976946c04573bbd18128bbb0674937c4eaf1/nova/virt/hyperv/hostops.py#L265\n\nFor the reason, pls see the Story.\n\nThe UT for this patch in https://review.opendev.org/#/c/696393.\n\nStory: 2006947\n\nChange-Id: I0aac84a1fc6b00b5523927bee27f7491daecd786\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b77df15bd322efa52345602fcc9cf0b7ffa6cb47"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b77df15bd322efa52345602fcc9cf0b7ffa6cb47"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}