)]}'
{"id":"openstack%2Fcyborg~696393","triplet_id":"openstack%2Fcyborg~master~I79379f55f3ea0690c58a7835d1e8c31117245626","project":"openstack/cyborg","branch":"master","topic":"fix_max_unit_error","hashtags":[],"change_id":"I79379f55f3ea0690c58a7835d1e8c31117245626","subject":"Refactor _gen_resource_inventory","status":"MERGED","created":"2019-11-27 19:32:38.000000000","updated":"2019-12-16 16:58:11.000000000","submitted":"2019-12-16 16:55:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"696393-1576515339624-a23e576b","meta_rev_id":"b8433e578cac9c12969d210d870582778e39745b","_number":696393,"virtual_id_number":696393,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},{"value":0,"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"date":"2019-12-16 15:41:41.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-16 16:55:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"recommended":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"all":[{"value":0,"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},{"value":0,"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-12-16 15:41:24.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":2,"date":"2019-12-16 15:41:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":2,"date":"2019-12-16 15:41:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"all":[{"value":0,"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},{"value":0,"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":1,"date":"2019-12-16 15:54:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-27 20:45:52.000000000","updated_by":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"reviewer":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"state":"REVIEWER"},{"updated":"2019-11-27 20:48:26.000000000","updated_by":{"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},"reviewer":{"_account_id":23168,"name":"Yumeng Bao","username":"Yumeng","inactive":true},"state":"REVIEWER"},{"updated":"2019-11-27 20:48:35.000000000","updated_by":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"reviewer":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"state":"REVIEWER"},{"updated":"2019-11-27 20:48:42.000000000","updated_by":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"reviewer":{"_account_id":27458,"name":"Li Liu","email":"liliueecg@gmail.com","username":"liliu"},"state":"REVIEWER"},{"updated":"2019-12-13 06:14:52.000000000","updated_by":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"reviewer":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"state":"REVIEWER"},{"updated":"2019-12-16 15:54:34.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-12-16 16:55:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8f7d72da056de74ba0cdd3b809edd9be0eff89c7","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-27 19:32:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ef297fc5f2ffd93509f82db49ee4c72f89afb52e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-27 20:14:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e4d8622ffef1413aa45ac7497ece2166 : SUCCESS in 4m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c22e619570fa481292ef610d9cfb619a : SUCCESS in 3m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/53d5d83c27d64f85a6ef5ce8a50366f8 : SUCCESS in 3m 51s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ed68c1f4c14445c4a617dbef214e2c2a : SUCCESS in 3m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/41c44d613f6f441997ef9ba675d4c85a : SUCCESS in 4m 02s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/f2e75df0535a4359abc519ace6921191 : SUCCESS in 31m 38s (non-voting)\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e7a6e8a203564a748f5767b57c845b18 : SUCCESS in 33m 13s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dbd29f1b585c6fe14c976977bbe2caf5dc5dab9f","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2019-11-27 20:45:52.000000000","message":"Patch Set 1: Code-Review+1\n\nEric, thanks for setting up the conductor UT framework.\n\nNeeds non-Intel +2 before I give a +2.","accounts_in_message":[],"_revision_number":1},{"id":"5944b7168e4b28e16b7768513bbef26d0e15347c","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-11-27 21:13:59.000000000","message":"Patch Set 1:\n\nJust confirming the new test suite ran:\n\nhttps://zuul.opendev.org/t/openstack/build/ed68c1f4c14445c4a617dbef214e2c2a/log/job-output.txt#679\nhttps://zuul.opendev.org/t/openstack/build/ed68c1f4c14445c4a617dbef214e2c2a/log/job-output.txt#743","accounts_in_message":[],"_revision_number":1},{"id":"69ec7cc82f83e6601c4b71e6d87124d1a536234b","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-11-29 05:56:50.000000000","message":"Patch Set 1: Code-Review+2\n\nNice! Big Thumb.","accounts_in_message":[],"_revision_number":1},{"id":"653b15536b1544507304aab8c76d07d196fc2bda","author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"date":"2019-12-13 06:14:21.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2fc1c5c7229df72cd07ef6c69dd11fd0b9bf3c2d","author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"date":"2019-12-13 06:14:52.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Eric, good catch.","accounts_in_message":[],"_revision_number":1},{"id":"bf12119ecdb141e7c31667c413c14afd54ab90ac","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-12-13 09:46:01.000000000","message":"Patch Set 1:\n\n@Xinran. https://review.opendev.org/#/c/696397/ Also need review.","accounts_in_message":[],"_revision_number":1},{"id":"a908451c00061fd27375841d9edc5c5e1fb51249","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-12-16 15:41:24.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"2fd79b7bdc4d8eaeb07009a9696b9a29ebf95072","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-12-16 15:41:41.000000000","message":"Patch Set 2:\n\nPS2 trivial rebase to resolve merge conflict.","accounts_in_message":[],"_revision_number":2},{"id":"4b8c4bbe6cd96f793ff15ce5e82d19bf3377e4f7","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-12-16 15:54:34.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"2c79cab690667090036eccf2581b3afb0fde57d5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 16:21:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b63b230d5bc74890aa41e3a9a2f70b62 : SUCCESS in 5m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/caeb6c3013414abd83f3080a896c49f8 : SUCCESS in 3m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d5d97d8d6f244447932df7fd7baebc6e : SUCCESS in 4m 35s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4953a7d031964953a44ccc9d862c9545 : SUCCESS in 6m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cb5281318490414d8e357c6714a7d984 : SUCCESS in 4m 23s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/5adc0fcdb00a473abd2efc3166e3c60f : SUCCESS in 31m 53s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/31d6b6980f6e459e9546e5f81c1e06ae : SUCCESS in 34m 12s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"257a9bfef10739c97ef2d79f8898fa324e472af9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 16:22:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b937da49f05c548c8df2d11398b73c6e8419646d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 16:55:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"67192198657bf4c282ca8d0215a4293e0a60b6bf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 16:55:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/37162d219ff54b4ba3d8a87bd4e83d80 : SUCCESS in 4m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1244a67523204e649cf90d77a99be6cf : SUCCESS in 4m 54s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/455f92bf19bd47c19fdc5f7dc27d93f2 : SUCCESS in 4m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c58e9773dd46484b87f429cada92133d : SUCCESS in 4m 52s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/2c046f7cadfd43cb8ccb19b9be903a6d : SUCCESS in 32m 03s","accounts_in_message":[],"_revision_number":2},{"id":"ffac7fc3d45d0a8b2fc6c35f535dd61a9f9d58bc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 16:58:11.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4284c43e532e4a68b5531bd4e10e0de1 : SUCCESS in 1m 58s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"59b8047ea15793ca0b71acce8cdc35533eea3d7a","revisions":{"a4fe3389498a98cd6449f02603a6ce96ea1eacdc":{"kind":"REWORK","_number":1,"created":"2019-11-27 19:32:38.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/93/696393/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/93/696393/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/93/696393/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/93/696393/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/93/696393/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/93/696393/1"}}},"commit":{"parents":[{"commit":"86f52c6fccebd08f2529bae1c29e114e8c69be53","subject":"BugFix: modify the max allocation limit of acceleration resources","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/86f52c6fccebd08f2529bae1c29e114e8c69be53"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-11-27 19:28:36.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-11-27 19:32:26.000000000","tz":-360},"subject":"Refactor _gen_resource_inventory","message":"Refactor _gen_resource_inventory\n\nThis refactors _gen_resource_inventory as suggested in [1], simplifying\nby removing unused fields which duplicated defaults that are set by\nplacement itself.\n\nThis patch introduces the previously absent test suite for conductor\nmanager.\n\n[1] I0aac84a1fc6b00b5523927bee27f7491daecd786\n\nChange-Id: I79379f55f3ea0690c58a7835d1e8c31117245626\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/a4fe3389498a98cd6449f02603a6ce96ea1eacdc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/a4fe3389498a98cd6449f02603a6ce96ea1eacdc"}]},"branch":"refs/heads/master"},"59b8047ea15793ca0b71acce8cdc35533eea3d7a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-12-16 15:41:24.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/93/696393/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/93/696393/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/93/696393/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/93/696393/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/93/696393/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/93/696393/2"}}},"commit":{"parents":[{"commit":"672aa7eb1e5335cfa7ab44480e1cd619c9de3e59","subject":"Merge \"Enable UT for objects/deployable.py and fix import error\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/672aa7eb1e5335cfa7ab44480e1cd619c9de3e59"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-11-27 19:28:36.000000000","tz":-360},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-12-16 15:41:24.000000000","tz":0},"subject":"Refactor _gen_resource_inventory","message":"Refactor _gen_resource_inventory\n\nThis refactors _gen_resource_inventory as suggested in [1], simplifying\nby removing unused fields which duplicated defaults that are set by\nplacement itself.\n\nThis patch introduces the previously absent test suite for conductor\nmanager.\n\n[1] I0aac84a1fc6b00b5523927bee27f7491daecd786\n\nChange-Id: I79379f55f3ea0690c58a7835d1e8c31117245626\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/59b8047ea15793ca0b71acce8cdc35533eea3d7a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/59b8047ea15793ca0b71acce8cdc35533eea3d7a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}