)]}'
{"cyborg/api/controllers/v2/arqs.py":[{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"41a3fa72454317e692da793eea55eed2afb8c396","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                # TODO(Sundar) This should return HTTP code 423"},{"line_number":199,"context_line":"                # if any ARQ for this instance is not resolved."},{"line_number":200,"context_line":"                LOG.warning(\u0027HTTP Response should be 423\u0027)"},{"line_number":201,"context_line":"                pecan.response.status \u003d http_client.LOCKED"},{"line_number":202,"context_line":"                return None"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        ret \u003d ARQCollection.convert_with_links(arqs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fdfa470f","side":"PARENT","line":201,"range":{"start_line":201,"start_character":16,"end_line":201,"end_character":58},"updated":"2019-11-28 10:30:39.000000000","message":"The reason why this line didn\u0027t work was because [1] overwrite this value. We can return a wsme.api.Response obj[2].\n[1]. https://opendev.org/x/wsme/src/branch/master/wsmeext/pecan.py#L87\n[2]. https://opendev.org/x/wsme/src/branch/master/wsmeext/pecan.py#L88","commit_id":"f6470592152224f45ca62abe55d09e75b56c3b2f"}],"cyborg/tests/unit/api/controllers/v2/test_arqs.py":[{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"6f66a9bb82e7bdc451127a40068bfb4af62788b5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from six.moves import http_client"},{"line_number":18,"context_line":"import unittest"},{"line_number":19,"context_line":"import webtest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a75012d7","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":14},"updated":"2019-12-03 01:33:32.000000000","message":"I don\u0027t think we need to add this extra module, if you want to the assert the Raises, just use webob\u0027s exc, there will have all the http exceptions.\nAnother thing is if you want to import extra modules next time you should add this into requirements.txt or test-requirements.txt.","commit_id":"6d0f5672dd3df9c2723df46e3792cf7325c70e76"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"7ec9efc8769251a9b3de00127f6fe47de4f7095d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from six.moves import http_client"},{"line_number":18,"context_line":"import unittest"},{"line_number":19,"context_line":"import webtest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e7adaa32","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":14},"in_reply_to":"3fa7e38b_a75012d7","updated":"2019-12-03 02:58:41.000000000","message":"Thanks zhurong. Agree if we import extra module, we should add this in test-requirement.txt.\nAnd I find that for this test case. Assert the response status_code is also a good solution. So in the new patch, I remove import webtest.","commit_id":"6d0f5672dd3df9c2723df46e3792cf7325c70e76"}]}