)]}'
{"cyborg/tests/unit/db/test_db_extarq.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ed80c442467991ce1f5608683e6292932df6f1ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Tests for manipulating ExtArq via the DB API\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cyborg.common import exception"},{"line_number":21,"context_line":"from cyborg.tests.unit.db import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8f3b76c7","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":32},"updated":"2020-02-08 04:39:15.000000000","message":"nit: Can we change this import to \"from oslo_utils.fixture import uuidsentinel as uuids\", when we want to get a uuid that  we can use \"uuid\u003duuids.fake (fake is any what would you want, eg. arq_uuid\u003duuids.arq_uuid)\".\n\nOf course, it\u0027s random.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"be35896688042e13b325524b3bf34ff0b30968df","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Tests for manipulating ExtArq via the DB API\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cyborg.common import exception"},{"line_number":21,"context_line":"from cyborg.tests.unit.db import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0c9b0d16","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":32},"in_reply_to":"3fa7e38b_8f3b76c7","updated":"2020-02-10 02:25:30.000000000","message":"Thanks Brin. That\u0027s a nice usage for uuid generator.  At the same time, I saw in Nova that some places use it, but there are still some codes that continue to use this method. So, I don\u0027t think it is necessary, but a good way, thank you for letting me know. I think I will use it at the right time.\nHere, generating a random uuid is obvious from the method name, and it is self-explanatory, which is why I decided to keep using it.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ed80c442467991ce1f5608683e6292932df6f1ac","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from cyborg.tests.unit.db import utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestDbExtArq(base.DbTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_create(self):"},{"line_number":28,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_efa0eaf4","line":25,"updated":"2020-02-08 04:39:15.000000000","message":"I saw in every patch of you tests contais \"created_extarq \u003d utils.create_test_extarq(self.context)\", how about set this in setUP() ? That while we use it by \"self.created_extarq\".\n\nAlso, it needs more than one request parameters in kw.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"05c123c56957d08558e8f097b28d01608e892699","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from cyborg.tests.unit.db import utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestDbExtArq(base.DbTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_create(self):"},{"line_number":28,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8f67f652","line":25,"in_reply_to":"3fa7e38b_efa0eaf4","updated":"2020-02-08 08:53:51.000000000","message":"Thanks. I thought about putting it in setup, but if we want to increase kw in the future, it is not convenient to put in setup, so we continue to put it in each function, although there are currently a few more codes.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ed80c442467991ce1f5608683e6292932df6f1ac","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_create(self):"},{"line_number":28,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"},{"line_number":29,"context_line":"        kw \u003d {\u0027uuid\u0027: random_uuid}"},{"line_number":30,"context_line":"        created_extarq \u003d utils.create_test_extarq(self.context, **kw)"},{"line_number":31,"context_line":"        self.assertEqual(random_uuid, created_extarq[\u0027uuid\u0027])"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0f96a6a1","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":10},"updated":"2020-02-08 04:39:15.000000000","message":"Can you add more than on parameter to the kw (eg. type, vendor)? I think that can be check your function in https://review.opendev.org/#/c/702807/9/cyborg/tests/unit/db/utils.py@45.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ed80c442467991ce1f5608683e6292932df6f1ac","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class TestDbExtArq(base.DbTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_create(self):"},{"line_number":28,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"},{"line_number":29,"context_line":"        kw \u003d {\u0027uuid\u0027: random_uuid}"},{"line_number":30,"context_line":"        created_extarq \u003d utils.create_test_extarq(self.context, **kw)"},{"line_number":31,"context_line":"        self.assertEqual(random_uuid, created_extarq[\u0027uuid\u0027])"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2f7602a5","line":29,"range":{"start_line":28,"start_character":8,"end_line":29,"end_character":34},"updated":"2020-02-08 04:39:15.000000000","message":"From above that this can be done as \"kw \u003d {\u0027uuid\u0027: uuids.uuid}\".","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"05c123c56957d08558e8f097b28d01608e892699","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_create(self):"},{"line_number":28,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"},{"line_number":29,"context_line":"        kw \u003d {\u0027uuid\u0027: random_uuid}"},{"line_number":30,"context_line":"        created_extarq \u003d utils.create_test_extarq(self.context, **kw)"},{"line_number":31,"context_line":"        self.assertEqual(random_uuid, created_extarq[\u0027uuid\u0027])"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_efad4a83","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":10},"in_reply_to":"3fa7e38b_0f96a6a1","updated":"2020-02-08 08:53:51.000000000","message":"I think the unique uuid is enough. The assertEqual can prove the create extarq is ok.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"05c123c56957d08558e8f097b28d01608e892699","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class TestDbExtArq(base.DbTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_create(self):"},{"line_number":28,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"},{"line_number":29,"context_line":"        kw \u003d {\u0027uuid\u0027: random_uuid}"},{"line_number":30,"context_line":"        created_extarq \u003d utils.create_test_extarq(self.context, **kw)"},{"line_number":31,"context_line":"        self.assertEqual(random_uuid, created_extarq[\u0027uuid\u0027])"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_af64324e","line":29,"range":{"start_line":28,"start_character":8,"end_line":29,"end_character":34},"in_reply_to":"3fa7e38b_2f7602a5","updated":"2020-02-08 08:53:51.000000000","message":"Thanks. Good advice.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ed80c442467991ce1f5608683e6292932df6f1ac","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertIsNone(return_value)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_get_by_uuid_not_exist(self):"},{"line_number":65,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"},{"line_number":66,"context_line":"        self.assertRaises(exception.ResourceNotFound,"},{"line_number":67,"context_line":"                          self.dbapi.extarq_get,"},{"line_number":68,"context_line":"                          self.context, random_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cf664ef1","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":47},"updated":"2020-02-08 04:39:15.000000000","message":"ditto.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"be35896688042e13b325524b3bf34ff0b30968df","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertIsNone(return_value)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_get_by_uuid_not_exist(self):"},{"line_number":65,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"},{"line_number":66,"context_line":"        self.assertRaises(exception.ResourceNotFound,"},{"line_number":67,"context_line":"                          self.dbapi.extarq_get,"},{"line_number":68,"context_line":"                          self.context, random_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ac83d9a9","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":47},"in_reply_to":"3fa7e38b_cf664ef1","updated":"2020-02-10 02:25:30.000000000","message":"Pls see the above reply.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ed80c442467991ce1f5608683e6292932df6f1ac","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                          self.context, random_uuid)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_delete_by_uuid_not_exist(self):"},{"line_number":71,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"},{"line_number":72,"context_line":"        self.assertRaises(exception.ResourceNotFound,"},{"line_number":73,"context_line":"                          self.dbapi.extarq_delete,"},{"line_number":74,"context_line":"                          self.context, random_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ef6b0ab5","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":47},"updated":"2020-02-08 04:39:15.000000000","message":"ditto.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"be35896688042e13b325524b3bf34ff0b30968df","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                          self.context, random_uuid)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_delete_by_uuid_not_exist(self):"},{"line_number":71,"context_line":"        random_uuid \u003d uuidutils.generate_uuid()"},{"line_number":72,"context_line":"        self.assertRaises(exception.ResourceNotFound,"},{"line_number":73,"context_line":"                          self.dbapi.extarq_delete,"},{"line_number":74,"context_line":"                          self.context, random_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cc80959f","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":47},"in_reply_to":"3fa7e38b_ef6b0ab5","updated":"2020-02-10 02:25:30.000000000","message":"Pls see the above reply.","commit_id":"e3012c1d1dba6591e0c01773857da58b7ffed53f"}]}