)]}'
{"id":"openstack%2Fcyborg~708655","triplet_id":"openstack%2Fcyborg~master~I263f7222119d8d0c89cfc2a4758fe376ce1afd60","project":"openstack/cyborg","branch":"master","topic":"async-ut-v9","hashtags":[],"change_id":"I263f7222119d8d0c89cfc2a4758fe376ce1afd60","subject":"change default SimpleQueue to _PySimpleQueue for queue","status":"MERGED","created":"2020-02-19 14:01:08.000000000","updated":"2020-03-05 06:07:35.000000000","submitted":"2020-03-05 06:07:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"708655-1583388455372-b70934f3","meta_rev_id":"5e9e55fcb779f4b74490212ddab0f9ce56054498","_number":708655,"virtual_id_number":708655,"owner":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-02-20 10:09:47.000000000","_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-05 06:07:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"all":[{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":2,"date":"2020-02-20 14:39:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":1,"date":"2020-02-21 09:10:46.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-02-21 09:19:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"all":[{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-02-21 09:19:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-20 14:39:13.000000000","updated_by":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"reviewer":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"state":"REVIEWER"},{"updated":"2020-02-21 09:10:46.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2020-02-21 09:19:04.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2020-03-05 06:07:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c2207c1410e304ae8d3ac5a672767412eff0b3f3","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-19 14:01:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ed2a87597f6d77116abe2896d443a4357c467807","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-19 14:01:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0cb826ccfb3a1ce5db4f5467d3af87415d73391e","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-19 14:02:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5ed1bfb3dbec4ace7676bb79cb95ef52d6e46f9f","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-19 14:31:43.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"b6b1032658c473d76af1262ee956b3e7fe23d836","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-19 14:36:01.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"930823ea324ae82b6103539cc0221bab73099b7f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 15:13:43.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ab5e21f6a866438dba967082992d4188 : FAILURE in 5m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5c6ad7a4e0514682b72ef3968626e49c : FAILURE in 8m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/80609e4cf6aa4bfc97f78184a4660a08 : FAILURE in 4m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/16847501947d4b139eda9146fcbe30c1 : SUCCESS in 6m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/766cc1c23077472f88f4702c52ca40d9 : SUCCESS in 7m 11s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/95c3cf4d0e9749c98a5a5fa7632ada2b : FAILURE in 5m 29s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/cf97654100134e02a7b8df1c9482ab74 : FAILURE in 31m 17s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a1ebec43827a4a54bb3bf34f53c9bbcf : FAILURE in 28m 18s (non-voting)\n- cyborg-tox-bandit https://zuul.opendev.org/t/openstack/build/afae7c895ebe4aa6a5f1342338eefbc4 : FAILURE in 7m 12s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"33f7529ab356cc9e0d2a41290393223a53393192","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-19 15:48:51.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"06498dff1b95f613c10aef60de629995d2dd408a","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-19 15:50:51.000000000","message":"Patch Set 6:\n\nAll these 6 patch sets can be used to fix this problem.","accounts_in_message":[],"_revision_number":6},{"id":"bf118117dc3dae44eaf0a34658a80ad92602edbd","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-19 16:18:11.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"7cf9671028f1c63cfe2f8376d1e0f9a042f346ce","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 17:02:13.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/caa72a99f6ec4999b1424956b60b239f : SUCCESS in 6m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a6f562d6a7cd4171836c59f16169af69 : SUCCESS in 5m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a45ef94484bd4c5a8ef8397fcd7123c3 : SUCCESS in 6m 59s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7df4618cfc184374b17b44010cf91f17 : SUCCESS in 5m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/07eb1db691ac4b588d97022f417959a2 : SUCCESS in 6m 18s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91766410361143f4b8171460914ee75e : SUCCESS in 7m 23s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/c8772a0557834544b4498596f5d341ed : SUCCESS in 30m 41s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1c9d33f690cf447093a39e1ec6609321 : SUCCESS in 36m 03s (non-voting)\n- cyborg-tox-bandit https://zuul.opendev.org/t/openstack/build/6fafb53e7a8c426793e928b54fa93d7b : FAILURE in 6m 15s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"63544851069165a00969b930ff3d0a5e5adcdf61","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-20 10:09:47.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"13fa2f7a50e6e01a4bb90a2f73a309c0cd74eeee","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-02-20 11:08:31.000000000","message":"Patch Set 7: Code-Review+1\n\n(1 comment)\n\nThanks shaohe.","accounts_in_message":[],"_revision_number":7},{"id":"a1ac40d2623797e14444852ebc7248f9c8cf029e","author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"date":"2020-02-20 14:39:13.000000000","message":"Patch Set 7: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":7},{"id":"902d9167ff024d338cad89b9d00975205ccee3b9","author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"date":"2020-02-20 15:08:31.000000000","message":"Patch Set 3:\n\nThe fallowing 2 patches must be depended on this one.","accounts_in_message":[],"_revision_number":3},{"id":"f1515c9afb3402109fd87eeb1404650fa685ee4b","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-02-21 09:10:46.000000000","message":"Patch Set 7: Code-Review+1\n\nLGTM, thanks  ShaoHe","accounts_in_message":[],"_revision_number":7},{"id":"35468da8df6a88d8780d1d72bfc3053043aef684","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-02-21 09:19:04.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":7},{"id":"292b264576def0c30210d3a921a6edf12df740fd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 05:31:25.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"3543d36a351c900e08b7bf814eabd9d8378e9fbf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 06:07:35.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/062769e6d0a940b88f59e14bc204b403 : SUCCESS in 4m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/21d7d0b34664428fa95e28198aa3dde0 : SUCCESS in 3m 44s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/42e14865a65a40b2b41297f10580c0ae : SUCCESS in 4m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ae1f4584f45e423db95dabdcb76f039f : SUCCESS in 3m 50s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/cb1d32f75bb64fbea339bcdcb5f60486 : SUCCESS in 31m 06s","accounts_in_message":[],"_revision_number":7},{"id":"8cc0b940233e58984d1ca3e881f860be6f9c6394","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 06:07:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"16ac71928deea9bc6e4f4d84c3a3a2b78f6e7367","revisions":{"4d8a311c80f7db50c31dc16f9fdfbce1e8384a5d":{"kind":"REWORK","_number":1,"created":"2020-02-19 14:01:08.000000000","uploader":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"ref":"refs/changes/55/708655/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/55/708655/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/55/708655/1"}}},"commit":{"parents":[{"commit":"b123b100c06e0c647e1a352ae3b9486507a5ae8a","subject":"add testcase for check_bindings_result failed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b123b100c06e0c647e1a352ae3b9486507a5ae8a"}]}],"author":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 09:52:48.000000000","tz":0},"committer":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 11:55:21.000000000","tz":0},"subject":"comment eventlet for unit test","message":"comment eventlet for unit test\n\npy3.7 deadlock with monkey patch of stdlib thread modules + use of\nThreadPoolExecutor\n\n3.7, ThreadPoolExecuter was changed to use queue.SimpleQueue; on 3.6 it\nuses queue.Queue. No issue in 3.6\n\nThe python37 default SimpleQueue was implemented with C code, which will\ncause hang the main thread.\n\nCommit 2a71b8e introduce eventlet for unittest, but I did not find\nwhy we need it.\nCheck other project they also use ThreadPoolExecutor, but not all\nof them introduce eventlet.\n\nMaybe GreenThreadPoolExecutor is another solution.\n\nRef:\nThreadPoolExecutor\nhttps://docs.python.org/3.7/library/concurrent.futures.html#threadpoolexecutor\n\nSame isses about ThreadPoolExecutor and eventlet\nhttps://bugs.launchpad.net/designate/+bug/1782647\nhttps://github.com/eventlet/eventlet/issues/508\nhttps://github.com/gevent/gevent/pull/1253\nhttps://github.com/ClericPy/torequests/issues/10\nhttps://bugs.python.org/issue34173\nhttps://github.com/gevent/gevent/issues/1248\nhttps://github.com/gevent/gevent/issues/1251\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-July/132473.html\nhttps://www.gitmemory.com/issue/eventlet/eventlet/508/511101004\n\nChange-Id: I263f7222119d8d0c89cfc2a4758fe376ce1afd60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/4d8a311c80f7db50c31dc16f9fdfbce1e8384a5d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/4d8a311c80f7db50c31dc16f9fdfbce1e8384a5d"}]},"branch":"refs/heads/master"},"86af28599975024711eb68b30cdb72171f53b863":{"kind":"REWORK","_number":2,"created":"2020-02-19 14:01:34.000000000","uploader":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"ref":"refs/changes/55/708655/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/55/708655/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/55/708655/2"}}},"commit":{"parents":[{"commit":"b123b100c06e0c647e1a352ae3b9486507a5ae8a","subject":"add testcase for check_bindings_result failed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b123b100c06e0c647e1a352ae3b9486507a5ae8a"}]}],"author":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 09:52:48.000000000","tz":0},"committer":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 13:43:40.000000000","tz":0},"subject":"change default SimpleQueue of queue to _PySimpleQueue for unit test","message":"change default SimpleQueue of queue to _PySimpleQueue for unit test\n\npy3.7 deadlock with monkey patch of stdlib thread modules + use of\nThreadPoolExecutor\n\n3.7, ThreadPoolExecuter was changed to use queue.SimpleQueue; on 3.6 it\nuses queue.Queue. No issue in 3.6\n\nThe python37 default SimpleQueue was implemented with C code, which will\ncause hang the main thread.\n\nCommit 2a71b8e introduce eventlet for unittest, but I did not find\nwhy we need it.\nCheck other project they also use ThreadPoolExecutor, but not all\nof them introduce eventlet.\n\nMaybe GreenThreadPoolExecutor is another solution.\n\nRef:\nThreadPoolExecutor\nhttps://docs.python.org/3.7/library/concurrent.futures.html#threadpoolexecutor\n\nSame isses about ThreadPoolExecutor and eventlet\nhttps://bugs.launchpad.net/designate/+bug/1782647\nhttps://github.com/eventlet/eventlet/issues/508\nhttps://github.com/gevent/gevent/pull/1253\nhttps://github.com/ClericPy/torequests/issues/10\nhttps://bugs.python.org/issue34173\nhttps://github.com/gevent/gevent/issues/1248\nhttps://github.com/gevent/gevent/issues/1251\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-July/132473.html\nhttps://www.gitmemory.com/issue/eventlet/eventlet/508/511101004\n\nChange-Id: I263f7222119d8d0c89cfc2a4758fe376ce1afd60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/86af28599975024711eb68b30cdb72171f53b863"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/86af28599975024711eb68b30cdb72171f53b863"}]},"branch":"refs/heads/master"},"9d2a9bddc623bf084a881436b54c5c3e6e8120d6":{"kind":"REWORK","_number":3,"created":"2020-02-19 14:02:22.000000000","uploader":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"ref":"refs/changes/55/708655/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/55/708655/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/55/708655/3"}}},"commit":{"parents":[{"commit":"b123b100c06e0c647e1a352ae3b9486507a5ae8a","subject":"add testcase for check_bindings_result failed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b123b100c06e0c647e1a352ae3b9486507a5ae8a"}]}],"author":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 09:52:48.000000000","tz":0},"committer":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 13:44:45.000000000","tz":0},"subject":"change default SimpleQueue to _PySimpleQueue for queue","message":"change default SimpleQueue to _PySimpleQueue for queue\n\npy3.7 deadlock with monkey patch of stdlib thread modules + use of\nThreadPoolExecutor\n\n3.7, ThreadPoolExecuter was changed to use queue.SimpleQueue; on 3.6 it\nuses queue.Queue. No issue in 3.6\n\nThe python37 default SimpleQueue was implemented with C code, which will\ncause hang the main thread.\n\nCommit 2a71b8e introduce eventlet for unittest, but I did not find\nwhy we need it.\nCheck other project they also use ThreadPoolExecutor, but not all\nof them introduce eventlet.\n\nMaybe GreenThreadPoolExecutor is another solution.\n\nRef:\nThreadPoolExecutor\nhttps://docs.python.org/3.7/library/concurrent.futures.html#threadpoolexecutor\n\nSame isses about ThreadPoolExecutor and eventlet\nhttps://bugs.launchpad.net/designate/+bug/1782647\nhttps://github.com/eventlet/eventlet/issues/508\nhttps://github.com/gevent/gevent/pull/1253\nhttps://github.com/ClericPy/torequests/issues/10\nhttps://bugs.python.org/issue34173\nhttps://github.com/gevent/gevent/issues/1248\nhttps://github.com/gevent/gevent/issues/1251\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-July/132473.html\nhttps://www.gitmemory.com/issue/eventlet/eventlet/508/511101004\n\nChange-Id: I263f7222119d8d0c89cfc2a4758fe376ce1afd60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/9d2a9bddc623bf084a881436b54c5c3e6e8120d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/9d2a9bddc623bf084a881436b54c5c3e6e8120d6"}]},"branch":"refs/heads/master"},"86293a451b2befafcd2a635e89c466fd39769d9a":{"kind":"REWORK","_number":4,"created":"2020-02-19 14:31:43.000000000","uploader":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"ref":"refs/changes/55/708655/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/55/708655/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/55/708655/4"}}},"commit":{"parents":[{"commit":"b123b100c06e0c647e1a352ae3b9486507a5ae8a","subject":"add testcase for check_bindings_result failed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b123b100c06e0c647e1a352ae3b9486507a5ae8a"}]}],"author":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 09:52:48.000000000","tz":0},"committer":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 14:18:13.000000000","tz":0},"subject":"change default SimpleQueue to _PySimpleQueue for queue","message":"change default SimpleQueue to _PySimpleQueue for queue\n\npy3.7 deadlock with monkey patch of stdlib thread modules + use of\nThreadPoolExecutor\n\n3.7, ThreadPoolExecuter was changed to use queue.SimpleQueue; on 3.6 it\nuses queue.Queue. No issue in 3.6\n\nThe python37 default SimpleQueue was implemented with C code, which will\ncause hang the main thread.\n\nCommit 2a71b8e introduce eventlet for unittest, but I did not find\nwhy we need it.\nCheck other project they also use ThreadPoolExecutor, but not all\nof them introduce eventlet.\n\nMaybe GreenThreadPoolExecutor is another solution.\n\nRef:\nThreadPoolExecutor\nhttps://docs.python.org/3.7/library/concurrent.futures.html#threadpoolexecutor\n\nSame isses about ThreadPoolExecutor and eventlet\nhttps://bugs.launchpad.net/designate/+bug/1782647\nhttps://github.com/eventlet/eventlet/issues/508\nhttps://github.com/gevent/gevent/pull/1253\nhttps://github.com/ClericPy/torequests/issues/10\nhttps://bugs.python.org/issue34173\nhttps://github.com/gevent/gevent/issues/1248\nhttps://github.com/gevent/gevent/issues/1251\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-July/132473.html\nhttps://www.gitmemory.com/issue/eventlet/eventlet/508/511101004\n\nChange-Id: I263f7222119d8d0c89cfc2a4758fe376ce1afd60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/86293a451b2befafcd2a635e89c466fd39769d9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/86293a451b2befafcd2a635e89c466fd39769d9a"}]},"branch":"refs/heads/master"},"0773b89e6f2bf136e874bb1bc88c21a07dabc1d4":{"kind":"REWORK","_number":5,"created":"2020-02-19 14:36:01.000000000","uploader":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"ref":"refs/changes/55/708655/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/55/708655/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/55/708655/5"}}},"commit":{"parents":[{"commit":"b123b100c06e0c647e1a352ae3b9486507a5ae8a","subject":"add testcase for check_bindings_result failed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b123b100c06e0c647e1a352ae3b9486507a5ae8a"}]}],"author":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 09:52:48.000000000","tz":0},"committer":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 14:22:05.000000000","tz":0},"subject":"change default SimpleQueue to _PySimpleQueue for queue","message":"change default SimpleQueue to _PySimpleQueue for queue\n\npy3.7 deadlock with monkey patch of stdlib thread modules + use of\nThreadPoolExecutor\n\n3.7, ThreadPoolExecuter was changed to use queue.SimpleQueue; on 3.6 it\nuses queue.Queue. No issue in 3.6\n\nThe python37 default SimpleQueue was implemented with C code, which will\ncause hang the main thread.\n\nCommit 2a71b8e introduce eventlet for unittest, but I did not find\nwhy we need it.\nCheck other project they also use ThreadPoolExecutor, but not all\nof them introduce eventlet.\n\nMaybe GreenThreadPoolExecutor is another solution.\n\nRef:\nThreadPoolExecutor\nhttps://docs.python.org/3.7/library/concurrent.futures.html#threadpoolexecutor\n\nSame isses about ThreadPoolExecutor and eventlet\nhttps://bugs.launchpad.net/designate/+bug/1782647\nhttps://github.com/eventlet/eventlet/issues/508\nhttps://github.com/gevent/gevent/pull/1253\nhttps://github.com/ClericPy/torequests/issues/10\nhttps://bugs.python.org/issue34173\nhttps://github.com/gevent/gevent/issues/1248\nhttps://github.com/gevent/gevent/issues/1251\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-July/132473.html\nhttps://www.gitmemory.com/issue/eventlet/eventlet/508/511101004\n\nChange-Id: I263f7222119d8d0c89cfc2a4758fe376ce1afd60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/0773b89e6f2bf136e874bb1bc88c21a07dabc1d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/0773b89e6f2bf136e874bb1bc88c21a07dabc1d4"}]},"branch":"refs/heads/master"},"1ee25bfbce28d11f40e2cc18840c32f0ad9b96f3":{"kind":"REWORK","_number":6,"created":"2020-02-19 15:48:51.000000000","uploader":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"ref":"refs/changes/55/708655/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/55/708655/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/55/708655/6"}}},"commit":{"parents":[{"commit":"b123b100c06e0c647e1a352ae3b9486507a5ae8a","subject":"add testcase for check_bindings_result failed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b123b100c06e0c647e1a352ae3b9486507a5ae8a"}]}],"author":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 09:52:48.000000000","tz":0},"committer":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 15:33:40.000000000","tz":0},"subject":"change default SimpleQueue to _PySimpleQueue for queue","message":"change default SimpleQueue to _PySimpleQueue for queue\n\npy3.7 deadlock with monkey patch of stdlib thread modules + use of\nThreadPoolExecutor\n\n3.7, ThreadPoolExecuter was changed to use queue.SimpleQueue; on 3.6 it\nuses queue.Queue. No issue in 3.6\n\nThe python37 default SimpleQueue was implemented with C code, which will\ncause hang the main thread.\n\nCommit 2a71b8e introduce eventlet for unittest, but I did not find\nwhy we need it.\nCheck other project they also use ThreadPoolExecutor, but not all\nof them introduce eventlet.\n\nMaybe GreenThreadPoolExecutor is another solution.\n\nRef:\nThreadPoolExecutor\nhttps://docs.python.org/3.7/library/concurrent.futures.html#threadpoolexecutor\n\nSame isses about ThreadPoolExecutor and eventlet\nhttps://bugs.launchpad.net/designate/+bug/1782647\nhttps://github.com/eventlet/eventlet/issues/508\nhttps://github.com/gevent/gevent/pull/1253\nhttps://github.com/ClericPy/torequests/issues/10\nhttps://bugs.python.org/issue34173\nhttps://github.com/gevent/gevent/issues/1248\nhttps://github.com/gevent/gevent/issues/1251\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-July/132473.html\nhttps://www.gitmemory.com/issue/eventlet/eventlet/508/511101004\n\nChange-Id: I263f7222119d8d0c89cfc2a4758fe376ce1afd60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/1ee25bfbce28d11f40e2cc18840c32f0ad9b96f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/1ee25bfbce28d11f40e2cc18840c32f0ad9b96f3"}]},"branch":"refs/heads/master"},"16ac71928deea9bc6e4f4d84c3a3a2b78f6e7367":{"kind":"REWORK","_number":7,"created":"2020-02-19 16:18:11.000000000","uploader":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"ref":"refs/changes/55/708655/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/55/708655/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/55/708655/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/55/708655/7"}}},"commit":{"parents":[{"commit":"b123b100c06e0c647e1a352ae3b9486507a5ae8a","subject":"add testcase for check_bindings_result failed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b123b100c06e0c647e1a352ae3b9486507a5ae8a"}]}],"author":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 09:52:48.000000000","tz":0},"committer":{"name":"Shaohe Feng","email":"shaohe.feng@intel.com","date":"2020-02-19 16:04:55.000000000","tz":0},"subject":"change default SimpleQueue to _PySimpleQueue for queue","message":"change default SimpleQueue to _PySimpleQueue for queue\n\npy3.7 deadlock with monkey patch of stdlib thread modules + use of\nThreadPoolExecutor\n\n3.7, ThreadPoolExecuter was changed to use queue.SimpleQueue; on 3.6 it\nuses queue.Queue. No issue in 3.6\n\nThe python37 default SimpleQueue was implemented with C code, which will\ncause hang the main thread.\n\nCommit 2a71b8e introduce eventlet for unittest, but I did not find\nwhy we need it.\nCheck other project they also use ThreadPoolExecutor, but not all\nof them introduce eventlet.\n\nMaybe GreenThreadPoolExecutor is another solution.\n\nRef:\nThreadPoolExecutor\nhttps://docs.python.org/3.7/library/concurrent.futures.html#threadpoolexecutor\n\nSame isses about ThreadPoolExecutor and eventlet\nhttps://bugs.launchpad.net/designate/+bug/1782647\nhttps://github.com/eventlet/eventlet/issues/508\nhttps://github.com/gevent/gevent/pull/1253\nhttps://github.com/ClericPy/torequests/issues/10\nhttps://bugs.python.org/issue34173\nhttps://github.com/gevent/gevent/issues/1248\nhttps://github.com/gevent/gevent/issues/1251\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-July/132473.html\nhttps://www.gitmemory.com/issue/eventlet/eventlet/508/511101004\n\nChange-Id: I263f7222119d8d0c89cfc2a4758fe376ce1afd60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/16ac71928deea9bc6e4f4d84c3a3a2b78f6e7367"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/16ac71928deea9bc6e4f4d84c3a3a2b78f6e7367"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}