)]}'
{"tox.ini":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"79e250fdc296295893219415e31c728c9fd92900","unresolved":false,"context_lines":[{"line_number":104,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":105,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,*sqlalchemy/alembic/versions/*,demo/,releasenotes"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"[testenv:bandit]"},{"line_number":108,"context_line":"commands \u003d bandit -r cyborg -x cyborg/tests/* -n 5 -ll"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"[hacking]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_a63fc982","side":"PARENT","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":16},"updated":"2020-02-20 08:00:28.000000000","message":"Just a suggestion: \nthe right patch is different orders of evn config with this one. \nSome hard for the reviewer to review.","commit_id":"e0ba01891fd479b42a95e76017b30d21b631430d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c8526225242b0000fc294aac0221d3c93e699938","unresolved":false,"context_lines":[{"line_number":104,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":105,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,*sqlalchemy/alembic/versions/*,demo/,releasenotes"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"[testenv:bandit]"},{"line_number":108,"context_line":"commands \u003d bandit -r cyborg -x cyborg/tests/* -n 5 -ll"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"[hacking]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_7523b258","side":"PARENT","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":16},"in_reply_to":"3fa7e38b_a63fc982","updated":"2020-02-20 12:53:52.000000000","message":"yes you are right althoug i kind of wanted to group common envs togther. e.g. i put all the tools together then all the docs evns. \n\ni guess i coudl have done that in a seperate patch.\ni plan to add 1 more patch to update the tox support to add pdf doc support as a follow up but this patch was already getting quite large","commit_id":"e0ba01891fd479b42a95e76017b30d21b631430d"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"79e250fdc296295893219415e31c728c9fd92900","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"envlist \u003d py3{6,7},pep8,docs,releasenotes,cover"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"# Automatic envs (pyXX) will only use the python version appropriate to that"},{"line_number":6,"context_line":"# env and ignore basepython inherited from [testenv] if we set"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_cba210ad","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":18},"updated":"2020-02-20 08:00:28.000000000","message":"wonder why generative envlist not include py38?","commit_id":"f0900a2e4375ddf450d4614eeff1939dfd1c3792"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c8526225242b0000fc294aac0221d3c93e699938","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"envlist \u003d py3{6,7},pep8,docs,releasenotes,cover"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"# Automatic envs (pyXX) will only use the python version appropriate to that"},{"line_number":6,"context_line":"# env and ignore basepython inherited from [testenv] if we set"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_b5cdaaba","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":18},"in_reply_to":"3fa7e38b_cba210ad","updated":"2020-02-20 12:53:52.000000000","message":"oh good point i can certainly add that\n\ni think py38 is not required for ussuri but it does not hurt to run it if you have it installed","commit_id":"f0900a2e4375ddf450d4614eeff1939dfd1c3792"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"79e250fdc296295893219415e31c728c9fd92900","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# ignore_basepython_conflict."},{"line_number":8,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":9,"context_line":"# skip default execution of test env if the interperter version is not present."},{"line_number":10,"context_line":"skip_missing_interpreters \u003d True"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[testenv]"},{"line_number":13,"context_line":"usedevelop \u003d True"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_2b872414","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":25},"updated":"2020-02-20 08:00:28.000000000","message":"waht\u0027s the default value? not find in the doc link, not know the side effect.\nhttps://tox.readthedocs.io/en/latest/config.html#conf-skip_missing_interpreters","commit_id":"f0900a2e4375ddf450d4614eeff1939dfd1c3792"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c8526225242b0000fc294aac0221d3c93e699938","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# ignore_basepython_conflict."},{"line_number":8,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":9,"context_line":"# skip default execution of test env if the interperter version is not present."},{"line_number":10,"context_line":"skip_missing_interpreters \u003d True"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[testenv]"},{"line_number":13,"context_line":"usedevelop \u003d True"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_952f4e56","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":25},"in_reply_to":"3fa7e38b_2b872414","updated":"2020-02-20 12:53:52.000000000","message":"the default is false i belive.\n\nsetting it to ture will just have the effefct that if an interperter is not availabel on the local host it will be skiped when tox is invoked without -e","commit_id":"f0900a2e4375ddf450d4614eeff1939dfd1c3792"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"79e250fdc296295893219415e31c728c9fd92900","unresolved":false,"context_lines":[{"line_number":61,"context_line":"[testenv:cover]"},{"line_number":62,"context_line":"envdir \u003d {toxworkdir}/venv"},{"line_number":63,"context_line":"setenv \u003d"},{"line_number":64,"context_line":"    {[testenv]setenv}"},{"line_number":65,"context_line":"    PYTHON\u003dcoverage run --source cyborg --parallel-mode"},{"line_number":66,"context_line":"commands \u003d"},{"line_number":67,"context_line":"    stestr run {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_067c9d72","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":21},"updated":"2020-02-20 08:00:28.000000000","message":"why need these extra setevn?\nIs there a bug before this patch?","commit_id":"f0900a2e4375ddf450d4614eeff1939dfd1c3792"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c8526225242b0000fc294aac0221d3c93e699938","unresolved":false,"context_lines":[{"line_number":61,"context_line":"[testenv:cover]"},{"line_number":62,"context_line":"envdir \u003d {toxworkdir}/venv"},{"line_number":63,"context_line":"setenv \u003d"},{"line_number":64,"context_line":"    {[testenv]setenv}"},{"line_number":65,"context_line":"    PYTHON\u003dcoverage run --source cyborg --parallel-mode"},{"line_number":66,"context_line":"commands \u003d"},{"line_number":67,"context_line":"    stestr run {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_95fd0eba","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":21},"in_reply_to":"3fa7e38b_067c9d72","updated":"2020-02-20 12:53:52.000000000","message":"well before this patch \n\n   VIRTUAL_ENV\u003d{envdir}\n    OS_TEST_PATH\u003dcyborg/tests/unit\nwere not set when runing coverage.\nbut the reason it is here is because of \n  CONSTRAINTS_OPT \u003d -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}\n\nthis with the way i have refactored it the substituion of in the deps will fail.","commit_id":"f0900a2e4375ddf450d4614eeff1939dfd1c3792"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# env and ignore basepython inherited from [testenv] if we set"},{"line_number":7,"context_line":"# ignore_basepython_conflict."},{"line_number":8,"context_line":"ignore_basepython_conflict \u003d True"},{"line_number":9,"context_line":"# skip default execution of test env if the interpreter version is not present."},{"line_number":10,"context_line":"skip_missing_interpreters \u003d True"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[testenv]"},{"line_number":13,"context_line":"basepython \u003d python3"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_fa5dccec","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":32},"updated":"2020-06-10 17:34:07.000000000","message":"We\u0027ve discussed this before so you know my thoughts. You shouldn\u0027t have this here. Alias tox with the command-line variant of this if you really want it","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"whitelist_externals \u003d"},{"line_number":16,"context_line":"  rm"},{"line_number":17,"context_line":"  make"},{"line_number":18,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":19,"context_line":"setenv \u003d"},{"line_number":20,"context_line":"    VIRTUAL_ENV\u003d{envdir}"},{"line_number":21,"context_line":"    OS_TEST_PATH\u003dcyborg/tests/unit"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_7a489c2d","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":47},"updated":"2020-06-10 17:34:07.000000000","message":"You don\u0027t need this. It\u0027s the default","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"setenv \u003d"},{"line_number":20,"context_line":"    VIRTUAL_ENV\u003d{envdir}"},{"line_number":21,"context_line":"    OS_TEST_PATH\u003dcyborg/tests/unit"},{"line_number":22,"context_line":"    CONSTRAINTS_OPT \u003d -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":23,"context_line":"deps \u003d"},{"line_number":24,"context_line":"   {env:CONSTRAINTS_OPT}"},{"line_number":25,"context_line":"  -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_da0728c9","line":22,"updated":"2020-06-10 17:34:07.000000000","message":"I get what you\u0027re doing here, but duplicating this elsewhere would be clearer IMO. It\u0027s not like it reduces line count","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"commands \u003d rm -f .testrepository/times.dbm"},{"line_number":29,"context_line":"           stestr run --slowest {posargs}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# --------------------- helper envs ----------------------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_5af318e8","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":58},"updated":"2020-06-10 17:34:07.000000000","message":"I like the idea of separating stuff but this seems like unnecessary noise, IMO","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"[testenv:pep8]"},{"line_number":76,"context_line":"envdir \u003d {toxworkdir}/venv"},{"line_number":77,"context_line":"commands \u003d"},{"line_number":78,"context_line":"    flake8"},{"line_number":79,"context_line":"    doc8 doc/source/ CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"[flake8]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_3a26246a","line":78,"range":{"start_line":78,"start_character":2,"end_line":78,"end_character":4},"updated":"2020-06-10 17:34:07.000000000","message":"nit: it\u0027d be nice settle on a preferred indentation while you\u0027re doing this surgery, IMO","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  M352 \u003d checks:no_log_warn"},{"line_number":100,"context_line":"paths \u003d ./cyborg/hacking"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[hacking]"},{"line_number":103,"context_line":"local-check-factory \u003d cyborg.hacking.checks.factory"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[testenv:bandit]"},{"line_number":106,"context_line":"envdir \u003d {toxworkdir}/venv"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_baeeb4ea","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":51},"updated":"2020-06-10 17:34:07.000000000","message":"oh, I assume cyborg is still using hacking \u003c 2.0? If not, this can go since it\u0027s not used in recent hacking versions","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"envdir \u003d {toxworkdir}/venv"},{"line_number":107,"context_line":"commands \u003d bandit -r cyborg -x cyborg/tests/* -n 5 -ll"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# ---------------------- docs -------------------------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[doc8]"},{"line_number":112,"context_line":"ignore-path \u003d .venv,.git,.tox,*cyborg/locale*,*lib/python*,*cyborg.egg*,api-ref/build,doc/build,doc/source/contributor/api"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_5a1cb812","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":55},"updated":"2020-06-10 17:34:07.000000000","message":"if you\u0027re keeping this, it really belongs below doc8 since doc8 is a linter","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"   {env:CONSTRAINTS_OPT}"},{"line_number":117,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":118,"context_line":"commands \u003d"},{"line_number":119,"context_line":"    rm -rf doc/build/html"},{"line_number":120,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"[testenv:pdf-docs]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_fad02c2e","line":119,"range":{"start_line":119,"start_character":2,"end_line":119,"end_character":4},"updated":"2020-06-10 17:34:07.000000000","message":"nit","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"154938eef3026d6a4cb51ee921490c3a22e2ba3d","unresolved":false,"context_lines":[{"line_number":140,"context_line":"commands \u003d"},{"line_number":141,"context_line":"  rm -rf api-ref/build"},{"line_number":142,"context_line":"  sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html"},{"line_number":143,"context_line":"whitelist_externals \u003d rm"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_dad5681d","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":24},"updated":"2020-06-10 17:34:07.000000000","message":"unnecessary (it\u0027s done in the parent)","commit_id":"b992803be88e6c6d0cdc11ace9036d0216899ce6"}]}