)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"352c4bce8f1301a3961b0bcafac6732e94daf7b0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  installs only the cyborg agent"},{"line_number":16,"context_line":"all-in-one:"},{"line_number":17,"context_line":"  installs all cyborg services, api, conductor"},{"line_number":18,"context_line":"  and agent on a singel host. This is the default"},{"line_number":19,"context_line":"  if CYBORG_MODE is not set."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This change moves all function definitions from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_fb9eb3f8","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":23},"updated":"2020-02-20 14:57:41.000000000","message":"single","commit_id":"1a6f266b72c12f8ce1e5688c457a978f5c59f5af"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"352c4bce8f1301a3961b0bcafac6732e94daf7b0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"all-in-one:"},{"line_number":17,"context_line":"  installs all cyborg services, api, conductor"},{"line_number":18,"context_line":"  and agent on a singel host. This is the default"},{"line_number":19,"context_line":"  if CYBORG_MODE is not set."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This change moves all function definitions from"},{"line_number":22,"context_line":"devstack/plugin.sh to devstack/lib/cyborg"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7b6883f2","line":19,"updated":"2020-02-20 14:57:41.000000000","message":"Maybe this is easier, but why can\u0027t we just go based on\n\ndisable_service cyborg-api\ndisable_service cyborg-cond\n\nwhen we\u0027re on a compute-only subnode? Isn\u0027t that more conventional for devstack?","commit_id":"1a6f266b72c12f8ce1e5688c457a978f5c59f5af"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"94127b2809b0fe09ff3418d76153e4cb2f1beaed","unresolved":false,"context_lines":[{"line_number":16,"context_line":"all-in-one:"},{"line_number":17,"context_line":"  installs all cyborg services, api, conductor"},{"line_number":18,"context_line":"  and agent on a singel host. This is the default"},{"line_number":19,"context_line":"  if CYBORG_MODE is not set."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This change moves all function definitions from"},{"line_number":22,"context_line":"devstack/plugin.sh to devstack/lib/cyborg"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_0157a0f7","line":19,"in_reply_to":"3fa7e38b_7b6883f2","updated":"2020-02-20 15:51:13.000000000","message":"yep it is.\n\ni had found that when we added the mode option to networking-ovs-dpdk people made less mistakes but we did not support enable_plugin or disable plugin because it was not normal partic to use that with plugin wehn we wrote it in kilo.\n\nover time that convention has started to be used in plugins too so i guss this is not needed\n\nthis is more a nice to have but config generation changes are neeed\n\nill split this into two patches and we can figure out  if the mode option is desireable later.","commit_id":"1a6f266b72c12f8ce1e5688c457a978f5c59f5af"}],"devstack/lib/cyborg":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"352c4bce8f1301a3961b0bcafac6732e94daf7b0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# - cleanup_cyborg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(sean-k-mooney): this does not install anything"},{"line_number":23,"context_line":"# consider renameing."},{"line_number":24,"context_line":"function install_cyborg_in_controller {"},{"line_number":25,"context_line":"    if is_service_enabled cyborg-api; then"},{"line_number":26,"context_line":"        local req_services\u003d\"key\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_3b6a0bea","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":20},"updated":"2020-02-20 14:57:41.000000000","message":"renaming","commit_id":"1a6f266b72c12f8ce1e5688c457a978f5c59f5af"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f7a57637e59c0cb3b9a6f7c965bbb139e7b82b98","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    iniset $CYBORG_CONF_FILE database connection `database_connection_url cyborg`"},{"line_number":156,"context_line":"    iniset $CYBORG_CONF_FILE DEFAULT state_path $CYBORG_STATE_PATH"},{"line_number":157,"context_line":"    iniset $CYBORG_CONF_FILE DEFAULT use_syslog $SYSLOG"},{"line_number":158,"context_line":"    iniset $CYBORG_CONF_FILE DEFAULT host $LOCAL_HOSTNAME"},{"line_number":159,"context_line":"    iniset_rpc_backend cyborg $CYBORG_CONF_FILE"},{"line_number":160,"context_line":"}"},{"line_number":161,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_21589c56","line":158,"updated":"2020-02-20 16:30:20.000000000","message":"This line is what breaks the default deployment for me, which is storyboard task #38811:\n\nhttps://storyboard.openstack.org/#!/story/2007310\n\nMy thinking is that we probably want to just nuke this line and let the cyborg agent get the host from the oslo.service bit just like nova does by default in devstack. It\u0027s not super critical so I guess we\u0027ll just leave that open and slide that change in on top of this when it gets closer. Probably best not to mix that functionality change with any of this cleanup.","commit_id":"1a6f266b72c12f8ce1e5688c457a978f5c59f5af"}],"devstack/settings":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"a404861927b6cf1ed942f0570bf873b684076efa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CYBORG_ENABLED_DRIVERS\u003d${CYBORG_ENABLED_DRIVERS:-fake_driver}"},{"line_number":22,"context_line":"CYBORG_MODE\u003d${CYBORG_MODE:-\"all-in-one\"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"case ${CYBORG_MODE} in"},{"line_number":25,"context_line":"    \"all-in-one\")"},{"line_number":26,"context_line":"        enable_service cyborg-common cyborg-api cyborg-cond cyborg-agent"},{"line_number":27,"context_line":"    ;;"},{"line_number":28,"context_line":"    \"controller\")"},{"line_number":29,"context_line":"        enable_service cyborg-common cyborg-api cyborg-cond"},{"line_number":30,"context_line":"    ;;"},{"line_number":31,"context_line":"    \"compute\")"},{"line_number":32,"context_line":"        enable_service cyborg-common cyborg-agent"},{"line_number":33,"context_line":"    ;;"},{"line_number":34,"context_line":"    *)"},{"line_number":35,"context_line":"        local msg\u003d\"CYBORG_MODE shoudl be one of \""},{"line_number":36,"context_line":"        msg+\u003d\"all-in-one|compute|controller not \""},{"line_number":37,"context_line":"        msg+\u003d\"${CYBORG_MODE}\""},{"line_number":38,"context_line":"        die ${LINENO} ${msg}"},{"line_number":39,"context_line":"esac"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"if [[ -d ${CYBORG_DIR}/bin ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_e6b2a105","line":39,"range":{"start_line":24,"start_character":0,"end_line":39,"end_character":4},"updated":"2020-02-20 08:35:07.000000000","message":"I like this idea. It simply the deployment. \ncyborg-cond and cyborg-api should always in one node together? \nCan cyborg-cond be separated with cyborg-api?\n\nI have see you also update the guide doc.\nBut seems deployers still can can use the legacy config.\nenable_service or disable_service. \nWill there be some conflict?","commit_id":"1a6f266b72c12f8ce1e5688c457a978f5c59f5af"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eff823cd35aeba74c8c7f429ee10669ddf5b30e8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CYBORG_ENABLED_DRIVERS\u003d${CYBORG_ENABLED_DRIVERS:-fake_driver}"},{"line_number":22,"context_line":"CYBORG_MODE\u003d${CYBORG_MODE:-\"all-in-one\"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"case ${CYBORG_MODE} in"},{"line_number":25,"context_line":"    \"all-in-one\")"},{"line_number":26,"context_line":"        enable_service cyborg-common cyborg-api cyborg-cond cyborg-agent"},{"line_number":27,"context_line":"    ;;"},{"line_number":28,"context_line":"    \"controller\")"},{"line_number":29,"context_line":"        enable_service cyborg-common cyborg-api cyborg-cond"},{"line_number":30,"context_line":"    ;;"},{"line_number":31,"context_line":"    \"compute\")"},{"line_number":32,"context_line":"        enable_service cyborg-common cyborg-agent"},{"line_number":33,"context_line":"    ;;"},{"line_number":34,"context_line":"    *)"},{"line_number":35,"context_line":"        local msg\u003d\"CYBORG_MODE shoudl be one of \""},{"line_number":36,"context_line":"        msg+\u003d\"all-in-one|compute|controller not \""},{"line_number":37,"context_line":"        msg+\u003d\"${CYBORG_MODE}\""},{"line_number":38,"context_line":"        die ${LINENO} ${msg}"},{"line_number":39,"context_line":"esac"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"if [[ -d ${CYBORG_DIR}/bin ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_8004ee14","line":39,"range":{"start_line":24,"start_character":0,"end_line":39,"end_character":4},"in_reply_to":"3fa7e38b_e6b2a105","updated":"2020-02-20 13:26:06.000000000","message":"so yes  you could run the api and conductor on different nodes. \n\nregarding if there is a conflict with the legacy way  i dont recall which get precedence. if the local.conf is sourced a second time after this file is loaded the it would take precidence which i think is what you want to happen.\n\ni could add legacy as another option that is the same as all-in-one but onely have it enable the servicves if you have not already enabled or disbled any cyborg services in the local.conf.\n\nif i make legacy the default the behavior would be the same as it was before and you could use enable/disable_serivce\nwithout conflict or you choudl choose to use the slimilar mode options whichever you prefer.","commit_id":"1a6f266b72c12f8ce1e5688c457a978f5c59f5af"}],"doc/source/contributor/devstack_setup.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"352c4bce8f1301a3961b0bcafac6732e94daf7b0","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"::"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  disable_service cyborg-agent"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Compute Nodes"},{"line_number":154,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_bb47db79","side":"PARENT","line":151,"updated":"2020-02-20 14:57:41.000000000","message":"Yeah, this... isn\u0027t this more conventional?","commit_id":"89ed92a5f2316602bc2b953216e0e25f0e5bb140"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"94127b2809b0fe09ff3418d76153e4cb2f1beaed","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"::"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  disable_service cyborg-agent"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Compute Nodes"},{"line_number":154,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_e6513a33","side":"PARENT","line":151,"in_reply_to":"3fa7e38b_bb47db79","updated":"2020-02-20 15:51:13.000000000","message":"in a way it has become more common.\nmost plugings dont have multiple ways of installing in my experience \n\nthe mode option is how we handled it in networking-ovs-dpdk.\nhttps://opendev.org/x/networking-ovs-dpdk/src/branch/master/devstack/settings#L69-L78\n\nhowever i dont think normal for the plugins to auto enable the services with a direct call to enabel_plugin the way cyborg currently does.\n\nfor networking-ovn ectra you use enabe_plugin in the local.conf.\n\ni can drop the mode chagne from this patch and jsut keep the other refactoring or i can support and document both.\n\ni had original intended for both to work but i did not test that.","commit_id":"89ed92a5f2316602bc2b953216e0e25f0e5bb140"}]}