)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"1f1ecc88699a0d6d0e9082d46923c9360e55d7b4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ControlPathID table tracks identifiers for a control path interface to devices."},{"line_number":10,"context_line":"When we were discussing the valid values of cpid_type at 2020-02-27 Cyborg"},{"line_number":11,"context_line":"weekly meeting[0], an agreement was made that allowed cpid_type values are"},{"line_number":12,"context_line":"(\"PCI\", \"MDEV\"). But for nvidia GPUs (either pGPU or vGPU), they all report"},{"line_number":13,"context_line":"\"PCI\" as their cpid_type, while attach_handle_type of them are different."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixes the improper attach_handle_type value and its test."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_36c4265f","line":12,"updated":"2020-03-03 01:33:31.000000000","message":"What does it mean for CPID type to be \u0027mdev\u0027? The attach handle can be a mdev but, even then, the cpid would be PCI, right?","commit_id":"42edbaea318041ae6c85ab200be893d218aa1b3e"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"466a5a2b4691c25e675eed51bb92bdd4586659fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix GPU\u0027s improper cpid_type allowed value and attach_handle_type value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ControlPathID table tracks identifiers for a control path interface to devices."},{"line_number":10,"context_line":"When we were discussing the valid values of cpid_type at 2020-02-27 Cyborg"},{"line_number":11,"context_line":"weekly meeting[0], an agreement was made that allowed cpid_type values are"},{"line_number":12,"context_line":"\"PCI\". And for GPUs (either pGPU or vGPU), they all report"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_bd076182","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"updated":"2020-03-05 14:42:06.000000000","message":"nit: ``ControlPathID``","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cfec0adb5c2f5f620662f9a6b37a590bebeccd40","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix GPU\u0027s improper cpid_type allowed value and attach_handle_type value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ControlPathID table tracks identifiers for a control path interface to devices."},{"line_number":10,"context_line":"When we were discussing the valid values of cpid_type at 2020-02-27 Cyborg"},{"line_number":11,"context_line":"weekly meeting[0], an agreement was made that allowed cpid_type values are"},{"line_number":12,"context_line":"\"PCI\". And for GPUs (either pGPU or vGPU), they all report"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_b76695c0","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"in_reply_to":"1fa4df85_bd076182","updated":"2020-03-06 02:59:14.000000000","message":"Done","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"466a5a2b4691c25e675eed51bb92bdd4586659fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ControlPathID table tracks identifiers for a control path interface to devices."},{"line_number":10,"context_line":"When we were discussing the valid values of cpid_type at 2020-02-27 Cyborg"},{"line_number":11,"context_line":"weekly meeting[0], an agreement was made that allowed cpid_type values are"},{"line_number":12,"context_line":"\"PCI\". And for GPUs (either pGPU or vGPU), they all report"},{"line_number":13,"context_line":"\"PCI\" as their cpid_type, while attach_handle_type of them are different."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_7de489e0","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":17},"updated":"2020-03-05 14:42:06.000000000","message":"you are missing this [0] http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-02-27-03.00.log.html","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cfec0adb5c2f5f620662f9a6b37a590bebeccd40","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ControlPathID table tracks identifiers for a control path interface to devices."},{"line_number":10,"context_line":"When we were discussing the valid values of cpid_type at 2020-02-27 Cyborg"},{"line_number":11,"context_line":"weekly meeting[0], an agreement was made that allowed cpid_type values are"},{"line_number":12,"context_line":"\"PCI\". And for GPUs (either pGPU or vGPU), they all report"},{"line_number":13,"context_line":"\"PCI\" as their cpid_type, while attach_handle_type of them are different."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_17752964","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":17},"in_reply_to":"1fa4df85_7de489e0","updated":"2020-03-06 02:59:14.000000000","message":"Done","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"466a5a2b4691c25e675eed51bb92bdd4586659fa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"When we were discussing the valid values of cpid_type at 2020-02-27 Cyborg"},{"line_number":11,"context_line":"weekly meeting[0], an agreement was made that allowed cpid_type values are"},{"line_number":12,"context_line":"\"PCI\". And for GPUs (either pGPU or vGPU), they all report"},{"line_number":13,"context_line":"\"PCI\" as their cpid_type, while attach_handle_type of them are different."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixes the improper cpid_type allowed value and attach_handle_type"},{"line_number":16,"context_line":"value. No unit test is affected."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_7dfd696c","line":13,"range":{"start_line":13,"start_character":32,"end_line":13,"end_character":50},"updated":"2020-03-05 14:42:06.000000000","message":"nit: ``attach_handle_type``","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cfec0adb5c2f5f620662f9a6b37a590bebeccd40","unresolved":false,"context_lines":[{"line_number":10,"context_line":"When we were discussing the valid values of cpid_type at 2020-02-27 Cyborg"},{"line_number":11,"context_line":"weekly meeting[0], an agreement was made that allowed cpid_type values are"},{"line_number":12,"context_line":"\"PCI\". And for GPUs (either pGPU or vGPU), they all report"},{"line_number":13,"context_line":"\"PCI\" as their cpid_type, while attach_handle_type of them are different."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixes the improper cpid_type allowed value and attach_handle_type"},{"line_number":16,"context_line":"value. No unit test is affected."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_575721cb","line":13,"range":{"start_line":13,"start_character":32,"end_line":13,"end_character":50},"in_reply_to":"1fa4df85_7dfd696c","updated":"2020-03-06 02:59:14.000000000","message":"Done","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"}],"cyborg/accelerator/drivers/gpu/utils.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"466a5a2b4691c25e675eed51bb92bdd4586659fa","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _generate_attach_handle(gpu):"},{"line_number":151,"context_line":"    driver_ah \u003d driver_attach_handle.DriverAttachHandle()"},{"line_number":152,"context_line":"    if gpu[\"rc\"] \u003d\u003d \"PGPU\":"},{"line_number":153,"context_line":"        driver_ah.attach_type \u003d constants.AH_TYPE_PCI"},{"line_number":154,"context_line":"    else:"},{"line_number":155,"context_line":"        driver_ah.attach_type \u003d constants.AH_TYPE_MDEV"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_d2156c9d","line":152,"updated":"2020-03-05 14:42:06.000000000","message":"It seems like lack of test case for this scenario, if your test case covers this scenatio, this will be trigger, right?","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"11c75f3413aa80c16266999c780cd526a459a985","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _generate_attach_handle(gpu):"},{"line_number":151,"context_line":"    driver_ah \u003d driver_attach_handle.DriverAttachHandle()"},{"line_number":152,"context_line":"    if gpu[\"rc\"] \u003d\u003d \"PGPU\":"},{"line_number":153,"context_line":"        driver_ah.attach_type \u003d constants.AH_TYPE_PCI"},{"line_number":154,"context_line":"    else:"},{"line_number":155,"context_line":"        driver_ah.attach_type \u003d constants.AH_TYPE_MDEV"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_c1710e78","line":152,"in_reply_to":"1fa4df85_174c4940","updated":"2020-03-06 09:29:10.000000000","message":"It\u0027s ok.. indeed we are missing too many UTs, which will make our code insecure.","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"e27cb6968e91e741280a92c1653b2cc3524ecc45","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _generate_attach_handle(gpu):"},{"line_number":151,"context_line":"    driver_ah \u003d driver_attach_handle.DriverAttachHandle()"},{"line_number":152,"context_line":"    if gpu[\"rc\"] \u003d\u003d \"PGPU\":"},{"line_number":153,"context_line":"        driver_ah.attach_type \u003d constants.AH_TYPE_PCI"},{"line_number":154,"context_line":"    else:"},{"line_number":155,"context_line":"        driver_ah.attach_type \u003d constants.AH_TYPE_MDEV"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_44e5dadb","line":152,"in_reply_to":"1fa4df85_c1710e78","updated":"2020-03-12 02:38:33.000000000","message":"Yes, we still need to improve our tempest and UTs.","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cfec0adb5c2f5f620662f9a6b37a590bebeccd40","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _generate_attach_handle(gpu):"},{"line_number":151,"context_line":"    driver_ah \u003d driver_attach_handle.DriverAttachHandle()"},{"line_number":152,"context_line":"    if gpu[\"rc\"] \u003d\u003d \"PGPU\":"},{"line_number":153,"context_line":"        driver_ah.attach_type \u003d constants.AH_TYPE_PCI"},{"line_number":154,"context_line":"    else:"},{"line_number":155,"context_line":"        driver_ah.attach_type \u003d constants.AH_TYPE_MDEV"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_174c4940","line":152,"in_reply_to":"1fa4df85_d2156c9d","updated":"2020-03-06 02:59:14.000000000","message":"emmmm.. Do you mean need case for both gpu[\"rc\"] \u003d\u003d \"PGPU\" and gpu[\"rc\"] \u003d\u003d \"VGPU\"? This is not a simple problem of adding test case, we need to support vGPU report first, then it\u0027s necessary to add test case. Otherwise, current PGPU test case is enough.","commit_id":"bfe094d5254143ae63d0e91dd6574f5d461cf9b6"}],"cyborg/common/constants.py":[{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"7e3ae7e52123951f0014fd054acd312908d43459","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Control Path ID type"},{"line_number":70,"context_line":"CPID_TYPE \u003d \"PCI\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Resource Class"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_6fbfcaa9","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":17},"updated":"2020-03-09 09:14:26.000000000","message":"Maybe it is better to use a multiple assignment like the ones above, to support more CPID type in the future.","commit_id":"c2ebb19fb23857994654b5751aa0261df7ccf85c"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"e27cb6968e91e741280a92c1653b2cc3524ecc45","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Control Path ID type"},{"line_number":70,"context_line":"CPID_TYPE \u003d \"PCI\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Resource Class"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_04cfe257","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":17},"in_reply_to":"1fa4df85_6fbfcaa9","updated":"2020-03-12 02:38:33.000000000","message":"ok.Done.","commit_id":"c2ebb19fb23857994654b5751aa0261df7ccf85c"}]}