)]}'
{"devstack/lib/cyborg":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd3dd60edba65de0c420507a760f47bf414a93f4","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# configure_cyborg() - Set config files, create data dirs, etc"},{"line_number":127,"context_line":"function configure_cyborg {"},{"line_number":128,"context_line":"    if is_service_enabled cyborg-common; then"},{"line_number":129,"context_line":"        configure_cyborg_common"},{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1fa4df85_cafc7140","line":128,"range":{"start_line":128,"start_character":26,"end_line":128,"end_character":39},"updated":"2020-02-25 00:38:44.000000000","message":"this should just be cyborg since i have factored out the cyborg mode change. that is why the job is failing","commit_id":"faf085e5d5fc4c6153bb5a4263e4feb2cfac26f7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"d9ff4dd9a4fce3756d09c6992f11b81da1b93f79","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# - cleanup_cyborg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(sean-k-mooney): this does not install anything"},{"line_number":23,"context_line":"# consider renameing."},{"line_number":24,"context_line":"function install_cyborg_in_controller {"},{"line_number":25,"context_line":"    if is_service_enabled cyborg-api; then"},{"line_number":26,"context_line":"        local req_services\u003d\"key\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1fa4df85_9ea9dae0","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":20},"updated":"2020-02-25 01:28:40.000000000","message":"s/renameing/renaming","commit_id":"58c1decf1ba501a435e9614b2352adacd0fec44f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"74c93f9b1937da207d48e1705f32c6624bff4f38","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# - cleanup_cyborg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(sean-k-mooney): this does not install anything"},{"line_number":23,"context_line":"# consider renameing."},{"line_number":24,"context_line":"function install_cyborg_in_controller {"},{"line_number":25,"context_line":"    if is_service_enabled cyborg-api; then"},{"line_number":26,"context_line":"        local req_services\u003d\"key\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1fa4df85_ea2a83e5","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":20},"in_reply_to":"1fa4df85_9ea9dae0","updated":"2020-02-25 12:57:59.000000000","message":"right i missed this last time.\nif i respin the patch ill fix it since this is deleted in the next patch in the chain i dont think it is worth a resping of this patch on its own but if i am updating the patch ill adress it.","commit_id":"58c1decf1ba501a435e9614b2352adacd0fec44f"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"f55ab30ca22a424a4635bde55db65f378118ac05","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        echo_summary \"Installing additional Cyborg packages\""},{"line_number":41,"context_line":"        if [[ \"$OPAE_INSTALL_ENABLE\" \u003d\u003d \"True\" ]] \u0026\u0026 install_opae_packages; then"},{"line_number":42,"context_line":"           echo_summary \"INFO: Additional Cyborg packages installed\""},{"line_number":43,"context_line":"        elif [[ \"$OPAE_INSTALL_ENABLE\" \u003d\u003d \"True\" ]]; then"},{"line_number":44,"context_line":"           echo \"WARNING: Failed to install additional Cyborg packages\""},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1fa4df85_5a2261a6","line":43,"range":{"start_line":43,"start_character":43,"end_line":43,"end_character":47},"updated":"2020-02-27 07:49:21.000000000","message":"Maybe False","commit_id":"58c1decf1ba501a435e9614b2352adacd0fec44f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a875d25c532bacc173b0d37ab8833e310dd5f192","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        echo_summary \"Installing additional Cyborg packages\""},{"line_number":41,"context_line":"        if [[ \"$OPAE_INSTALL_ENABLE\" \u003d\u003d \"True\" ]] \u0026\u0026 install_opae_packages; then"},{"line_number":42,"context_line":"           echo_summary \"INFO: Additional Cyborg packages installed\""},{"line_number":43,"context_line":"        elif [[ \"$OPAE_INSTALL_ENABLE\" \u003d\u003d \"True\" ]]; then"},{"line_number":44,"context_line":"           echo \"WARNING: Failed to install additional Cyborg packages\""},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1fa4df85_7441710b","line":43,"range":{"start_line":43,"start_character":43,"end_line":43,"end_character":47},"in_reply_to":"1fa4df85_5a2261a6","updated":"2020-02-27 13:06:09.000000000","message":"this is what it was orginally so im trying not to change the logic in this refactor.\n\nyou will only take this branch if  \"$OPAE_INSTALL_ENABLE\" \u003d\u003d \"True\"  and install_opae_package failed\n\n\nif OPAE_INSTALL_ENABLE\" \u003d\u003d \"False\" we would not want to emit the warning below because we told the plugin not to install opae so its expected.","commit_id":"58c1decf1ba501a435e9614b2352adacd0fec44f"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"0f11e75d122608eadeecb5c5d514aec97cabc074","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        echo_summary \"Installing additional Cyborg packages\""},{"line_number":41,"context_line":"        if [[ \"$OPAE_INSTALL_ENABLE\" \u003d\u003d \"True\" ]] \u0026\u0026 install_opae_packages; then"},{"line_number":42,"context_line":"           echo_summary \"INFO: Additional Cyborg packages installed\""},{"line_number":43,"context_line":"        elif [[ \"$OPAE_INSTALL_ENABLE\" \u003d\u003d \"True\" ]]; then"},{"line_number":44,"context_line":"           echo \"WARNING: Failed to install additional Cyborg packages\""},{"line_number":45,"context_line":"        fi"},{"line_number":46,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1fa4df85_e3e60017","line":43,"range":{"start_line":43,"start_character":43,"end_line":43,"end_character":47},"in_reply_to":"1fa4df85_7441710b","updated":"2020-02-28 01:20:48.000000000","message":"Ok. So there is no problem with the logic of this code.","commit_id":"58c1decf1ba501a435e9614b2352adacd0fec44f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"da755553c0738242e9a86efb505dd642df87e1fb","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    # NOTE(sean-k-mooney) it is not obvious why this is in the conductor"},{"line_number":220,"context_line":"    # section or what sets is_deployed_by_agent so this should either be"},{"line_number":221,"context_line":"    # documented, removed or moved to the correct locaiton."},{"line_number":222,"context_line":"    if is_deployed_by_agent; then"},{"line_number":223,"context_line":"        iniset $CYBORG_CONF_FILE api ramdisk_heartbeat_timeout 30"},{"line_number":224,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1fa4df85_10194ed6","line":221,"range":{"start_line":221,"start_character":50,"end_line":221,"end_character":58},"updated":"2020-02-25 14:55:19.000000000","message":"location","commit_id":"58c1decf1ba501a435e9614b2352adacd0fec44f"}]}