)]}'
{"cyborg/agent/manager.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"61d257e32436df0be8c81f0f112b0588c00c1466","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def periodic_tasks(self, context, raise_on_error\u003dFalse):"},{"line_number":48,"context_line":"        return self.run_periodic_tasks(context, raise_on_error\u003draise_on_error)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def fpga_program_v2(self, context, controlpath_id,"},{"line_number":51,"context_line":"                        bitstream_uuid, driver_name):"},{"line_number":52,"context_line":"        # TODO() Use tempfile module?"},{"line_number":53,"context_line":"        download_path \u003d \"/tmp/\" + bitstream_uuid + \".gbs\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_a4ca8e17","line":50,"range":{"start_line":50,"start_character":20,"end_line":50,"end_character":23},"updated":"2020-03-12 02:58:21.000000000","message":"ditto.","commit_id":"c616da80487b83e8506e3fa18cc707fd50f5eb5c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"61d257e32436df0be8c81f0f112b0588c00c1466","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                bitstream_uuid,"},{"line_number":56,"context_line":"                                dest_path\u003ddownload_path)"},{"line_number":57,"context_line":"        driver \u003d self.fpga_driver.create(driver_name)"},{"line_number":58,"context_line":"        ret \u003d driver.program_v2(controlpath_id, download_path)"},{"line_number":59,"context_line":"        LOG.info(\u0027Driver program() API returned code %s\u0027, ret)"},{"line_number":60,"context_line":"        os.remove(download_path)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_84c5120d","line":58,"range":{"start_line":58,"start_character":28,"end_line":58,"end_character":31},"updated":"2020-03-12 02:58:21.000000000","message":"ditto.","commit_id":"c616da80487b83e8506e3fa18cc707fd50f5eb5c"}],"cyborg/agent/rpcapi.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"7b4265abb77fbedc6136b61d80c6dfde6dd2b4b9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\"Signal the agent to find local hardware.\"\"\""},{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def program_fpga_with_bitstream(self,"},{"line_number":60,"context_line":"                                    context,"},{"line_number":61,"context_line":"                                    deployable_uuid,"},{"line_number":62,"context_line":"                                    bitstream_uuid):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_d19905c4","side":"PARENT","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":35},"updated":"2020-03-04 08:11:24.000000000","message":"Did you want to deprecated the Deployables program() [1] API, that it called this function to program the FPGA?\n\n[1]https://opendev.org/openstack/cyborg/src/branch/master/cyborg/api/controllers/v1/deployables.py#L134","commit_id":"e9db6e87972eb1af5cd7fb6f95fbc7501260895a"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"90bb2c189738d219bd68af58e4e73980db647b8d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\"Signal the agent to find local hardware.\"\"\""},{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def program_fpga_with_bitstream(self,"},{"line_number":60,"context_line":"                                    context,"},{"line_number":61,"context_line":"                                    deployable_uuid,"},{"line_number":62,"context_line":"                                    bitstream_uuid):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_71537140","side":"PARENT","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":35},"in_reply_to":"1fa4df85_d19905c4","updated":"2020-03-04 09:02:32.000000000","message":"Good Catch. Brin. I plan to remove V1 API and  related context in the next patches.\n I had create a story, will do it recently:https://storyboard.openstack.org/#!/story/2007369","commit_id":"e9db6e87972eb1af5cd7fb6f95fbc7501260895a"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0caa835cec5b7b25a715dab6447f92fb30dc13ad","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\"Signal the agent to find local hardware.\"\"\""},{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def program_fpga_with_bitstream(self,"},{"line_number":60,"context_line":"                                    context,"},{"line_number":61,"context_line":"                                    deployable_uuid,"},{"line_number":62,"context_line":"                                    bitstream_uuid):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_710cd1ec","side":"PARENT","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":35},"in_reply_to":"1fa4df85_d19905c4","updated":"2020-03-04 08:12:51.000000000","message":"s/?/./ , I am sorry for the spelling error.","commit_id":"e9db6e87972eb1af5cd7fb6f95fbc7501260895a"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"7b4265abb77fbedc6136b61d80c6dfde6dd2b4b9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def program_fpga_with_bitstream(self,"},{"line_number":60,"context_line":"                                    context,"},{"line_number":61,"context_line":"                                    deployable_uuid,"},{"line_number":62,"context_line":"                                    bitstream_uuid):"},{"line_number":63,"context_line":"        \"\"\"Actiion to program a target FPGA\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_713e118d","side":"PARENT","line":60,"updated":"2020-03-04 08:11:24.000000000","message":"This function has test case, if we should remove this feature in v1,I think this file does not need to exist.\n\n[2]https://opendev.org/openstack/cyborg/src/branch/master/cyborg/tests/unit/api/controllers/v1/_test_fpga_program.py#L31","commit_id":"e9db6e87972eb1af5cd7fb6f95fbc7501260895a"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"90bb2c189738d219bd68af58e4e73980db647b8d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def program_fpga_with_bitstream(self,"},{"line_number":60,"context_line":"                                    context,"},{"line_number":61,"context_line":"                                    deployable_uuid,"},{"line_number":62,"context_line":"                                    bitstream_uuid):"},{"line_number":63,"context_line":"        \"\"\"Actiion to program a target FPGA\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_91570d27","side":"PARENT","line":60,"in_reply_to":"1fa4df85_713e118d","updated":"2020-03-04 09:02:32.000000000","message":"Pls see the above reply. Now because this file is mocked in UT. I will remove it and V1 API in the next patches.","commit_id":"e9db6e87972eb1af5cd7fb6f95fbc7501260895a"},{"author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"change_message_id":"9c99215c1e725eb8f8cdbbf6dd80eb485c885d34","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                     version_cap\u003dself.RPC_API_VERSION,"},{"line_number":52,"context_line":"                                     serializer\u003dserializer)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def fpga_program_v2(self, context, hostname, controlpath_id,"},{"line_number":55,"context_line":"                        bitstream_uuid, driver_name):"},{"line_number":56,"context_line":"        LOG.info(\u0027Agent fpga_program_v2: hostname: (%s) \u0027 +"},{"line_number":57,"context_line":"                 \u0027bitstream_id: (%s)\u0027, hostname, bitstream_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_2ca7a0bf","line":54,"updated":"2020-03-09 05:53:00.000000000","message":"Should we just rename this as fpga_program, without the v2, since v1 is gone?","commit_id":"c616da80487b83e8506e3fa18cc707fd50f5eb5c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"61d257e32436df0be8c81f0f112b0588c00c1466","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                     version_cap\u003dself.RPC_API_VERSION,"},{"line_number":52,"context_line":"                                     serializer\u003dserializer)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def fpga_program_v2(self, context, hostname, controlpath_id,"},{"line_number":55,"context_line":"                        bitstream_uuid, driver_name):"},{"line_number":56,"context_line":"        LOG.info(\u0027Agent fpga_program_v2: hostname: (%s) \u0027 +"},{"line_number":57,"context_line":"                 \u0027bitstream_id: (%s)\u0027, hostname, bitstream_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_a465ae47","line":54,"in_reply_to":"1fa4df85_0c8d0431","updated":"2020-03-12 02:58:21.000000000","message":"Agree with Sundar, but maybe there are many place need to change, ether way for me is ok.","commit_id":"c616da80487b83e8506e3fa18cc707fd50f5eb5c"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"df60421da7b54b9583bf8192d49f0b936d572752","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                     version_cap\u003dself.RPC_API_VERSION,"},{"line_number":52,"context_line":"                                     serializer\u003dserializer)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def fpga_program_v2(self, context, hostname, controlpath_id,"},{"line_number":55,"context_line":"                        bitstream_uuid, driver_name):"},{"line_number":56,"context_line":"        LOG.info(\u0027Agent fpga_program_v2: hostname: (%s) \u0027 +"},{"line_number":57,"context_line":"                 \u0027bitstream_id: (%s)\u0027, hostname, bitstream_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_0c8d0431","line":54,"in_reply_to":"1fa4df85_2ca7a0bf","updated":"2020-03-09 06:02:40.000000000","message":"Agree. But I think this method should be modify in another patch for more clear.","commit_id":"c616da80487b83e8506e3fa18cc707fd50f5eb5c"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"ea6f2e08df6ceb52ae4a05baeeec4d3d65535798","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                     version_cap\u003dself.RPC_API_VERSION,"},{"line_number":52,"context_line":"                                     serializer\u003dserializer)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def fpga_program_v2(self, context, hostname, controlpath_id,"},{"line_number":55,"context_line":"                        bitstream_uuid, driver_name):"},{"line_number":56,"context_line":"        LOG.info(\u0027Agent fpga_program_v2: hostname: (%s) \u0027 +"},{"line_number":57,"context_line":"                 \u0027bitstream_id: (%s)\u0027, hostname, bitstream_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_24ff7e35","line":54,"in_reply_to":"1fa4df85_a465ae47","updated":"2020-03-12 03:08:23.000000000","message":"in my opinion, that\u0027s not what this patch should do. I think the theme should be consistent. We can optimize here with a separate theme.","commit_id":"c616da80487b83e8506e3fa18cc707fd50f5eb5c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"61d257e32436df0be8c81f0f112b0588c00c1466","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def fpga_program_v2(self, context, hostname, controlpath_id,"},{"line_number":55,"context_line":"                        bitstream_uuid, driver_name):"},{"line_number":56,"context_line":"        LOG.info(\u0027Agent fpga_program_v2: hostname: (%s) \u0027 +"},{"line_number":57,"context_line":"                 \u0027bitstream_id: (%s)\u0027, hostname, bitstream_uuid)"},{"line_number":58,"context_line":"        version \u003d \u00271.0\u0027"},{"line_number":59,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhostname, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_c44d4ac5","line":56,"range":{"start_line":56,"start_character":36,"end_line":56,"end_character":39},"updated":"2020-03-12 02:58:21.000000000","message":"ditto.","commit_id":"c616da80487b83e8506e3fa18cc707fd50f5eb5c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"61d257e32436df0be8c81f0f112b0588c00c1466","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                 \u0027bitstream_id: (%s)\u0027, hostname, bitstream_uuid)"},{"line_number":58,"context_line":"        version \u003d \u00271.0\u0027"},{"line_number":59,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhostname, version\u003dversion)"},{"line_number":60,"context_line":"        return cctxt.call(context, \u0027fpga_program_v2\u0027,"},{"line_number":61,"context_line":"                          controlpath_id\u003dcontrolpath_id,"},{"line_number":62,"context_line":"                          bitstream_uuid\u003dbitstream_uuid,"},{"line_number":63,"context_line":"                          driver_name\u003ddriver_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_445aba83","line":60,"range":{"start_line":60,"start_character":48,"end_line":60,"end_character":51},"updated":"2020-03-12 02:58:21.000000000","message":"ditto.","commit_id":"c616da80487b83e8506e3fa18cc707fd50f5eb5c"}]}