)]}'
{"id":"openstack%2Fcyborg~711912","triplet_id":"openstack%2Fcyborg~master~Ia9e7a21f36b7154809d5bcf7812bb7fa73eff6df","project":"openstack/cyborg","branch":"master","topic":"bugfix_report","hashtags":[],"change_id":"Ia9e7a21f36b7154809d5bcf7812bb7fa73eff6df","subject":"Bugfix: expose placement service unavailable before diff cyborg db","status":"MERGED","created":"2020-03-09 12:37:47.000000000","updated":"2020-03-17 08:58:03.000000000","submitted":"2020-03-17 08:56:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":20,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"711912-1584435407957-eb552905","meta_rev_id":"1ee423b64d5112bb2351c75d1936400b70f4c20f","_number":711912,"virtual_id_number":711912,"owner":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"date":"2020-03-17 02:56:02.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-17 08:56:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"all":[{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2020-03-17 01:57:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2020-03-17 03:54:22.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":2,"date":"2020-03-17 08:26:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":1,"date":"2020-03-12 01:36:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"all":[{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":1,"date":"2020-03-17 08:26:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-09 12:39:52.000000000","updated_by":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"reviewer":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"state":"REVIEWER"},{"updated":"2020-03-09 12:40:00.000000000","updated_by":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"reviewer":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"state":"REVIEWER"},{"updated":"2020-03-09 12:40:20.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2020-03-10 12:49:26.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-03-12 01:36:53.000000000","updated_by":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"reviewer":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"state":"REVIEWER"},{"updated":"2020-03-17 01:57:24.000000000","updated_by":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"reviewer":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"state":"REVIEWER"},{"updated":"2020-03-17 03:54:22.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2020-03-17 08:26:23.000000000","updated_by":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"reviewer":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"state":"REVIEWER"},{"updated":"2020-03-17 08:56:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8f2d699e07d2abe1eb108bd070cf44389b366266","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-09 12:37:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"05a644e9bd3e6b7ec4ea81c49a7341408adc57d7","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-03-09 13:14:32.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"794a64564488ecd7d848a53fe20725c164851c53","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-09 13:15:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a67eb5231aa64d04b110eb8ea1874b79 : SUCCESS in 7m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d8837f3dd3c44e6ea84b4c9a61535643 : SUCCESS in 4m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fbd68b1d11d84b4483d3f9e1443b4bc9 : SUCCESS in 5m 12s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/611606ec8dec49caac6d34d42fa68178 : SUCCESS in 4m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e2eb039c5a6a4e45b7b9f2817592ed97 : SUCCESS in 4m 36s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3bbbfe97c2284598864f209a5bebf2b3 : SUCCESS in 3m 49s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/0aead442c42344d39572bd20015a0f96 : SUCCESS in 29m 30s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c799fae5ab2b490582658fd3665fcf94 : SUCCESS in 33m 04s (non-voting)\n- cyborg-tox-bandit https://zuul.opendev.org/t/openstack/build/1f2d8442f30b49debf5a7f5a1348d2f1 : FAILURE in 3m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"297174b0ad2b1457972d26569e5b0e6a9e0dd1e7","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-03-09 13:27:23.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6648b56c3985cd53e82ecc780ed9670751842fc4","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-10 02:00:49.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3d7c51188623d38fd56043058cf937dadbd5659f","author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"date":"2020-03-10 07:34:53.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"043564f96b8ed08f7c221425dab1b573ed3b1512","author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"date":"2020-03-10 08:13:33.000000000","message":"Patch Set 1: Code-Review+1\n\nHi ChenKe, thanks for your patch.\nIt looks good to me overall, besides, I\u0027d like to suggest have a double check before throw out the exception. For example, if we didn\u0027t install placement service in the env, or if we run cyborg as a standalone project. My suggest is to read /etc/cyborg/cyborg.conf and check if it has the [placement] section. \nI will give a +1 and let other review later.","accounts_in_message":[],"_revision_number":1},{"id":"f09838a1f1310d82b279dc95ecc6b9ea25a3aa98","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-10 09:06:54.000000000","message":"Patch Set 1:\n\n\u003e Hi ChenKe, thanks for your patch.\n \u003e It looks good to me overall, besides, I\u0027d like to suggest have a\n \u003e double check before throw out the exception. For example, if we\n \u003e didn\u0027t install placement service in the env, or if we run cyborg as\n \u003e a standalone project. My suggest is to read /etc/cyborg/cyborg.conf\n \u003e and check if it has the [placement] section.\n \u003e I will give a +1 and let other review later.\n\nThanks xinran\u0027s quick review.  About the double check idea, I think this is based on the assumption that cyborg does not report data to placement. At present, I personally think that the big trend is that all components report resources to placements, such as nova, neutron. I\u0027m not sure if there are scenarios where cyborg does not plan to schedule through placement. If, in future discussions, there is such a need, I think your suggestion is great. We can choose through /etc/cyborg/cyborg.conf to determine whether there is a placement field. At that time, we can optimize this.","accounts_in_message":[],"_revision_number":1},{"id":"789d4c922aa26f78f39dcabab737676ca8765a19","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-03-10 12:49:26.000000000","message":"Patch Set 1: Code-Review+1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"af8f614e48666b855cdc67cbcc526b89abe2a0a3","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-10 13:26:48.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"374be4d22f9d06938af69dcb8861d95882647a00","author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"date":"2020-03-11 05:58:49.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3fa32a1665065eecbe5208df13a0ec7abbc24553","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-11 08:10:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f7eae0043f5f80c0bf38bafae45e5d10cedcbcda","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-11 08:22:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c19cb83e5f75a1f7d689f7e84b61aa48454074dc","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-11 08:25:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"da1882d3b0544142e82c872976212b6bf433a2ff","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-11 08:31:46.000000000","message":"Topic changed from test_delete_context to bugfix_report","accounts_in_message":[],"_revision_number":2},{"id":"63f5ea66cc226c1371ce9ffeb75a96e09ccd220a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 09:13:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6865ac9960794b58a0e93039a9d0ae6b : SUCCESS in 5m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5e7b301d4a05417ba06a73bb3b0964e1 : SUCCESS in 4m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e8dbf01f5b0049a8b55b84fff5c4aa61 : SUCCESS in 4m 07s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/da3e1a52fbb34f7db15dcd65d8fd236f : SUCCESS in 5m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/97c0f08c60054038815267ebe518aa6c : SUCCESS in 5m 26s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/82e3621a280040de9c55c1a2737cefb9 : SUCCESS in 5m 20s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/b33c6b2c51cf4255ba785b430a4dd2fe : SUCCESS in 27m 16s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/38a5b4ea66a4400ab06cd432dd388b95 : SUCCESS in 32m 13s (non-voting)\n- cyborg-tox-bandit https://zuul.opendev.org/t/openstack/build/80484335e3c74f55b9fa17b84ca459bd : FAILURE in 4m 09s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c8364b515803327fbf256b0725da537de94cad4c","author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"date":"2020-03-12 01:36:53.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"4fd4efbde390f4ccd690a82ba7238654cdb8705b","author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"date":"2020-03-13 06:36:19.000000000","message":"Patch Set 2:\n\n\u003e \u003e Hi ChenKe, thanks for your patch.\n \u003e \u003e It looks good to me overall, besides, I\u0027d like to suggest have a\n \u003e \u003e double check before throw out the exception. For example, if we\n \u003e \u003e didn\u0027t install placement service in the env, or if we run cyborg\n \u003e as\n \u003e \u003e a standalone project. My suggest is to read /etc/cyborg/cyborg.conf\n \u003e \u003e and check if it has the [placement] section.\n \u003e \u003e I will give a +1 and let other review later.\n \u003e \n \u003e Thanks xinran\u0027s quick review.  About the double check idea, I think\n \u003e this is based on the assumption that cyborg does not report data to\n \u003e placement. At present, I personally think that the big trend is\n \u003e that all components report resources to placements, such as nova,\n \u003e neutron. I\u0027m not sure if there are scenarios where cyborg does not\n \u003e plan to schedule through placement. If, in future discussions,\n \u003e there is such a need, I think your suggestion is great. We can\n \u003e choose through /etc/cyborg/cyborg.conf to determine whether there\n \u003e is a placement field. At that time, we can optimize this.\n\nSure, I agree. We can do this check when cyborg run as a stand alone service.","accounts_in_message":[],"_revision_number":2},{"id":"a56b4d797a9b7593463cb3404c0c0ff0bb08388d","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-13 07:24:45.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a4a846e8d81242d2c4976af6e83ab5a00e67da52","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-16 01:43:10.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c1a8dfc82acab761f938342f0ada21e7745c2c8e","author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"date":"2020-03-17 01:57:24.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks chenker!","accounts_in_message":[],"_revision_number":2},{"id":"937010f89df532bd9d3d805c9bb2fe841681639e","author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"date":"2020-03-17 02:45:20.000000000","message":"Patch Set 2:\n\nShould we add a NOTE somewhere in the code, serving as a reminder that do placement related check when cyborg runs as a stand-alone service in the future?","accounts_in_message":[],"_revision_number":2},{"id":"19fb02a6214905face448b338e51ab12fe19130d","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-17 02:56:02.000000000","message":"Patch Set 2:\n\n\u003e Should we add a NOTE somewhere in the code, serving as a reminder\n \u003e that do placement related check when cyborg runs as a stand-alone\n \u003e service in the future?\nI think the placement stand-alone is just a propose. If we want do it, we have to refactor this part code. At current stage, there is no need to add notes, and it has little relevance to this bugfix. Moreover, if placement stand-alone, I think a spec will be needed to explain the situation in detail, a simple note is not enough.","accounts_in_message":[],"_revision_number":2},{"id":"4a92c6936484f4e968946541948c617c49b92c35","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-17 03:54:22.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"96e5940adb7c016221f0ca280ffa76043dcb454a","author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"date":"2020-03-17 08:26:23.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"de299947b8b50719829b32da533e165fc1f2373f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 08:26:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"6925ce7e9b937a85cd76681c8c1ce4d9e6a90c18","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 08:56:47.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/03d9cbf0269d4aba885e64ea2034a545 : SUCCESS in 3m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1a31822218c7462ca0011e08c2597794 : SUCCESS in 3m 53s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/74edd08825b249a9b45b5026a22195f6 : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c4e8a07655734fe19cc1f651baa96d29 : SUCCESS in 4m 27s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/7e3bad9ff0d240c5bb05a1de46b87493 : SUCCESS in 28m 43s","accounts_in_message":[],"_revision_number":2},{"id":"49696cd922861d30b0cb2b1515fe7413be7ce98b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 08:56:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"1ee423b64d5112bb2351c75d1936400b70f4c20f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 08:58:03.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bf0577ceb5af431d87de4e4f8284667b : SUCCESS in 1m 00s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6633fa32e887a17770913ceadeb42152ee6eb5ec","revisions":{"e49f3c81296d76645a8b79e149aadb043b375712":{"kind":"REWORK","_number":1,"created":"2020-03-09 12:37:47.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/12/711912/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/12/711912/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/12/711912/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/12/711912/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/12/711912/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/12/711912/1"}}},"commit":{"parents":[{"commit":"6dab512af226677c9065f85f264a691f3aeb6eab","subject":"Merge \"Revert \"Solve py37 timeout\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/6dab512af226677c9065f85f264a691f3aeb6eab"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2020-03-09 11:36:58.000000000","tz":480},"committer":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2020-03-09 12:26:34.000000000","tz":480},"subject":"Bugfix: expose placement service unavailable before diff cyborg db","message":"Bugfix: expose placement service unavailable before diff cyborg db\n\nWe know that cyborg will periodically synchronize data\nwith placement, but there is a prerequisite for data\nsynchronization. That is, when Cyborg periodically scans\nand finds that the database has changed, it will update\nthe placement.\n\nThere will be an implicit bug, that is, when the placement\nservice is abnormal (for example: the installation service\nis abnormal, the node where the placement service is down),\ncyborg will still update its database. When the placement\nservice is normal, the cyborg database has been updated.\nAlthough the device inspection will be performed in the next\ncycle, because it has been reported to the cyborg database before,\nthere will be no diff at this time, and the placement side will\nnot be updated. Therefore, this situation will cause the data\nstored in the placement side to be dirty data.\n\nThe solution is to expose the exception of the placement service,\nrather than a simple error prompt. Stop the data diff by throwing\nan unreachable service exception. In the next cycle, maybe the\nplacement service is back to normal, and at this point diff can\nproceed smoothly.\nThe reason why this is done is because the entry for resource\nscheduling is in placement. When the placement data is incorrect,\nthe data on cyborg side will lose its meaning.\n\nStory: 2007393\nTask: 38989\n\nChange-Id: Ia9e7a21f36b7154809d5bcf7812bb7fa73eff6df\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/e49f3c81296d76645a8b79e149aadb043b375712"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/e49f3c81296d76645a8b79e149aadb043b375712"}]},"branch":"refs/heads/master"},"6633fa32e887a17770913ceadeb42152ee6eb5ec":{"kind":"REWORK","_number":2,"created":"2020-03-11 08:22:51.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/12/711912/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/12/711912/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/12/711912/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/12/711912/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/12/711912/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/12/711912/2"}}},"commit":{"parents":[{"commit":"6dab512af226677c9065f85f264a691f3aeb6eab","subject":"Merge \"Revert \"Solve py37 timeout\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/6dab512af226677c9065f85f264a691f3aeb6eab"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2020-03-09 11:36:58.000000000","tz":480},"committer":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2020-03-11 08:21:43.000000000","tz":480},"subject":"Bugfix: expose placement service unavailable before diff cyborg db","message":"Bugfix: expose placement service unavailable before diff cyborg db\n\nWe know that cyborg will periodically synchronize data\nwith placement, but there is a prerequisite for data\nsynchronization. That is, when Cyborg periodically scans\nand finds that the database has changed, it will update\nthe placement.\n\nThere will be an implicit bug, that is, when the placement\nservice is abnormal (for example: the installation service\nis abnormal, the node where the placement service is down),\ncyborg will still update its database. When the placement\nservice is normal, the cyborg database has been updated.\nAlthough the device inspection will be performed in the next\ncycle, because it has been reported to the cyborg database before,\nthere will be no diff at this time, and the placement side will\nnot be updated. Therefore, this situation will cause the data\nstored in the placement side to be dirty data.\n\nThe solution is to expose the exception of the placement service,\nrather than a simple error prompt. Stop the data diff by throwing\nan unreachable service exception. In the next cycle, maybe the\nplacement service is back to normal, and at this point diff can\nproceed smoothly.\nThe reason why this is done is because the entry for resource\nscheduling is in placement. When the placement data is incorrect,\nthe data on cyborg side will lose its meaning.\n\nStory: 2007393\nTask: 38989\n\nChange-Id: Ia9e7a21f36b7154809d5bcf7812bb7fa73eff6df\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/6633fa32e887a17770913ceadeb42152ee6eb5ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/6633fa32e887a17770913ceadeb42152ee6eb5ec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}