)]}'
{"id":"openstack%2Fcyborg~712283","triplet_id":"openstack%2Fcyborg~master~Idddad0e514e78174d14cb84341d8bba9855f6dd8","project":"openstack/cyborg","branch":"master","topic":"bug_fix","hashtags":[],"change_id":"Idddad0e514e78174d14cb84341d8bba9855f6dd8","subject":"Bugfix: Set the appropriate status code for ServiceUnavailable","status":"MERGED","created":"2020-03-11 08:44:23.000000000","updated":"2020-03-17 09:14:31.000000000","submitted":"2020-03-17 09:12:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"712283-1584436356672-99049c42","meta_rev_id":"36f807d2b57cd9f67c6adf7d40932a9c08e72801","_number":712283,"virtual_id_number":712283,"owner":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":30759,"name":"Shogo Saito","email":"shogo.saito.ac@hco.ntt.co.jp","username":"s.shogo"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":0,"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-17 09:12:36.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-17 05:53:49.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"all":[{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":30759,"name":"Shogo Saito","email":"shogo.saito.ac@hco.ntt.co.jp","username":"s.shogo"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":2,"date":"2020-03-17 07:53:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":2,"date":"2020-03-17 08:40:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"date":"2020-03-17 08:10:08.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"all":[{"value":0,"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"value":0,"_account_id":30759,"name":"Shogo Saito","email":"shogo.saito.ac@hco.ntt.co.jp","username":"s.shogo"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"value":1,"date":"2020-03-17 08:40:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":30759,"name":"Shogo Saito","email":"shogo.saito.ac@hco.ntt.co.jp","username":"s.shogo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-11 08:45:35.000000000","updated_by":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"reviewer":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"state":"REVIEWER"},{"updated":"2020-03-11 08:45:42.000000000","updated_by":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"reviewer":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"state":"REVIEWER"},{"updated":"2020-03-11 08:46:11.000000000","updated_by":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"reviewer":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"state":"REVIEWER"},{"updated":"2020-03-11 08:46:19.000000000","updated_by":{"_account_id":30759,"name":"Shogo Saito","email":"shogo.saito.ac@hco.ntt.co.jp","username":"s.shogo"},"reviewer":{"_account_id":30759,"name":"Shogo Saito","email":"shogo.saito.ac@hco.ntt.co.jp","username":"s.shogo"},"state":"REVIEWER"},{"updated":"2020-03-17 07:53:25.000000000","updated_by":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"reviewer":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"state":"REVIEWER"},{"updated":"2020-03-17 08:10:08.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2020-03-17 08:40:01.000000000","updated_by":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"reviewer":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"state":"REVIEWER"},{"updated":"2020-03-17 09:12:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2c8ef4b225497c635110207f9f8efbc671dbd048","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-11 08:44:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fbaf09b5bf1cb7fc19f077a62de4c7db958e3884","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 09:25:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fbe9603cdbba4b929686d05602fc2420 : SUCCESS in 5m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/af92b11cb72343788e4b1739b1f2e4ef : SUCCESS in 4m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/efb9ad55a7b3489ab8ced5843b312a9b : SUCCESS in 6m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4192ad94a5374d44a33d2e8ad1c26f85 : SUCCESS in 6m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a546e4519d104bd9b1a34c50d5834dbb : SUCCESS in 7m 21s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9425257a51e845ad8fe14d65dbbf74c4 : SUCCESS in 5m 48s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/9906e581bec948d7b5271e419c64121c : SUCCESS in 29m 14s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c8edec1a752245088b682cee1f2c4c67 : SUCCESS in 39m 00s (non-voting)\n- cyborg-tox-bandit https://zuul.opendev.org/t/openstack/build/85c0b7a93c51420485928aaaeb3c64d3 : FAILURE in 4m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"29d2903482690e3d3f85f398857b517c7786970f","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-11 12:20:45.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nA suggestion inline.","accounts_in_message":[],"_revision_number":1},{"id":"ab643893419cd396a0262a4c72fde6441c9e3106","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-11 12:22:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"aa640a15b672d45443f68b7cd44c9a4d82d130ae","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-12 02:31:31.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"aa95819b4f1375e6d417db58f0270889d5fbef0f","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-12 02:32:29.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"1c5511ac2f64724918e40db7ab42dab1af89227f","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-12 02:32:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d262ce583c7fa2f26ed04d31d6c866bd4b54fbb2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-12 03:07:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0e0521c073a343e8b9fcca9aba2c75bb : SUCCESS in 4m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2a804d92827741ffb5b68c0df86db841 : SUCCESS in 3m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b7340f000de7473e8df64e12b9961324 : SUCCESS in 4m 23s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b981d039a10241b19fa05f6ce3283f81 : SUCCESS in 4m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a6644863479d4fca8a645861aab9c15b : SUCCESS in 4m 31s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/42b042abb3c248ad8fabaa5341ee4e60 : SUCCESS in 3m 35s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/e981cff2fa984c78b70a2cd2b2bb204c : SUCCESS in 24m 04s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d8d2f8d164f04e42a424e6445d784b3a : SUCCESS in 30m 18s (non-voting)\n- cyborg-tox-bandit https://zuul.opendev.org/t/openstack/build/74c08f44c97748caa4be5936bee1dd8b : FAILURE in 3m 51s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"6b0de580d46875e661478eca75fdcfa48de25a8f","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-13 07:34:11.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nI think we shuold add a test case for this change.","accounts_in_message":[],"_revision_number":2},{"id":"6186d05dbecd705fa142ebf27eb3aec894a8595a","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-13 10:32:47.000000000","message":"Patch Set 2:\n\n\u003e (2 comments)\n \u003e \n \u003e I think we shuold add a test case for this change.\n\nGood Catch. Now We didn\u0027t have UT about get_sdk_adapter. After thinking about it, I\u0027m not very good at the UT of this function. If it\u0027s just for testing this exception, I gave the relevant ones to mock (_get_conf_group, _get_auth_and_session, connection.Connection). But I don\u0027t think it makes much sense to write such a UT. When our cyborg later optimizes this UT, we can add this part of assert, what do you think? Or if you have time, could you add a UT about this function?","accounts_in_message":[],"_revision_number":2},{"id":"d1204d0762ccacc277444f4e8c7a18545688ec97","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-17 02:15:18.000000000","message":"Patch Set 2:\n\n@Brin. Do your forgot this patch? If you have time. Pls review again.","accounts_in_message":[],"_revision_number":2},{"id":"24292858d9dfbd2d2eee51895a9c07241e9ff534","author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"date":"2020-03-17 03:09:49.000000000","message":"Patch Set 2:\n\n\u003e \u003e (2 comments)\n \u003e \u003e\n \u003e \u003e I think we shuold add a test case for this change.\n \u003e \n \u003e Good Catch. Now We didn\u0027t have UT about get_sdk_adapter. After\n \u003e thinking about it, I\u0027m not very good at the UT of this function. If\n \u003e it\u0027s just for testing this exception, I gave the relevant ones to\n \u003e mock (_get_conf_group, _get_auth_and_session, connection.Connection).\n \u003e But I don\u0027t think it makes much sense to write such a UT. When our\n \u003e cyborg later optimizes this UT, we can add this part of assert,\n \u003e what do you think? Or if you have time, could you add a UT about\n \u003e this function?\n\nAgree that this patch probably doesn\u0027t need a test case.\nIf we want to check the exact results of this change through get_sdk_adapter, we need to at least add a testcase Class TestGetSDKAdapter() like this[0]. Adding unittest is always welcome and good for the code quality, but I personally think it\u0027s still safe for this change without a test. \nBut then again, we should add TestGetSDKAdapter() in another patch.\n[0]https://github.com/openstack/nova/blob/0f81adfaa3f493b4397fcea9339ab14dfeb3ef45/nova/tests/unit/test_utils.py#L1184","accounts_in_message":[],"_revision_number":2},{"id":"b853a801f45eb45f03b6f89a2739678c88c93ae4","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-17 03:43:35.000000000","message":"Patch Set 2: -Code-Review\n\n\u003e \u003e \u003e (2 comments)\n \u003e \u003e \u003e\n \u003e \u003e \u003e I think we shuold add a test case for this change.\n \u003e \u003e\n \u003e \u003e Good Catch. Now We didn\u0027t have UT about get_sdk_adapter. After\n \u003e \u003e thinking about it, I\u0027m not very good at the UT of this function.\n \u003e If\n \u003e \u003e it\u0027s just for testing this exception, I gave the relevant ones to\n \u003e \u003e mock (_get_conf_group, _get_auth_and_session, connection.Connection).\n \u003e \u003e But I don\u0027t think it makes much sense to write such a UT. When\n \u003e our\n \u003e \u003e cyborg later optimizes this UT, we can add this part of assert,\n \u003e \u003e what do you think? Or if you have time, could you add a UT about\n \u003e \u003e this function?\n \u003e \n \u003e Agree that this patch probably doesn\u0027t need a test case.\n \u003e If we want to check the exact results of this change through\n \u003e get_sdk_adapter, we need to at least add a testcase Class\n \u003e TestGetSDKAdapter() like this[0]. Adding unittest is always welcome\n \u003e and good for the code quality, but I personally think it\u0027s still\n \u003e safe for this change without a test.\n \u003e But then again, we should add TestGetSDKAdapter() in another patch.\n \u003e [0]https://github.com/openstack/nova/blob/0f81adfaa3f493b4397fcea9339ab14dfeb3ef45/nova/tests/unit/test_utils.py#L1184\n\nI am ok with this change whether to add the test case, but I think we should add the test case ASAP, if we always jump cover the test case, maybe that will be a long or a never implement TODO.","accounts_in_message":[],"_revision_number":2},{"id":"a83cd4819dcfa5d162aa29fc2bf8fa59cf3e1383","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2020-03-17 05:53:49.000000000","message":"Patch Set 2:\n\n\u003e I am ok with this change whether to add the test case, but I think\n \u003e we should add the test case ASAP, if we always jump cover the test\n \u003e case, maybe that will be a long or a never implement TODO.\n\nActually, I have been working on improving unit tests for a long time, including db and object modules. It\u0027s true that unit tests are important, but we have to come one by one, right? Fixing bugs, improving unit tests, and pushing new features are all aimed at making cyborg more robust and trusting more people. This requires our joint efforts, so I care about your concern. Let us continue to work hard.","accounts_in_message":[],"_revision_number":2},{"id":"6aba475b4170b497de6aa3ccdaff7d3b6c5bacfb","author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"date":"2020-03-17 07:53:25.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"ec84a467f1b7eaba7392da58fe5f6fd74cab99b4","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-17 08:10:08.000000000","message":"Patch Set 2:\n\n\u003e \u003e I am ok with this change whether to add the test case, but I\n \u003e think\n \u003e \u003e we should add the test case ASAP, if we always jump cover the\n \u003e test\n \u003e \u003e case, maybe that will be a long or a never implement TODO.\n \u003e \n \u003e Actually, I have been working on improving unit tests for a long\n \u003e time, including db and object modules. It\u0027s true that unit tests\n \u003e are important, but we have to come one by one, right? Fixing bugs,\n \u003e improving unit tests, and pushing new features are all aimed at\n \u003e making cyborg more robust and trusting more people. This requires\n \u003e our joint efforts, so I care about your concern. Let us continue to\n \u003e work hard.\n\nYeah, step by step, it is always difficult to get the best of both worlds.","accounts_in_message":[],"_revision_number":2},{"id":"07d64cb7589d7069fe9d1f30714cb8340dfe1b9a","author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"date":"2020-03-17 08:40:01.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM, agree Brin, we should have testcase and re-thinking about the inherirtance of these exceptions, I found there are several exceptions should inherit from bad_request class which is now inherit from cyborgexception.","accounts_in_message":[],"_revision_number":2},{"id":"9568b21712e74f4ebfe9a0eede4022fe72ccf5f6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 08:40:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b4c92bd043ccb086cb8767665ff34b8aefd33a78","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 09:12:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"dcf7fd08a58146bd6121739ea46730cc5603db0d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 09:12:36.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/81257eea5f8a4222b49854c114948085 : SUCCESS in 4m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9dc13c4893d54dabb7e1658b9ff37adc : SUCCESS in 3m 55s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f96bd0b8bde44b5fb874d1ef08891a41 : SUCCESS in 5m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d0ccb1f0c6a848799b58b5109289172a : SUCCESS in 4m 00s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/59ebf38c084543458d95743035ad5a85 : SUCCESS in 30m 20s","accounts_in_message":[],"_revision_number":2},{"id":"145738cde07ad047316c1228dc4ab2da5ba52eb8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 09:14:31.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c970789be2e541009375e0fdd4b8a05f : SUCCESS in 1m 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b0492aad8ec4bad0d9326b7f639740ba47bbec50","revisions":{"ad7e02ba3051a3bf8878b0c4e594e927bcb5d8fa":{"kind":"REWORK","_number":1,"created":"2020-03-11 08:44:23.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/83/712283/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/83/712283/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/83/712283/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/83/712283/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/83/712283/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/83/712283/1"}}},"commit":{"parents":[{"commit":"6633fa32e887a17770913ceadeb42152ee6eb5ec","subject":"Bugfix: expose placement service unavailable before diff cyborg db","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/6633fa32e887a17770913ceadeb42152ee6eb5ec"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2020-03-11 08:38:06.000000000","tz":480},"committer":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2020-03-11 08:43:14.000000000","tz":480},"subject":"Bugfix: Set the appropriate status code for ServiceUnavailable","message":"Bugfix: Set the appropriate status code for ServiceUnavailable\n\nNow this class inherit from Invalid, However，the code of invalid\nexception is BAD_REQUEST(400), the status code of ServiceUnavailable\nshould be 503.\n\nChange-Id: Idddad0e514e78174d14cb84341d8bba9855f6dd8\nStory: 2007393\nTask: 39026\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/ad7e02ba3051a3bf8878b0c4e594e927bcb5d8fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/ad7e02ba3051a3bf8878b0c4e594e927bcb5d8fa"}]},"branch":"refs/heads/master"},"b0492aad8ec4bad0d9326b7f639740ba47bbec50":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-03-12 02:32:29.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/83/712283/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/83/712283/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/83/712283/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/83/712283/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/83/712283/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/83/712283/2"}}},"commit":{"parents":[{"commit":"6633fa32e887a17770913ceadeb42152ee6eb5ec","subject":"Bugfix: expose placement service unavailable before diff cyborg db","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/6633fa32e887a17770913ceadeb42152ee6eb5ec"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2020-03-11 08:38:06.000000000","tz":480},"committer":{"name":"chenker","email":"chen.ke14@zte.com.cn","date":"2020-03-12 02:32:24.000000000","tz":0},"subject":"Bugfix: Set the appropriate status code for ServiceUnavailable","message":"Bugfix: Set the appropriate status code for ServiceUnavailable\n\nNow this class inherit from Invalid, However,the code of invalid\nexception is BAD_REQUEST(400), the status code of ServiceUnavailable\nshould be 503.\n\nChange-Id: Idddad0e514e78174d14cb84341d8bba9855f6dd8\nStory: 2007393\nTask: 39026\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b0492aad8ec4bad0d9326b7f639740ba47bbec50"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/b0492aad8ec4bad0d9326b7f639740ba47bbec50"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}