)]}'
{"id":"openstack%2Fcyborg~714971","triplet_id":"openstack%2Fcyborg~master~I1687043dc2469343878cfeb466703eb9d4099ad0","project":"openstack/cyborg","branch":"master","topic":"hostname","hashtags":[],"change_id":"I1687043dc2469343878cfeb466703eb9d4099ad0","subject":"default host to socket.gethostname()","status":"MERGED","created":"2020-03-25 15:27:46.000000000","updated":"2020-03-31 10:10:03.000000000","submitted":"2020-03-31 10:08:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"714971-1585649310167-8abbd6ef","meta_rev_id":"bba9a79498b4291edd5e74665ef66e5a3b3677f7","_number":714971,"virtual_id_number":714971,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-03-26 16:50:50.000000000","_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-31 10:08:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2020-03-31 05:33:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":2,"date":"2020-03-31 09:18:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":1,"date":"2020-03-31 09:18:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-31 05:33:26.000000000","updated_by":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"reviewer":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"state":"REVIEWER"},{"updated":"2020-03-31 09:18:30.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2020-03-31 10:08:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"62108be8476e3c2561c4a842eac4f7e23ca5bb86","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-03-25 15:27:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8f271017ab8bb820acec7807d93ca296ec0f7b82","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-25 16:16:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5a09c8b94ab449fcaca199f7f8647fc8 : SUCCESS in 5m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c2b692f0d3c44cc3bc50ec5d1638eac5 : SUCCESS in 4m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/315c44d7fc664ffda6d218a8a6298e06 : SUCCESS in 6m 11s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e8c18ee99bd44dd1927c08b025faab76 : SUCCESS in 4m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/78f6281a6fbd4235b889848d489c6aa5 : SUCCESS in 5m 35s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/25fbff41b09a4aabb932b5fce6e804e5 : SUCCESS in 5m 32s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/b4734cf3bd504a289543f6cf0f27fc35 : SUCCESS in 31m 19s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/eb98cb169f8c457db3d8c7aef60650e9 : SUCCESS in 42m 15s (non-voting)\n- cyborg-tox-bandit https://zuul.opendev.org/t/openstack/build/fd0d5ba30411491497fcaf5136ff02ea : FAILURE in 4m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7e17ff22b443e6854d4436f8614a2bb0683f3dd3","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-03-26 16:50:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"df4ad692372a2ea614cc5b6badb3db25575b5125","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-30 01:21:24.000000000","message":"Patch Set 1: Code-Review+1\n\n+1 for this default change, hope Sundar and others can check again.","accounts_in_message":[],"_revision_number":1},{"id":"ad8a57d61d713346dd46724063435a42e83a2f75","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2020-03-31 05:33:26.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3d6b8682d97aec0eab99985547d2b4682129e5e8","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-31 09:18:30.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"97705712d35ec6258951626221df2d858fa65a53","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 09:18:44.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"25cbf25fe0c718fde21e757afa6dc3c76d41d14c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 10:08:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fad2e191be0e4ae8a8a12b35cbfd8ca2 : SUCCESS in 4m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c64d210714d84f4183b926555993d1fb : SUCCESS in 5m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/cc8b63d565a943fd8eecc9e5227b21bd : SUCCESS in 6m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91c6f437344b4b7ea0312f8807d0685a : SUCCESS in 6m 04s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/cbb2eaa688324a15b720665aae2c5c16 : SUCCESS in 47m 21s","accounts_in_message":[],"_revision_number":1},{"id":"ee9e90b3aa5528ac632be2576e0d3272e673602b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 10:08:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"09814e3d1bdb16cdf2b41690b2efdd912f6895d7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 10:10:03.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa108688f200497b864081cf060ec93e : SUCCESS in 1m 14s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ec0eab0ffb4fc18574dbd937f29545832d317e4c","revisions":{"ec0eab0ffb4fc18574dbd937f29545832d317e4c":{"kind":"REWORK","_number":1,"created":"2020-03-25 15:27:46.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/71/714971/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/71/714971/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/71/714971/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/71/714971/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/71/714971/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/71/714971/1"}}},"commit":{"parents":[{"commit":"31d23b73159e542d8791602afec991b4d3990cdf","subject":"Generate PDF documentation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/31d23b73159e542d8791602afec991b4d3990cdf"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2020-03-25 15:12:54.000000000","tz":0},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2020-03-25 15:12:54.000000000","tz":0},"subject":"default host to socket.gethostname()","message":"default host to socket.gethostname()\n\nAs disucssed in november cyborg does not defualt its host\nparamater to the same value as nova.\nhttp://lists.openstack.org/pipermail/openstack-discuss/2019-November/011044.html\n\nThis change updates the default value to match novas.\n\nOn a host that does not have a fqdn set via dhcp\nand a corresponding dns record getfqdn() and gethostname()\nwill return differnet values. This can also be seen in the\ndifferece in the hostname command output.\n\n[stack@cyborg-2 ~] hostname\ncyborg-2\n[stack@cyborg-2 ~] hostname --fqdn\nlocalhost\n\nas a result on a host without an fqdn set in /etc/hostname\nor an fqdn set via dhcp/dns using socket.getfqdn() will\nresult in \u0027localhost.localdomain\u0027 where as socket.gethostname()\nwill result in \u0027cyborg-2\u0027\n\nThis is required to have the correct default behavior so that\ncyborg and discover and the parent placment resouce provider\ncorresponding to the current host.\n\nChange-Id: I1687043dc2469343878cfeb466703eb9d4099ad0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/ec0eab0ffb4fc18574dbd937f29545832d317e4c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/ec0eab0ffb4fc18574dbd937f29545832d317e4c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}