)]}'
{"id":"openstack%2Fcyborg~715951","triplet_id":"openstack%2Fcyborg~master~I5d11a1f87d9547d9b6a27bf1f79cd69e0f73c741","project":"openstack/cyborg","branch":"master","topic":"update-hacking","hashtags":[],"change_id":"I5d11a1f87d9547d9b6a27bf1f79cd69e0f73c741","subject":"Update hacking for Python3","status":"MERGED","created":"2020-03-30 14:18:22.000000000","updated":"2020-03-31 15:24:05.000000000","submitted":"2020-03-31 15:21:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"715951-1585668065631-c8b48262","meta_rev_id":"e1f8b35abbcff33fb3f895313766ae3331932d25","_number":715951,"virtual_id_number":715951,"owner":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-31 15:21:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"date":"2020-03-31 06:41:25.000000000","_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-03-31 14:50:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":2,"date":"2020-03-31 09:13:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":1,"date":"2020-03-31 12:30:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-03-31 14:50:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-31 09:13:35.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2020-03-31 12:30:31.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-03-31 14:50:19.000000000","updated_by":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"reviewer":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"state":"REVIEWER"},{"updated":"2020-03-31 15:21:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"67e7ea4c4fd8464542f0f13835b33eaa1a624a5e","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-03-30 14:18:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"26ab007ba2384361106d98495e2fe7f5bb31823a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-30 15:36:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/bea277ed3c6d48b3a5af62d363a2ff4f : SUCCESS in 4m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/db6906dc1bb641b8a89a9158f8d4d38b : SUCCESS in 6m 35s\n- requirements-check https://zuul.opendev.org/t/openstack/build/82ad958288d34227abafd903a6b5db34 : SUCCESS in 4m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/89edceb9bb5a4f74842401db60461498 : SUCCESS in 6m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b35e79f1f7314c78a389f7738612db91 : SUCCESS in 4m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6206ccdf003a4d209f7337c01e9a3cf8 : SUCCESS in 8m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2d1b5fe191544ef48aaf55a5f207f6d3 : SUCCESS in 5m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3cfaea099af64f67812831824d23a822 : SUCCESS in 6m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/63e7e460c02245ec8ed664d186e738f1 : SUCCESS in 6m 48s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/d631fb81f6394a4d94a39b333ea42034 : SUCCESS in 36m 02s\n- cyborg-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/10bf08de86ef4d6bac2bdc89919243c9 : SUCCESS in 37m 12s (non-voting)\n- cyborg-tox-bandit https://zuul.opendev.org/t/openstack/build/c7a9165af8f44242b8c50cd7e2eecd78 : FAILURE in 5m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a3c6b241f0484466dbfc4b9399f919e42f875f78","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-31 01:17:43.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks update, my concern as the same in cyborgclient, we should check the order of import files\n1.import third-party libraries\n2.import oslo_ * libraries\n3.import the library of this project\n\nThere is a sort similar to the above order, forgive me for not finding that article for a while.","accounts_in_message":[],"_revision_number":1},{"id":"f48c2d3aea009ff370dc559e65964a16ed9ff90d","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2020-03-31 05:43:41.000000000","message":"Patch Set 1: Code-Review-1\n\n\u003e we should check the order of import files\n\nHi ANdrea, Brin Zhang is expressing a concern here. Would you be addressing that in this patch?","accounts_in_message":[],"_revision_number":1},{"id":"f747f6bb92e376c7ac521d0987643d2879a396c3","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2020-03-31 05:44:13.000000000","message":"Patch Set 1:\n\n\u003e \u003e we should check the order of import files\n \u003e \n \u003e Hi ANdrea, Brin Zhang is expressing a concern here. Would you be\n \u003e addressing that in this patch?\n\nAndreas","accounts_in_message":[],"_revision_number":1},{"id":"a050ce520a3c28771104369e84e72dc2b4b2a94e","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-03-31 06:41:25.000000000","message":"Patch Set 1:\n\nBrin, I\u0027m not changing those import in this change at all.\n\nI think you\u0027re talking about H306 which is enabled and your imports look correct to me. Reference: https://docs.openstack.org/hacking/latest/user/hacking.html#imports\n\nCould you reconsider your review, please?","accounts_in_message":[],"_revision_number":1},{"id":"f08f1b15344e977a1d89a1abc786116c4688ee52","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-31 09:13:30.000000000","message":"Patch Set 1:\n\n\u003e Brin, I\u0027m not changing those import in this change at all.\n \u003e \n \u003e I think you\u0027re talking about H306 which is enabled and your imports\n \u003e look correct to me. Reference: https://docs.openstack.org/hacking/latest/user/hacking.html#imports\n \u003e \n \u003e Could you reconsider your review, please?\n\nYes, the H306 is enabled by default, thanks for you explain in irc. irc-log http://eavesdrop.openstack.org/irclogs/%23openstack-qa/%23openstack-qa.2020-03-31.log.html#t2020-03-31T08:16:25","accounts_in_message":[],"_revision_number":1},{"id":"d7765fa33ed7f969f77893de107acc5ad53c8b1b","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-03-31 09:13:35.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c15155e1dc00d972d23064426238ca2438653af9","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-03-31 12:30:31.000000000","message":"Patch Set 1: Code-Review+1\n\nI think bandit warn could be `noqa`\u0027ed","accounts_in_message":[],"_revision_number":1},{"id":"2d77e90a5b277f0ae5284d7a4b59a79a5b462b75","author":{"_account_id":21672,"name":"Sundar Nadathur","email":"sundar.nadathur@intel.com","username":"nsundar"},"date":"2020-03-31 14:50:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nAgreed based on the discussion.","accounts_in_message":[],"_revision_number":1},{"id":"b695dfd3a575531befd028f41d39e6b42001b0b9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 14:50:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"bf32cf0484a9fa36a5a2cf810f094e7dd291c2f4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 15:21:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/efc65b9fcc4d4f02b3d5de66a196f086 : SUCCESS in 5m 52s\n- requirements-check https://zuul.opendev.org/t/openstack/build/e11dad95fab442158039278ee6f931eb : SUCCESS in 4m 02s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a64ec305804f4c1683ab780a0eb2b8c8 : SUCCESS in 5m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/35a9d234bd6b42d383fead6078e40ca0 : SUCCESS in 6m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8ede16cddf6643418309e781a2fcfe2e : SUCCESS in 7m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0b29bfacb0ba422a90996c83df274cc4 : SUCCESS in 7m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/595fd66dc4ba4af78ef81dc648c4fca8 : SUCCESS in 8m 59s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/71d0f2b2e6f84e9084fdd199ea8cfe10 : SUCCESS in 28m 53s","accounts_in_message":[],"_revision_number":1},{"id":"97d91a6180abef82a5ddda6ca87962ef26cf58d9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 15:21:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"55300eee6121b212c0d0653abc6668cfe2a8fd1d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-31 15:24:05.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-api-ref https://zuul.opendev.org/t/openstack/build/871639d4d2da4c21a7624b1c8daba94e : SUCCESS in 2m 15s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3678f9189a18404c96742553e1711881 : SUCCESS in 1m 55s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/674c2b54f018439caebef59dd1dc33aa : SUCCESS in 1m 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a6f84335bbf6ef761bc5a56e6ee09830c7a6288e","revisions":{"a6f84335bbf6ef761bc5a56e6ee09830c7a6288e":{"kind":"REWORK","_number":1,"created":"2020-03-30 14:18:22.000000000","uploader":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"ref":"refs/changes/51/715951/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cyborg","ref":"refs/changes/51/715951/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/51/715951/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/51/715951/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cyborg refs/changes/51/715951/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cyborg refs/changes/51/715951/1"}}},"commit":{"parents":[{"commit":"07db145919a3b50c6d9627f1191965287b5d8367","subject":"Merge \"Add \u0027description\u0027 field to the device profile object\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/07db145919a3b50c6d9627f1191965287b5d8367"}]}],"author":{"name":"Andreas Jaeger","email":"aj@suse.com","date":"2020-03-30 14:07:49.000000000","tz":120},"committer":{"name":"Andreas Jaeger","email":"aj@suse.com","date":"2020-03-30 14:18:12.000000000","tz":120},"subject":"Update hacking for Python3","message":"Update hacking for Python3\n\nThe repo is Python 3 now, so update hacking to version 3.0 which\nsupports Python 3.\n\nFix problems found:\nE117 over-indented\nE501 line too long\nE741 ambiguous variable name \u0027l\u0027\nW605 invalid escape sequence\n\nBlacklist:\nW503 line break before binary operator\nW504 line break after binary operator\n\nUpdate local hacking checks for new flake8.\n\nChange-Id: I5d11a1f87d9547d9b6a27bf1f79cd69e0f73c741\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/a6f84335bbf6ef761bc5a56e6ee09830c7a6288e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cyborg/commit/a6f84335bbf6ef761bc5a56e6ee09830c7a6288e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}