)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"95b2c9b5c0c0a48e2b7c9ea9d836c4dd6fc949c8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cyborg specifically needs Nova API version 2.82, because"},{"line_number":10,"context_line":"that defines the ARQ binding event [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://review.opendev.org/#/c/692707/17/nova/api/openstack/api_version_request.py@235"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Storyboard: https://storyboard.openstack.org/#!/story/2006921"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_0cba7f6c","line":12,"updated":"2020-04-01 08:29:27.000000000","message":"nit: it is can also instead of by https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id75, that why I insist on add the microversion change histroy docs to the v2, that we can know what has changed in any minor version..","commit_id":"f01c80b9b7c04d0c2fa3c6aa2f9a6c2347f6868a"}],"cyborg/common/nova_client.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"95b2c9b5c0c0a48e2b7c9ea9d836c4dd6fc949c8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class NovaAPI(object):"},{"line_number":24,"context_line":"    def __init__(self):"},{"line_number":25,"context_line":"        self.nova_client \u003d utils.get_sdk_adapter(\u0027compute\u0027)"},{"line_number":26,"context_line":"        self.nova_client.default_microversion \u003d \u00272.82\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _get_acc_changed_events(self, instance_uuid, arq_bind_statuses):"},{"line_number":29,"context_line":"        return [{\u0027name\u0027: \u0027accelerator-request-bound\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_0c3d5fdc","line":26,"updated":"2020-04-01 08:29:27.000000000","message":"Technically we have no problem using \u0027latest\u0027, as long as microversion\u003e 2.82, nova can use cyborg accelerators.\n\nIf we have to change the nova api because we need to enhance the arq function again, we need to set this default_microversion to the latest.\n\nI am ok with this use latest or fixed microversion.","commit_id":"f01c80b9b7c04d0c2fa3c6aa2f9a6c2347f6868a"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dc818b4129c4944122f3365f850c90dc87095c14","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class NovaAPI(object):"},{"line_number":24,"context_line":"    def __init__(self):"},{"line_number":25,"context_line":"        self.nova_client \u003d utils.get_sdk_adapter(\u0027compute\u0027)"},{"line_number":26,"context_line":"        self.nova_client.default_microversion \u003d \u00272.82\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _get_acc_changed_events(self, instance_uuid, arq_bind_statuses):"},{"line_number":29,"context_line":"        return [{\u0027name\u0027: \u0027accelerator-request-bound\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_cf086e93","line":26,"in_reply_to":"df33271e_0c3d5fdc","updated":"2020-04-02 05:45:54.000000000","message":"Comments from Eric Fried, agreed.\n\n\"Sorry I didn\u0027t catch this review earlier, but it is bad practice to use \u0027latest\u0027 as the default microversion.\n\nIf what you\u0027re trying to do is chase whatever microversion ends up exposing the new notification, and you have a chicken/egg dependency such that you can\u0027t actually wait until the nova side lands, then you should use \u0027latest\u0027 only on the *specific* call(s) that involve that notification, with a big fat TODO on those lines to cut over to the specific microversion when $patch lands.\"","commit_id":"f01c80b9b7c04d0c2fa3c6aa2f9a6c2347f6868a"}]}