)]}'
{"cyborg/common/authorize_wsgi.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d69e9948844d1c050d83f5b8a7464131f52f91d4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        from cyborg.common import authorize_wsgi"},{"line_number":106,"context_line":"        class AcceleratorController(rest.RestController):"},{"line_number":107,"context_line":"            ...."},{"line_number":108,"context_line":"            @authorize_wsgi.authorize_wsgi(\"cyborg:accelerator\", \"create\", False)"},{"line_number":109,"context_line":"            @wsme_pecan.wsexpose(Accelerator, body\u003dtypes.jsontype,"},{"line_number":110,"context_line":"                                 status_code\u003dhttp_client.CREATED)"},{"line_number":111,"context_line":"            def post(self, values):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8cc7ae45","line":108,"updated":"2020-09-10 10:23:08.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"0175a86756b4a3e6d9771c6f7c669a6471f088fc"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e5fc73c82b2e29a5782ecbe6aba0f2905cf4a611","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            credentials \u003d context.to_policy_values()"},{"line_number":137,"context_line":"            credentials[\u0027is_admin\u0027] \u003d context.is_admin"},{"line_number":138,"context_line":"            if context.system_scope \u003d\u003d \u0027all\u0027:"},{"line_number":139,"context_line":"                credentials[\u0027system\u0027] \u003d True"},{"line_number":140,"context_line":"            target \u003d {}"},{"line_number":141,"context_line":"            # maybe we can pass \"_get_resource\" to authorize_wsgi"},{"line_number":142,"context_line":"            if need_target and hasattr(self, \"_get_resource\"):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_2f3ac232","line":139,"range":{"start_line":139,"start_character":16,"end_line":139,"end_character":37},"updated":"2020-09-11 03:03:01.000000000","message":"why we set it to True?","commit_id":"7f2c79c9f76bd1d774fd5409bb2c4ad80d97ce11"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"f5de21e935f878270209f52f85c652530111f7a0","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            credentials \u003d context.to_policy_values()"},{"line_number":137,"context_line":"            credentials[\u0027is_admin\u0027] \u003d context.is_admin"},{"line_number":138,"context_line":"            if context.system_scope \u003d\u003d \u0027all\u0027:"},{"line_number":139,"context_line":"                credentials[\u0027system\u0027] \u003d True"},{"line_number":140,"context_line":"            target \u003d {}"},{"line_number":141,"context_line":"            # maybe we can pass \"_get_resource\" to authorize_wsgi"},{"line_number":142,"context_line":"            if need_target and hasattr(self, \"_get_resource\"):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_abb7e584","line":139,"range":{"start_line":139,"start_character":16,"end_line":139,"end_character":37},"in_reply_to":"9f560f44_2f3ac232","updated":"2020-09-11 05:39:17.000000000","message":"because of here in the policy check:https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L992. if system_scope \u003d\u003d \u0027all\u0027, the token_scope should be \u0027system\u0027","commit_id":"7f2c79c9f76bd1d774fd5409bb2c4ad80d97ce11"}],"cyborg/tests/unit/policies/test_device_profiles.py":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e5fc73c82b2e29a5782ecbe6aba0f2905cf4a611","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.flags(enforce_scope\u003dTrue, group\u003d\"oslo_policy\")"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # check that system_admin is able to do create and delete operations."},{"line_number":159,"context_line":"        self.create_authorized_contexts \u003d ["},{"line_number":160,"context_line":"            self.system_admin_context]"},{"line_number":161,"context_line":"        self.delete_authorized_contexts \u003d self.create_authorized_contexts"},{"line_number":162,"context_line":"        # Check that non-system or non-admin is not able to perform the system"},{"line_number":163,"context_line":"        # level actions on device_profiles."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_cfdd0615","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":38},"updated":"2020-09-11 03:03:01.000000000","message":"you can put them in one line.","commit_id":"7f2c79c9f76bd1d774fd5409bb2c4ad80d97ce11"}]}
