)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-09-24 03:59:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add releasenote for policy refresh base and device profile policies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08f9d9043a488c8bb55c57f14f8eac860d47eb1f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_60f9717e","line":8,"updated":"2020-09-25 06:11:31.000000000","message":"As talked in wechat, we are better to decribe we add the releasenote but we have not completed this feature, after we completed this, we will update the \"Updated Decription\" and \"Decrepated Description\" sections.\n\nAnother thing, IMO, this need to add depend-on tag, the hyperlink related to the policy docs.\n\nDepend-On: 5997bdcc1fc809dddb9638cd8947f906cabdf9f4","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"}],"releasenotes/notes/policy_refresh_base_and_device_profile-cef00fca580d2323.yaml":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e8367dc8f7a3ea19beb2b94fde4547bea895e0af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    In this release, the policy refresh (RBAC with scoped) for cyborg is"},{"line_number":4,"context_line":"    partially implemented, we\u0027ve implemented new default rules in base policy"},{"line_number":5,"context_line":"    and device_profile policy, and added the basic testing framework for all"},{"line_number":6,"context_line":"    policies. For the Backward Compatibility, the new and old policy"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_a37fd864","line":3,"range":{"start_line":3,"start_character":41,"end_line":3,"end_character":45},"updated":"2020-09-15 03:09:28.000000000","message":"could u plz explain `RBAC`?","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5fe11dfd54b35067d1a2d5924b920e686c63245e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    In this release, the policy refresh (RBAC with scoped) for cyborg is"},{"line_number":4,"context_line":"    partially implemented, we\u0027ve implemented new default rules in base policy"},{"line_number":5,"context_line":"    and device_profile policy, and added the basic testing framework for all"},{"line_number":6,"context_line":"    policies. For the Backward Compatibility, the new and old policy"},{"line_number":7,"context_line":"    will both work, although old rules are maintained as deprecated rules."},{"line_number":8,"context_line":"    After we implement all the features, we\u0027ll give two cycles transition"},{"line_number":9,"context_line":"    period for operators. See `policy default refresh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_d8763740","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":44},"updated":"2020-09-15 02:44:53.000000000","message":"...backward compatibility, if you want to emphasize it, you can use **backward compatibility**.","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5fe11dfd54b35067d1a2d5924b920e686c63245e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    In this release, the policy refresh (RBAC with scoped) for cyborg is"},{"line_number":4,"context_line":"    partially implemented, we\u0027ve implemented new default rules in base policy"},{"line_number":5,"context_line":"    and device_profile policy, and added the basic testing framework for all"},{"line_number":6,"context_line":"    policies. For the Backward Compatibility, the new and old policy"},{"line_number":7,"context_line":"    will both work, although old rules are maintained as deprecated rules."},{"line_number":8,"context_line":"    After we implement all the features, we\u0027ll give two cycles transition"},{"line_number":9,"context_line":"    period for operators. See `policy default refresh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_1871cf45","line":6,"range":{"start_line":6,"start_character":62,"end_line":6,"end_character":68},"updated":"2020-09-15 02:44:53.000000000","message":"policies","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"ad214ad711b18c188192093c5abe05cb975ae77c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    In this release, the policy refresh (RBAC with scoped) for cyborg is"},{"line_number":4,"context_line":"    partially implemented, we\u0027ve implemented new default rules in base policy"},{"line_number":5,"context_line":"    and device_profile policy, and added the basic testing framework for all"},{"line_number":6,"context_line":"    policies. For the Backward Compatibility, the new and old policy"},{"line_number":7,"context_line":"    will both work, although old rules are maintained as deprecated rules."},{"line_number":8,"context_line":"    After we implement all the features, we\u0027ll give two cycles transition"},{"line_number":9,"context_line":"    period for operators. See `policy default refresh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_43b51c32","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":44},"in_reply_to":"9f560f44_d8763740","updated":"2020-09-15 02:56:26.000000000","message":"done.pls check the update.","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5fe11dfd54b35067d1a2d5924b920e686c63245e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u003chttps://specs.openstack.org/openstack/cyborg-specs/specs/ussuri/approved/policy-defaults-refresh.html\u003e`_"},{"line_number":11,"context_line":"features:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Added protection test framwork for all APIs\u0027 policy check."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Added protection test for device profile APIs\u0027 policy check."},{"line_number":16,"context_line":"    A protection test is similar to an API test, but mainly focused on the"},{"line_number":17,"context_line":"    authoritative outcome. DeviceProfilePolicyTest tests both legacy rules"},{"line_number":18,"context_line":"    and new rules by setting"},{"line_number":19,"context_line":"    ``cyborg.conf [oslo_policy] enforce_scope \u003d False`` in SetUp(),"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_18bf0fab","line":16,"range":{"start_line":13,"start_character":4,"end_line":16,"end_character":48},"updated":"2020-09-15 02:44:53.000000000","message":"I think we can say we were introduced the new policy check, and added the related unit tests, covered the framwork, device profile APIs.\n\nIndeed, the tests of the functions decription just need to add in the commit message, in releasenote is not much necessary.","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"ad214ad711b18c188192093c5abe05cb975ae77c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u003chttps://specs.openstack.org/openstack/cyborg-specs/specs/ussuri/approved/policy-defaults-refresh.html\u003e`_"},{"line_number":11,"context_line":"features:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Added protection test framwork for all APIs\u0027 policy check."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Added protection test for device profile APIs\u0027 policy check."},{"line_number":16,"context_line":"    A protection test is similar to an API test, but mainly focused on the"},{"line_number":17,"context_line":"    authoritative outcome. DeviceProfilePolicyTest tests both legacy rules"},{"line_number":18,"context_line":"    and new rules by setting"},{"line_number":19,"context_line":"    ``cyborg.conf [oslo_policy] enforce_scope \u003d False`` in SetUp(),"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_e3a71009","line":16,"range":{"start_line":13,"start_character":4,"end_line":16,"end_character":48},"in_reply_to":"9f560f44_18bf0fab","updated":"2020-09-15 02:56:26.000000000","message":"ok.removed","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e8367dc8f7a3ea19beb2b94fde4547bea895e0af","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      system or project reader,"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      The belowing rules are marked as deprecated old rules in base policy."},{"line_number":35,"context_line":"      public_api,\u0027allow\u0027,\u0027deny\u0027,\u0027admin_api\u0027,\u0027is_admin\u0027,"},{"line_number":36,"context_line":"      admin_or_owner,\u0027admin_or_user\u0027."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    * **New Defaults for device_profile APIs**"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_835c54f1","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":16},"updated":"2020-09-15 03:09:28.000000000","message":"nit:\u0027public_api\u0027","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e8367dc8f7a3ea19beb2b94fde4547bea895e0af","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      The belowing rules are marked as deprecated old rules in base policy."},{"line_number":35,"context_line":"      public_api,\u0027allow\u0027,\u0027deny\u0027,\u0027admin_api\u0027,\u0027is_admin\u0027,"},{"line_number":36,"context_line":"      admin_or_owner,\u0027admin_or_user\u0027."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    * **New Defaults for device_profile APIs**"},{"line_number":39,"context_line":"      Rewrite check string(authorization rules) using new personas for"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_636140a9","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":20},"updated":"2020-09-15 03:09:28.000000000","message":"nit:\u0027admin_or_owner\u0027","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e8367dc8f7a3ea19beb2b94fde4547bea895e0af","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      - ``cyborg:device_profile:create``"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"      Add check_str\u003dbase.SYSTEM_ADMIN and"},{"line_number":52,"context_line":"      deprecated base.deprecated_default for"},{"line_number":53,"context_line":"      - ``cyborg:device_profile:delete``"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    Updated policy documentation on cyborg-doc page"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_e3439010","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":17},"updated":"2020-09-15 03:09:28.000000000","message":"miss `check_str`","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5fe11dfd54b35067d1a2d5924b920e686c63245e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    Updated policy documentation on cyborg-doc page"},{"line_number":56,"context_line":"deprecations:"},{"line_number":57,"context_line":"  - |"},{"line_number":58,"context_line":"    Old rules are marked as deprecated rules, but both the old rules and new"},{"line_number":59,"context_line":"    rules still work today because a deployment sets"},{"line_number":60,"context_line":"    ``cyborg.conf [oslo_policy] enforce_scope \u003d False`` as the default set."},{"line_number":61,"context_line":"    Users can set ``cyborg.conf [oslo_policy] enforce_scope \u003d True`` by default"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_634e606f","line":58,"range":{"start_line":58,"start_character":50,"end_line":58,"end_character":76},"updated":"2020-09-15 02:44:53.000000000","message":"I think this is just to say the old rules is ok.","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"ad214ad711b18c188192093c5abe05cb975ae77c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    Updated policy documentation on cyborg-doc page"},{"line_number":56,"context_line":"deprecations:"},{"line_number":57,"context_line":"  - |"},{"line_number":58,"context_line":"    Old rules are marked as deprecated rules, but both the old rules and new"},{"line_number":59,"context_line":"    rules still work today because a deployment sets"},{"line_number":60,"context_line":"    ``cyborg.conf [oslo_policy] enforce_scope \u003d False`` as the default set."},{"line_number":61,"context_line":"    Users can set ``cyborg.conf [oslo_policy] enforce_scope \u003d True`` by default"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_03ab24d7","line":58,"range":{"start_line":58,"start_character":50,"end_line":58,"end_character":76},"in_reply_to":"9f560f44_634e606f","updated":"2020-09-15 02:56:26.000000000","message":"Done","commit_id":"286100014b82b5ad510e95e5585fc5eea9b66efd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0c6c02afce6373e19a6b5ba499fcf1070a22297a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    authorization for API access, and implemented new default rules in base"},{"line_number":5,"context_line":"    policy and device_profile policy."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    During the development period, the new and old policy will both work,"},{"line_number":8,"context_line":"    although old rules are marked as deprecated rules. After we implement"},{"line_number":9,"context_line":"    all the features, we\u0027ll give two cycles transition period for operators."},{"line_number":10,"context_line":"    See `policy default refresh"},{"line_number":11,"context_line":"    \u003chttps://specs.openstack.org/openstack/cyborg-specs/specs/ussuri/approved/policy-defaults-refresh.html\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_7a287eed","line":8,"range":{"start_line":7,"start_character":3,"end_line":8,"end_character":54},"updated":"2020-09-17 21:35:05.000000000","message":"this is tricky and not always true if operator generates the policy file by oslo tool in JSON format. basically this bug: https://bugs.launchpad.net/nova/+bug/1875418\n\nBefore this we need to deprecate the JSON format in policy file and also change the default of policy_file to policy.yaml otherwise we can have chance to break the operator existing deployment. \nwhich is this part https://wiki.openstack.org/wiki/Consistent_and_Secure_Default_Policies_Popup_Team#Pre-work_to_provide_a_smooth_migration_path_to_the_new_policy","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e70ac8be97db7eda4a4e5722bd0efc1f58e1dcf9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    authorization for API access, and implemented new default rules in base"},{"line_number":5,"context_line":"    policy and device_profile policy."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    During the development period, the new and old policy will both work,"},{"line_number":8,"context_line":"    although old rules are marked as deprecated rules. After we implement"},{"line_number":9,"context_line":"    all the features, we\u0027ll give two cycles transition period for operators."},{"line_number":10,"context_line":"    See `policy default refresh"},{"line_number":11,"context_line":"    \u003chttps://specs.openstack.org/openstack/cyborg-specs/specs/ussuri/approved/policy-defaults-refresh.html\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_7de6b84c","line":8,"range":{"start_line":7,"start_character":3,"end_line":8,"end_character":54},"in_reply_to":"9f560f44_7a287eed","updated":"2020-09-17 22:23:27.000000000","message":"Doing this in https://review.opendev.org/#/c/752576/","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cddc033363caddfb7f2700c191cc8332535c68cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    authorization for API access, and implemented new default rules in base"},{"line_number":5,"context_line":"    policy and device_profile policy."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    During the development period, the new and old policy will both work,"},{"line_number":8,"context_line":"    although old rules are marked as deprecated rules. After we implement"},{"line_number":9,"context_line":"    all the features, we\u0027ll give two cycles transition period for operators."},{"line_number":10,"context_line":"    See `policy default refresh"},{"line_number":11,"context_line":"    \u003chttps://specs.openstack.org/openstack/cyborg-specs/specs/ussuri/approved/policy-defaults-refresh.html\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_32c1c2e5","line":8,"range":{"start_line":7,"start_character":3,"end_line":8,"end_character":54},"in_reply_to":"9f560f44_7de6b84c","updated":"2020-10-10 07:07:20.000000000","message":"Thanks Ghanshyam! patch 752576 merged.","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ab9742a422e49ad74c7f990075a3d92f5f0784e4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    See `policy default refresh"},{"line_number":11,"context_line":"    \u003chttps://specs.openstack.org/openstack/cyborg-specs/specs/ussuri/approved/policy-defaults-refresh.html\u003e`_"},{"line_number":12,"context_line":"features:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    * **Base policy change**"},{"line_number":15,"context_line":"      Introduced scope_type, and dded the below new scoped-based rules to"},{"line_number":16,"context_line":"      base policy and mark old ones as deprecated rules."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_59615bd3","line":13,"updated":"2020-09-17 08:03:51.000000000","message":"As talked before, here also need to describe the new policy how to enable.","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"17aff8d5b837198fc4a2dfbf6f0f8aec6aad0e83","unresolved":false,"context_lines":[{"line_number":12,"context_line":"features:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    * **Base policy change**"},{"line_number":15,"context_line":"      Introduced scope_type, and dded the below new scoped-based rules to"},{"line_number":16,"context_line":"      base policy and mark old ones as deprecated rules."},{"line_number":17,"context_line":"      project reader,"},{"line_number":18,"context_line":"      project member,"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_a7017f09","line":15,"updated":"2020-09-16 18:51:30.000000000","message":"nit: added","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"17aff8d5b837198fc4a2dfbf6f0f8aec6aad0e83","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * **Base policy change**"},{"line_number":15,"context_line":"      Introduced scope_type, and dded the below new scoped-based rules to"},{"line_number":16,"context_line":"      base policy and mark old ones as deprecated rules."},{"line_number":17,"context_line":"      project reader,"},{"line_number":18,"context_line":"      project member,"},{"line_number":19,"context_line":"      project admin,"},{"line_number":20,"context_line":"      system admin,"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_820f092e","line":17,"updated":"2020-09-16 18:51:30.000000000","message":"missing the _ char on those roles","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"17aff8d5b837198fc4a2dfbf6f0f8aec6aad0e83","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"      The belowing rules are marked as deprecated old rules in base policy."},{"line_number":26,"context_line":"      public_api,\u0027allow\u0027,\u0027deny\u0027,\u0027admin_api\u0027,\u0027is_admin\u0027,"},{"line_number":27,"context_line":"      admin_or_owner,\u0027admin_or_user\u0027."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    * **New Defaults for device_profile APIs**"},{"line_number":30,"context_line":"      Rewrite check string(authorization rules) using new personas for"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_e229a589","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":20},"updated":"2020-09-16 18:51:30.000000000","message":"\u0027admin_or_owner\u0027","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ab9742a422e49ad74c7f990075a3d92f5f0784e4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      deprecated base.deprecated_default for"},{"line_number":44,"context_line":"      - ``cyborg:device_profile:delete``"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    Updated policy documentation on cyborg-doc page"},{"line_number":47,"context_line":"deprecations:"},{"line_number":48,"context_line":"  - |"},{"line_number":49,"context_line":"    Old rules are marked as deprecated rules, but the old rules still work"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_999813cd","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":51},"updated":"2020-09-17 08:03:51.000000000","message":"It\u0027s better add a hyperlink for this","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cddc033363caddfb7f2700c191cc8332535c68cf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      deprecated base.deprecated_default for"},{"line_number":44,"context_line":"      - ``cyborg:device_profile:delete``"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    Updated policy documentation on cyborg-doc page"},{"line_number":47,"context_line":"deprecations:"},{"line_number":48,"context_line":"  - |"},{"line_number":49,"context_line":"    Old rules are marked as deprecated rules, but the old rules still work"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_f2774ad0","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":51},"in_reply_to":"9f560f44_999813cd","updated":"2020-10-10 07:07:20.000000000","message":"cyborg-doc page is doing in this https://review.opendev.org/#/c/753233/,pls help to review.","commit_id":"d824540b087083e4fcae5c488f5806a11c0805ef"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    old policy will both work because a deployment sets"},{"line_number":11,"context_line":"    ``cyborg.conf [oslo_policy] enforce_scope \u003d False`` as the default set."},{"line_number":12,"context_line":"    Although users can set ``cyborg.conf [oslo_policy] enforce_scope \u003d True``"},{"line_number":13,"context_line":"    by default in their deployment, if they want to ignore old rules and support new rules"},{"line_number":14,"context_line":"    only. After we implement all the features, we\u0027ll give two cycles"},{"line_number":15,"context_line":"    transition period for operators. For specification of new policy,"},{"line_number":16,"context_line":"    please refer to `policy default refresh`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_000eb5e2","line":13,"updated":"2020-09-25 06:11:31.000000000","message":"This line more than 79 characters.","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cddc033363caddfb7f2700c191cc8332535c68cf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    old policy will both work because a deployment sets"},{"line_number":11,"context_line":"    ``cyborg.conf [oslo_policy] enforce_scope \u003d False`` as the default set."},{"line_number":12,"context_line":"    Although users can set ``cyborg.conf [oslo_policy] enforce_scope \u003d True``"},{"line_number":13,"context_line":"    by default in their deployment, if they want to ignore old rules and support new rules"},{"line_number":14,"context_line":"    only. After we implement all the features, we\u0027ll give two cycles"},{"line_number":15,"context_line":"    transition period for operators. For specification of new policy,"},{"line_number":16,"context_line":"    please refer to `policy default refresh`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_d81c777d","line":13,"in_reply_to":"9f560f44_000eb5e2","updated":"2020-10-10 07:07:20.000000000","message":"Done","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      two types of ``sope_type`` with their combination. ``[\u0027system\u0027]``,"},{"line_number":22,"context_line":"      ``[\u0027project\u0027]`` and ``[\u0027system\u0027, \u0027project\u0027]``."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"      To know each policy scope_type, please refer the `Policy Reference`_"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"      This feature is disabled by default can be enabled via config option"},{"line_number":27,"context_line":"      ``[oslo_policy]enforce_scope`` in ``cyborg.conf``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_80f925c6","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":36},"updated":"2020-09-25 06:11:31.000000000","message":"nit: ``scope_type``","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cddc033363caddfb7f2700c191cc8332535c68cf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      two types of ``sope_type`` with their combination. ``[\u0027system\u0027]``,"},{"line_number":22,"context_line":"      ``[\u0027project\u0027]`` and ``[\u0027system\u0027, \u0027project\u0027]``."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"      To know each policy scope_type, please refer the `Policy Reference`_"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"      This feature is disabled by default can be enabled via config option"},{"line_number":27,"context_line":"      ``[oslo_policy]enforce_scope`` in ``cyborg.conf``"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_f81fbb6e","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":36},"in_reply_to":"9f560f44_80f925c6","updated":"2020-10-10 07:07:20.000000000","message":"Done","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"      Cyborg introduced seven basic roles based on the new defaults combined"},{"line_number":38,"context_line":"      with different scope_types."},{"line_number":39,"context_line":"      project_reader,"},{"line_number":40,"context_line":"      project_member,"},{"line_number":41,"context_line":"      project_admin,"},{"line_number":42,"context_line":"      system_admin,"},{"line_number":43,"context_line":"      system_reader,"},{"line_number":44,"context_line":"      system_admin_or_owner,"},{"line_number":45,"context_line":"      system_or_project_reader,"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      The belowing rules are marked as deprecated old rules in base policy."},{"line_number":48,"context_line":"      old rules:\u0027public_api\u0027,\u0027allow\u0027,\u0027deny\u0027,\u0027admin_api\u0027,\u0027is_admin\u0027,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_a0ec29f4","line":45,"range":{"start_line":39,"start_character":0,"end_line":45,"end_character":31},"updated":"2020-09-25 06:11:31.000000000","message":"IMO, we can format this by:\n      ... with different scope_types.\n      - project_reader,\n      - project_member,\n      - project_admin,\n      - system_admin,\n      - system_reader,\n      - system_admin_or_owner,\n      - system_or_project_reader,","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cddc033363caddfb7f2700c191cc8332535c68cf","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"      Cyborg introduced seven basic roles based on the new defaults combined"},{"line_number":38,"context_line":"      with different scope_types."},{"line_number":39,"context_line":"      project_reader,"},{"line_number":40,"context_line":"      project_member,"},{"line_number":41,"context_line":"      project_admin,"},{"line_number":42,"context_line":"      system_admin,"},{"line_number":43,"context_line":"      system_reader,"},{"line_number":44,"context_line":"      system_admin_or_owner,"},{"line_number":45,"context_line":"      system_or_project_reader,"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      The belowing rules are marked as deprecated old rules in base policy."},{"line_number":48,"context_line":"      old rules:\u0027public_api\u0027,\u0027allow\u0027,\u0027deny\u0027,\u0027admin_api\u0027,\u0027is_admin\u0027,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_0337a4e6","line":45,"range":{"start_line":39,"start_character":0,"end_line":45,"end_character":31},"in_reply_to":"9f560f44_a0ec29f4","updated":"2020-10-10 07:07:20.000000000","message":"Done","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      The belowing rules are marked as deprecated old rules in base policy."},{"line_number":48,"context_line":"      old rules:\u0027public_api\u0027,\u0027allow\u0027,\u0027deny\u0027,\u0027admin_api\u0027,\u0027is_admin\u0027,"},{"line_number":49,"context_line":"      -\u0027admin_or_owner\u0027,\u0027admin_or_user\u0027."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    * **New Defaults for device_profile APIs**"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_604a1127","line":49,"range":{"start_line":49,"start_character":6,"end_line":49,"end_character":7},"updated":"2020-09-25 06:11:31.000000000","message":"??","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      Add checkstr\u003dbase.PROJECT_READER_OR_SYSTEM_READER and"},{"line_number":57,"context_line":"      deprecated checkstr\u003dbase.deprecated_default for"},{"line_number":58,"context_line":"      - ``cyborg:device_profile:get_one``"},{"line_number":59,"context_line":"      - ``cyborg:device_profile:get_all``"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"      Add check_str\u003dbase.SYSTEM_ADMIN and"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_00aa3582","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":41},"updated":"2020-09-25 06:11:31.000000000","message":"You can add a blank line on it.","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"      Add check_str\u003dbase.SYSTEM_ADMIN and"},{"line_number":62,"context_line":"      deprecated check_str\u003dbase.deprecated_is_admin for"},{"line_number":63,"context_line":"      - ``cyborg:device_profile:create``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"      Add check_str\u003dbase.SYSTEM_ADMIN and"},{"line_number":66,"context_line":"      deprecated base.deprecated_default for"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_408f0d2d","line":63,"updated":"2020-09-25 06:11:31.000000000","message":"ditto","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"      Add check_str\u003dbase.SYSTEM_ADMIN and"},{"line_number":66,"context_line":"      deprecated base.deprecated_default for"},{"line_number":67,"context_line":"      - ``cyborg:device_profile:delete``"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    * **Added policy configuration guide on cyborg doc page*"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_a09a696b","line":67,"updated":"2020-09-25 06:11:31.000000000","message":"ditto.","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"      Please refer to `policy configuration guide`_"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    .. _policy-defaults-refresh: https://specs.openstack.org/openstack/cyborg-specs/specs/ussuri/approved/policy-defaults-refresh.html"},{"line_number":74,"context_line":"    .. _Policy Reference: URL depends on https://review.opendev.org/#/c/753233/"},{"line_number":75,"context_line":"    .. _policy configuration guide: ditto"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_e03621b4","line":74,"range":{"start_line":74,"start_character":41,"end_line":74,"end_character":79},"updated":"2020-09-25 06:11:31.000000000","message":"It\u0027s also belongs to the policy refresh feature, so we can wait for the docs change mereged, then look back for this patch. I mean we should use the docs page url directly.","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29a9cdf457b6a4af143488e7556fafaace6015fd","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    .. _policy-defaults-refresh: https://specs.openstack.org/openstack/cyborg-specs/specs/ussuri/approved/policy-defaults-refresh.html"},{"line_number":74,"context_line":"    .. _Policy Reference: URL depends on https://review.opendev.org/#/c/753233/"},{"line_number":75,"context_line":"    .. _policy configuration guide: ditto"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_00a4f505","line":75,"range":{"start_line":75,"start_character":36,"end_line":75,"end_character":41},"updated":"2020-09-25 06:11:31.000000000","message":"What\u0027s this? it will be an invalid hyperlinks in the releasenote page.","commit_id":"a6c5e7af023a7954d3b16f649a57f87e09df94ce"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a46df03dbbf836dc560823c5e8ab221148ce18a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      - system_admin_or_owner,"},{"line_number":45,"context_line":"      - system_or_project_reader,"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      The belowing rules are marked as deprecated old rules in base policy."},{"line_number":48,"context_line":"      - public_api,"},{"line_number":49,"context_line":"      - allow,"},{"line_number":50,"context_line":"      - deny,"},{"line_number":51,"context_line":"      - admin_api,"},{"line_number":52,"context_line":"      - is_admin,"},{"line_number":53,"context_line":"      - admin_or_owner,"},{"line_number":54,"context_line":"      - admin_or_user."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    * **New Defaults for device_profile APIs**"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_534e61c2","line":54,"range":{"start_line":47,"start_character":0,"end_line":54,"end_character":22},"updated":"2020-10-01 19:01:17.000000000","message":"these should go into the deprecation section.","commit_id":"07ebfce8d40485ff1aab86cdc090933b5d65ac6b"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"cddc033363caddfb7f2700c191cc8332535c68cf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      - system_admin_or_owner,"},{"line_number":45,"context_line":"      - system_or_project_reader,"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      The belowing rules are marked as deprecated old rules in base policy."},{"line_number":48,"context_line":"      - public_api,"},{"line_number":49,"context_line":"      - allow,"},{"line_number":50,"context_line":"      - deny,"},{"line_number":51,"context_line":"      - admin_api,"},{"line_number":52,"context_line":"      - is_admin,"},{"line_number":53,"context_line":"      - admin_or_owner,"},{"line_number":54,"context_line":"      - admin_or_user."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    * **New Defaults for device_profile APIs**"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_1ebc76b3","line":54,"range":{"start_line":47,"start_character":0,"end_line":54,"end_character":22},"in_reply_to":"9f560f44_534e61c2","updated":"2020-10-10 07:07:20.000000000","message":"Thanks for the review! Done","commit_id":"07ebfce8d40485ff1aab86cdc090933b5d65ac6b"}]}