)]}'
{"cyborg/api/controllers/v2/device_profiles.py":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"1f1911e9bc2dc96acbeb03be33036e91124c5115","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                if key.startswith(\"resources:\"):"},{"line_number":166,"context_line":"                    inner_origin_rc \u003d \":\".join(key.split(\":\")[1:])"},{"line_number":167,"context_line":"                    inner_rc \u003d inner_origin_rc.strip(\" \")"},{"line_number":168,"context_line":"                    if inner_rc not in constants.SUPPORT_RESOURCES and \\"},{"line_number":169,"context_line":"                        not inner_rc.startswith(\u0027CUSTOM_\u0027):"},{"line_number":170,"context_line":"                        raise exception.InvalidParameterValue("},{"line_number":171,"context_line":"                            err\u003d\"Unsupported resource class %s\" % inner_rc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d08c0b3b","line":168,"range":{"start_line":168,"start_character":67,"end_line":168,"end_character":70},"updated":"2020-09-18 00:56:59.000000000","message":"`or` and you should complete the unittest.","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"644dc2d9b8c493be1332d16b369f7294d3621676","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                if key.startswith(\"resources:\"):"},{"line_number":166,"context_line":"                    inner_origin_rc \u003d \":\".join(key.split(\":\")[1:])"},{"line_number":167,"context_line":"                    inner_rc \u003d inner_origin_rc.strip(\" \")"},{"line_number":168,"context_line":"                    if inner_rc not in constants.SUPPORT_RESOURCES and \\"},{"line_number":169,"context_line":"                        not inner_rc.startswith(\u0027CUSTOM_\u0027):"},{"line_number":170,"context_line":"                        raise exception.InvalidParameterValue("},{"line_number":171,"context_line":"                            err\u003d\"Unsupported resource class %s\" % inner_rc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e9732ae7","line":168,"range":{"start_line":168,"start_character":67,"end_line":168,"end_character":70},"in_reply_to":"9f560f44_d08c0b3b","updated":"2020-09-18 07:22:41.000000000","message":"sorry, mislead the logic.","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"eb7ef8e9c6e743a4193f1ac0b595b7f65e21bbc4","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                if key.startswith(\"resources:\"):"},{"line_number":166,"context_line":"                    inner_origin_rc \u003d \":\".join(key.split(\":\")[1:])"},{"line_number":167,"context_line":"                    inner_rc \u003d inner_origin_rc.strip(\" \")"},{"line_number":168,"context_line":"                    if inner_rc not in constants.SUPPORT_RESOURCES and \\"},{"line_number":169,"context_line":"                        not inner_rc.startswith(\u0027CUSTOM_\u0027):"},{"line_number":170,"context_line":"                        raise exception.InvalidParameterValue("},{"line_number":171,"context_line":"                            err\u003d\"Unsupported resource class %s\" % inner_rc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d931a1a4","line":168,"range":{"start_line":168,"start_character":67,"end_line":168,"end_character":70},"in_reply_to":"9f560f44_e9732ae7","updated":"2020-09-22 10:32:47.000000000","message":"no pl, wenping. :)","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"1f1911e9bc2dc96acbeb03be33036e91124c5115","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                        del group[key]"},{"line_number":180,"context_line":"                        standard_key \u003d \"resources:\" + inner_rc"},{"line_number":181,"context_line":"                        group[standard_key] \u003d value"},{"line_number":182,"context_line":"                # first check resource and trait format"},{"line_number":183,"context_line":"                if key \u003d\u003d \"resources:VGPU\" and int(value) \u003e 1:"},{"line_number":184,"context_line":"                    raise exception.InvalidParameterValue("},{"line_number":185,"context_line":"                        err\u003d\"Device profile does not support request more \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_70b9bfea","line":182,"range":{"start_line":182,"start_character":15,"end_line":182,"end_character":55},"updated":"2020-09-18 00:56:59.000000000","message":"what do you means of this comment?","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"eb7ef8e9c6e743a4193f1ac0b595b7f65e21bbc4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                        del group[key]"},{"line_number":180,"context_line":"                        standard_key \u003d \"resources:\" + inner_rc"},{"line_number":181,"context_line":"                        group[standard_key] \u003d value"},{"line_number":182,"context_line":"                # first check resource and trait format"},{"line_number":183,"context_line":"                if key \u003d\u003d \"resources:VGPU\" and int(value) \u003e 1:"},{"line_number":184,"context_line":"                    raise exception.InvalidParameterValue("},{"line_number":185,"context_line":"                        err\u003d\"Device profile does not support request more \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f92c654b","line":182,"range":{"start_line":182,"start_character":15,"end_line":182,"end_character":55},"in_reply_to":"9f560f44_70b9bfea","updated":"2020-09-22 10:32:47.000000000","message":"removed.","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"1f1911e9bc2dc96acbeb03be33036e91124c5115","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                        standard_key \u003d \"resources:\" + inner_rc"},{"line_number":181,"context_line":"                        group[standard_key] \u003d value"},{"line_number":182,"context_line":"                # first check resource and trait format"},{"line_number":183,"context_line":"                if key \u003d\u003d \"resources:VGPU\" and int(value) \u003e 1:"},{"line_number":184,"context_line":"                    raise exception.InvalidParameterValue("},{"line_number":185,"context_line":"                        err\u003d\"Device profile does not support request more \""},{"line_number":186,"context_line":"                            \"than one VGPU now because nvidia does not \""},{"line_number":187,"context_line":"                            \"support creating multiple mdev devices\")"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _get_device_profile_list(self, names\u003dNone, uuid\u003dNone):"},{"line_number":190,"context_line":"        \"\"\"Get a list of API objects representing device profiles.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d019ab23","line":187,"range":{"start_line":183,"start_character":0,"end_line":187,"end_character":69},"updated":"2020-09-18 00:56:59.000000000","message":"you may miss the unittest.","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"eb7ef8e9c6e743a4193f1ac0b595b7f65e21bbc4","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                        standard_key \u003d \"resources:\" + inner_rc"},{"line_number":181,"context_line":"                        group[standard_key] \u003d value"},{"line_number":182,"context_line":"                # first check resource and trait format"},{"line_number":183,"context_line":"                if key \u003d\u003d \"resources:VGPU\" and int(value) \u003e 1:"},{"line_number":184,"context_line":"                    raise exception.InvalidParameterValue("},{"line_number":185,"context_line":"                        err\u003d\"Device profile does not support request more \""},{"line_number":186,"context_line":"                            \"than one VGPU now because nvidia does not \""},{"line_number":187,"context_line":"                            \"support creating multiple mdev devices\")"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _get_device_profile_list(self, names\u003dNone, uuid\u003dNone):"},{"line_number":190,"context_line":"        \"\"\"Get a list of API objects representing device profiles.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_99fa89b7","line":187,"range":{"start_line":183,"start_character":0,"end_line":187,"end_character":69},"in_reply_to":"9f560f44_d019ab23","updated":"2020-09-22 10:32:47.000000000","message":"I will remove VGPU validation from this patch, since we don\u0027t support VGPU now. we can add this in the next release when we implement VGPU.","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"}],"cyborg/tests/unit/api/controllers/v2/test_device_profiles.py":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"1f1911e9bc2dc96acbeb03be33036e91124c5115","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # we change ths \"FPGA\" to \" FPGA \", If the assertFalse pass,"},{"line_number":141,"context_line":"        # means we strip extra space in rc is successful."},{"line_number":142,"context_line":"        self.assertFalse(out_dp[\u0027groups\u0027] \u003d\u003d dp[0][\u0027groups\u0027])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_create_with_unsupported_rc(self):"},{"line_number":145,"context_line":"        test_unsupport_dp \u003d self.fake_dps[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_900f33df","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":61},"updated":"2020-09-18 00:56:59.000000000","message":"should assert what out_dp[\u0027groups\u0027] equals.","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"eb7ef8e9c6e743a4193f1ac0b595b7f65e21bbc4","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # we change ths \"FPGA\" to \" FPGA \", If the assertFalse pass,"},{"line_number":141,"context_line":"        # means we strip extra space in rc is successful."},{"line_number":142,"context_line":"        self.assertFalse(out_dp[\u0027groups\u0027] \u003d\u003d dp[0][\u0027groups\u0027])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_create_with_unsupported_rc(self):"},{"line_number":145,"context_line":"        test_unsupport_dp \u003d self.fake_dps[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1f3bf9e9","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":61},"in_reply_to":"9f560f44_900f33df","updated":"2020-09-22 10:32:47.000000000","message":"done","commit_id":"2b92c97ca6677addc465fca83bf00e31785c5f79"}]}