)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0b970ec69b79d4cfba4cd87401d7c3e3d8debdc1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change default policy file from JSON to YAML"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As Cyborg is switching to new policy, this is required"},{"line_number":10,"context_line":"to avoid breaking the existing deoloyement using policy"},{"line_number":11,"context_line":"file in json format and relying on default value of"},{"line_number":12,"context_line":"\u0027CONF.oslo_policy.policy_file\u0027."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_b0e4f7e1","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":42},"updated":"2020-09-18 02:12:32.000000000","message":"deployment","commit_id":"d62f7046d6f45c5a45b788fc3d734c9b75401cf1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"05143b051dab3ed3e05bf517c8136b5f749c9b22","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change default policy file from JSON to YAML"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As Cyborg is switching to new policy, this is required"},{"line_number":10,"context_line":"to avoid breaking the existing deoloyement using policy"},{"line_number":11,"context_line":"file in json format and relying on default value of"},{"line_number":12,"context_line":"\u0027CONF.oslo_policy.policy_file\u0027."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_aa48fb2d","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":42},"in_reply_to":"9f560f44_b0e4f7e1","updated":"2020-09-18 14:16:57.000000000","message":"Done","commit_id":"d62f7046d6f45c5a45b788fc3d734c9b75401cf1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0b970ec69b79d4cfba4cd87401d7c3e3d8debdc1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"An upgrade checks is added to check the policy_file format and"},{"line_number":20,"context_line":"fail upgrade checks if it is JSON formatted."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Added a warning in policy doc about JSON formatted file is deprecated,"},{"line_number":23,"context_line":"also removed all the reference to policy.json file in doc as well as"},{"line_number":24,"context_line":"in tests."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_d01febb5","line":22,"updated":"2020-09-18 02:12:32.000000000","message":"++","commit_id":"d62f7046d6f45c5a45b788fc3d734c9b75401cf1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0b970ec69b79d4cfba4cd87401d7c3e3d8debdc1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"also removed all the reference to policy.json file in doc as well as"},{"line_number":24,"context_line":"in tests."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Related Blueprint: policy-json-to-yaml"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I865227e516dc7505c463ac279309169d95ea6a22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_30f10797","line":26,"range":{"start_line":26,"start_character":19,"end_line":26,"end_character":38},"updated":"2020-09-18 02:12:32.000000000","message":"It seems cannot redirect correctly, the blueprint exists in oslo.policy\u0027s project.\nhttps://blueprints.launchpad.net/oslo.policy/+spec/policy-json-to-yaml","commit_id":"d62f7046d6f45c5a45b788fc3d734c9b75401cf1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"05143b051dab3ed3e05bf517c8136b5f749c9b22","unresolved":false,"context_lines":[{"line_number":23,"context_line":"also removed all the reference to policy.json file in doc as well as"},{"line_number":24,"context_line":"in tests."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Related Blueprint: policy-json-to-yaml"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I865227e516dc7505c463ac279309169d95ea6a22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_8a437711","line":26,"range":{"start_line":26,"start_character":19,"end_line":26,"end_character":38},"in_reply_to":"9f560f44_30f10797","updated":"2020-09-18 14:16:57.000000000","message":"Done","commit_id":"d62f7046d6f45c5a45b788fc3d734c9b75401cf1"}],"cyborg/cmd/status.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # NOTE(gmann): Check if policy file exist and is in"},{"line_number":42,"context_line":"        # JSON format by actually loading the file not just"},{"line_number":43,"context_line":"        # by checking the extension."},{"line_number":44,"context_line":"        policy_path \u003d CONF.find_file(CONF.oslo_policy.policy_file)"},{"line_number":45,"context_line":"        if policy_path and fileutils.is_json(policy_path):"},{"line_number":46,"context_line":"            status \u003d upgradecheck.Result(upgradecheck.Code.FAILURE, msg)"},{"line_number":47,"context_line":"        return status"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9d358c48","line":44,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027CONF\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # NOTE(gmann): Check if policy file exist and is in"},{"line_number":42,"context_line":"        # JSON format by actually loading the file not just"},{"line_number":43,"context_line":"        # by checking the extension."},{"line_number":44,"context_line":"        policy_path \u003d CONF.find_file(CONF.oslo_policy.policy_file)"},{"line_number":45,"context_line":"        if policy_path and fileutils.is_json(policy_path):"},{"line_number":46,"context_line":"            status \u003d upgradecheck.Result(upgradecheck.Code.FAILURE, msg)"},{"line_number":47,"context_line":"        return status"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fd3be835","line":44,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027CONF\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0b970ec69b79d4cfba4cd87401d7c3e3d8debdc1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _check_policy_json(self):"},{"line_number":34,"context_line":"        \"Checks to see if policy file is JSON-formatted policy file.\""},{"line_number":35,"context_line":"        msg \u003d _(\"Your policy file  is JSON-formatted which is \""},{"line_number":36,"context_line":"                \"deprecated since Victoria release (Cyborg 5.0.0). \""},{"line_number":37,"context_line":"                \"You need to switch to YAML-formatted file. You can use the \""},{"line_number":38,"context_line":"                \"``oslopolicy-convert-json-to-yaml`` tool to convert existing \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_705fff74","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":35},"updated":"2020-09-18 02:12:32.000000000","message":"nit: redundant a white space.","commit_id":"d62f7046d6f45c5a45b788fc3d734c9b75401cf1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"05143b051dab3ed3e05bf517c8136b5f749c9b22","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _check_policy_json(self):"},{"line_number":34,"context_line":"        \"Checks to see if policy file is JSON-formatted policy file.\""},{"line_number":35,"context_line":"        msg \u003d _(\"Your policy file  is JSON-formatted which is \""},{"line_number":36,"context_line":"                \"deprecated since Victoria release (Cyborg 5.0.0). \""},{"line_number":37,"context_line":"                \"You need to switch to YAML-formatted file. You can use the \""},{"line_number":38,"context_line":"                \"``oslopolicy-convert-json-to-yaml`` tool to convert existing \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ea52f3dd","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":35},"in_reply_to":"9f560f44_705fff74","updated":"2020-09-18 14:16:57.000000000","message":"Done","commit_id":"d62f7046d6f45c5a45b788fc3d734c9b75401cf1"}],"cyborg/tests/unit/cmd/test_status.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_serialization import jsonutils"},{"line_number":21,"context_line":"from oslo_upgradecheck.upgradecheck import Code"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from cyborg.cmd import status"},{"line_number":24,"context_line":"from cyborg.tests import base"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_dd36e44f","line":21,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F401 \u0027oslo_upgradecheck.upgradecheck.Code\u0027 imported but unused","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(TestUpgradeCheckPolicyJSON, self).setUp()"},{"line_number":31,"context_line":"        self.cmd \u003d status.UpgradeCommands()"},{"line_number":32,"context_line":"        policy.CONF.clear_override(\u0027policy_file\u0027, group\u003d\u0027oslo_policy\u0027)"},{"line_number":33,"context_line":"        self.data \u003d {"},{"line_number":34,"context_line":"            \u0027rule_admin\u0027: \u0027True\u0027,"},{"line_number":35,"context_line":"            \u0027rule_admin2\u0027: \u0027is_admin:True\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3d4600c2","line":32,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027policy\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            \u0027rule_admin\u0027: \u0027True\u0027,"},{"line_number":35,"context_line":"            \u0027rule_admin2\u0027: \u0027is_admin:True\u0027"},{"line_number":36,"context_line":"        }"},{"line_number":37,"context_line":"        self.temp_dir \u003d self.useFixture(fixtures.TempDir())"},{"line_number":38,"context_line":"        fd, self.json_file \u003d tempfile.mkstemp(dir\u003dself.temp_dir.path)"},{"line_number":39,"context_line":"        fd, self.yaml_file \u003d tempfile.mkstemp(dir\u003dself.temp_dir.path)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1d417ca7","line":37,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027fixtures\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def test_policy_json_file_fail_upgrade(self):"},{"line_number":55,"context_line":"        # Test with policy json file full path set in config."},{"line_number":56,"context_line":"        self.flags(policy_file\u003dself.json_file, group\u003d\"oslo_policy\")"},{"line_number":57,"context_line":"        self.assertEqual(upgradecheck.Code.FAILURE,"},{"line_number":58,"context_line":"                         self.cmd._check_policy_json().code)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_policy_yaml_file_pass_upgrade(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7d1198af","line":57,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027upgradecheck\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def test_policy_yaml_file_pass_upgrade(self):"},{"line_number":61,"context_line":"        # Test with full policy yaml file path set in config."},{"line_number":62,"context_line":"        self.flags(policy_file\u003dself.yaml_file, group\u003d\"oslo_policy\")"},{"line_number":63,"context_line":"        self.assertEqual(upgradecheck.Code.SUCCESS,"},{"line_number":64,"context_line":"                         self.cmd._check_policy_json().code)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_no_policy_file_pass_upgrade(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5d14949f","line":63,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027upgradecheck\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_no_policy_file_pass_upgrade(self):"},{"line_number":67,"context_line":"        # Test with no policy file exist."},{"line_number":68,"context_line":"        self.assertEqual(upgradecheck.Code.SUCCESS,"},{"line_number":69,"context_line":"                         self.cmd._check_policy_json().code)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_default_policy_yaml_file_pass_upgrade(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bd0b307b","line":68,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027upgradecheck\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        tmpfilename \u003d os.path.join(self.temp_dir.path, \u0027policy.yaml\u0027)"},{"line_number":73,"context_line":"        with open(tmpfilename, \u0027w\u0027) as fh:"},{"line_number":74,"context_line":"            yaml.dump(self.data, fh)"},{"line_number":75,"context_line":"        self.assertEqual(upgradecheck.Code.SUCCESS,"},{"line_number":76,"context_line":"                         self.cmd._check_policy_json().code)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_old_default_policy_json_file_fail_upgrade(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9d0e2c8a","line":75,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027upgradecheck\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f079089ebf759b1fabd4aadc1f700e37d39b9b84","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        tmpfilename \u003d os.path.join(self.temp_dir.path, \u0027policy.json\u0027)"},{"line_number":81,"context_line":"        with open(tmpfilename, \u0027w\u0027) as fh:"},{"line_number":82,"context_line":"            jsonutils.dump(self.data, fh)"},{"line_number":83,"context_line":"        self.assertEqual(upgradecheck.Code.FAILURE,"},{"line_number":84,"context_line":"                         self.cmd._check_policy_json().code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fd248810","line":83,"updated":"2020-09-17 23:03:33.000000000","message":"pep8: F821 undefined name \u0027upgradecheck\u0027","commit_id":"a30bfe10f043762f111f411d2895ee568a5c504e"}]}