)]}'
{"cyborg/api/controllers/v2/arqs.py":[{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"26b263210758de305cd1ecb92f7c137755aee0c4","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        devprof \u003d None"},{"line_number":123,"context_line":"        dp_name \u003d req.get(\u0027device_profile_name\u0027)"},{"line_number":124,"context_line":"        if dp_name is not None:"},{"line_number":125,"context_line":"            try:"},{"line_number":126,"context_line":"                devprof \u003d objects.DeviceProfile.get_by_name(context, dp_name)"},{"line_number":127,"context_line":"            except Exception:"},{"line_number":128,"context_line":"                raise exception.ResourceNotFound("},{"line_number":129,"context_line":"                    resource\u003d\u0027Device Profile\u0027,"},{"line_number":130,"context_line":"                    msg\u003d\u0027with name\u003d%s\u0027 % dp_name)"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            raise exception.DeviceProfileNameNeeded()"},{"line_number":133,"context_line":"        LOG.info(\u0027[arqs] post. device profile name\u003d%s\u0027, dp_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_21a2ff3f","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":49},"updated":"2020-10-10 10:53:47.000000000","message":"Good Start. I think this catch should be more specific.","commit_id":"dd7f41b1307dd6281f904cf0a897dc6f000a6b37"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"7bad3991a46cdb1a176bbcbbd89951e32b0e749b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        devprof \u003d None"},{"line_number":123,"context_line":"        dp_name \u003d req.get(\u0027device_profile_name\u0027)"},{"line_number":124,"context_line":"        if dp_name is not None:"},{"line_number":125,"context_line":"            try:"},{"line_number":126,"context_line":"                devprof \u003d objects.DeviceProfile.get_by_name(context, dp_name)"},{"line_number":127,"context_line":"            except Exception:"},{"line_number":128,"context_line":"                raise exception.ResourceNotFound("},{"line_number":129,"context_line":"                    resource\u003d\u0027Device Profile\u0027,"},{"line_number":130,"context_line":"                    msg\u003d\u0027with name\u003d%s\u0027 % dp_name)"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            raise exception.DeviceProfileNameNeeded()"},{"line_number":133,"context_line":"        LOG.info(\u0027[arqs] post. device profile name\u003d%s\u0027, dp_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_03fedb04","line":130,"range":{"start_line":125,"start_character":0,"end_line":130,"end_character":49},"in_reply_to":"9f560f44_21a2ff3f","updated":"2020-10-12 00:41:00.000000000","message":"yeah, specified as ResourceNotFound exception, and please see the unit test.","commit_id":"dd7f41b1307dd6281f904cf0a897dc6f000a6b37"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"98fb81894240c0eaafc41aa2f3211c4bb8f70577","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        if dp_name is not None:"},{"line_number":125,"context_line":"            try:"},{"line_number":126,"context_line":"                devprof \u003d objects.DeviceProfile.get_by_name(context, dp_name)"},{"line_number":127,"context_line":"            except (exception.ResourceNotFound, Exception) as e:"},{"line_number":128,"context_line":"                raise e"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            raise exception.DeviceProfileNameNeeded()"},{"line_number":131,"context_line":"        LOG.info(\u0027[arqs] post. device profile name\u003d%s\u0027, dp_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_6fd979f2","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":23},"updated":"2020-10-12 03:10:33.000000000","message":"It is better to print an exception msg as before.","commit_id":"29f841d094e3437770691c564e7b316b023d4d53"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a56496bcc77e6c0fa68f0322ebb90da91ded26c2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        if dp_name is not None:"},{"line_number":125,"context_line":"            try:"},{"line_number":126,"context_line":"                devprof \u003d objects.DeviceProfile.get_by_name(context, dp_name)"},{"line_number":127,"context_line":"            except (exception.ResourceNotFound, Exception) as e:"},{"line_number":128,"context_line":"                raise e"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            raise exception.DeviceProfileNameNeeded()"},{"line_number":131,"context_line":"        LOG.info(\u0027[arqs] post. device profile name\u003d%s\u0027, dp_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_78dbfd7b","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":23},"in_reply_to":"9f560f44_6fd979f2","updated":"2020-10-12 06:52:23.000000000","message":"thanks xinran. done","commit_id":"29f841d094e3437770691c564e7b316b023d4d53"}]}