)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"33b91f19a7589262f137a7890a69288bd0dc87bf","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Installation document improvement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) v2 api is used since v1 is deprecated and removed"},{"line_number":10,"context_line":"2) host_ip configures the ip address on which cyborg-api listens, and"},{"line_number":11,"context_line":"its default value(localhost) does not work in real cases"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4776147cdb6274fe269e1f1017ff9aad47bd63cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7275a3f3_1dfeb882","line":11,"range":{"start_line":10,"start_character":66,"end_line":11,"end_character":56},"updated":"2021-01-07 03:10:52.000000000","message":"Shiyan, I was wondering what\u0027s your case? Because in my case, the default value works well.","commit_id":"7c972f6b88a476b737c2f91cdeac229a67cef160"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"b088f82331edd57cfec8263b7eb4fae19978977f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Installation document improvement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) v2 api is used since v1 is deprecated and removed"},{"line_number":10,"context_line":"2) host_ip configures the ip address on which cyborg-api listens, and"},{"line_number":11,"context_line":"its default value(localhost) does not work in real cases"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4776147cdb6274fe269e1f1017ff9aad47bd63cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fafe5ea6_9dcb8642","line":11,"range":{"start_line":10,"start_character":66,"end_line":11,"end_character":56},"in_reply_to":"7275a3f3_1dfeb882","updated":"2021-01-07 03:14:22.000000000","message":"here is a discussion baout your patch in weekly meeting, http://eavesdrop.openstack.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-01-07-02.09.log.html#l-52","commit_id":"7c972f6b88a476b737c2f91cdeac229a67cef160"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"7f9675c19fed4d76a87dbb169f6eb7fc09013b5c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Installation document improvement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) v2 api is used since v1 is deprecated and removed"},{"line_number":10,"context_line":"2) host_ip configures the ip address on which cyborg-api listens, and"},{"line_number":11,"context_line":"its default value(localhost) does not work in real cases"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4776147cdb6274fe269e1f1017ff9aad47bd63cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e8033701_787afbea","line":11,"range":{"start_line":10,"start_character":66,"end_line":11,"end_character":56},"in_reply_to":"fafe5ea6_9dcb8642","updated":"2021-01-07 06:11:13.000000000","message":"Thanks for the discussion. For example in the setup cyborg-api and client are not from the same host which is quite common in the production, the cyborg-api with the default localhost setting will not serve the request because the requests are not from the localhost.","commit_id":"7c972f6b88a476b737c2f91cdeac229a67cef160"}],"doc/source/install/common.rst":[{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"6d9b04b87d62c1c5b1e8a2339a77e2ade1062060","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        ..."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        [api]"},{"line_number":124,"context_line":"        host_ip \u003d 0.0.0.0"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        ..."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f45d49ca_b7157b4c","line":124,"range":{"start_line":124,"start_character":7,"end_line":124,"end_character":25},"updated":"2020-12-24 08:56:25.000000000","message":"I would not support changing host_ip to 0.0.0.0 in the installation guide.\nbecause binding to 0.0.0.0 has the potential to introduce security issue[0]. That\u0027s why we modified this to localhost in [1].\n\nSo from the project\u0027s perspective, I would not recommend you to use 0.0.0.0 in installation, but if you are aware of this risk and feel confident about this, then follow your heart. 😉\n\n\n[0]https://bandit.readthedocs.io/en/latest/plugins/b104_hardcoded_bind_all_interfaces.html\n[1]https://review.opendev.org/c/openstack/cyborg/+/720149","commit_id":"b653ed4bb81bc9198997a3c6b7e9453a5865f23b"},{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"27c71cd05b8603b6b102f9eada0fe31d4081cae2","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        ..."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        [api]"},{"line_number":124,"context_line":"        host_ip \u003d 0.0.0.0"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        ..."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"8c97879d_b2682613","line":124,"range":{"start_line":124,"start_character":7,"end_line":124,"end_character":25},"in_reply_to":"765088fb_543f205a","updated":"2020-12-25 02:34:02.000000000","message":"ok. Your suggestion looks good to me. It\u0027s good for all possible users(both trail/PoC and production) to remind them all the relavant parameters.\nSo please make sure if 0.0.0.0 is mentioned in the doc, we should mention the rish and our recommendation as well.","commit_id":"b653ed4bb81bc9198997a3c6b7e9453a5865f23b"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"33190953f25d33c37560571ac0d476f5fa201d55","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        ..."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        [api]"},{"line_number":124,"context_line":"        host_ip \u003d 0.0.0.0"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        ..."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"765088fb_543f205a","line":124,"range":{"start_line":124,"start_character":7,"end_line":124,"end_character":25},"in_reply_to":"f45d49ca_b7157b4c","updated":"2020-12-24 23:09:36.000000000","message":"Thanks, yeah I agree it\u0027s rational to keep localhost as the default value here. \n\nAt the same time I think maybe it\u0027s better to still mention this config or maybe in other way? As from ops point of view, when we set up trail/PoC in the cloud environment, it would be convenient that installation doc will remind us all the relavant parameters.","commit_id":"b653ed4bb81bc9198997a3c6b7e9453a5865f23b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"80c2ae2bd69aa823393539210d27a893c7f6c064","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        ..."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        [api]"},{"line_number":124,"context_line":"        host_ip \u003d %BIND_IP%"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        ..."}],"source_content_type":"text/x-rst","patch_set":3,"id":"59339d74_c07adcdb","line":123,"updated":"2020-12-28 08:43:06.000000000","message":"I am not sure this is need to add a [api] section, how does it configured in [DEFAULT] section?","commit_id":"7c972f6b88a476b737c2f91cdeac229a67cef160"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"417d480a62e415f03df2b3ecfe8a41458452d8a1","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        ..."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        [api]"},{"line_number":124,"context_line":"        host_ip \u003d %BIND_IP%"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        ..."}],"source_content_type":"text/x-rst","patch_set":3,"id":"2773246f_18e952eb","line":123,"in_reply_to":"59339d74_c07adcdb","updated":"2021-01-04 02:59:31.000000000","message":"I think it should be in [api] section, see this doc: https://docs.openstack.org/cyborg/latest/configuration/sample-config.html","commit_id":"7c972f6b88a476b737c2f91cdeac229a67cef160"}],"doc/source/install/install-from-source.rst":[{"author":{"_account_id":24872,"name":"YumengBao","email":"yumeng_bao@yahoo.com","username":"Yumeng_Bao"},"change_message_id":"ed708dd091d0050e029966ff5bf5eedf9288e5c6","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    .. code-block:: console"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        cp ~/cyborg/cyborg/etc/cyborg/api-paste.ini /etc/cyborg"},{"line_number":51,"context_line":"    .."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"#.  Install Cyborg packages."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b13bb075_cd95d278","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":63},"updated":"2020-12-17 02:40:45.000000000","message":"Is this cp operation already done in line 41 ?","commit_id":"79273448e224d61ad3698cdac1a35bf010757488"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"7256470b2bf8c2c070c11d05a69ea0cbb0f04ce0","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    .. code-block:: console"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        cp ~/cyborg/cyborg/etc/cyborg/api-paste.ini /etc/cyborg"},{"line_number":51,"context_line":"    .."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"#.  Install Cyborg packages."}],"source_content_type":"text/x-rst","patch_set":1,"id":"72d8c1eb_bef5d883","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":63},"in_reply_to":"b13bb075_cd95d278","updated":"2020-12-18 00:00:51.000000000","message":"oh you\u0027re right, didn\u0027t notice that, will fix it.","commit_id":"79273448e224d61ad3698cdac1a35bf010757488"}]}