)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"26a16d0b734f853bd2e7a6bb503821370cfa6d6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aa0586ee_96a1dc3a","updated":"2023-03-11 02:28:49.000000000","message":"LGTM","commit_id":"4b34d897d206f30a5a0ac9a963b119242ded6488"}],"cyborg/accelerator/drivers/gpu/utils.py":[{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"060d3a894b376640e2c35d67b3fa3065581b48bc","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@cyborg.privsep.sys_admin_pctxt.entrypoint"},{"line_number":46,"context_line":"def create_mdev(pci_addr, mdev_type, ah_uuid):"},{"line_number":47,"context_line":"    \"\"\"Instantiate a mediated device.\"\"\""},{"line_number":48,"context_line":"    if ah_uuid is None:"},{"line_number":49,"context_line":"        raise exception.AttachHandleUUIDNeeded()"}],"source_content_type":"text/x-python","patch_set":2,"id":"02e1aaa5_ca69e3af","line":46,"range":{"start_line":46,"start_character":9,"end_line":46,"end_character":15},"updated":"2021-02-02 05:53:19.000000000","message":"better to have create_mdev_priviliged here, to align the name with remove opareation","commit_id":"21d38ce3269c4751efa581beac5d1c2218716382"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e8f1c694076b619f15a930805107d8707ec1e102","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@cyborg.privsep.sys_admin_pctxt.entrypoint"},{"line_number":46,"context_line":"def create_mdev(pci_addr, mdev_type, ah_uuid):"},{"line_number":47,"context_line":"    \"\"\"Instantiate a mediated device.\"\"\""},{"line_number":48,"context_line":"    if ah_uuid is None:"},{"line_number":49,"context_line":"        raise exception.AttachHandleUUIDNeeded()"}],"source_content_type":"text/x-python","patch_set":2,"id":"982c9d65_930ebb86","line":46,"range":{"start_line":46,"start_character":9,"end_line":46,"end_character":15},"in_reply_to":"02e1aaa5_ca69e3af","updated":"2021-02-24 07:27:54.000000000","message":"Done","commit_id":"21d38ce3269c4751efa581beac5d1c2218716382"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"060d3a894b376640e2c35d67b3fa3065581b48bc","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        raise exception.AttachHandleUUIDNeeded()"},{"line_number":50,"context_line":"    fpath \u003d \u0027/sys/class/mdev_bus/{0}/mdev_supported_types/{1}/create\u0027"},{"line_number":51,"context_line":"    fpath \u003d fpath.format(pci_addr, mdev_type)"},{"line_number":52,"context_line":"    with open(fpath, \u0027w\u0027) as f:"},{"line_number":53,"context_line":"        f.write(ah_uuid)"},{"line_number":54,"context_line":"    return ah_uuid"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"@cyborg.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":2,"id":"c9b4ef5c_c5831b15","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":18},"updated":"2021-02-02 05:53:19.000000000","message":"do we need a try-except here for opening a file?","commit_id":"21d38ce3269c4751efa581beac5d1c2218716382"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e8f1c694076b619f15a930805107d8707ec1e102","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        raise exception.AttachHandleUUIDNeeded()"},{"line_number":50,"context_line":"    fpath \u003d \u0027/sys/class/mdev_bus/{0}/mdev_supported_types/{1}/create\u0027"},{"line_number":51,"context_line":"    fpath \u003d fpath.format(pci_addr, mdev_type)"},{"line_number":52,"context_line":"    with open(fpath, \u0027w\u0027) as f:"},{"line_number":53,"context_line":"        f.write(ah_uuid)"},{"line_number":54,"context_line":"    return ah_uuid"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"@cyborg.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":2,"id":"f8a43277_6089bc59","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":18},"in_reply_to":"c9b4ef5c_c5831b15","updated":"2021-02-24 07:27:54.000000000","message":"\u0027with open\u0027 can raise IO exception itself, we have catched the execption when called, so we neednot a try-except here.","commit_id":"21d38ce3269c4751efa581beac5d1c2218716382"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"060d3a894b376640e2c35d67b3fa3065581b48bc","unresolved":true,"context_lines":[{"line_number":58,"context_line":"def remove_mdev_privileged(physical_device, mdev_type, medv_uuid):"},{"line_number":59,"context_line":"    fpath \u003d (\u0027/sys/class/mdev_bus/{0}/mdev_supported_types/\u0027"},{"line_number":60,"context_line":"             \u0027{1}/devices/{2}/remove\u0027)"},{"line_number":61,"context_line":"    fpath \u003d fpath.format(physical_device, mdev_type, medv_uuid)"},{"line_number":62,"context_line":"    with open(fpath, \u0027w\u0027) as f:"},{"line_number":63,"context_line":"        f.write(\"1\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def get_pci_devices(pci_flags, vendor_id\u003dNone):"},{"line_number":67,"context_line":"    device_for_vendor_out \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"25bdde9b_8f1232c2","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":0},"updated":"2021-02-02 05:53:19.000000000","message":"ditto","commit_id":"21d38ce3269c4751efa581beac5d1c2218716382"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e8f1c694076b619f15a930805107d8707ec1e102","unresolved":true,"context_lines":[{"line_number":58,"context_line":"def remove_mdev_privileged(physical_device, mdev_type, medv_uuid):"},{"line_number":59,"context_line":"    fpath \u003d (\u0027/sys/class/mdev_bus/{0}/mdev_supported_types/\u0027"},{"line_number":60,"context_line":"             \u0027{1}/devices/{2}/remove\u0027)"},{"line_number":61,"context_line":"    fpath \u003d fpath.format(physical_device, mdev_type, medv_uuid)"},{"line_number":62,"context_line":"    with open(fpath, \u0027w\u0027) as f:"},{"line_number":63,"context_line":"        f.write(\"1\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def get_pci_devices(pci_flags, vendor_id\u003dNone):"},{"line_number":67,"context_line":"    device_for_vendor_out \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"0d899935_26891311","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":0},"in_reply_to":"25bdde9b_8f1232c2","updated":"2021-02-24 07:27:54.000000000","message":"ditto","commit_id":"21d38ce3269c4751efa581beac5d1c2218716382"}],"cyborg/objects/arq.py":[{"author":{"_account_id":33003,"name":"Shuai Qian","email":"qianshuai01@inspur.com","username":"qianshuai01"},"change_message_id":"949fa137e3c88e2fcfb4e897087144e27f4460b2","unresolved":true,"context_lines":[{"line_number":29,"context_line":"class ARQ(base.CyborgObject, object_base.VersionedObjectDictCompat):"},{"line_number":30,"context_line":"    # Version 1.0: Initial version"},{"line_number":31,"context_line":"    # 1.1: v2 API and Nova integration"},{"line_number":32,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    dbapi \u003d dbapi.get_instance()"},{"line_number":35,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ca7bc6c_49ea601a","line":32,"range":{"start_line":32,"start_character":3,"end_line":32,"end_character":19},"updated":"2021-10-28 08:47:37.000000000","message":"maybe we should update this to \u00271.2\u0027,and so does extarq.","commit_id":"d78936d576aca7acb2a5792cd503c4f42190f454"}],"cyborg/objects/ext_arq.py":[{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"060d3a894b376640e2c35d67b3fa3065581b48bc","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                attach_info[\u0027device\u0027], attach_info[\u0027function\u0027])"},{"line_number":210,"context_line":"            hostname \u003d self.arq.hostname"},{"line_number":211,"context_line":"            asked_type \u003d attach_info[\u0027asked_type\u0027]"},{"line_number":212,"context_line":"            agent \u003d AgentAPI()"},{"line_number":213,"context_line":"            agent.create_mdev("},{"line_number":214,"context_line":"                context, hostname, pci_addr, asked_type, ah.uuid)"},{"line_number":215,"context_line":"        LOG.info(\u0027Attach handle(%s) for ARQ(%s) successfully.\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5af0603f_be397191","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":30},"updated":"2021-02-02 05:53:19.000000000","message":"can we mova this to the outside of the method, to make it a attribute of this class?","commit_id":"21d38ce3269c4751efa581beac5d1c2218716382"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e8f1c694076b619f15a930805107d8707ec1e102","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                attach_info[\u0027device\u0027], attach_info[\u0027function\u0027])"},{"line_number":210,"context_line":"            hostname \u003d self.arq.hostname"},{"line_number":211,"context_line":"            asked_type \u003d attach_info[\u0027asked_type\u0027]"},{"line_number":212,"context_line":"            agent \u003d AgentAPI()"},{"line_number":213,"context_line":"            agent.create_mdev("},{"line_number":214,"context_line":"                context, hostname, pci_addr, asked_type, ah.uuid)"},{"line_number":215,"context_line":"        LOG.info(\u0027Attach handle(%s) for ARQ(%s) successfully.\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b6f5f35f_1dc632e7","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":30},"in_reply_to":"5af0603f_be397191","updated":"2021-02-24 07:27:54.000000000","message":"Done","commit_id":"21d38ce3269c4751efa581beac5d1c2218716382"}]}