)]}'
{"cyborg/accelerator/drivers/fpga/intel/sysinfo.py":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"2f26e8fee23e8abf8a06c2c634b408bb3184f1c5","unresolved":true,"context_lines":[{"line_number":331,"context_line":"        for vf in fpga[\"regions\"]:"},{"line_number":332,"context_line":"            for k, values in vf.items():"},{"line_number":333,"context_line":"                if k \u003d\u003d \"traits\":"},{"line_number":334,"context_line":"                    for index, val in enumerate(values):"},{"line_number":335,"context_line":"                        driver_attr \u003d driver_attribute.DriverAttribute("},{"line_number":336,"context_line":"                            key\u003d\"trait\" + str(index), value\u003dval)"},{"line_number":337,"context_line":"                        attr_list.append(driver_attr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8364f43_b98bdba1","line":334,"range":{"start_line":334,"start_character":24,"end_line":334,"end_character":29},"updated":"2021-03-03 00:55:31.000000000","message":"the index is defined above and modified, i think we cannot start it from zero.","commit_id":"7b866bb6ba090a19e30919d7b1a3adec42830cc7"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e3fb9007f2d01d16e065c7ba0e5ff66684f64141","unresolved":true,"context_lines":[{"line_number":332,"context_line":"                if k \u003d\u003d \"traits\":"},{"line_number":333,"context_line":"                    for index_vf, val in enumerate(values):"},{"line_number":334,"context_line":"                        driver_attr \u003d driver_attribute.DriverAttribute("},{"line_number":335,"context_line":"                            key\u003d\"trait\" + str(index_vf + index_pf), value\u003dval)"},{"line_number":336,"context_line":"                        attr_list.append(driver_attr)"},{"line_number":337,"context_line":"    return attr_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"848e47d7_9662ce01","line":335,"range":{"start_line":335,"start_character":57,"end_line":335,"end_character":65},"updated":"2021-03-05 00:40:40.000000000","message":"so what if the index_pf is undefined? does the traits key always in fpga? IMO, let this part as before is better.","commit_id":"15b1d6287467f0d6b96269bbb05741f10ad050bf"},{"author":{"_account_id":25738,"name":"Xinran WANG","email":"xin-ran.wang@intel.com","username":"Xinran"},"change_message_id":"e9c1f2b7fae9234f52538b1c7b6f3e6f7939254f","unresolved":true,"context_lines":[{"line_number":332,"context_line":"                if k \u003d\u003d \"traits\":"},{"line_number":333,"context_line":"                    for index_vf, val in enumerate(values):"},{"line_number":334,"context_line":"                        driver_attr \u003d driver_attribute.DriverAttribute("},{"line_number":335,"context_line":"                            key\u003d\"trait\" + str(index_vf + index_pf), value\u003dval)"},{"line_number":336,"context_line":"                        attr_list.append(driver_attr)"},{"line_number":337,"context_line":"    return attr_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"3db78540_eda014b1","line":335,"range":{"start_line":335,"start_character":57,"end_line":335,"end_character":65},"in_reply_to":"848e47d7_9662ce01","updated":"2021-03-05 06:45:25.000000000","message":"the trait is always in fpga.","commit_id":"15b1d6287467f0d6b96269bbb05741f10ad050bf"}],"cyborg/accelerator/drivers/qat/intel/sysinfo.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"91eb8e9558d89760928b59023a18288d31515dcd","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def _generate_attribute_list(qat):"},{"line_number":197,"context_line":"    attr_list \u003d []"},{"line_number":198,"context_line":"    for k, v in qat.items():"},{"line_number":199,"context_line":"        if k \u003d\u003d \"rc\":"},{"line_number":200,"context_line":"            driver_attr \u003d driver_attribute.DriverAttribute()"},{"line_number":201,"context_line":"            driver_attr.key \u003d k"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b20a76f_26ede0f5","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":12},"updated":"2021-03-04 05:46:05.000000000","message":"nit: In order to keep a good code habit, I would like to use \u0027key, value\u0027 instead of using \u0027k,v\u0027.","commit_id":"152b63e8d628c2fc734a22daff96c9e6bb8a2b24"}]}