)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"abff93fda676ab53782a5b7de99e8d923a958e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ae5fdc4_5a40541d","updated":"2022-01-19 09:27:26.000000000","message":"It\u0027s also need to add a releasenote to describe these changes.","commit_id":"d2265f651bde8658824cbe3ffc83c98beaa354b4"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"2cecc3995c1659a0000f7c39573ce49c71c4ef13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e7823581_94fc722b","updated":"2022-01-22 07:57:54.000000000","message":"Should add ut.","commit_id":"d2265f651bde8658824cbe3ffc83c98beaa354b4"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"d66c486d0bc628d36fa1d621dc6b2ab033c95077","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b70a9563_1667cf24","updated":"2022-01-19 09:25:32.000000000","message":"on question inline, and this feature lack of unit tests for each changes.","commit_id":"d2265f651bde8658824cbe3ffc83c98beaa354b4"},{"author":{"_account_id":33003,"name":"Shuai Qian","email":"qianshuai01@inspur.com","username":"qianshuai01"},"change_message_id":"88b38eb2b8fda68ca591b0b1a2adbb21c6b4009e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f008daf_3dacff80","updated":"2021-10-29 08:29:47.000000000","message":"recheck","commit_id":"d2265f651bde8658824cbe3ffc83c98beaa354b4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b91144324dcefb24c9498dd6057822e0917e1018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2887323a_83c11112","updated":"2025-12-02 14:34:28.000000000","message":"note, mdevs persistence cpould be ensured by Nova now.\nThis is also discussed in the re-spec https://review.opendev.org/c/openstack/nova-specs/+/967515","commit_id":"7816bfad8fcbfc6bb18f8e8b013cfc34e8738a20"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ec8d8691554d03c9fa49b9cb60c32517b6ce005e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4406e3ce_575ebc3f","updated":"2025-12-08 19:35:23.000000000","message":"yes if we are to do this going forward it likely shoudl be delegated to nova or doen out fo tree with something like mdevctl or mig-parted rather then doing it when the agent start.\n\ni don\u0027t really like the idea of sending an external event to nova or having it rebind the arq on host/vm rebooots so this is not really the best long term solution for this.","commit_id":"7816bfad8fcbfc6bb18f8e8b013cfc34e8738a20"}],"cyborg/agent/manager.py":[{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"2cecc3995c1659a0000f7c39573ce49c71c4ef13","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        if gpu_drivers_with_mdev \u003c\u003d {d.VENDOR for d in self._rt.acc_drivers}:"},{"line_number":102,"context_line":"            self._check_mdev(context)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _check_mdev(self, context):"},{"line_number":105,"context_line":"        extarq_list \u003d [extarq for extarq in ExtARQ.list(context)"},{"line_number":106,"context_line":"                       if extarq.arq.hostname \u003d\u003d CONF.host]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"337bdd8c_18d53feb","line":104,"updated":"2022-01-22 07:57:54.000000000","message":"There is \"create\" op in the method, should change the method name to \"_check_and_create_mdev\".","commit_id":"d2265f651bde8658824cbe3ffc83c98beaa354b4"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"2cecc3995c1659a0000f7c39573ce49c71c4ef13","unresolved":true,"context_lines":[{"line_number":138,"context_line":"                    self.create_vgpu_mdev(pci_addr, vgpu_type, ah_uuid)"},{"line_number":139,"context_line":"                except exception as e:"},{"line_number":140,"context_line":"                    LOG.error(\u0027recreate mdev %s (vgpu_type: %s) failed. %s\u0027,"},{"line_number":141,"context_line":"                              ah_uuid, vgpu_type, e)"},{"line_number":142,"context_line":"                    recreate_status \u003d \u0027failed\u0027"},{"line_number":143,"context_line":"                else:"},{"line_number":144,"context_line":"                    LOG.info(\u0027recreate mdev %s successfully.\u0027, ah_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5413cd39_4e782df6","line":141,"updated":"2022-01-22 07:57:54.000000000","message":"It is better that using \"Failed to create mdev %s (vgpu_type: %s) after restarting node.\"","commit_id":"d2265f651bde8658824cbe3ffc83c98beaa354b4"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"2cecc3995c1659a0000f7c39573ce49c71c4ef13","unresolved":true,"context_lines":[{"line_number":141,"context_line":"                              ah_uuid, vgpu_type, e)"},{"line_number":142,"context_line":"                    recreate_status \u003d \u0027failed\u0027"},{"line_number":143,"context_line":"                else:"},{"line_number":144,"context_line":"                    LOG.info(\u0027recreate mdev %s successfully.\u0027, ah_uuid)"},{"line_number":145,"context_line":"                    recreate_status \u003d \u0027completed\u0027"},{"line_number":146,"context_line":"                finally:"},{"line_number":147,"context_line":"                    mdev_recreated_statuses.append((ah_uuid, recreate_status))"}],"source_content_type":"text/x-python","patch_set":2,"id":"d4bd4cc6_3d7e2e4f","line":144,"updated":"2022-01-22 07:57:54.000000000","message":"Refer to the above.","commit_id":"d2265f651bde8658824cbe3ffc83c98beaa354b4"}],"cyborg/common/nova_client.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"d66c486d0bc628d36fa1d621dc6b2ab033c95077","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        events \u003d self._get_acc_changed_events(instance_uuid, arq_bind_statuses)"},{"line_number":99,"context_line":"        self._send_events(events)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def notify_recreating(self, instance_uuid, mdev_recreate_statuses):"},{"line_number":102,"context_line":"        \"\"\"Notify Nova that MDEV recreating are resolved for a given instance."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        :param instance_uuid: UUID of the instance whose MDEVs are resolved"}],"source_content_type":"text/x-python","patch_set":2,"id":"0db551c3_65ac1248","line":101,"updated":"2022-01-19 09:25:32.000000000","message":"If Nova accept this which operation it will done?","commit_id":"d2265f651bde8658824cbe3ffc83c98beaa354b4"}]}