)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"79d011a959552dce036f9b9ea8118d03b6e70444","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be172a0f_59e547eb","updated":"2026-02-02 05:42:39.000000000","message":"@smooney@redhat.com Do we need a release note for the eventlet removal? I am not sure about the releasenote as cyborg never used eventlet.\n\nOverall It looks good.","commit_id":"e9595d31c1ca6581585365066a37f9ca88aa21f0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"407160a99ac20be5531d4cd4996622974f55ec7c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6378f50f_065605fd","in_reply_to":"be172a0f_59e547eb","updated":"2026-02-04 15:11:32.000000000","message":"technically no but im going to re-spin this for joan\u0027s comment so ill add one anyway.\n\nnormally i would say yes but there shoudl be no direct enduser or operator impact the main change would be for packages as they nolnger need to include eventlet as a dependency.\n\nbut it does not hurt to have one.","commit_id":"e9595d31c1ca6581585365066a37f9ca88aa21f0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6a6a7388dd29f4c8a162184f9d65b311bdab476d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f5d2faa0_7b4093a7","updated":"2026-02-16 14:44:34.000000000","message":"we will dicuss this in the irc meeting tomorrow and likely proceed with it later in the week if no negitive feedback is recived","commit_id":"f0da2a458327bb30e429193f5423c4aa419c8cd8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"081e2fa6ee4e7ed4cd3a98d1da05ae9560a95219","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32a46272_6cb71708","updated":"2026-02-16 18:53:38.000000000","message":"Looks good Sean, thanks","commit_id":"eabcd949d6684bef310cd2714b6cf7c41145bf6c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb3fb47e11ad56b5f91ab38facb6e6b1a9d5861a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cf39084f_79b45ac6","updated":"2026-02-17 21:25:04.000000000","message":"if there are no other feedback ill proceed with this tomorrow","commit_id":"099779119254506e3b535264794150904c0ea63c"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"65b2bc76e88bee877881eb8ad76fa5bdfeb654f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"09192a92_93b0de61","updated":"2026-02-18 18:30:11.000000000","message":"lgtm","commit_id":"099779119254506e3b535264794150904c0ea63c"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"51b2c125055a7a378b0446f5b1b0bf80209aa88c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fb5e0fb0_7a449eb8","updated":"2026-02-18 14:13:10.000000000","message":"lgtm, I could not reproduce the `py313` unit test failure locally","commit_id":"099779119254506e3b535264794150904c0ea63c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6629d1c9024a2377d77dc07cc59db6156584ab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8cd01347_178692dd","updated":"2026-02-18 17:55:43.000000000","message":"recheck need to debug the segfault","commit_id":"099779119254506e3b535264794150904c0ea63c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6629d1c9024a2377d77dc07cc59db6156584ab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"711c8721_a57fdce6","in_reply_to":"fb5e0fb0_7a449eb8","updated":"2026-02-18 17:55:43.000000000","message":"sigh i will run this in a loop for a bit and see if i can repoduce","commit_id":"099779119254506e3b535264794150904c0ea63c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c4625932835a604458c0b32eb8db9b287fd86aa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"75260804_5c2fcf5b","updated":"2026-02-18 23:21:20.000000000","message":"i left this runing in a loop for 2 hours with no crashes\n\ni needed to port dougs db lock fixture and some other enhancment form watcher to stablise it\n\nthe segfault was in sqlight with background thread manipulating the db concurrently.","commit_id":"caecf3438030d314e6de717b9680e9d2f8243e34"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9943815b0c7f19f922bf151f49f8ae62c36c32a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"968e9214_85a4bb3f","in_reply_to":"75260804_5c2fcf5b","updated":"2026-02-18 23:22:28.000000000","message":"importantly i could reproduce the crash locally 3-4 iterations of the fully test suite","commit_id":"caecf3438030d314e6de717b9680e9d2f8243e34"}],"cyborg/common/rpc.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"53d5b0bde84dd8f1f5fc25ea52cd1d25bc1a9c0a","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    return messaging.get_rpc_server(TRANSPORT,"},{"line_number":109,"context_line":"                                    target,"},{"line_number":110,"context_line":"                                    endpoints,"},{"line_number":111,"context_line":"                                    executor\u003d\u0027threading\u0027,"},{"line_number":112,"context_line":"                                    serializer\u003dserializer,"},{"line_number":113,"context_line":"                                    access_policy\u003daccess_policy)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e08d3f98_f3fe412a","line":111,"updated":"2025-12-17 14:49:45.000000000","message":"looking at the docs it seems that this parameter is deprecated https://docs.openstack.org/oslo.messaging/2025.2/reference/server.html#oslo_messaging.get_rpc_server, IIUC the threading executor will be the only one supported eventually, so maybe we don\u0027t need to specify it?","commit_id":"8ef59de6b20244910cf47d01adb08c7f48e4a0ed"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb3fb47e11ad56b5f91ab38facb6e6b1a9d5861a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    return messaging.get_rpc_server(TRANSPORT,"},{"line_number":109,"context_line":"                                    target,"},{"line_number":110,"context_line":"                                    endpoints,"},{"line_number":111,"context_line":"                                    executor\u003d\u0027threading\u0027,"},{"line_number":112,"context_line":"                                    serializer\u003dserializer,"},{"line_number":113,"context_line":"                                    access_policy\u003daccess_policy)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"14ed73b6_0612666e","line":111,"in_reply_to":"5edf0562_f57cf31f","updated":"2026-02-17 21:25:04.000000000","message":"Done","commit_id":"8ef59de6b20244910cf47d01adb08c7f48e4a0ed"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8e1d19242d17812d015ae283fb3a1943a5360995","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    return messaging.get_rpc_server(TRANSPORT,"},{"line_number":109,"context_line":"                                    target,"},{"line_number":110,"context_line":"                                    endpoints,"},{"line_number":111,"context_line":"                                    executor\u003d\u0027threading\u0027,"},{"line_number":112,"context_line":"                                    serializer\u003dserializer,"},{"line_number":113,"context_line":"                                    access_policy\u003daccess_policy)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5edf0562_f57cf31f","line":111,"in_reply_to":"e08d3f98_f3fe412a","updated":"2025-12-30 16:58:58.000000000","message":"we had some issues with the auto detection in the past when they first startrd addeing the threading supprot but we could remove it an see if it now works reliably.","commit_id":"8ef59de6b20244910cf47d01adb08c7f48e4a0ed"}],"cyborg/common/utils.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"081e2fa6ee4e7ed4cd3a98d1da05ae9560a95219","unresolved":true,"context_lines":[{"line_number":219,"context_line":"    pass"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class ThreadPoolExecutor(CFThreadPoolExecutor):"},{"line_number":223,"context_line":"    \"\"\"Derived from concurrent.futures.ThreadPoolExecutor\"\"\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"00b8b76d_a14e8df8","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":47},"updated":"2026-02-16 18:53:38.000000000","message":"haven\u0027t you consider removing this class too?","commit_id":"f0da2a458327bb30e429193f5423c4aa419c8cd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3e4d47395b9bccd1f031d5e6e36a977d8f9b8ad","unresolved":true,"context_lines":[{"line_number":219,"context_line":"    pass"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class ThreadPoolExecutor(CFThreadPoolExecutor):"},{"line_number":223,"context_line":"    \"\"\"Derived from concurrent.futures.ThreadPoolExecutor\"\"\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"aec4e47b_03753a77","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":47},"in_reply_to":"00b8b76d_a14e8df8","updated":"2026-02-16 19:49:35.000000000","message":"actully yes i forgot about that\n\nif i end up respingin this ill try to remember to drop it.\n\ni wproably will tomorrow","commit_id":"f0da2a458327bb30e429193f5423c4aa419c8cd8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb3fb47e11ad56b5f91ab38facb6e6b1a9d5861a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    pass"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class ThreadPoolExecutor(CFThreadPoolExecutor):"},{"line_number":223,"context_line":"    \"\"\"Derived from concurrent.futures.ThreadPoolExecutor\"\"\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d097861_1637e2d5","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":47},"in_reply_to":"aec4e47b_03753a77","updated":"2026-02-17 21:25:04.000000000","message":"Done","commit_id":"f0da2a458327bb30e429193f5423c4aa419c8cd8"}],"cyborg/tests/unit/__init__.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df63bd5d34b00aad488ef39eb45668468c937b74","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# Make sure this is done after eventlet monkey patching otherwise"},{"line_number":32,"context_line":"# the threading.local() store used in oslo_messaging will be initialized to"},{"line_number":33,"context_line":"# threadlocal storage rather than greenthread local. This will cause context"},{"line_number":34,"context_line":"# sets and deletes in that storage to clobber each other."},{"line_number":35,"context_line":"# Make sure we have all of the objects loaded. We do this"},{"line_number":36,"context_line":"# at module import time, because we may be using mock decorators in our"},{"line_number":37,"context_line":"# tests that run at import time."}],"source_content_type":"text/x-python","patch_set":3,"id":"392ba2bc_4a0dc18b","side":"PARENT","line":34,"updated":"2026-02-16 15:04:48.000000000","message":"we needed to itialies the threaded backend in the tests.","commit_id":"2446e168af2d99c7f355b7a7f9e75f94ca89fb1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7f9836098e7bc28a46dbcea152717e2d8c6b2999","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Make sure this is done after eventlet monkey patching otherwise"},{"line_number":32,"context_line":"# the threading.local() store used in oslo_messaging will be initialized to"},{"line_number":33,"context_line":"# threadlocal storage rather than greenthread local. This will cause context"},{"line_number":34,"context_line":"# sets and deletes in that storage to clobber each other."},{"line_number":35,"context_line":"# Make sure we have all of the objects loaded. We do this"},{"line_number":36,"context_line":"# at module import time, because we may be using mock decorators in our"},{"line_number":37,"context_line":"# tests that run at import time."}],"source_content_type":"text/x-python","patch_set":3,"id":"8c74600a_eba867a3","side":"PARENT","line":34,"in_reply_to":"392ba2bc_4a0dc18b","updated":"2026-02-16 15:07:56.000000000","message":"Done","commit_id":"2446e168af2d99c7f355b7a7f9e75f94ca89fb1e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"081e2fa6ee4e7ed4cd3a98d1da05ae9560a95219","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import oslo_service.backend as service"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cyborg import objects"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"service.init_backend(service.BackendType.THREADING)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"50f37196_eb5a1033","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":26},"updated":"2026-02-16 18:53:38.000000000","message":"we just need to make sure that any import before \"init_backend\" does not have any include of oslo_service, otherwise it will fail in the \"init_backend\" (since defaul is still eventlet). But I think that we are good here.","commit_id":"eabcd949d6684bef310cd2714b6cf7c41145bf6c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3e4d47395b9bccd1f031d5e6e36a977d8f9b8ad","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import oslo_service.backend as service"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cyborg import objects"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"service.init_backend(service.BackendType.THREADING)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"a20f95bd_1370b985","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":26},"in_reply_to":"50f37196_eb5a1033","updated":"2026-02-16 19:49:35.000000000","message":"ack i could no qa it but for now i think we are ok","commit_id":"eabcd949d6684bef310cd2714b6cf7c41145bf6c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb3fb47e11ad56b5f91ab38facb6e6b1a9d5861a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import oslo_service.backend as service"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cyborg import objects"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"service.init_backend(service.BackendType.THREADING)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"e9d62261_d55edf76","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":26},"in_reply_to":"a20f95bd_1370b985","updated":"2026-02-17 21:25:04.000000000","message":"Acknowledged","commit_id":"eabcd949d6684bef310cd2714b6cf7c41145bf6c"}]}
