)]}'
{"cyborg/accelerator/drivers/gpu/nvidia/sysinfo.py":[{"robot_id":"zuul","robot_run_id":"be71eb36060a4d30a9d81b0115f1d033","url":"https://zuul.teim.app/t/main/buildset/be71eb36060a4d30a9d81b0115f1d033","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3a3b874224a87ae9147648e2ff74bb74a5d1ecc0","patch_set":1,"id":"acd6fcd7_d914524b","line":233,"updated":"2026-03-03 11:13:24.000000000","message":"Consider moving the _is_vf() helper function to the shared gpu/utils.py module for potential reuse by other GPU drivers that may also need SR-IOV VF filtering.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Improves code maintainability and enables consistent VF filtering across all GPU drivers if SR-IOV support expands to other vendors\n\n**Recommendation**:\nIf other GPU vendors (e.g., Intel, AMD) may implement SR-IOV in the future, move _is_vf() to cyborg/accelerator/drivers/gpu/utils.py and import it from there. This would also make it easier to add unit tests specifically for this function.","commit_id":"6d513f7303f20af6d84451e1aa1a5a5ef20b648c"},{"robot_id":"zuul","robot_run_id":"be71eb36060a4d30a9d81b0115f1d033","url":"https://zuul.teim.app/t/main/buildset/be71eb36060a4d30a9d81b0115f1d033","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3a3b874224a87ae9147648e2ff74bb74a5d1ecc0","patch_set":1,"id":"de11c826_918c5153","line":233,"updated":"2026-03-03 11:13:24.000000000","message":"The _is_vf() function should handle potential OSError exceptions when checking sysfs paths. Malformed PCI addresses or permission issues could cause unexpected failures during device discovery.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Device discovery could fail silently or with cryptic errors if sysfs access issues occur, potentially causing the cyborg service to miss reporting valid GPU devices\n\n**Suggestion**:\nConsider wrapping the os.path.exists() call in a try-except block to handle OSError gracefully. Log a warning if the check fails and treat the device as a non-VF (safe default) to avoid missing valid devices. For example: try: return os.path.exists(physfn_path); except OSError: LOG.warning(\u0027Cannot determine VF status for %s\u0027, pci_address); return False","commit_id":"6d513f7303f20af6d84451e1aa1a5a5ef20b648c"},{"robot_id":"zuul","robot_run_id":"be71eb36060a4d30a9d81b0115f1d033","url":"https://zuul.teim.app/t/main/buildset/be71eb36060a4d30a9d81b0115f1d033","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3a3b874224a87ae9147648e2ff74bb74a5d1ecc0","patch_set":1,"id":"459ebf60_560afdb9","line":257,"updated":"2026-03-03 11:13:24.000000000","message":"Add a TODO comment or documentation note about the future need to revisit VF handling when vfio-variant-driver support is added.\n\n**Severity**: SUGGESTION | **Confidence**: 0.6\n\n**Benefit**: Helps future maintainers understand the intentional limitation and where to make changes when OS support for vfio-variant-driver matures\n\n**Recommendation**:\nThe existing NOTE comment already documents this well. Consider adding a TODO() marker with a tracking issue or blueprint reference if there is a planned feature for MIG-backed VF passthrough support.","commit_id":"6d513f7303f20af6d84451e1aa1a5a5ef20b648c"},{"robot_id":"zuul","robot_run_id":"0019e00645a04545bf4e710083a4b2df","url":"https://zuul.opendev.org/t/openstack/buildset/0019e00645a04545bf4e710083a4b2df","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa26d2060d419fbf79e05e79839e91d7b8a4a60e","patch_set":2,"id":"e8f5a78c_f42b3657","line":262,"updated":"2026-03-03 15:48:37.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"5a789578b9149036aea2f5f705c26e8d44979b30"},{"robot_id":"zuul","robot_run_id":"1b659a0e0e6f40a9a838033219e7d45e","url":"https://zuul.teim.app/t/main/buildset/1b659a0e0e6f40a9a838033219e7d45e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"60f30b11a8a63b068f04ba659edc1b4fee2ffd8a","patch_set":2,"id":"3c995c92_3ddd5a41","line":276,"updated":"2026-03-03 15:43:45.000000000","message":"The LOG.info message when skipping VF could include the config option name for operator troubleshooting\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Operators reviewing logs will immediately understand why VFs are being filtered and which configuration controls this behavior\n\n**Recommendation**:\nConsider enhancing the log message to: \u0027Skipping VF device %s (filtered by [gpu_devices]filter_sp_vfs), only PFs and mediated devices are reported.\u0027 This provides better operational visibility.","commit_id":"5a789578b9149036aea2f5f705c26e8d44979b30"},{"robot_id":"zuul","robot_run_id":"d0fafc02168447618533cc87dd01b79e","url":"https://zuul.teim.app/t/main/buildset/d0fafc02168447618533cc87dd01b79e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"99ec87ec34e251eebfcf8521dfbad16d26ce6da4","patch_set":3,"id":"691a11b7_87ec4664","line":233,"updated":"2026-03-03 16:17:06.000000000","message":"The _is_vf() function could benefit from a docstring parameter description for the pci_address parameter.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Improves API documentation and code maintainability for future developers\n\n**Recommendation**:\nAdd a :param pci_address: description to the docstring. Example: \u0027:param pci_address: PCI device address in domain:bus:device.function format, e.g. \"0000:3b:00.4\"\u0027","commit_id":"a7406ecf7c3b8e780814b225f7c228ea5de1d052"},{"robot_id":"zuul","robot_run_id":"d0fafc02168447618533cc87dd01b79e","url":"https://zuul.teim.app/t/main/buildset/d0fafc02168447618533cc87dd01b79e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"99ec87ec34e251eebfcf8521dfbad16d26ce6da4","patch_set":3,"id":"925b8ae5_38032f20","line":240,"updated":"2026-03-03 16:17:06.000000000","message":"The _is_vf() function catches OSError but os.path.exists() does not typically raise OSError for permission issues - it returns False instead. The exception handler may never be triggered for expected scenarios.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Dead code in exception handler may lead to false sense of error handling coverage\n\n**Suggestion**:\nOSError could occur from filesystem issues but not typical path existence checks. The defensive approach is reasonable but document the expected error scenarios or consider if a different validation approach is needed.","commit_id":"a7406ecf7c3b8e780814b225f7c228ea5de1d052"},{"robot_id":"zuul","robot_run_id":"d0fafc02168447618533cc87dd01b79e","url":"https://zuul.teim.app/t/main/buildset/d0fafc02168447618533cc87dd01b79e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"99ec87ec34e251eebfcf8521dfbad16d26ce6da4","patch_set":3,"id":"279ba7f9_a0f746b0","line":277,"updated":"2026-03-03 16:17:06.000000000","message":"The LOG.info message when skipping VF devices could include more context for debugging, such as the hostname being processed.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Makes debugging and log analysis easier for operators in multi-node deployments\n\n**Recommendation**:\nConsider extending the log message with additional context: LOG.info(\u0027Skipping VF device %s on host %s\u0027, gpu_dict[\u0027devices\u0027], CONF.host)","commit_id":"a7406ecf7c3b8e780814b225f7c228ea5de1d052"},{"robot_id":"zuul","robot_run_id":"54763a300bd140e0b7b71b473718bdc3","url":"https://zuul.teim.app/t/main/buildset/54763a300bd140e0b7b71b473718bdc3","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3450c42c01147a46545de733d9492b82dd5c9d6b","patch_set":6,"id":"fa57acf9_364aad02","line":1,"updated":"2026-03-03 17:02:10.000000000","message":"Typo in commit message: \u0027passthough\u0027 should be \u0027passthrough\u0027\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Minor documentation quality issue in commit message, does not affect functionality.\n\n**Suggestion**:\nFix typo in commit message: \u0027It is possible to passthough the VF\u0027 -\u003e \u0027It is possible to passthrough the VF\u0027","commit_id":"a02f1a37f81eb34c28bf79f6ea2d4522b741567f"},{"robot_id":"zuul","robot_run_id":"54763a300bd140e0b7b71b473718bdc3","url":"https://zuul.teim.app/t/main/buildset/54763a300bd140e0b7b71b473718bdc3","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3450c42c01147a46545de733d9492b82dd5c9d6b","patch_set":6,"id":"9fe7633f_51e9f2db","line":279,"updated":"2026-03-03 17:02:10.000000000","message":"Bare \u0027except Exception:\u0027 clause catches too broadly, violating H201 hacking rule and masking potential errors\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: Catches SystemExit, KeyboardInterrupt, and other exceptions that should propagate. Makes debugging difficult and violates OpenStack coding standards.\n\n**Priority**: Before merge\n**Why This Matters**: OpenStack hacking rule H201 explicitly prohibits broad exception catching. The _is_vf function already handles OSError internally, so the outer handler should catch specific exceptions.\n\n**Recommendation**:\nChange \u0027except Exception:\u0027 to \u0027except (OSError, ValueError) as e:\u0027 or similar specific exceptions. The _is_vf function catches OSError internally and returns False, so this outer catch is likely redundant.","commit_id":"a02f1a37f81eb34c28bf79f6ea2d4522b741567f"},{"robot_id":"zuul","robot_run_id":"54763a300bd140e0b7b71b473718bdc3","url":"https://zuul.teim.app/t/main/buildset/54763a300bd140e0b7b71b473718bdc3","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3450c42c01147a46545de733d9492b82dd5c9d6b","patch_set":6,"id":"0e4df834_37249431","line":285,"updated":"2026-03-03 17:02:10.000000000","message":"Consider adding LOG.debug for successful VF detection in production environments\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Provides debugging visibility when investigating why specific GPUs are or are not being reported, without cluttering logs at default log levels.\n\n**Recommendation**:\nThe existing LOG.info at line 287 is appropriate for when a VF is skipped. Consider adding LOG.debug for when filter_sriov_vfs is enabled but device is not a VF, to aid debugging.","commit_id":"a02f1a37f81eb34c28bf79f6ea2d4522b741567f"},{"robot_id":"zuul","robot_run_id":"54763a300bd140e0b7b71b473718bdc3","url":"https://zuul.teim.app/t/main/buildset/54763a300bd140e0b7b71b473718bdc3","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3450c42c01147a46545de733d9492b82dd5c9d6b","patch_set":6,"id":"ff7d113d_581f124c","line":287,"updated":"2026-03-03 17:02:10.000000000","message":"Line length exceeds 79 characters in LOG.info call\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: May fail pep8/flake8 checks. However, the project may use ruff for formatting which could handle this automatically.\n\n**Suggestion**:\nVerify if pre-commit hooks or ruff will auto-format this. If not, break the LOG.info string across lines at natural word boundaries while maintaining delayed interpolation.","commit_id":"a02f1a37f81eb34c28bf79f6ea2d4522b741567f"}],"cyborg/conf/devices.py":[{"robot_id":"zuul","robot_run_id":"d0fafc02168447618533cc87dd01b79e","url":"https://zuul.teim.app/t/main/buildset/d0fafc02168447618533cc87dd01b79e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"99ec87ec34e251eebfcf8521dfbad16d26ce6da4","patch_set":3,"id":"94b033fb_f6e911ad","line":46,"updated":"2026-03-03 16:17:06.000000000","message":"Configuration option name \u0027filter_sp_vfs\u0027 is ambiguous - \u0027sp\u0027 could be interpreted as \u0027service processor\u0027 or other meanings instead of \u0027SR-IOV PCI\u0027.\n\n**Severity**: WARNING | **Confidence**: 0.7\n\n**Impact**: Operators may be confused about what the option filters without reading detailed documentation\n\n**Suggestion**:\nConsider renaming to \u0027filter_sriov_vfs\u0027 for clarity, or add inline comment explaining \u0027sp\u0027 means \u0027SR-IOV PCI\u0027. The release note correctly explains SR-IOV, so the option name should match.","commit_id":"a7406ecf7c3b8e780814b225f7c228ea5de1d052"}],"cyborg/tests/unit/accelerator/drivers/gpu/test_utils.py":[{"robot_id":"zuul","robot_run_id":"be71eb36060a4d30a9d81b0115f1d033","url":"https://zuul.teim.app/t/main/buildset/be71eb36060a4d30a9d81b0115f1d033","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3a3b874224a87ae9147648e2ff74bb74a5d1ecc0","patch_set":1,"id":"66c16433_6495f697","line":241,"updated":"2026-03-03 11:13:24.000000000","message":"The test mock for _is_vf could be more explicit by mocking os.path.exists directly to verify the actual implementation logic rather than mocking the function under test.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Testing the actual sysfs path check implementation provides better confidence that the VF detection works correctly with real sysfs paths\n\n**Recommendation**:\nConsider adding an additional test that mocks os.path.exists directly with the expected \u0027/sys/bus/pci/devices/0000:3b:00.4/physfn\u0027 path to verify the implementation. The current test mocks _is_vf itself, which is acceptable but provides less coverage of the actual implementation.","commit_id":"6d513f7303f20af6d84451e1aa1a5a5ef20b648c"},{"robot_id":"zuul","robot_run_id":"1b659a0e0e6f40a9a838033219e7d45e","url":"https://zuul.teim.app/t/main/buildset/1b659a0e0e6f40a9a838033219e7d45e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"60f30b11a8a63b068f04ba659edc1b4fee2ffd8a","patch_set":2,"id":"af28edda_3bbfbe55","line":153,"updated":"2026-03-03 15:43:45.000000000","message":"Mock decorators in test_discover_gpus_report_vGPU lack autospec\u003dTrue parameter for H210 compliance\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: May allow test interface mismatches to go undetected; inconsistent with recommended OpenStack mock practices for new code\n\n**Suggestion**:\nAdd autospec\u003dTrue to mock decorators for _is_vf, builtins.open, os.listdir, os.path.exists, and lspci_privileged. Note: The mock at line 154 uses \u0027builtins.open\u0027 which is correct for Python 3, but the test class already handles Python version compatibility via the BUILTIN variable defined at line 48 (though not used for this specific mock).","commit_id":"5a789578b9149036aea2f5f705c26e8d44979b30"},{"robot_id":"zuul","robot_run_id":"1b659a0e0e6f40a9a838033219e7d45e","url":"https://zuul.teim.app/t/main/buildset/1b659a0e0e6f40a9a838033219e7d45e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"60f30b11a8a63b068f04ba659edc1b4fee2ffd8a","patch_set":2,"id":"8f298c18_14ddcacd","line":247,"updated":"2026-03-03 15:43:45.000000000","message":"Test data format mismatch in test_discover_gpus_filters_vf_devices returns concatenated string instead of list of lines\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: The mock returns a list with one element containing newline-joined PF and VF info, which may not correctly simulate lspci_privileged returning separate lines for each device\n\n**Suggestion**:\nVerify the expected format of lspci_privileged return value. If it returns a list of lines (one per device), change to [NVIDIA_A100_PF_INFO, NVIDIA_A100_VF_INFO] without the newline concatenation. The test at line 75 uses readlines() which suggests line-based parsing.","commit_id":"5a789578b9149036aea2f5f705c26e8d44979b30"},{"robot_id":"zuul","robot_run_id":"1b659a0e0e6f40a9a838033219e7d45e","url":"https://zuul.teim.app/t/main/buildset/1b659a0e0e6f40a9a838033219e7d45e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"60f30b11a8a63b068f04ba659edc1b4fee2ffd8a","patch_set":2,"id":"ef9d1966_9fb8d7b6","line":292,"updated":"2026-03-03 15:43:45.000000000","message":"Consider adding unit test for OSError handling path in _is_vf function beyond the existing test\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: While test_is_vf_returns_false_on_oserror exists, adding an integration-style test that verifies the full discovery flow handles sysfs access failures gracefully would improve coverage\n\n**Recommendation**:\nAdd a test case that mocks _is_vf to raise OSError and verifies discovery continues without the VF (or consider if the current test coverage is sufficient for the simple fallback behavior)","commit_id":"5a789578b9149036aea2f5f705c26e8d44979b30"},{"robot_id":"zuul","robot_run_id":"d0fafc02168447618533cc87dd01b79e","url":"https://zuul.teim.app/t/main/buildset/d0fafc02168447618533cc87dd01b79e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"99ec87ec34e251eebfcf8521dfbad16d26ce6da4","patch_set":3,"id":"9092b386_03a60a9c","line":35,"updated":"2026-03-03 16:17:06.000000000","message":"The test constants NVIDIA_A100_PF_INFO and NVIDIA_A100_VF_INFO have identical product IDs (20f1), which is correct for SR-IOV but could benefit from an explanatory comment.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Helps future maintainers understand why PF and VF share the same product ID\n\n**Recommendation**:\nAdd a comment like \u0027# Note: PF and VF share the same product ID (20f1) - this is expected for SR-IOV devices\u0027","commit_id":"a7406ecf7c3b8e780814b225f7c228ea5de1d052"},{"robot_id":"zuul","robot_run_id":"d0fafc02168447618533cc87dd01b79e","url":"https://zuul.teim.app/t/main/buildset/d0fafc02168447618533cc87dd01b79e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"99ec87ec34e251eebfcf8521dfbad16d26ce6da4","patch_set":3,"id":"b061bf19_dcc607bf","line":153,"updated":"2026-03-03 16:17:06.000000000","message":"New test mocks use @mock.patch without autospec\u003dTrue, inconsistent with other test files in the project (test_service.py, test_extarq.py) that use autospec\u003dTrue for better mock safety.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Tests may pass even if function signatures change, reducing test reliability for catching interface breaks\n\n**Suggestion**:\nFor new test code, consider adding autospec\u003dTrue to @mock.patch decorators to match project patterns. Example: @mock.patch(\u0027cyborg.accelerator.drivers.gpu.nvidia.sysinfo._is_vf\u0027, autospec\u003dTrue, return_value\u003dFalse)","commit_id":"a7406ecf7c3b8e780814b225f7c228ea5de1d052"},{"robot_id":"zuul","robot_run_id":"54763a300bd140e0b7b71b473718bdc3","url":"https://zuul.teim.app/t/main/buildset/54763a300bd140e0b7b71b473718bdc3","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3450c42c01147a46545de733d9492b82dd5c9d6b","patch_set":6,"id":"236616ca_63269693","line":245,"updated":"2026-03-03 17:02:10.000000000","message":"Test mocks missing autospec\u003dTrue for several @mock.patch decorators, inconsistent with project patterns\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Tests may pass even when function signatures change, reducing test reliability. Inconsistent with existing tests in the same file that use autospec\u003dTrue (line 157).\n\n**Suggestion**:\nAdd autospec\u003dTrue to @mock.patch decorators at lines 245, 246, 264, 265, 280, 281, 301, 307, 313 for consistency with line 157 and project patterns.","commit_id":"a02f1a37f81eb34c28bf79f6ea2d4522b741567f"},{"robot_id":"zuul","robot_run_id":"54763a300bd140e0b7b71b473718bdc3","url":"https://zuul.teim.app/t/main/buildset/54763a300bd140e0b7b71b473718bdc3","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3450c42c01147a46545de733d9492b82dd5c9d6b","patch_set":6,"id":"947fc02d_57c322bc","line":300,"updated":"2026-03-03 17:02:10.000000000","message":"Consider adding integration test for PF+VF scenario\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Would verify end-to-end behavior with real sysfs paths if functional testing infrastructure exists.\n\n**Recommendation**:\nThe current unit tests are adequate for this change. Consider adding a functional test only if the project has functional test infrastructure for GPU discovery.","commit_id":"a02f1a37f81eb34c28bf79f6ea2d4522b741567f"}],"releasenotes/notes/filter-nvidia-gpu-sriov-vfs-3258d05ad5cd4de0.yaml":[{"robot_id":"zuul","robot_run_id":"d0fafc02168447618533cc87dd01b79e","url":"https://zuul.teim.app/t/main/buildset/d0fafc02168447618533cc87dd01b79e","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"99ec87ec34e251eebfcf8521dfbad16d26ce6da4","patch_set":3,"id":"a02a0ba1_2ad0bf68","line":6,"updated":"2026-03-03 16:17:06.000000000","message":"The release note mentions \u0027filter_sp_vfs\u0027 option but the naming could be clarified to match the documented behavior more closely.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Operators can immediately understand what the option controls from the name alone\n\n**Recommendation**:\nConsider if the option name should match the documented behavior (filter_sriov_vfs), or ensure the help text explicitly mentions \u0027sp\u0027 stands for \u0027SR-IOV PCI\u0027","commit_id":"a7406ecf7c3b8e780814b225f7c228ea5de1d052"}]}