)]}'
{"devstack/cyborg_vm.xml":[{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"7a35831e_0fe78d8e","line":13,"updated":"2026-04-01 10:13:05.000000000","message":"The cyborg_vm.xml uses machine type \u0027pc-q35-10.1\u0027 which is a versioned machine type. This may become outdated as QEMU versions advance. The vm-setup.rst uses \u0027--machine q35\u0027 which selects the latest Q35 version.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Using the unversioned \u0027q35\u0027 machine type would make the XML more portable across different QEMU versions and reduce maintenance burden.\n\n**Recommendation**:\nConsider changing machine type from \u0027pc-q35-10.1\u0027 to \u0027q35\u0027 in cyborg_vm.xml for better forward compatibility, or add a comment explaining why the version is pinned.","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"e7d8ff6d_e94a03ec","line":181,"updated":"2026-04-01 10:13:05.000000000","message":"devstack/cyborg_vm.xml has a trailing blank line (line 182 is empty after the closing tag on line 180). This will be flagged by the trailing-whitespace pre-commit hook.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: The trailing-whitespace pre-commit hook will flag the extra blank line, causing CI to fail.\n\n**Suggestion**:\nRemove the trailing blank line at the end of cyborg_vm.xml. The file should end with a single newline after the closing tag.","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"08ee251d_eab22799","line":176,"updated":"2026-04-10 07:32:21.000000000","message":"The `addr\u003d0x12` in the NVMe device QEMU argument maps to PCI slot 0x12, but this address is on the root bus (bus 0). On the Q35 machine type used in the XML, the root bus slots are limited and may conflict with other devices.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Users would avoid potential PCI address conflicts when adding additional devices or modifying the VM configuration.\n\n**Recommendation**:\nConsider using a higher slot number (e.g., `addr\u003d0x1e`) or attaching the NVMe device to one of the existing PCIe root ports to avoid potential conflicts with the Q35 chipset reserved addresses.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"}],"devstack/local-conf":[{"robot_id":"zuul","robot_run_id":"75fdb815c6294e0e9b95263741a93602","url":"https://zuul.teim.app/t/main/buildset/75fdb815c6294e0e9b95263741a93602","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"10c2a30d2080c1b53d544e0155e031536e379d60","patch_set":1,"id":"f71f3638_9deca535","line":53,"updated":"2026-03-30 19:04:06.000000000","message":"Line 53 of local-conf exceeds 79 characters (98 chars). While strict line length is a Python convention, keeping DevStack config lines short improves readability.\n\n**Severity**: WARNING | **Confidence**: 0.7\n\n**Impact**: Minor readability concern. Long inline comments in config files can be hard to read on narrow terminals.\n\n**Suggestion**:\nMove the inline comment to a separate line above the passthrough_whitelist directive.","commit_id":"bd35e0dc5a5e426433fab13290f9cdb2d83ebe8f"},{"robot_id":"zuul","robot_run_id":"75fdb815c6294e0e9b95263741a93602","url":"https://zuul.teim.app/t/main/buildset/75fdb815c6294e0e9b95263741a93602","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"10c2a30d2080c1b53d544e0155e031536e379d60","patch_set":1,"id":"fd1ce965_9f5345d0","line":53,"updated":"2026-03-30 19:04:06.000000000","message":"The local.conf template uses vendor_id 0c51 and product_id 0110 in the passthrough_whitelist, which do not match the NVMe controller IDs (1b36:0010) documented in the RST guide. A user following both files will have a non-functional setup unless they catch and correct this discrepancy.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: Users who copy the local.conf template verbatim will have a passthrough_whitelist that does not match any device in their VM, causing Cyborg PCI driver to discover zero devices. The guide instructs users to update the whitelist but the template should provide consistent example values.\n\n**Priority**: Before merge\n**Why This Matters**: Consistency between the template and the documentation guide is essential for a good first-time user experience. A template with mismatched device IDs is confusing and could cause users to waste time debugging.\n\n**Recommendation**:\nUpdate the passthrough_whitelist in devstack/local-conf:53 to use vendor_id 1b36 and product_id 0010, matching the example NVMe controller documented throughout the RST guide.","commit_id":"bd35e0dc5a5e426433fab13290f9cdb2d83ebe8f"},{"robot_id":"zuul","robot_run_id":"380b4dabcf17449ba14c21c493b06a1a","url":"https://zuul.teim.app/t/main/buildset/380b4dabcf17449ba14c21c493b06a1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1381b4a8f440a336935738d8f609f8a0044de27b","patch_set":2,"id":"7035b48d_db9d50f7","line":59,"updated":"2026-03-31 13:48:32.000000000","message":"The passthrough_whitelist line in devstack/local-conf is 133 characters on a single line, making it very hard to read and edit. The trailing comment adds further clutter.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Users will find it difficult to parse and modify this configuration line. The inline comment mixes documentation with configuration, which is fragile if someone edits the JSON.\n\n**Suggestion**:\nMove the comment to its own line above the configuration. Consider splitting or formatting for readability. For example:\n\n# Replace with your actual vendor and product IDs\npassthrough_whitelist\u003d\u0027{\"vendor_id\":\"0c51\",\"product_id\":\"0110\"}\u0027","commit_id":"beb2cf207311563a47935aec78c3a33aa720ef01"}],"doc/source/contributor/devstack_nvme.rst":[{"robot_id":"zuul","robot_run_id":"75fdb815c6294e0e9b95263741a93602","url":"https://zuul.teim.app/t/main/buildset/75fdb815c6294e0e9b95263741a93602","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"10c2a30d2080c1b53d544e0155e031536e379d60","patch_set":1,"id":"059edc9e_64e80a3f","line":25,"updated":"2026-03-30 19:04:06.000000000","message":"The guide does not mention minimum RAM requirements for the host system. The VM requires 12GB RAM and DevStack needs additional resources inside it.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Helps users assess feasibility before starting and avoids frustrating out-of-memory errors during DevStack installation.\n\n**Recommendation**:\nAdd a brief note about recommended host system resources (e.g., 16GB+ RAM, 4+ vCPUs for the host) in the Host System Requirements section.","commit_id":"bd35e0dc5a5e426433fab13290f9cdb2d83ebe8f"},{"robot_id":"zuul","robot_run_id":"75fdb815c6294e0e9b95263741a93602","url":"https://zuul.teim.app/t/main/buildset/75fdb815c6294e0e9b95263741a93602","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"10c2a30d2080c1b53d544e0155e031536e379d60","patch_set":1,"id":"1e6f8943_b88f61f1","line":77,"updated":"2026-03-30 19:04:06.000000000","message":"The guide documents a very specific Fedora 43 + QEMU 10.1.4 + libvirt 11.6.0 combination but does not state minimum version requirements upfront.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Users on older distributions or with older QEMU versions would have clearer guidance on whether their environment is supported.\n\n**Recommendation**:\nAdd minimum version requirement to the note, e.g., QEMU \u003e\u003d 2.9 for Intel IOMMU emulation (as mentioned later in the troubleshooting section).","commit_id":"bd35e0dc5a5e426433fab13290f9cdb2d83ebe8f"},{"robot_id":"zuul","robot_run_id":"75fdb815c6294e0e9b95263741a93602","url":"https://zuul.teim.app/t/main/buildset/75fdb815c6294e0e9b95263741a93602","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"10c2a30d2080c1b53d544e0155e031536e379d60","patch_set":1,"id":"88bb11e2_4276eae9","line":507,"updated":"2026-03-30 19:04:06.000000000","message":"The RST guide shows multiple passthrough_whitelist lines for adding both NVMe and RNG devices. While repeating the key is correct for DevStack ini format (MultiStrOpt), the guide should clarify that the [pci] section header should only appear once.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Users may accidentally create duplicate [pci] sections when copy-pasting, causing only the last section\u0027s values to take effect, silently dropping the first whitelist entry.\n\n**Suggestion**:\nRestructure the example to show a single [pci] section block with both passthrough_whitelist lines together, making it clear they belong to the same config section.","commit_id":"bd35e0dc5a5e426433fab13290f9cdb2d83ebe8f"},{"robot_id":"zuul","robot_run_id":"75fdb815c6294e0e9b95263741a93602","url":"https://zuul.teim.app/t/main/buildset/75fdb815c6294e0e9b95263741a93602","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"10c2a30d2080c1b53d544e0155e031536e379d60","patch_set":1,"id":"7fa0c3b6_2276139b","line":950,"updated":"2026-03-30 19:04:06.000000000","message":"The guide demonstrates manual ARQ deletion in the troubleshooting section but does not warn strongly enough that this may leave Placement resources in an inconsistent state.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Prevents users from causing resource allocation inconsistencies by manually deleting ARQs without understanding the implications.\n\n**Recommendation**:\nAdd an explicit .. warning:: directive before the manual ARQ delete command explaining that manual deletion may leave Placement resource providers inconsistent.","commit_id":"bd35e0dc5a5e426433fab13290f9cdb2d83ebe8f"},{"robot_id":"zuul","robot_run_id":"380b4dabcf17449ba14c21c493b06a1a","url":"https://zuul.teim.app/t/main/buildset/380b4dabcf17449ba14c21c493b06a1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1381b4a8f440a336935738d8f609f8a0044de27b","patch_set":2,"id":"a7d4c5ad_fc80a779","line":132,"updated":"2026-03-31 13:48:32.000000000","message":"The virt-install command uses in-line comments after backslash continuations which may cause issues in some shell environments and is unusual for DevStack/OpenStack documentation.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Improves copy-paste reliability and follows the cleaner style seen in existing Cyborg docs.\n\n**Recommendation**:\nRemove inline comments from the virt-install command or convert them to a numbered list below the command. The existing devstack_setup.rst does not use inline comments in shell commands.","commit_id":"beb2cf207311563a47935aec78c3a33aa720ef01"},{"robot_id":"zuul","robot_run_id":"380b4dabcf17449ba14c21c493b06a1a","url":"https://zuul.teim.app/t/main/buildset/380b4dabcf17449ba14c21c493b06a1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1381b4a8f440a336935738d8f609f8a0044de27b","patch_set":2,"id":"a8dfc5ec_c57e9094","line":343,"updated":"2026-03-31 13:48:32.000000000","message":"RNG device product ID inconsistency: the guide text states the RNG device has product_id \u00271005\u0027 but the actual lspci output shown two lines later and the local.conf whitelist example both use \u00271044\u0027. A user following the guide will encounter mismatched device IDs.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: Users will copy the wrong product ID (\u00271005\u0027) and their PCI passthrough whitelist will not match the actual device (\u00271044\u0027), causing the device to not be discovered by Cyborg.\n\n**Priority**: Before merge\n**Why This Matters**: Incorrect device IDs in documentation will lead to user confusion and wasted debugging time when the NVMe/RNG device is not discovered.\n\n**Recommendation**:\nChange the product ID on line 343 from \u00271005\u0027 to \u00271044\u0027 to match the actual lspci output shown on line 383. The text should read: product ID \u00271044\u0027 (Virtio RNG). Also update the trait reference on line 610 from \u0027CUSTOM_PCI_PRODUCT_ID_1005\u0027 to \u0027CUSTOM_PCI_PRODUCT_ID_1044\u0027.","commit_id":"beb2cf207311563a47935aec78c3a33aa720ef01"},{"robot_id":"zuul","robot_run_id":"380b4dabcf17449ba14c21c493b06a1a","url":"https://zuul.teim.app/t/main/buildset/380b4dabcf17449ba14c21c493b06a1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1381b4a8f440a336935738d8f609f8a0044de27b","patch_set":2,"id":"e39c8c69_f14917e6","line":572,"updated":"2026-03-31 13:48:32.000000000","message":"Many prose lines in the RST file exceed 79 characters (the OpenStack line-length limit). While existing docs have some long lines (2 in devstack_setup.rst), this new file has significantly more long prose lines beyond what is typical.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: While code blocks with terminal output are expected to be wide, several prose paragraphs and note blocks exceed 79 characters, which is inconsistent with the OpenStack documentation style enforced by the style guide.\n\n**Suggestion**:\nWrap prose lines to 79 characters. The most impactful ones to fix are: line 572-574 (paragraph about device profile JSON file), line 608 (note about matching traits), line 885 (note about hardware requirements). Keep code block output as-is since terminal output cannot be reformatted.","commit_id":"beb2cf207311563a47935aec78c3a33aa720ef01"},{"robot_id":"zuul","robot_run_id":"380b4dabcf17449ba14c21c493b06a1a","url":"https://zuul.teim.app/t/main/buildset/380b4dabcf17449ba14c21c493b06a1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1381b4a8f440a336935738d8f609f8a0044de27b","patch_set":2,"id":"88ec90b1_b9d222af","line":572,"updated":"2026-03-31 13:48:32.000000000","message":"The guide says the device profile must be created using a JSON file, but the example immediately following shows using a single-quoted JSON string as a direct command-line argument, not a file.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Users may waste time trying to figure out how to create a separate JSON file when the CLI approach shown in the example works fine. The statement is misleading.\n\n**Suggestion**:\nRemove the sentence about requiring a JSON file. The example already demonstrates the correct command-line approach, which contradicts the statement.","commit_id":"beb2cf207311563a47935aec78c3a33aa720ef01"},{"robot_id":"zuul","robot_run_id":"380b4dabcf17449ba14c21c493b06a1a","url":"https://zuul.teim.app/t/main/buildset/380b4dabcf17449ba14c21c493b06a1a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"1381b4a8f440a336935738d8f609f8a0044de27b","patch_set":2,"id":"b3b61d21_e7551271","line":702,"updated":"2026-03-31 13:48:32.000000000","message":"The \u0027Verify Device Attachment\u0027 section heading is orphaned with no content below it before the next major heading \u0027Verify Accelerator Request (ARQ) Bindings\u0027.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: An empty section heading is invalid RST and will produce a warning during documentation build. It may also confuse readers.\n\n**Suggestion**:\nRemove the orphaned \u0027Verify Device Attachment\u0027 heading since the content that follows belongs to the ARQ verification section. Alternatively, add the missing content under that heading.","commit_id":"beb2cf207311563a47935aec78c3a33aa720ef01"}],"doc/source/contributor/index.rst":[{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"e7e80cfa_68ff98ee","line":33,"updated":"2026-04-10 07:32:21.000000000","message":"The index.rst toctree addition correctly places nvme-driver after vm-setup, but the descriptive link text on line 33 could be more descriptive about what distinguishes this guide from the general driver development guide.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Contributors browsing the index would better understand which guide to follow for their specific use case.\n\n**Recommendation**:\nConsider updating the description to \u0027NVMe/PCI driver development environment setup\u0027 to clarify it covers the PCI driver specifically.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"}],"doc/source/contributor/nvme-driver.rst":[{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"f82dd257_63a8ed4d","line":1,"updated":"2026-04-01 10:13:05.000000000","message":"The nvme-driver.rst and vm-setup.rst guides do not mention release note requirements. Since this is a significant documentation addition, a reno release note may be appropriate.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Release notes help users discover new documentation when upgrading. The project has a releasenotes/ directory and a contributor guide for writing release notes.\n\n**Recommendation**:\nConsider adding a release note in releasenotes/notes/ documenting the new contributor guides for VM setup and NVMe driver configuration. See :doc:`/contributor/releasenotes` for the project\u0027s release note process.","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"b6ef2136_c2289fbe","line":106,"updated":"2026-04-01 10:13:05.000000000","message":"The nvme-driver.rst note at line 106-108 claims \u0027The Intel IOMMU model works on both Intel and AMD hosts.\u0027 This is inaccurate for QEMU/libvirt vIOMMU. The \u0027intel\u0027 IOMMU model in libvirt specifically emulates an Intel VT-d IOMMU. While QEMU can translate this to work on AMD hosts for basic device passthrough, claiming it works equivalently on AMD is misleading. AMD KVM hosts should use the \u0027amd\u0027 IOMMU model for full feature parity.\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: Users on AMD hosts may encounter unexpected vIOMMU behavior or missing features if they follow this guidance without modification.\n\n**Priority**: Before merge\n**Why This Matters**: Technical accuracy of documentation directly affects user experience. AMD hosts using Intel IOMMU model may hit edge cases with interrupt remapping (intremap) or extended interrupt mode (eim) features that are Intel-specific.\n\n**Recommendation**:\nEither update the note to clarify that the Intel model is used as a baseline that works on AMD in basic configurations but that AMD users may need to adjust, or provide separate instructions for AMD hosts using the \u0027amd\u0027 IOMMU model. A balanced approach: \u0027The Intel IOMMU model is used here as a common default. On AMD hosts, you may need to replace model\u003d\"intel\" with model\u003d\"amd\" for full feature support.\u0027","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"f58a5d70_9a02b770","line":198,"updated":"2026-04-01 10:13:05.000000000","message":"nvme-driver.rst has 16 lines exceeding doc8\u0027s default 79-character line-length limit (up to 144 chars). The project runs doc8 via pre-commit and tox -e docs. Lines 276-278, 339, 350, 394-400 contain wide table output and long NVMe configuration strings. Lines 198, 263, 457-458 have overlong prose.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: CI failure: doc8 (D001) will reject lines over 79 characters, blocking merge unless overridden.\n\n**Priority**: Before merge\n**Why This Matters**: The project\u0027s pre-commit hooks include doc8 v1.1.2 which enforces a default max-line-length of 79 characters. The tox -e docs job also runs sphinx-build with -W (warnings-as-errors). These overlong lines will cause CI failures.\n\n**Recommendation**:\nWrap all prose lines to 79 characters. For table output in code-block:: console blocks, consider splitting long lines or adding a comment noting the output is truncated. For NVMe QEMU arg strings (lines 198-202, 339), break them across multiple lines. For the wide table output (lines 394-400), wrap the lines within the code-block or reduce column width in the example.","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"c9d9b749_7ded92b6","line":319,"updated":"2026-04-01 10:13:05.000000000","message":"The nvme-driver.rst lists a virtio-rng device (vendor 0x1af4, product 0x1044) as a potential test device in the passthrough_whitelist comments and expected output. However, the cyborg_vm.xml already includes a virtio-rng device (lines 163-167). This means the VM will have this device by default, and if users enable the commented-out whitelist entry, they will see it in device discovery.\n\n**Severity**: WARNING | **Confidence**: 0.7\n\n**Impact**: Users may be confused about why a virtio-rng device appears in their device list even if they did not explicitly add one, since the reference XML includes it.\n\n**Suggestion**:\nAdd a note clarifying that the cyborg_vm.xml reference already includes a virtio-rng device, so users who use that XML will see it automatically. Alternatively, clarify in the expected output section that the virtio-rng line only appears if explicitly enabled in the whitelist.","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"949a590e_093cd59c","line":391,"updated":"2026-04-01 10:13:05.000000000","message":"The nvme-driver.rst Verify Device Discovery section (line 392) has an extra blank line before the openstack command, which may trigger sphinx-lint or RST formatting warnings.\n\n**Severity**: WARNING | **Confidence**: 0.7\n\n**Impact**: The extra blank line inside a code-block:: console directive may cause unexpected formatting in the rendered HTML output.\n\n**Suggestion**:\nRemove the extra blank line before the \u0027$ openstack accelerator device list\u0027 command in the code-block at line 392.","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"3fd98a66_100f0ebb","line":416,"updated":"2026-04-01 10:13:05.000000000","message":"The nvme-driver.rst Troubleshooting section is minimal with only one scenario (Device Not Discovered). Adding troubleshooting for other common failure modes would improve the guide\u0027s usefulness.\n\n**Severity**: SUGGESTION | **Confidence**: 0.6\n\n**Benefit**: Users encountering IOMMU group issues, permission problems, or DevStack configuration errors would benefit from additional troubleshooting guidance.\n\n**Recommendation**:\nConsider adding troubleshooting sections for: (1) IOMMU groups not created (vIOMMU misconfiguration), (2) \u0027Permission denied\u0027 errors when accessing /dev/nvme*, (3) DevStack Cyborg agent failing to start with PCI driver errors.","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"d88d16eec7494ca8944a1c3f5949d895","url":"https://zuul.teim.app/t/main/buildset/d88d16eec7494ca8944a1c3f5949d895","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"df6376cbe83bf796d87bf5d289b54fa53dde0a07","patch_set":6,"id":"cee18982_90c2a857","line":49,"updated":"2026-04-01 10:26:58.000000000","message":"The nvme-driver.rst guide uses `qemu-kvm` in the verification command but the vm-setup.rst guide installs `qemu-kvm` as a package. On some distributions the binary may be named `qemu-system-x86_64` instead of `qemu-kvm`.\n\n**Severity**: SUGGESTION | **Confidence**: 0.6\n\n**Benefit**: Prevents confusion for users on distributions where the qemu-kvm wrapper binary is not available.\n\n**Recommendation**:\nConsider adding a fallback note: if `qemu-kvm` is not found, try `qemu-system-x86_64 -device help | grep nvme` instead.","commit_id":"23acd3c8d14fab814a56c24158aad4d8f1c49ae2"},{"robot_id":"zuul","robot_run_id":"d88d16eec7494ca8944a1c3f5949d895","url":"https://zuul.teim.app/t/main/buildset/d88d16eec7494ca8944a1c3f5949d895","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"df6376cbe83bf796d87bf5d289b54fa53dde0a07","patch_set":6,"id":"bd47af6a_57063c99","line":136,"updated":"2026-04-01 10:26:58.000000000","message":"The guides reference `\u003ccyborg-repo\u003e` as a placeholder for the Cyborg repository path (e.g., `\u003ccyborg-repo\u003e/devstack/cyborg_vm.xml`). New contributors may not know what to substitute here.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Clarity for first-time contributors who may not be familiar with the convention of using placeholder paths in documentation.\n\n**Recommendation**:\nAdd a brief note near the first use of `\u003ccyborg-repo\u003e` explaining that it should be replaced with the actual path to the cloned cyborg repository, for example `/opt/stack/cyborg` in a typical DevStack setup.","commit_id":"23acd3c8d14fab814a56c24158aad4d8f1c49ae2"},{"robot_id":"zuul","robot_run_id":"d88d16eec7494ca8944a1c3f5949d895","url":"https://zuul.teim.app/t/main/buildset/d88d16eec7494ca8944a1c3f5949d895","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"df6376cbe83bf796d87bf5d289b54fa53dde0a07","patch_set":6,"id":"95b440eb_abd92b3a","line":270,"updated":"2026-04-01 10:26:58.000000000","message":"The nvme list example output table in the code block exceeds reasonable line width (~98 characters). While this is inside a code-block (so Sphinx will not wrap it), it may cause horizontal scrolling in some documentation renderers and PDF builds.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: In PDF output, wide tables in code blocks can overflow page margins, making them unreadable without scrolling. In HTML, some themes may clip wide content.\n\n**Suggestion**:\nConsider breaking the nvme list output into a more compact form, using fewer columns, or adding a note that the output may wrap. Alternatively, restructure as a list format rather than relying on the raw table layout.","commit_id":"23acd3c8d14fab814a56c24158aad4d8f1c49ae2"},{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"b892d852_25e2636a","line":3,"updated":"2026-04-10 07:32:21.000000000","message":"RST section header underline length mismatches will produce Sphinx warnings. The title on line 2 has 42 chars but the underline on line 3 is 45 chars. Similar mismatches occur at lines 116, 157, 235, 283, 369, 375, and 382.\n\n**Severity**: WARNING | **Confidence**: 1.0\n\n**Impact**: Sphinx will emit SEVERE/WARNING messages during doc builds. In CI, this can cause documentation job failures if warnings are treated as errors.\n\n**Suggestion**:\nMake each section underline match the title length exactly. For example, line 3 should be 42 \u0027\u003d\u0027 characters instead of 45. Run `doc8` or `sphinx-build -W` locally to verify.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"},{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"7ce96bde_734acd45","line":108,"updated":"2026-04-10 07:32:21.000000000","message":"The document explains the shutdown/start cycle twice (lines 68-84 for vIOMMU, lines 138-154 for NVMe devices) with identical steps. Users following the guide sequentially would shut down, start for vIOMMU, then immediately shut down again for NVMe.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: A smoother user experience by combining both configuration changes into a single VM stop/edit/start cycle.\n\n**Recommendation**:\nConsider restructuring to apply vIOMMU and NVMe configuration in a single edit session, or add a note after the vIOMMU start step suggesting users proceed to the NVMe section without starting the VM in between.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"},{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"44f77693_86fe891d","line":169,"updated":"2026-04-10 07:32:21.000000000","message":"The `chown qemu:qemu` instruction at line 169 may be incorrect for Ubuntu 24.04 (the OS specified in the VM XML). On Debian/Ubuntu the QEMU process typically runs as `libvirt-qemu` or `qemu` depending on the libvirt version.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Users following the guide on Ubuntu 24.04 may get a \u0027invalid user\u0027 error when running the chown command, which would prevent the NVMe backing file from being accessible to QEMU.\n\n**Suggestion**:\nVerify the correct QEMU user for Ubuntu 24.04 (likely `libvirt-qemu:kvm` or check with `ps aux | grep qemu`). Consider adding a note that the user may differ by distribution, or use `sudo qemu-img create` which often handles ownership automatically when run as root.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"},{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"bc0ca0a2_1ac327c8","line":235,"updated":"2026-04-10 07:32:21.000000000","message":"RST section header underline at line 235 is 26 chars but title \u0027Verify NVMe Devices in VM\u0027 is 25 chars (off by 1).\n\n**Severity**: WARNING | **Confidence**: 1.0\n\n**Impact**: Sphinx warning during documentation build. May fail CI doc jobs with -W flag.\n\n**Suggestion**:\nChange the underline to 25 \u0027\u003d\u0027 characters to match the title length.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"},{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"a6288ce4_a01e3180","line":283,"updated":"2026-04-10 07:32:21.000000000","message":"RST section header underline at line 283 is 33 chars but title \u0027Configure PCI Driver in DevStack\u0027 is 32 chars (off by 1).\n\n**Severity**: WARNING | **Confidence**: 1.0\n\n**Impact**: Sphinx warning during documentation build.\n\n**Suggestion**:\nChange the underline to 32 \u0027\u003d\u0027 characters to match the title length.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"},{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"cff306e7_5ed1a4fb","line":386,"updated":"2026-04-10 07:32:21.000000000","message":"There is an extra blank line between the `.. code-block:: console` directive and the code content (lines 385-386). While valid RST, it creates unnecessary vertical spacing in rendered output.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Cleaner rendered documentation with consistent code block spacing throughout the document.\n\n**Recommendation**:\nRemove the extra blank line at line 386 so there is exactly one blank line between the directive and the indented code content, matching the pattern used in all other code blocks in this document.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"},{"robot_id":"zuul","robot_run_id":"2e72c72c403b4b0da86bb2e37b061545","url":"https://zuul.teim.app/t/main/buildset/2e72c72c403b4b0da86bb2e37b061545","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"294cb2c0268f9ae20de21a420856dac14bae9f50","patch_set":8,"id":"26b53cf5_e4bcce8b","line":401,"updated":"2026-04-10 07:32:21.000000000","message":"The document explains each NVMe QEMU parameter in detail, which is excellent. However, the NVMe device type is reported as \u0027GPU\u0027 by the PCI driver, which is confusing. The existing note could be expanded.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Users would understand that the GPU label is a known Cyborg PCI driver behavior rather than a misconfiguration on their part.\n\n**Recommendation**:\nExpand the existing note on line 401-402 with a brief sentence explaining that the PCI driver currently classifies all devices generically, and link to any relevant bug or blueprint tracking proper NVMe type classification if one exists.","commit_id":"988dd82e2f1f1f1460a45e6c995da91bf628253c"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"6fd52ce0_dbb9a8f0","line":1,"updated":"2026-04-10 10:07:47.000000000","message":"The commit subject line is 56 characters, exceeding the OpenStack 50-character limit.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Following the 50-character subject line convention maintains consistency with OpenStack commit message standards.\n\n**Recommendation**:\nShorten the commit subject to 50 characters or fewer. For example: \u0027Add Cyborg NVMe driver dev env documentation\u0027 (45 chars) or \u0027Add NVMe driver development environment docs\u0027 (44 chars).","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"1604fbc3_f8fe7183","line":128,"updated":"2026-04-10 10:07:47.000000000","message":"The guide mentions the VM was created with Q35 machine type but does not explain why Q35 is important for NVMe/PCI passthrough testing (it provides PCIe support needed for NVMe).\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Users would understand the architectural requirement for Q35 vs i440fx and why the NVMe setup may not work on older machine types.\n\n**Recommendation**:\nAdd a brief note in the Prerequisites or Scope section explaining that the Q35 machine type (used in the VM setup guide) provides the PCIe bus topology needed for NVMe device attachment, and that i440fx-based VMs may not support NVMe passthrough correctly.","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"545c5c9a_e1c6bbf6","line":163,"updated":"2026-04-10 10:07:47.000000000","message":"The guide references a 10G qcow2 disk image for NVMe backing storage but does not explain whether the size matters for testing or how to adjust it.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Users would understand whether the 10G size is significant for their testing needs or if a smaller size would suffice for development purposes.\n\n**Recommendation**:\nAdd a note near the qemu-img create command explaining that 10G is a reasonable default for testing but can be adjusted. A smaller size (e.g., 1G) is sufficient for basic device discovery testing since the actual data storage is not used by Cyborg.","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"6536f06f_484754ba","line":169,"updated":"2026-04-10 10:07:47.000000000","message":"The documentation instructs users to run \u0027chown qemu:qemu\u0027 on Ubuntu, but the default libvirt user on Ubuntu is \u0027libvirt-qemu\u0027, not \u0027qemu\u0027. This will fail on the Ubuntu 24.04 setup described in the VM XML.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: Users following the guide on Ubuntu will get a \u0027chown: invalid user: qemu:qemu\u0027 error and the NVMe backing file will not have correct ownership, potentially causing VM startup failure.\n\n**Priority**: Before merge\n**Why This Matters**: The guide targets Ubuntu 24.04 (as shown in the VM XML os id) but uses Fedora/RHEL user/group names for the chown command. This is a factual error that will block users.\n\n**Recommendation**:\nChange \u0027sudo chown qemu:qemu\u0027 to \u0027sudo chown libvirt-qemu:libvirt-qemu\u0027 on line 169. Alternatively, add a note explaining the difference between distributions (qemu:qemu on Fedora/RHEL, libvirt-qemu:libvirt-qemu on Ubuntu/Debian) and recommend users verify with \u0027ls -la /var/lib/libvirt/images/\u0027.","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"c7165ccc_20d24075","line":188,"updated":"2026-04-10 10:07:47.000000000","message":"The documentation uses the qemu:commandline approach for NVMe devices which bypasses libvirt device management. While this works, it is considered a legacy approach and may not work with newer libvirt versions that restrict QEMU command-line passthrough.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Users may encounter issues with newer libvirt versions or distributions that restrict the qemu:commandline element. The guide does not mention this limitation or potential alternatives.\n\n**Suggestion**:\nAdd a \u0027.. note::\u0027 block after the qemu:commandline configuration explaining that this is a development/testing approach and that production environments should use libvirt-native NVMe device attachment. Mention that users may need to set \u0027namespaces\u0027 in /etc/libvirt/qemu.conf to enable the QEMU namespace on some distributions.","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"7dd7f649_9f9ba8bc","line":270,"updated":"2026-04-10 10:07:47.000000000","message":"The RST file contains several lines exceeding reasonable documentation widths (up to 144 chars) in console output blocks. While RST does not enforce line length like Python, very long lines can be difficult to read in text editors.\n\n**Severity**: SUGGESTION | **Confidence**: 0.6\n\n**Benefit**: Keeping line lengths reasonable in documentation source files improves readability for contributors editing the files directly.\n\n**Recommendation**:\nConsider whether the nvme list and accelerator device list output tables need to be included at full width, or if a truncated/example format would suffice. For the accelerator device list table, showing 2-3 columns with ellipsis for the rest may be cleaner.","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"88d87d33_07f3e528","line":385,"updated":"2026-04-10 10:07:47.000000000","message":"There is a double blank line after the \u0027.. code-block:: console\u0027 directive at line 384, which can cause rendering inconsistencies in some docutils/Sphinx versions.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: The extra blank line between the code-block directive and the indented content may cause the code block to render incorrectly or produce a build warning in some Sphinx configurations.\n\n**Suggestion**:\nRemove the extra blank line at line 386 so there is exactly one blank line between the \u0027.. code-block:: console\u0027 directive and the indented code content.","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"cecb1c64_8ccf3be8","line":398,"updated":"2026-04-10 10:07:47.000000000","message":"The \u0027accelerator device list\u0027 command output shows the NVMe device typed as \u0027GPU\u0027 which is misleading. While the doc notes this is expected behavior, it may confuse users trying to verify NVMe-specific functionality.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Users may think the device was misclassified or that the PCI driver is not working correctly for NVMe devices specifically. The note is present but could be more prominent.\n\n**Suggestion**:\nConsider moving the GPU type note to a \u0027.. note::\u0027 directive with more detail about why this happens (the PCI driver currently maps NVMe devices to the GPU type category). This would make it more visible and explain the underlying cause rather than just stating it is expected.","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"},{"robot_id":"zuul","robot_run_id":"5fa96e56713344a6ba1aea9d75d54950","url":"https://zuul.teim.app/t/main/buildset/5fa96e56713344a6ba1aea9d75d54950","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2622727a5432394e52982717cf9435c531ac2a79","patch_set":11,"id":"4d7fda93_b60e32f2","line":411,"updated":"2026-04-10 10:07:47.000000000","message":"The troubleshooting section could benefit from additional guidance for common issues such as QEMU namespace errors and SELinux/AppArmor denials.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Users encountering permission or namespace errors would have a clear path to resolution without needing to search external resources.\n\n**Recommendation**:\nConsider adding troubleshooting items for: (1) \u0027qemu: namespace error\u0027 -- check /etc/libvirt/qemu.conf namespaces setting, (2) SELinux/AppArmor denials -- check audit logs and set appropriate contexts on the NVMe disk image, (3) VM fails to start -- verify the qcow2 image exists and has correct ownership.","commit_id":"1078415cd4263ac882844bfc037e3cdbb52181b1"}],"doc/source/contributor/vm-setup.rst":[{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"f4f185b7_a818f745","line":23,"updated":"2026-04-01 10:13:05.000000000","message":"The vm-setup.rst file references \u002716GB+ RAM\u0027 in prerequisites (line 23) but the virt-install command allocates only 12GB (--ram 12288) to the guest VM. The host needs 16GB+ for the host OS plus the VM, but this could be clearer.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Users with exactly 16GB host RAM may be confused because the VM alone uses 12GB, leaving only 4GB for the host.\n\n**Suggestion**:\nAdd a clarifying note such as: \u0027(The host needs 16GB+ total -- the VM uses 12GB, leaving 4GB+ for the host system.)\u0027","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"0f90e5db26f5495b8ec9d6657def76d8","url":"https://zuul.teim.app/t/main/buildset/0f90e5db26f5495b8ec9d6657def76d8","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"209e6f4f307d2470e970f67ccf6218842fd4bf2e","patch_set":5,"id":"ab4c6c87_e2421d03","line":154,"updated":"2026-04-01 10:13:05.000000000","message":"vm-setup.rst has 4 lines exceeding doc8\u0027s 79-character limit. Line 366 has a QEMU URL reference at 92 chars. Lines 154, 273, 367 are also over 79 chars.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: CI failure: doc8 will flag these lines, potentially causing build failures.\n\n**Priority**: Before merge\n**Why This Matters**: Same doc8 enforcement as nvme-driver.rst. While fewer violations, they will still be caught by CI.\n\n**Recommendation**:\nWrap line 154 (the wget URL) by breaking the URL across lines if possible, or restructure the command. Wrap line 273 (domifaddr output example) across multiple lines. Wrap line 366 (QEMU URL) by splitting the inline link reference across lines.","commit_id":"fc63ddb8e5eae62cceffad1f8cc4035540a3bbb1"},{"robot_id":"zuul","robot_run_id":"d88d16eec7494ca8944a1c3f5949d895","url":"https://zuul.teim.app/t/main/buildset/d88d16eec7494ca8944a1c3f5949d895","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"df6376cbe83bf796d87bf5d289b54fa53dde0a07","patch_set":6,"id":"3644b3ae_ec724087","line":49,"updated":"2026-04-01 10:26:58.000000000","message":"The vm-setup.rst guide only covers Intel processors for nested virtualization (VMX) and IOMMU (intel_iommu). AMD processors (AMD-V / SVM, amd_iommu) are not mentioned at all.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Contributors using AMD hardware will not find the necessary guidance and may assume the guide does not support their platform, reducing its usefulness.\n\n**Suggestion**:\nAdd a subsection or parallel instructions for AMD processors: check svm in /proc/cpuinfo, verify kvm_amd nested parameter, and use amd_iommu\u003don iommu\u003dpt in GRUB_CMDLINE_LINUX.","commit_id":"23acd3c8d14fab814a56c24158aad4d8f1c49ae2"},{"robot_id":"zuul","robot_run_id":"d88d16eec7494ca8944a1c3f5949d895","url":"https://zuul.teim.app/t/main/buildset/d88d16eec7494ca8944a1c3f5949d895","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"df6376cbe83bf796d87bf5d289b54fa53dde0a07","patch_set":6,"id":"19d79a95_360c56eb","line":167,"updated":"2026-04-01 10:26:58.000000000","message":"The virt-install command in vm-setup.rst uses `--graphics vnc,listen\u003d0.0.0.0` which binds VNC to all interfaces. This is convenient but may be a security concern in shared or networked environments.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Improved security awareness for developers setting up VMs on shared hosts or cloud environments.\n\n**Recommendation**:\nAdd a brief note that VNC listening on 0.0.0.0 is acceptable for local development but should be restricted (e.g., listen\u003d127.0.0.1 or use SSH tunneling) on multi-user hosts.","commit_id":"23acd3c8d14fab814a56c24158aad4d8f1c49ae2"}]}