)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"e5d207943f82d6a23f6ca9f82c33e12ea3620811","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a864e05_95e886ce","updated":"2026-04-14 10:06:21.000000000","message":"overall lgtm, just left a couple minor comments","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4ac99547_a420f8b9","updated":"2026-05-06 12:22:34.000000000","message":"i think this is ok but the scope and orderign fo the doc could be impvoed\n\nim going to swap to otehr reviews for a while and come back to this sereise tomrrow","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"}],"doc/source/contributor/vm-setup.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98144736570fd6d14f114446dd420e531dd4675a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"access to physical hardware with accelerator devices, or when you want to"},{"line_number":11,"context_line":"test in an isolated environment."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The VM created using these instructions provides a foundation suitable for any"},{"line_number":14,"context_line":"Cyborg driver development. Driver-specific device configuration (such as NVMe,"},{"line_number":15,"context_line":"GPU, or FPGA emulation) should be added after following this guide - refer to"},{"line_number":16,"context_line":"the respective driver documentation for device-specific setup."}],"source_content_type":"text/x-rst","patch_set":4,"id":"02b622d8_2c9eb549","line":13,"range":{"start_line":13,"start_character":75,"end_line":13,"end_character":78},"updated":"2026-04-13 10:56:13.000000000","message":"so this is generally not correct.\nmost accelerator loss the ability to use sriov or partitioning when passed to a vm.\n\nso this is valid for a subset of driver but any is overstated.","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"977763f42bfaac18795ec6d5e3a1d7898c0aabf5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"access to physical hardware with accelerator devices, or when you want to"},{"line_number":11,"context_line":"test in an isolated environment."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The VM created using these instructions provides a foundation suitable for any"},{"line_number":14,"context_line":"Cyborg driver development. Driver-specific device configuration (such as NVMe,"},{"line_number":15,"context_line":"GPU, or FPGA emulation) should be added after following this guide - refer to"},{"line_number":16,"context_line":"the respective driver documentation for device-specific setup."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1d60bec7_a0e01849","line":13,"range":{"start_line":13,"start_character":75,"end_line":13,"end_character":78},"in_reply_to":"02b622d8_2c9eb549","updated":"2026-04-28 06:52:30.000000000","message":"Done","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"e5d207943f82d6a23f6ca9f82c33e12ea3620811","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: console"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   $ dmesg | grep -e IOMMU -e DMAR"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"You should see messages indicating IOMMU/DMAR is enabled. If not, you may need"},{"line_number":86,"context_line":"to enable it in your BIOS/UEFI settings and add kernel parameters."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ef0ed8c_37c86eba","line":83,"updated":"2026-04-14 10:06:21.000000000","message":"doesn\u0027t dmesg require elevated privileges in most systems? In all environments I\u0027ve tried I needed them\n \n```suggestion\n   $ sudo dmesg | grep -e IOMMU -e DMAR\n```","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"977763f42bfaac18795ec6d5e3a1d7898c0aabf5","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: console"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   $ dmesg | grep -e IOMMU -e DMAR"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"You should see messages indicating IOMMU/DMAR is enabled. If not, you may need"},{"line_number":86,"context_line":"to enable it in your BIOS/UEFI settings and add kernel parameters."}],"source_content_type":"text/x-rst","patch_set":4,"id":"af1aab18_238269e3","line":83,"in_reply_to":"1ef0ed8c_37c86eba","updated":"2026-04-28 06:52:30.000000000","message":"Done","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"e5d207943f82d6a23f6ca9f82c33e12ea3620811","unresolved":true,"context_lines":[{"line_number":133,"context_line":".. code-block:: console"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"   $ cd /var/lib/libvirt/images/"},{"line_number":136,"context_line":"   $ sudo wget https://releases.ubuntu.com/24.04/ubuntu-24.04-live-server-amd64.iso"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Create VM Using virt-install"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f483542_58f1046e","line":136,"updated":"2026-04-14 10:06:21.000000000","message":"this link is broken, the current one seems to be https://releases.ubuntu.com/24.04/ubuntu-24.04.4-live-server-amd64.iso","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"977763f42bfaac18795ec6d5e3a1d7898c0aabf5","unresolved":false,"context_lines":[{"line_number":133,"context_line":".. code-block:: console"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"   $ cd /var/lib/libvirt/images/"},{"line_number":136,"context_line":"   $ sudo wget https://releases.ubuntu.com/24.04/ubuntu-24.04-live-server-amd64.iso"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Create VM Using virt-install"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c81089b2_6e1ff883","line":136,"in_reply_to":"9f483542_58f1046e","updated":"2026-04-28 06:52:30.000000000","message":"Done","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98144736570fd6d14f114446dd420e531dd4675a","unresolved":true,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   $ sudo qemu-img create -f qcow2 /var/lib/libvirt/images/devstack.qcow2 150G"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Install VM with virt-install"},{"line_number":151,"context_line":"-----------------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Use ``virt-install`` to create and start the VM installation. This command"},{"line_number":154,"context_line":"creates a VM with the necessary configuration for Cyborg development:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":".. code-block:: console"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"   $ sudo virt-install \\"},{"line_number":159,"context_line":"       --name cyborg-devstack \\"},{"line_number":160,"context_line":"       --ram 12288 \\"},{"line_number":161,"context_line":"       --vcpus 4 \\"},{"line_number":162,"context_line":"       --cpu host-passthrough \\"},{"line_number":163,"context_line":"       --machine q35 \\"},{"line_number":164,"context_line":"       --disk path\u003d/var/lib/libvirt/images/devstack.qcow2,bus\u003dvirtio \\"},{"line_number":165,"context_line":"       --os-variant ubuntu24.04 \\"},{"line_number":166,"context_line":"       --network network\u003ddefault,model\u003dvirtio \\"},{"line_number":167,"context_line":"       --graphics vnc,listen\u003d0.0.0.0 \\"},{"line_number":168,"context_line":"       --noautoconsole \\"},{"line_number":169,"context_line":"       --cdrom /var/lib/libvirt/images/ubuntu-24.04-live-server-amd64.iso"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"**Key configuration options:**"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* ``--name cyborg-devstack``: VM name in libvirt"},{"line_number":174,"context_line":"* ``--ram 12288``: 12GB RAM (minimum for DevStack)"},{"line_number":175,"context_line":"* ``--vcpus 4``: 4 virtual CPUs"},{"line_number":176,"context_line":"* ``--cpu host-passthrough``: Pass through host CPU features for nested"},{"line_number":177,"context_line":"  virtualization"},{"line_number":178,"context_line":"* ``--machine q35``: Q35 chipset required for IOMMU and PCIe support"},{"line_number":179,"context_line":"* ``--disk bus\u003dvirtio``: Virtio disk for better performance"},{"line_number":180,"context_line":"* ``--os-variant ubuntu24.04``: OS type for optimized defaults"},{"line_number":181,"context_line":"* ``--network network\u003ddefault``: Use default NAT network with virtio model"},{"line_number":182,"context_line":"* ``--graphics vnc``: VNC console accessible from any IP"},{"line_number":183,"context_line":"* ``--noautoconsole``: Don\u0027t auto-launch console viewer"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Connect to VM Console"},{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Connect to the VM console to complete the installation:"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":".. code-block:: console"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   $ virt-viewer --connect qemu:///system --wait cyborg-devstack"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Key VM Features"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c8078f62_98a7e0b1","line":192,"range":{"start_line":150,"start_character":0,"end_line":192,"end_character":64},"updated":"2026-04-13 10:56:13.000000000","message":"so this is ok but you were ment to rewrite this to use the xmls and virsh define.","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"977763f42bfaac18795ec6d5e3a1d7898c0aabf5","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   $ sudo qemu-img create -f qcow2 /var/lib/libvirt/images/devstack.qcow2 150G"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Install VM with virt-install"},{"line_number":151,"context_line":"-----------------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Use ``virt-install`` to create and start the VM installation. This command"},{"line_number":154,"context_line":"creates a VM with the necessary configuration for Cyborg development:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":".. code-block:: console"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"   $ sudo virt-install \\"},{"line_number":159,"context_line":"       --name cyborg-devstack \\"},{"line_number":160,"context_line":"       --ram 12288 \\"},{"line_number":161,"context_line":"       --vcpus 4 \\"},{"line_number":162,"context_line":"       --cpu host-passthrough \\"},{"line_number":163,"context_line":"       --machine q35 \\"},{"line_number":164,"context_line":"       --disk path\u003d/var/lib/libvirt/images/devstack.qcow2,bus\u003dvirtio \\"},{"line_number":165,"context_line":"       --os-variant ubuntu24.04 \\"},{"line_number":166,"context_line":"       --network network\u003ddefault,model\u003dvirtio \\"},{"line_number":167,"context_line":"       --graphics vnc,listen\u003d0.0.0.0 \\"},{"line_number":168,"context_line":"       --noautoconsole \\"},{"line_number":169,"context_line":"       --cdrom /var/lib/libvirt/images/ubuntu-24.04-live-server-amd64.iso"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"**Key configuration options:**"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* ``--name cyborg-devstack``: VM name in libvirt"},{"line_number":174,"context_line":"* ``--ram 12288``: 12GB RAM (minimum for DevStack)"},{"line_number":175,"context_line":"* ``--vcpus 4``: 4 virtual CPUs"},{"line_number":176,"context_line":"* ``--cpu host-passthrough``: Pass through host CPU features for nested"},{"line_number":177,"context_line":"  virtualization"},{"line_number":178,"context_line":"* ``--machine q35``: Q35 chipset required for IOMMU and PCIe support"},{"line_number":179,"context_line":"* ``--disk bus\u003dvirtio``: Virtio disk for better performance"},{"line_number":180,"context_line":"* ``--os-variant ubuntu24.04``: OS type for optimized defaults"},{"line_number":181,"context_line":"* ``--network network\u003ddefault``: Use default NAT network with virtio model"},{"line_number":182,"context_line":"* ``--graphics vnc``: VNC console accessible from any IP"},{"line_number":183,"context_line":"* ``--noautoconsole``: Don\u0027t auto-launch console viewer"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Connect to VM Console"},{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Connect to the VM console to complete the installation:"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":".. code-block:: console"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   $ virt-viewer --connect qemu:///system --wait cyborg-devstack"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Key VM Features"}],"source_content_type":"text/x-rst","patch_set":4,"id":"32026af9_2b0bd589","line":192,"range":{"start_line":150,"start_character":0,"end_line":192,"end_character":64},"in_reply_to":"c8078f62_98a7e0b1","updated":"2026-04-28 06:52:30.000000000","message":"Done","commit_id":"e280f8c6142661b650eede8b7ec6ca04651262b1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":44,"context_line":"Your host system must support nested virtualization to run VMs inside the"},{"line_number":45,"context_line":"development VM."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"For Intel processors, check VMX (Virtual Machine Extensions):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. code-block:: console"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"cce893cc_6135bac5","line":47,"in_reply_to":"73c19787_51235fe2","updated":"2026-05-06 12:22:34.000000000","message":"same commen here and belove we can make tihs vendor neutroal by inlcuding the amd optiosn\n\n\nwith that said ethis is a little less relevent given the linux kernel had defaulted nested virt to on for a number of years.","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"   # For Intel processors"},{"line_number":60,"context_line":"   $ cat /sys/module/kvm_intel/parameters/nested"},{"line_number":61,"context_line":"   Y"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"If the value is ``N`` or ``0``, enable it:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. code-block:: console"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   # For Intel"},{"line_number":68,"context_line":"   $ sudo modprobe -r kvm_intel"},{"line_number":69,"context_line":"   $ sudo modprobe kvm_intel nested\u003d1"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Verify IOMMU Support"},{"line_number":72,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e0e5ea67_3689256a","line":69,"range":{"start_line":61,"start_character":1,"end_line":69,"end_character":37},"updated":"2026-05-06 12:22:34.000000000","message":"if we are going to document this at all we should document how to create the persistent file so that it works across reboots.\n\nit actually may generally better to link to https://github.com/openstack/devstack/blob/master/doc/source/guides/devstack-with-nested-kvm.rst\n\ninstead of duplicating ti here","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":68,"context_line":"   $ sudo modprobe -r kvm_intel"},{"line_number":69,"context_line":"   $ sudo modprobe kvm_intel nested\u003d1"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Verify IOMMU Support"},{"line_number":72,"context_line":"--------------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"IOMMU (Input-Output Memory Management Unit) is required for device passthrough"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ac2e07c8_c464ce6f","line":71,"range":{"start_line":71,"start_character":3,"end_line":71,"end_character":20},"updated":"2026-05-06 12:22:34.000000000","message":"this need a call out that its for inside the vm not the host.\nor perhaps we shoudl note its for the environment where devstack is run.","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. code-block:: console"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"   # For Intel processors"},{"line_number":91,"context_line":"   $ sudo vim /etc/default/grub"},{"line_number":92,"context_line":"   # Add to GRUB_CMDLINE_LINUX: intel_iommu\u003don iommu\u003dpt"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"82693acf_8aad0402","line":90,"in_reply_to":"aca00646_e61f4563","updated":"2026-05-06 12:22:34.000000000","message":"\u003e The IOMMU section only provides Intel-specific GRUB parameters (intel_iommu\u003don). AMD systems use amd_iommu\u003don instead.\n\u003e \n\u003e **Severity**: WARNING | **Confidence**: 0.9\n\u003e \n\u003e **Impact**: AMD users will add incorrect kernel parameters that have no effect on their system, leaving IOMMU disabled and passthrough non-functional.\n\u003e \n\u003e **Suggestion**:\n\u003e Show both Intel and AMD GRUB parameters:\n\u003e - Intel: `intel_iommu\u003don iommu\u003dpt`\n\u003e - AMD: `amd_iommu\u003don iommu\u003dpt`\n\nthis is valid.\n\nthe `# For intel processors`  should likely be remvoe or update to x86 processors\n\nto refer to the architecture not the vendor.","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":98,"context_line":"   $ sudo update-grub"},{"line_number":99,"context_line":"   $ sudo reboot"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Install Required Packages"},{"line_number":102,"context_line":"--------------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Install QEMU, libvirt, and related tools:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"4ca7c55c_15d33642","line":101,"updated":"2026-05-06 12:22:34.000000000","message":"here we swapping abck to the hsot setupp so the iommu discsion above is a bit confusing.","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":148,"context_line":"Create VM Disk Image"},{"line_number":149,"context_line":"--------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Create a 150GB qcow2 disk image for the VM:"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. code-block:: console"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"c71c18b6_6ba31035","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":14},"updated":"2026-05-06 12:22:34.000000000","message":"so i guess that is requrieed to provde extra spec for the nvme device\n\nbut normlly you only need 25-50G for a compute node and 50-80 for a all-in-one or contoler node so \n150G is a lot for a devstack vm.\n\nwe shoudl default to 50 here in my opinion.","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"* **Q35 machine type**: Required for IOMMU and PCIe device passthrough"},{"line_number":250,"context_line":"* **host-passthrough CPU**: Provides nested virtualization support"},{"line_number":251,"context_line":"* **12GB RAM, 4 vCPUs**: Minimum resources for DevStack"},{"line_number":252,"context_line":"* **UEFI firmware (OVMF)**: Manages boot order via NVRAM; boots the installer"},{"line_number":253,"context_line":"  ISO on first start, then automatically boots the installed system after"},{"line_number":254,"context_line":"  the ISO is ejected"}],"source_content_type":"text/x-rst","patch_set":7,"id":"c7bfc89f_63ef944d","line":251,"range":{"start_line":251,"start_character":0,"end_line":251,"end_character":55},"updated":"2026-05-06 12:22:34.000000000","message":"technically its 8G ram for the contoller/all-in-one and 4G for compute\nwith 4 cores as a minium but typically 8","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":".. code-block:: console"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"   $ ssh stack@192.168.122.100"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Reclaim Disk Space"},{"line_number":293,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"35ef6bdf_dee48a1c","line":290,"in_reply_to":"ada59331_cc23d68c","updated":"2026-05-06 12:22:34.000000000","message":"thats true for cloud image but if you follow the procedure above we are installing form the iso so there is no defautl username\n\nstack is the defautl user we use in devstack when not using a cloud image so i think stack is fine.\n\nwe need to decied how to prhase \nhttps://review.opendev.org/c/openstack/cyborg/+/983964/7/doc/source/contributor/vm-setup.rst#228\n\n\nif we used stack there then the home directory woudl not be /opt/stack for that use which is fine, devstack does nto requrie that butits just something to consider.","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"9b621edb07493113a9e007826e9e5872ffa5b427","unresolved":true,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":".. code-block:: console"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"   $ ssh stack@192.168.122.100"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Reclaim Disk Space"},{"line_number":293,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ada59331_cc23d68c","line":290,"in_reply_to":"b86c69ad_cb2c6264","updated":"2026-05-06 11:02:28.000000000","message":"\u003e The SSH example uses \u0027stack\u0027 as the username, but the Ubuntu installation steps never mention creating a user named \u0027stack\u0027. This is inconsistent with the installation instructions.\n\u003e \n\u003e **Severity**: SUGGESTION | **Confidence**: 0.8\n\u003e \n\u003e **Benefit**: Users who follow the installation steps literally will create their own username, then find the SSH example does not match. This creates friction in the onboarding flow.\n\u003e \n\u003e **Recommendation**:\n\u003e Either update the SSH example to use a generic placeholder like `ssh \u003cusername\u003e@192.168.122.100`, or add a note in the installation steps recommending the username \u0027stack\u0027 for consistency with DevStack conventions.\nThis is a good point, by default the ubuntu vm\u0027s username is `ubuntu`","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8841937a79b8df963b03c0c5158731832deb8a92","unresolved":true,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"   $ ssh stack@192.168.122.100"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Reclaim Disk Space"},{"line_number":293,"context_line":"------------------"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"The Ubuntu installer may not use all available disk space. Extend the logical"}],"source_content_type":"text/x-rst","patch_set":7,"id":"cf1fc9d5_0e3bea68","line":292,"range":{"start_line":292,"start_character":0,"end_line":292,"end_character":18},"updated":"2026-05-06 12:22:34.000000000","message":"this is something you chosse when doiogn the install\n\nso i dont really think this is that relevent.\n\nwe can not this but its not ubuntu specific\n\nthis feels a bit out of scope fo the doc","commit_id":"62d559354b986ffe8caea29dc40a65ca1e103a1e"}]}