)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"36e866975d7d515f1a95fac11791f843fb77e0f9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  - repo: https://opendev.org/openstack/bashate"},{"line_number":61,"context_line":"    rev: 2.1.1"},{"line_number":62,"context_line":"    hooks:"},{"line_number":63,"context_line":"      - id: bashate"},{"line_number":64,"context_line":"        description: This hook runs bashate for linting shell scripts"},{"line_number":65,"context_line":"        types: [shell]"},{"line_number":66,"context_line":"        entry: bashate"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7b6438c3_40152dd1","line":63,"updated":"2026-07-21 13:39:04.000000000","message":"The commit message claims the bashate hook runs \u0027only on shell scripts in the devstack/ directory,\u0027 but the actual files pattern in .pre-commit-config.yaml is ^(devstack|pci-sim)/, which also covers the pci-sim/ directory. This inaccuracy could mislead future contributors who add scripts under pc...\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Future contributors reading the commit history may be surprised that bashate also covers pci-sim/ scripts. Low operational impact since the configuration itself is correct; only the commit message description is inaccurate.\n\n**Recommendation**:\nUpdate the commit message to state the hook covers both devstack/ and pci-sim/ directories, e.g.: \u0027The bashate hook is configured to run on shell scripts in the devstack/ and pci-sim/ directories.\u0027","commit_id":"959840640cd9f04d3349389bb84fc4bc51775890"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bcc9bea0b54d0d67eeec92049360ac4293845684","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7338cd1c_7d81388b","updated":"2026-07-09 20:05:51.000000000","message":"we should probaly pick this back up and add it but not a huge priortiy","commit_id":"4ca09f752da0b7516f8da1ccdb82ef8ad939ce26"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"625c886675443f1e4cada795598cf953dfbfce37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f1b957f8_ebced543","updated":"2026-07-21 15:28:32.000000000","message":"do we need https://review.opendev.org/c/openstack/cyborg/+/979788 anymore?","commit_id":"959840640cd9f04d3349389bb84fc4bc51775890"}],"devstack/plugin.sh":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"c48d225219a02cfc6defe7680a2458125cff4ca5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                # services have been started."},{"line_number":49,"context_line":"                # Configure pci-sim Cyborg service settings before starting"},{"line_number":50,"context_line":"                # the agent so it picks up pci_driver and passthrough_whitelist."},{"line_number":51,"context_line":"                if [[ \"$ENABLE_PCI_SIM\" \u003d\u003d True \u0026\u0026 \"$PCI_SIM_LOAD\" \u003d\u003d True ]]; then"},{"line_number":52,"context_line":"                    configure_pci_sim_cyborg_service_config"},{"line_number":53,"context_line":"                fi"},{"line_number":54,"context_line":"                # Initialize cyborg"}],"source_content_type":"text/x-sh","patch_set":3,"id":"437613fc_829efba8","line":51,"updated":"2026-07-21 12:55:34.000000000","message":"The patch adds bashate linting and claims to resolve all violations including E006, but line 51 of devstack/plugin.sh still exceeds the 79-character limit at 83 characters. Running bashate 2.1.1 on this file reports \u0027E006 Line too long\u0027.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: The newly added bashate pre-commit hook will emit an E006 warning every time devstack/plugin.sh is modified. The commit message is inaccurate in claiming all violations are resolved.\n\n**Recommendation**:\nBreak line 51 to stay within 79 characters, e.g.:\\n if [[ \"$ENABLE_PCI_SIM\" \u003d\u003d True \u0026\u0026 \\\\ \"$PCI_SIM_LOAD\" \u003d\u003d True ]]; then","commit_id":"90c127134f29da451be1e342371510ce31c68353"}],"pci-sim/run_fake_pci_qemu_vfio_smoke.sh":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"e0f8a9c8cc2ee2c24b4f7c19ba54bdd20ff0afca","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"msg \"bind VF to pci_sim_vfio_pci\""},{"line_number":114,"context_line":"sudo -n modprobe vfio-pci"},{"line_number":115,"context_line":"unsafe_int\u003d/sys/module/vfio_iommu_type1/parameters/allow_unsafe_interrupts"},{"line_number":116,"context_line":"if [ \"$ALLOW_UNSAFE_INTERRUPTS\" \u003d 1 ] \u0026\u0026 [ -e \"$unsafe_int\" ]; then"},{"line_number":117,"context_line":"    msg \"enable vfio_iommu_type1.allow_unsafe_interrupts for nested test VM\""},{"line_number":118,"context_line":"    echo Y | sudo -n tee \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"a54559fe_5d06fc62","line":115,"updated":"2026-07-21 10:14:44.000000000","message":"The patch introduces a new variable `unsafe_int` for the vfio_iommu_type1 allow_unsafe_interrupts sysfs path, uses it in the condition check, but then the tee command on the next lines uses the full hardcoded path instead of the variable, creating a maintainability risk.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: If the sysfs path ever changes, two locations need updating. The variable gives a false sense of single-source-of-truth since it only covers the condition, not the tee command.\n\n**Recommendation**:\nReplace the hardcoded path in the tee command with `\"$unsafe_int\"` to use the variable consistently, or remove the variable if the goal was only to shorten the condition line.","commit_id":"f71fc5ccda31622aabaec6f1cb12b1001ea52607"}]}