)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ec27f77fc648f81d7c3d4d32da70b39e52db6284","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2577b539_0413caaa","updated":"2026-04-28 13:47:30.000000000","message":"Do we need some unittest for this change?","commit_id":"5ea046df246188690d9e4ec9066ac5fb5a3ada4f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"9ee4395f6cb0f390f17ed7a5e794960988d746ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"221c37e1_c102ab11","updated":"2026-04-29 02:38:58.000000000","message":"Is this trait only stored in the Cyborg database?","commit_id":"5ea046df246188690d9e4ec9066ac5fb5a3ada4f"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"df00ddd1860e5698cfbc655d7c733a74a2c671ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0cec8b23_3c4e7ab0","updated":"2026-04-29 02:30:14.000000000","message":"Will this trait affect vm scheduling? Does the Nova project need to be modified?","commit_id":"5ea046df246188690d9e4ec9066ac5fb5a3ada4f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d7d3c305d24f9e392d4e056851d755231338fe3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b448572b_4ef29dca","in_reply_to":"0cec8b23_3c4e7ab0","updated":"2026-05-05 10:09:01.000000000","message":"Nope, OWNER_CYBORG is the resource provider managed by cyborg only. . Nova has zero references to OWNER_CYBORG in its codebase https://github.com/search?q\u003drepo%3Aopenstack%2Fnova%20OWNER_CYBORG\u0026type\u003dcode It will not affect vm scheduling","commit_id":"5ea046df246188690d9e4ec9066ac5fb5a3ada4f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d7d3c305d24f9e392d4e056851d755231338fe3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0407997_93817395","in_reply_to":"221c37e1_c102ab11","updated":"2026-05-05 10:09:01.000000000","message":"Yes, it is stored in the cyborg attribute table in cyborg database. \n\nThe NVIDIA GPU driver (https://github.com/openstack/cyborg/blob/f111946df6713aa64efa29dd025d47839241c529/cyborg/accelerator/drivers/gpu/nvidia/sysinfo.py#L54) already uses OWNER_CYBORG in the same way. This patch makes the PCI\n  ▎ driver consistent with it.","commit_id":"5ea046df246188690d9e4ec9066ac5fb5a3ada4f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ea427074a7e4e0e15cc27e6135dc320465554c0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a4ee53e_65c275c4","in_reply_to":"2577b539_0413caaa","updated":"2026-04-28 13:48:24.000000000","message":"and a release note?","commit_id":"5ea046df246188690d9e4ec9066ac5fb5a3ada4f"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"b6c437e4300faadcd65fc16168dc70af06ea1161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"22c29f6e_280c0b03","updated":"2026-05-08 12:01:58.000000000","message":"lgtm, thanks","commit_id":"4d8316e8e877ef0c59b049504f3a2196c30aeafa"}],"cyborg/accelerator/drivers/pci/pci/sysinfo.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ffc38ba804dfbb22faf8a652ef0557d1635c9756","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    Example PGPU traits:"},{"line_number":55,"context_line":"    {traits:[\"OWNER_CYBORG\", \"CUSTOM_PCI_1EB8\"]}"},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":"    traits \u003d [\"OWNER_CYBORG\"]"},{"line_number":58,"context_line":"    vendor_name \u003d pci_utils.VENDOR_MAPS.get(vendor_id)"},{"line_number":59,"context_line":"    if vendor_name:"},{"line_number":60,"context_line":"        traits.append(\"CUSTOM_PCI_\" + vendor_name.upper())"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5ad6763_17040842","line":57,"in_reply_to":"478062bd_4581cca0","updated":"2026-04-28 14:21:36.000000000","message":"\u003e Consider defining OWNER_CYBORG as a named constant in cyborg.common.constants rather than using a bare string literal.\n\u003e \n\u003e **Severity**: SUGGESTION | **Confidence**: 0.8\n\u003e \n\u003e **Benefit**: A named constant prevents typos and makes it easier to grep for all usages across the codebase. The NVIDIA GPU driver uses the same string literal.\n\u003e \n\u003e **Recommendation**:\n\u003e Add OWNER_CYBORG \u003d \u0027OWNER_CYBORG\u0027 to cyborg/common/constants.py and import it in both pci/sysinfo.py and gpu/nvidia/sysinfo.py. This is a follow-up improvement, not a blocker for this patch.\nI think this suggestion is good. Even though it\u0027s unlikely that we need to change the actual string it signals that is not a driver-dependant trait, but a global one for all drivers","commit_id":"5ea046df246188690d9e4ec9066ac5fb5a3ada4f"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"b6c437e4300faadcd65fc16168dc70af06ea1161","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    Example PGPU traits:"},{"line_number":55,"context_line":"    {traits:[\"OWNER_CYBORG\", \"CUSTOM_PCI_1EB8\"]}"},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":"    traits \u003d [\"OWNER_CYBORG\"]"},{"line_number":58,"context_line":"    vendor_name \u003d pci_utils.VENDOR_MAPS.get(vendor_id)"},{"line_number":59,"context_line":"    if vendor_name:"},{"line_number":60,"context_line":"        traits.append(\"CUSTOM_PCI_\" + vendor_name.upper())"}],"source_content_type":"text/x-python","patch_set":1,"id":"54ed77d4_12c21de2","line":57,"in_reply_to":"e5ad6763_17040842","updated":"2026-05-08 12:01:58.000000000","message":"Done","commit_id":"5ea046df246188690d9e4ec9066ac5fb5a3ada4f"}]}