)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7f6b8b9c4738d2eb4a56477d6dabc89766b28e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"995b7fbe_5c2ca640","updated":"2026-05-14 07:50:27.000000000","message":"lgtm!","commit_id":"53600221477c558401a4b3802abbeb3ddaf948bb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"c5eece76b058ecae0c9396f33b62da7a8c802b5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"98ffec96_384c5dbf","updated":"2026-05-21 09:51:58.000000000","message":"recheck unit tests should be fixed now that https://review.opendev.org/c/openstack/cyborg/+/989165 is merged","commit_id":"53600221477c558401a4b3802abbeb3ddaf948bb"}],"cyborg/accelerator/accelerator.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ba8bb9a4a56901b4eefe8365686e93559b6576c9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from sqlalchemy import Column"},{"line_number":16,"context_line":"from sqlalchemy import Integer"},{"line_number":17,"context_line":"from sqlalchemy import String"},{"line_number":18,"context_line":"from sqlalchemy.orm import declarative_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Base \u003d declarative_base()"}],"source_content_type":"text/x-python","patch_set":2,"id":"617b6ed0_bc1a8648","line":18,"in_reply_to":"3e84fc27_538a61d0","updated":"2026-05-13 09:28:11.000000000","message":"\u003e In accelerator.py, the import style uses a direct import (from sqlalchemy.orm import declarative_base) while models.py uses the qualified orm.declarative_base form. Consider unifying the style for consistency across the codebase.\n\u003e \n\u003e **Severity**: SUGGESTION | **Confidence**: 0.7\n\u003e \n\u003e **Benefit**: Consistent import style improves readability and makes future maintenance easier.\n\u003e \n\u003e **Recommendation**:\n\u003e Either use `from sqlalchemy.orm import declarative_base` consistently in both files, or use the `orm.declarative_base()` qualified form in both. The direct import form in accelerator.py is acceptable since `orm` is not otherwise imported there.\n\nGood suggestion, We would go with `from sqlalchemy import orm` to keep consistent with other file. and change `declarative_base()` to `orm.declarative_base()`","commit_id":"e1e92aa1ad28db6f77408bc11ac3c8a4ea657434"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c1874a1bb29facba39659eec271e6b10b54012f9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from sqlalchemy import Column"},{"line_number":16,"context_line":"from sqlalchemy import Integer"},{"line_number":17,"context_line":"from sqlalchemy import String"},{"line_number":18,"context_line":"from sqlalchemy.orm import declarative_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Base \u003d declarative_base()"}],"source_content_type":"text/x-python","patch_set":2,"id":"63014dbd_a973dba5","line":18,"in_reply_to":"617b6ed0_bc1a8648","updated":"2026-05-13 13:40:02.000000000","message":"Done","commit_id":"e1e92aa1ad28db6f77408bc11ac3c8a4ea657434"}],"requirements.txt":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7f6b8b9c4738d2eb4a56477d6dabc89766b28e52","unresolved":true,"context_lines":[{"line_number":18,"context_line":"oslo.utils\u003e\u003d4.5.0 # Apache-2.0"},{"line_number":19,"context_line":"oslo.versionedobjects\u003e\u003d1.31.2 # Apache-2.0"},{"line_number":20,"context_line":"oslo.policy\u003e\u003d4.5.0 # Apache-2.0"},{"line_number":21,"context_line":"SQLAlchemy\u003e\u003d1.4.0 # MIT"},{"line_number":22,"context_line":"alembic\u003e\u003d0.8.10 # MIT"},{"line_number":23,"context_line":"stevedore\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":24,"context_line":"keystonemiddleware\u003e\u003d4.17.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"04102179_71e569cd","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":10},"updated":"2026-05-14 07:50:27.000000000","message":"fine to bump to 1.4.0 as nova has SQLAlchemy\u003e\u003d1.4.13 (https://opendev.org/openstack/nova/src/branch/master/requirements.txt#L6) and placement has SQLAlchemy\u003e\u003d1.4.0 # MIT (https://opendev.org/openstack/placement/src/branch/master/requirements.txt#L6)","commit_id":"53600221477c558401a4b3802abbeb3ddaf948bb"}]}