)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"69272d6bb34ca2e8675b8cec42c98e7bb2edf1f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0a9aaf5c_a1ec2bf0","updated":"2026-06-10 13:15:23.000000000","message":"thanks Chandan, lgtm","commit_id":"078b0bbb0eef3d3b4197f9dccafeadc609999323"}],"cyborg/agent/manager.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"69272d6bb34ca2e8675b8cec42c98e7bb2edf1f8","unresolved":true,"context_lines":[{"line_number":180,"context_line":"            context, bitstream_uuid, dest_path\u003ddownload_path.name"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            driver \u003d self.fpga_driver.create(driver_name)"},{"line_number":184,"context_line":"            ret \u003d driver.update(controlpath_id, download_path.name)"},{"line_number":185,"context_line":"            LOG.info(\u0027Driver update() API returned %s\u0027, ret)"},{"line_number":186,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"611134aa_324157ee","line":183,"updated":"2026-06-10 13:15:23.000000000","message":"this is out of the scope of the scope of this change, but ideally I think we should ensure all drivers inherit from the `GenericDriver` and we move the logic of this `create` method to a function that searches through the subclasses of the GenericDriver instead of the base fpga one","commit_id":"078b0bbb0eef3d3b4197f9dccafeadc609999323"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"fbdb05925a773fca005371ef3abbbbd972cc0511","unresolved":true,"context_lines":[{"line_number":180,"context_line":"            context, bitstream_uuid, dest_path\u003ddownload_path.name"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            driver \u003d self.fpga_driver.create(driver_name)"},{"line_number":184,"context_line":"            ret \u003d driver.update(controlpath_id, download_path.name)"},{"line_number":185,"context_line":"            LOG.info(\u0027Driver update() API returned %s\u0027, ret)"},{"line_number":186,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5c4e0c74_85b777ad","line":183,"in_reply_to":"611134aa_324157ee","updated":"2026-07-21 04:51:14.000000000","message":"Good point, Added it here: https://review.opendev.org/c/openstack/cyborg/+/998004","commit_id":"078b0bbb0eef3d3b4197f9dccafeadc609999323"}]}