)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"7d1b832b752cbe718483d7ae5ffe40c0183a9d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"acee3a16_1e43ece7","updated":"2026-07-17 11:37:09.000000000","message":"the document is clear and useful, the ci failure is carried from the previous patch in the chain","commit_id":"653667790a008f0fda6066a9d119f386d1d16034"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"38af69d37e449bdead1946e4db7281b5bcb55019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"821059fa_7a657b8b","updated":"2026-08-24 11:24:20.000000000","message":"over all, it\u0027s a nice addition.","commit_id":"d9657f63f43fbd26bf3fc22659b08f603e6c157e"}],"doc/source/configuration/drivers/pci.rst":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bb3206423d59386bc1a2d2bcd6f8b917f7d2a06d","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. code-block:: shell"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"   $ openstack accelerator device profile create generic-pci.json"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Create a Nova flavor that requests the device profile:"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8312a860_42f9db1e","line":136,"updated":"2026-07-09 22:06:08.000000000","message":"The command \u0027openstack accelerator device profile create generic-pci.json\u0027 passes a single filename argument. The established CLI syntax, as documented elsewhere in the same project (doc/source/user/using-cyborg.rst), takes two positional arguments: a profile name and an inline JSON body. The com...\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Operators following this guide would encounter a CLI error or unexpected behavior when trying to create a device profile, as the command syntax does not match the actual cyborgclient CLI interface.\n\n**Suggestion**:\nReplace the command with the established two-argument form, e.g.: \u0027openstack accelerator device profile create generic-pci \\\\\u0027 [{\"resources:CUSTOM_PCI\": 1}] \\\u0027\u0027. Alternatively, if the JSON block shown above (lines 119-130) is intended, reference it inline rather than as a filename.","commit_id":"653667790a008f0fda6066a9d119f386d1d16034"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"7d1b832b752cbe718483d7ae5ffe40c0183a9d92","unresolved":true,"context_lines":[{"line_number":363,"context_line":"     {"},{"line_number":364,"context_line":"       \"name\": \"vfio-variant-vf\","},{"line_number":365,"context_line":"       \"groups\": ["},{"line_number":366,"context_line":"         {"},{"line_number":367,"context_line":"           \"resources:CUSTOM_PCI\": 1"},{"line_number":368,"context_line":"         }"},{"line_number":369,"context_line":"       ]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"567e0bc3_5372d180","line":366,"updated":"2026-07-17 11:37:09.000000000","message":"in the future we probably should have some document demonstrating a more complex use case with several devices, and device profiles using traits to distinguish between the devices, but we don\u0027t need that for this work","commit_id":"653667790a008f0fda6066a9d119f386d1d16034"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63e612b7731a35109b32c37a92aa8b1037332aca","unresolved":true,"context_lines":[{"line_number":363,"context_line":"     {"},{"line_number":364,"context_line":"       \"name\": \"vfio-variant-vf\","},{"line_number":365,"context_line":"       \"groups\": ["},{"line_number":366,"context_line":"         {"},{"line_number":367,"context_line":"           \"resources:CUSTOM_PCI\": 1"},{"line_number":368,"context_line":"         }"},{"line_number":369,"context_line":"       ]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8abdb2c8_d8f5821e","line":366,"in_reply_to":"567e0bc3_5372d180","updated":"2026-08-10 17:24:38.000000000","message":"yes we can certenly build addtional advanced example even multi driver examples","commit_id":"653667790a008f0fda6066a9d119f386d1d16034"},{"author":{"_account_id":39344,"name":"Gihong Lee","display_name":"gamio","email":"gh9231@gmail.com","username":"gamio"},"change_message_id":"860effbcbb99a0e6192aa611094a8577bc0e88bb","unresolved":true,"context_lines":[{"line_number":84,"context_line":"   The device\u0027s host-driver binding may be managed as part of assignment. Use"},{"line_number":85,"context_line":"   this for devices that can be rebound to a generic assignment driver."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"``managed\u003dfalse``"},{"line_number":88,"context_line":"   The existing host-driver binding must remain unchanged. Use this for devices"},{"line_number":89,"context_line":"   that must remain bound to a VFIO variant driver or other vendor-specific"},{"line_number":90,"context_line":"   host driver."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ef31cf76_369abe50","line":87,"updated":"2026-08-12 15:04:46.000000000","message":"The parser accepts more than true/false (yes/no, 1/0, on/off). Could we list the same full set as the devspec error message here?","commit_id":"d9657f63f43fbd26bf3fc22659b08f603e6c157e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"38af69d37e449bdead1946e4db7281b5bcb55019","unresolved":true,"context_lines":[{"line_number":157,"context_line":"Enable IOMMU"},{"line_number":158,"context_line":"------------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"PCI assignment requires IOMMU support. On x86 hosts, enable the appropriate"},{"line_number":161,"context_line":"kernel arguments and reboot. For example:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":".. code-block:: shell"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dc109ef4_97e4d485","line":160,"range":{"start_line":160,"start_character":39,"end_line":160,"end_character":51},"updated":"2026-08-24 11:24:20.000000000","message":"Since grubby works on rpms based distro. It would be good to mention that.\n```suggestion\nPCI assignment requires IOMMU support. On x86 hosts with rpm based distros, enable the appropriate\n```","commit_id":"d9657f63f43fbd26bf3fc22659b08f603e6c157e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bedbf4d07220c285c7b0e889b5aeee9b88f13cf1","unresolved":true,"context_lines":[{"line_number":157,"context_line":"Enable IOMMU"},{"line_number":158,"context_line":"------------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"PCI assignment requires IOMMU support. On x86 hosts, enable the appropriate"},{"line_number":161,"context_line":"kernel arguments and reboot. For example:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":".. code-block:: shell"}],"source_content_type":"text/x-rst","patch_set":5,"id":"aaacc3bc_b99c68f9","line":160,"range":{"start_line":160,"start_character":39,"end_line":160,"end_character":51},"in_reply_to":"dc109ef4_97e4d485","updated":"2026-08-24 12:34:08.000000000","message":"actully we shoudl proably remove grubby entirly as we shoudl not favor rpm distors\n\nor at least descirbn the argument to add gerenicly first and we cna include grubby as an example","commit_id":"d9657f63f43fbd26bf3fc22659b08f603e6c157e"},{"author":{"_account_id":39344,"name":"Gihong Lee","display_name":"gamio","email":"gh9231@gmail.com","username":"gamio"},"change_message_id":"860effbcbb99a0e6192aa611094a8577bc0e88bb","unresolved":true,"context_lines":[{"line_number":173,"context_line":"After reboot, verify that IOMMU support is active before starting the"},{"line_number":174,"context_line":"accelerator services."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Concrete example: NVIDIA SR-IOV vGPU VFs"},{"line_number":177,"context_line":"----------------------------------------"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"NVIDIA SR-IOV vGPU VFs are one concrete example of the generic VFIO variant"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9c793e0c_f74f895d","line":176,"updated":"2026-08-12 15:04:46.000000000","message":"you pushed for vendor-neutral docs elsewhere, but since this is a concrete NVIDIA example, so i think it might help to say this applies to Ampere and later.","commit_id":"d9657f63f43fbd26bf3fc22659b08f603e6c157e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bedbf4d07220c285c7b0e889b5aeee9b88f13cf1","unresolved":true,"context_lines":[{"line_number":173,"context_line":"After reboot, verify that IOMMU support is active before starting the"},{"line_number":174,"context_line":"accelerator services."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Concrete example: NVIDIA SR-IOV vGPU VFs"},{"line_number":177,"context_line":"----------------------------------------"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"NVIDIA SR-IOV vGPU VFs are one concrete example of the generic VFIO variant"}],"source_content_type":"text/x-rst","patch_set":5,"id":"a42b2fe7_e53168db","line":176,"in_reply_to":"9c793e0c_f74f895d","updated":"2026-08-24 12:34:08.000000000","message":"the general split we aim for is to have a vendor neutral core that explaines the feature\n\nand then we allow usign vendor specific examples to ilistrate it end to end provide that stays relivitly clean/short\n\ni woudl generally avoid calling out things like \"Ampere and later\" because it actully doesnt just depend on the hardware generation but also the kernel\n\nAmpere only support this on centos 10 or ubuntu 26.04 for example on centos 9 and 24.04 ampere uses mdevs.\n\nthose specific are too vendor specific for the main doc but we could add it to a note or a trouble-shooting section","commit_id":"d9657f63f43fbd26bf3fc22659b08f603e6c157e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"38af69d37e449bdead1946e4db7281b5bcb55019","unresolved":true,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":".. code-block:: shell"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"   # /usr/lib/nvidia/sriov-manage -e 0000:17:00.0"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Automate this at boot with a PF-scoped systemd template unit,"},{"line_number":198,"context_line":"``/etc/systemd/system/nvidia-sriov-manage@.service``:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da117762_121a8232","line":195,"range":{"start_line":195,"start_character":3,"end_line":195,"end_character":49},"updated":"2026-08-24 11:24:20.000000000","message":"While running this command on L4 baremetal machine, I hit following error\n```\n/usr/lib/nvidia/sriov-manage: line 243: echo: write error: Cannot allocate memory\n```\nAdding pci\u003drealloc to re-assign memory and I/O resource spaces for PCI device to grub and doing reboot\n```\ngrubby --args\u003d\"pci\u003drealloc\" --update-kernel\u003dALL\n```\nand re-running `usr/lib/nvidia/sriov-manage -e 0000:17:00.0` works fine to enable VF.\n\nIn case if we want to add a troubleshotting section in the doc.","commit_id":"d9657f63f43fbd26bf3fc22659b08f603e6c157e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bedbf4d07220c285c7b0e889b5aeee9b88f13cf1","unresolved":true,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":".. code-block:: shell"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"   # /usr/lib/nvidia/sriov-manage -e 0000:17:00.0"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Automate this at boot with a PF-scoped systemd template unit,"},{"line_number":198,"context_line":"``/etc/systemd/system/nvidia-sriov-manage@.service``:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8da38731_a33af9ef","line":195,"range":{"start_line":195,"start_character":3,"end_line":195,"end_character":49},"in_reply_to":"da117762_121a8232","updated":"2026-08-24 12:34:08.000000000","message":"i think yes but maybe we shoudl do that in a followup\n\n--args\u003d\"pci\u003drealloc\" was not reqruied when i tested this on what shoudl be an identical server to what you were usign.\n\ni would defer this to its own section at the end as realloc is geenrally only requried when the bios does not report the correct data so its typiclly menas the system needs a firmware update.\n\nbut i think having a general troubleshootign or workaround section at the end makes sense","commit_id":"d9657f63f43fbd26bf3fc22659b08f603e6c157e"}]}