)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"44222eca0b7e68a8cee8ef07ab3c714be3819e71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"72655211_71032c02","updated":"2026-08-20 15:26:47.000000000","message":"Overall It looks good.\n\nI have tested it on my system.\n\n```\n[stack@xx cyborg]$ openstack accelerator device list\n+--------------------------------------+------+--------+--------------------------------------+--------------------------------------------+\n| uuid                                 | type | vendor | hostname                             | std_board_info                             |\n+--------------------------------------+------+--------+--------------------------------------+--------------------------------------------+\n| 6c97ce5a-f4b8-4b7b-974d-b709e9902559 | GPU  | 10de   | xx.com                               | {\"product_id\": \"27b8\", \"controller\": null} |\n| 510eea72-8284-46ae-85a0-dcefda5d8469 | GPU  | 10de   | xx.com                               | {\"product_id\": \"27b8\", \"controller\": null} |\n```","commit_id":"24e47cf99da0676ec73438e5c7e42619ce5048fe"}],"devstack/lib/nvidia_vgpu":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"44222eca0b7e68a8cee8ef07ab3c714be3819e71","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        if nvidia_vgpu_csv_has_value \"$CYBORG_NVIDIA_VGPU_PFS\" \"$vf\"; then"},{"line_number":113,"context_line":"            die $LINENO \"Configured NVIDIA vGPU VF is also a PF: $vf\""},{"line_number":114,"context_line":"        fi"},{"line_number":115,"context_line":"    done \u003c \u003c(nvidia_vgpu_csv_to_lines \"$CYBORG_NVIDIA_VGPU_VFS\")"},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"function nvidia_vgpu_parent_pf_for_vf {"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"658dcbfc_bdfb1e53","line":115,"updated":"2026-08-20 15:26:47.000000000","message":"I was trying it on A30 and A100 where `/sys/bus/pci/devices/$vf/nvidia/creatable_vgpu_types` was not there and no vGPU type was found. While testing it on\nL4, I found this file. I think we can also add a check here to make sure this file contains vGPU type info otherwise fail if missing . It will help to validate the vGPU type in the start of stack run.\n\n```suggestion\n    done \u003c \u003c(nvidia_vgpu_csv_to_lines \"$CYBORG_NVIDIA_VGPU_VFS\")\n    \n    # Validate the configured vGPU type is supported by each VF.\n    while read -r vf; do\n        vf\u003d${vf,,}\n        local creatable\u003d\"/sys/bus/pci/devices/$vf/nvidia/creatable_vgpu_types\"\n        grep -Eq \"^[[:space:]]*${CYBORG_NVIDIA_VGPU_TYPE}[[:space:]]*:\" \\\n            \"$creatable\" 2\u003e/dev/null || \\\n            [[ ! -e \"$creatable\" ]] || \\\n            die $LINENO \"vGPU type $CYBORG_NVIDIA_VGPU_TYPE is not creatable on $vf\"\n    done \u003c \u003c(nvidia_vgpu_csv_to_lines \"$CYBORG_NVIDIA_VGPU_VFS\")\n```","commit_id":"24e47cf99da0676ec73438e5c7e42619ce5048fe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e9545022cd431de6f9fd46fc387a021dc55e9403","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        if nvidia_vgpu_csv_has_value \"$CYBORG_NVIDIA_VGPU_PFS\" \"$vf\"; then"},{"line_number":113,"context_line":"            die $LINENO \"Configured NVIDIA vGPU VF is also a PF: $vf\""},{"line_number":114,"context_line":"        fi"},{"line_number":115,"context_line":"    done \u003c \u003c(nvidia_vgpu_csv_to_lines \"$CYBORG_NVIDIA_VGPU_VFS\")"},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"function nvidia_vgpu_parent_pf_for_vf {"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1637765e_7bcb4fc0","line":115,"in_reply_to":"658dcbfc_bdfb1e53","updated":"2026-08-24 12:42:04.000000000","message":"so ampear is where nvidia orgially only supprot mdevs at lauch and it apprely is ment to bel able to supprot vfio variant driver on rhel/centos 10 if you have the corect driver\n\nthis is intended for L (ada lovelace, blackwell and hopper generation) device or anything else that supprot vfio-viartn drivers.\n\nthis should fail if you try to use it with a device tha tdoes not supprot this feature yes. so we can harden this.","commit_id":"24e47cf99da0676ec73438e5c7e42619ce5048fe"}],"doc/source/configuration/drivers/pci.rst":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"44222eca0b7e68a8cee8ef07ab3c714be3819e71","unresolved":true,"context_lines":[{"line_number":344,"context_line":"listed in ``CYBORG_NVIDIA_VGPU_PFS`` are used only for SR-IOV enablement and"},{"line_number":345,"context_line":"must not be included in the Cyborg whitelist."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"The helper does not create device profiles automatically. Create one"},{"line_number":348,"context_line":"explicitly for the resource class and traits reported by your hardware."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Configure Cyborg for the VFs"},{"line_number":351,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"2e0bc42d_bac81146","line":348,"range":{"start_line":347,"start_character":0,"end_line":348,"end_character":71},"updated":"2026-08-20 15:26:47.000000000","message":"+1 for mentioning this.","commit_id":"24e47cf99da0676ec73438e5c7e42619ce5048fe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e9545022cd431de6f9fd46fc387a021dc55e9403","unresolved":true,"context_lines":[{"line_number":344,"context_line":"listed in ``CYBORG_NVIDIA_VGPU_PFS`` are used only for SR-IOV enablement and"},{"line_number":345,"context_line":"must not be included in the Cyborg whitelist."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"The helper does not create device profiles automatically. Create one"},{"line_number":348,"context_line":"explicitly for the resource class and traits reported by your hardware."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Configure Cyborg for the VFs"},{"line_number":351,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"b023814b_16f0a6f4","line":348,"range":{"start_line":347,"start_character":0,"end_line":348,"end_character":71},"in_reply_to":"2e0bc42d_bac81146","updated":"2026-08-24 12:42:04.000000000","message":"i might consdider automating that at some point but for now i just had it automate the host config.\n\ni do create the device profiles for pci_sim in the devstack plugin but that partly becaose we know the values of those up front.","commit_id":"24e47cf99da0676ec73438e5c7e42619ce5048fe"}]}