)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"2f7da3156de0ef9e8842f66033d1fd96f11cfa8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e5d78c61_03c68fa9","updated":"2026-07-09 14:04:30.000000000","message":"the change lgtm, one possible improvement (not sure how feasible) would be to add the lint check to pre-commit for pci-sim changes, although probably we won\u0027t be changing it enough to justify the effort","commit_id":"3f9aa074b47b1d59cc8888b569b7f4298ed63d7f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71620a454c9080b27ec79dc77b89321a5ae303ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25ed92f3_dbba1b3b","in_reply_to":"e5d78c61_03c68fa9","updated":"2026-07-09 14:43:44.000000000","message":"i was debating if that was a good idea or not. i dont know if i cna have that only run on change to the c files\n\ni think you can specify the lanague theat pre-commit triggers on but ill look in to that in the ci patch for this.\n\ni dont nessiarly want to force you to have perl or clang-format installed to work on they cycorg repo in gerenal which is why i was heitent to do it.","commit_id":"3f9aa074b47b1d59cc8888b569b7f4298ed63d7f"}],"pci-sim/kernel-convetions.rst":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"6f8a769c9e858686f564488da9362b7976f86ee7","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. SPDX-License-Identifier: GPL-2.0-only"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Kernel conventions for pci-sim"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b96f0f1a_a848d0bf","line":1,"updated":"2026-07-06 14:18:08.000000000","message":"The new documentation file is named kernel-convetions.rst, missing the letter \u0027n\u0027 in \u0027conventions\u0027. The file content uses the correct spelling throughout, confirming the filename is a typo.\n\n**Severity**: SUGGESTION | **Confidence**: 1.0\n\n**Benefit**: The misspelled filename reduces discoverability and looks unprofessional. Future references to this file will propagate the typo unless corrected early.\n\n**Recommendation**:\nRename pci-sim/kernel-convetions.rst to pci-sim/kernel-conventions.rst before merge. No other files reference the filename yet, so the rename is trivial.","commit_id":"1117b3edbab5ea014ae7354284c76d169f7f4278"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb3f4ff275dc1dd4c44a6d296d4edd099c8e4847","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. SPDX-License-Identifier: GPL-2.0-only"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Kernel conventions for pci-sim"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4e6c1e7e_20902476","line":1,"in_reply_to":"b96f0f1a_a848d0bf","updated":"2026-07-09 10:32:23.000000000","message":"i never would have spotted that but yes this is valid","commit_id":"1117b3edbab5ea014ae7354284c76d169f7f4278"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"6f8a769c9e858686f564488da9362b7976f86ee7","unresolved":false,"context_lines":[{"line_number":146,"context_line":"* A one-time normalization with ``clang-format`` is acceptable if it is a"},{"line_number":147,"context_line":"  dedicated formatting-only change."},{"line_number":148,"context_line":"* Use the Linux tree configuration, for example"},{"line_number":149,"context_line":"  ``/home/smooney/repos/linux/.clang-format``."},{"line_number":150,"context_line":"* Review the resulting diff manually.  The Linux ``.clang-format``"},{"line_number":151,"context_line":"  approximates kernel style but is not perfect."},{"line_number":152,"context_line":"* Do not mix formatting-only churn with functional changes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a2348468_9f9c94cc","line":149,"updated":"2026-07-06 14:18:08.000000000","message":"The kernel-convetions.rst documentation uses a developer-specific path \u0027/home/smooney/repos/linux/.clang-format\u0027 as an example for finding the Linux tree clang-format configuration. This path is tied to one developer\u0027s machine.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Other developers following this documentation will encounter a non-existent path, causing confusion. It also leaks a developer\u0027s local directory structure into a shared repository.\n\n**Recommendation**:\nReplace \u0027/home/smooney/repos/linux/.clang-format\u0027 with a generic path such as \u0027/path/to/linux/.clang-format\u0027 or reference the kernel documentation path already cited elsewhere in the document.","commit_id":"1117b3edbab5ea014ae7354284c76d169f7f4278"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"49083484f26d11540d5da5f6a7b00a10bd95d10c","unresolved":true,"context_lines":[{"line_number":146,"context_line":"* A one-time normalization with ``clang-format`` is acceptable if it is a"},{"line_number":147,"context_line":"  dedicated formatting-only change."},{"line_number":148,"context_line":"* Use the Linux tree configuration, for example"},{"line_number":149,"context_line":"  ``/home/smooney/repos/linux/.clang-format``."},{"line_number":150,"context_line":"* Review the resulting diff manually.  The Linux ``.clang-format``"},{"line_number":151,"context_line":"  approximates kernel style but is not perfect."},{"line_number":152,"context_line":"* Do not mix formatting-only churn with functional changes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c3e332fd_d68da987","line":149,"in_reply_to":"a2348468_9f9c94cc","updated":"2026-07-09 10:37:09.000000000","message":"\u003e The kernel-convetions.rst documentation uses a developer-specific path \u0027/home/smooney/repos/linux/.clang-format\u0027 as an example for finding the Linux tree clang-format configuration. This path is tied to one developer\u0027s machine.\n\u003e \n\u003e **Severity**: SUGGESTION | **Confidence**: 0.9\n\u003e \n\u003e **Benefit**: Other developers following this documentation will encounter a non-existent path, causing confusion. It also leaks a developer\u0027s local directory structure into a shared repository.\n\u003e \n\u003e **Recommendation**:\n\u003e Replace \u0027/home/smooney/repos/linux/.clang-format\u0027 with a generic path such as \u0027/path/to/linux/.clang-format\u0027 or reference the kernel documentation path already cited elsewhere in the document.\n\nEven better to point to linux github url.\n```suggestion\n* Use the Linux tree configuration: https://github.com/torvalds/linux/blob/master/.clang-format\n```","commit_id":"1117b3edbab5ea014ae7354284c76d169f7f4278"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb3f4ff275dc1dd4c44a6d296d4edd099c8e4847","unresolved":true,"context_lines":[{"line_number":146,"context_line":"* A one-time normalization with ``clang-format`` is acceptable if it is a"},{"line_number":147,"context_line":"  dedicated formatting-only change."},{"line_number":148,"context_line":"* Use the Linux tree configuration, for example"},{"line_number":149,"context_line":"  ``/home/smooney/repos/linux/.clang-format``."},{"line_number":150,"context_line":"* Review the resulting diff manually.  The Linux ``.clang-format``"},{"line_number":151,"context_line":"  approximates kernel style but is not perfect."},{"line_number":152,"context_line":"* Do not mix formatting-only churn with functional changes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"461216c4_eb69b68c","line":149,"in_reply_to":"a2348468_9f9c94cc","updated":"2026-07-09 10:32:23.000000000","message":"Marked as unresolved.i forget to make this a relitive path","commit_id":"1117b3edbab5ea014ae7354284c76d169f7f4278"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8a496e0478c65548f2a2cc2454fb76b5b2618e35","unresolved":true,"context_lines":[{"line_number":146,"context_line":"* A one-time normalization with ``clang-format`` is acceptable if it is a"},{"line_number":147,"context_line":"  dedicated formatting-only change."},{"line_number":148,"context_line":"* Use the Linux tree configuration, for example"},{"line_number":149,"context_line":"  ``/home/smooney/repos/linux/.clang-format``."},{"line_number":150,"context_line":"* Review the resulting diff manually.  The Linux ``.clang-format``"},{"line_number":151,"context_line":"  approximates kernel style but is not perfect."},{"line_number":152,"context_line":"* Do not mix formatting-only churn with functional changes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3036d21c_f9cbc80f","line":149,"in_reply_to":"c3e332fd_d68da987","updated":"2026-07-09 10:41:34.000000000","message":"no i dont want use to require peloel to have the linux kernel tree cloned on there system to work on this, that is why imp orting the config and checkpatch in the frist palce","commit_id":"1117b3edbab5ea014ae7354284c76d169f7f4278"}]}