)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85223352914009bc1196d5ec00cd637fec1fdac5","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    rev: v1.1.2"},{"line_number":58,"context_line":"    hooks:"},{"line_number":59,"context_line":"      - id: doc8"},{"line_number":60,"context_line":"  - repo: local"},{"line_number":61,"context_line":"    hooks:"},{"line_number":62,"context_line":"      - id: pci-sim-test-and-lint"},{"line_number":63,"context_line":"        name: Run pci-sim tests and lint (Debian/Ubuntu/CentOS only)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9862e31e_5bc78f26","line":60,"updated":"2026-07-09 17:58:47.000000000","message":"i do not want to require the kernel moduel lint tools, make or clang ectra to contribute to cybrog by default.\n\n\nthe conventional way  to invoke make in a precommit hook is like this\n\nhttps://github.com/openstack-k8s-operators/nova-operator/blob/main/.pre-commit-config.yaml#L1-L9\n\nuseing the system lanauge and make as the entrypoitn and the ven as the argment.\n\n\nsystem and script are now \n\nhttps://pre-commit.com/#unsupported\nhttps://pre-commit.com/#unsupported_script\n\nmy inclidntion is to not integate with precommit at all as i was not plannign to run this check in the pep8 job but rather add a new job for this so we can contol what disto is runs on seperatly.","commit_id":"0f38fbe75d15e94f6a8462fa054800a2e75e7d3e"}],"pci-sim/tools/pci-sim-pre-commit.sh":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"97b92f44c81c6a7d431f45bdd9b7b80fce347b44","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# SPDX-License-Identifier: GPL-2.0-only"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"if grep -Eiq \u0027ubuntu|debian|centos\u0027 /etc/os-release 2\u003e/dev/null; then"},{"line_number":5,"context_line":"    make -C pci-sim test \u0026\u0026 make -C pci-sim lint"},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    echo \"Skipping pci-sim: not a Debian/Ubuntu/CentOS system.\""},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"89425d0f_eacb6a18","line":5,"updated":"2026-07-09 14:56:42.000000000","message":"The pre-commit script runs \u0027make -C pci-sim test \u0026\u0026 make -C pci-sim lint\u0027. The \u0027test\u0027 target includes test-loopback (uses sudo -n to load/unload kernel modules) and test-multi-pf (requires sudo, lspci, vfio-pci). These heavyweight system-state-modifying tests will block routine commits for develo...\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Any commit touching pci-sim/ files on Debian/Ubuntu/CentOS will attempt to compile a kernel module, load it with sudo, run VFIO smoke tests, and interact with /dev/ttyPCI_SIM* devices. This blocks commits for developers without kernel headers, passwordless sudo, or a compatible kernel, creating s...\n\n**Suggestion**:\nRun only \u0027make -C pci-sim lint\u0027 (or \u0027make -C pci-sim check\u0027) in the pre-commit hook. Keep the \u0027test\u0027 target for CI jobs or a separate manual command. Lint is fast and unprivileged; the integration tests are not appropriate for commit-time checks.","commit_id":"0f38fbe75d15e94f6a8462fa054800a2e75e7d3e"}]}