)]}'
{"cyborg/db/sqlalchemy/models.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b1b9f0a1454a98be5230beb5716da4861c4c01dc","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            \u0027QAT\u0027,"},{"line_number":91,"context_line":"            \u0027NIC\u0027,"},{"line_number":92,"context_line":"            \u0027SSD\u0027,"},{"line_number":93,"context_line":"            \u0027MDEV\u0027,"},{"line_number":94,"context_line":"            \u0027PCI\u0027,"},{"line_number":95,"context_line":"            name\u003d\u0027device_type\u0027,"},{"line_number":96,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":5,"id":"d32ce2f1_e25c117a","line":93,"updated":"2026-07-22 13:40:50.000000000","message":"we could use the same constants here","commit_id":"b8ab253336b356ec8b31fbc880217b5c22412c2d"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"88585fe3bab74935f687af74052f9292f22edf25","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            \u0027QAT\u0027,"},{"line_number":91,"context_line":"            \u0027NIC\u0027,"},{"line_number":92,"context_line":"            \u0027SSD\u0027,"},{"line_number":93,"context_line":"            \u0027MDEV\u0027,"},{"line_number":94,"context_line":"            \u0027PCI\u0027,"},{"line_number":95,"context_line":"            name\u003d\u0027device_type\u0027,"},{"line_number":96,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f0cd675_a33eaebc","line":93,"in_reply_to":"d32ce2f1_e25c117a","updated":"2026-07-22 14:57:26.000000000","message":"good point, done","commit_id":"b8ab253336b356ec8b31fbc880217b5c22412c2d"}],"cyborg/tests/unit/db/test_migrations.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"908c84a029df7ca745eaf9a27d71ec75d7095bb5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.migration_api.upgrade(version, config\u003dconfig)"},{"line_number":79,"context_line":"        self.assertEqual(version, self.migration_api.version(config))"},{"line_number":80,"context_line":"        if with_data:"},{"line_number":81,"context_line":"            check \u003d getattr(self, f\"_check_{version}\", None)"},{"line_number":82,"context_line":"            if version not in self._skippable_migrations():"},{"line_number":83,"context_line":"                self.assertIsNotNone("},{"line_number":84,"context_line":"                    check,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9cae6085_8baa7afe","line":81,"updated":"2026-07-20 10:33:37.000000000","message":"The _check_9625668549b5 method added by this change contains detailed enum value verification, but _migrate_up never calls the check function. The check variable is retrieved via getattr and asserted to be non-None, but check(engine, data) is never invoked, so the assertions inside _check_9625668...\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: The migration test appears to verify the device_type enum includes MDEV and PCI, but the verification never actually runs. If the migration were incorrect, the test would not catch it. This provides a false sense of test coverage for a schema-altering migration.\n\n**Recommendation**:\nAdd a call to the check function in _migrate_up after the assertIsNone check, e.g.: \u0027check(engine, data)\u0027 or \u0027check(engine, None)\u0027. Alternatively, if the current behavior (asserting existence only) is intentional, document it clearly so reviewers know the _check methods are not invoked.","commit_id":"32cb6e9f4d5de7035446812931b17649805e1f6a"}]}