)]}'
{"cyborg/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"4ae86919956f68347fd9535191a8e09b147234e6","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.cm._warn_duplicate_devices(devices)"},{"line_number":230,"context_line":"        mock_log.warning.assert_called_once()"},{"line_number":231,"context_line":"        args \u003d mock_log.warning.call_args[0]"},{"line_number":232,"context_line":"        self.assertIn(devices[0].controlpath_id.cpid_info, args[1])"},{"line_number":233,"context_line":"        self.assertEqual([\u0027GPU/0xABCD\u0027, \u0027GPU/0xDCBA\u0027], args[2])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @mock.patch("}],"source_content_type":"text/x-python","patch_set":1,"id":"745bc93a_aadf41e2","line":232,"updated":"2026-07-13 14:23:52.000000000","message":"The assertion `self.assertIn(devices[0].controlpath_id.cpid_info, args[1])` checks substring containment of a string within itself, since args[1] is the exact cpid_info string passed to LOG.warning. This assertion always passes regardless of the actual value, making it ineffective at verifying th...\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: The test does not effectively verify that the correct cpid_info value is passed to the warning. A regression that passes the wrong cpid_info could go undetected as long as the expected value remains a substring of the actual value.\n\n**Recommendation**:\nReplace `self.assertIn(devices[0].controlpath_id.cpid_info, args[1])` with `self.assertEqual(devices[0].controlpath_id.cpid_info, args[1])` to perform a precise equality check on the logged cpid_info value.","commit_id":"3115cf89058e6d397de34a6979ee66104fbe32c1"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a4f80a9b3416d2b479ccca203ed5790bb068a0e4","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.cm._warn_duplicate_devices(devices)"},{"line_number":230,"context_line":"        mock_log.warning.assert_called_once()"},{"line_number":231,"context_line":"        args \u003d mock_log.warning.call_args[0]"},{"line_number":232,"context_line":"        self.assertIn(devices[0].controlpath_id.cpid_info, args[1])"},{"line_number":233,"context_line":"        self.assertEqual([\u0027GPU/0xABCD\u0027, \u0027GPU/0xDCBA\u0027], args[2])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @mock.patch("}],"source_content_type":"text/x-python","patch_set":2,"id":"a6fab1fd_3122addb","line":232,"updated":"2026-07-13 17:53:53.000000000","message":"The test uses assertIn to check cpid_info but compares a string against itself, making the assertion always pass regardless of correctness.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: The test appears to verify that the correct cpid_info is included in the warning, but the assertion is a no-op. If a future refactor accidentally passed a wrong value, this assertion would still pass, masking the regression.\n\n**Recommendation**:\nReplace self.assertIn(devices[0].controlpath_id.cpid_info, args[1]) with self.assertEqual(devices[0].controlpath_id.cpid_info, args[1]) to perform a meaningful equality check on the logged cpid_info value.","commit_id":"b3e09696220bd85426f9e2b19f76dbd69712b583"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3716d6f5c2275302b8f2865ac239be552ff17eb0","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.cm._warn_duplicate_devices(devices)"},{"line_number":230,"context_line":"        mock_log.warning.assert_called_once()"},{"line_number":231,"context_line":"        args \u003d mock_log.warning.call_args[0]"},{"line_number":232,"context_line":"        self.assertIn(devices[0].controlpath_id.cpid_info, args[1])"},{"line_number":233,"context_line":"        self.assertEqual([\u0027GPU/0xABCD\u0027, \u0027GPU/0xDCBA\u0027], args[2])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @mock.patch("}],"source_content_type":"text/x-python","patch_set":3,"id":"78d22ccd_e9c0e821","line":232,"updated":"2026-07-16 17:27:24.000000000","message":"The assertion self.assertIn(devices[0].controlpath_id.cpid_info, args[1]) checks that a string is a substring of itself, which is always True. It provides no meaningful verification.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: The assertion appears to verify that the correct cpid_info is passed to the warning but actually verifies nothing. A regression changing which cpid_info is logged would not be caught.\n\n**Recommendation**:\nReplace assertIn with assertEqual: self.assertEqual(devices[0].controlpath_id.cpid_info, args[1]) to verify the correct cpid_info value is passed to LOG.warning.","commit_id":"1b2e3cd0f425c27983688c16335b662b04dfd761"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"2b1a818782199d58f7fd5894751ce2d01f9a5b76","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.cm._warn_duplicate_devices(devices)"},{"line_number":230,"context_line":"        mock_log.warning.assert_called_once()"},{"line_number":231,"context_line":"        args \u003d mock_log.warning.call_args[0]"},{"line_number":232,"context_line":"        self.assertIn(devices[0].controlpath_id.cpid_info, args[1])"},{"line_number":233,"context_line":"        self.assertEqual([\u0027GPU/0xABCD\u0027, \u0027GPU/0xDCBA\u0027], args[2])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @mock.patch("}],"source_content_type":"text/x-python","patch_set":6,"id":"d81c35ee_7e4434eb","line":232,"updated":"2026-07-22 12:49:50.000000000","message":"The assertion assertIn(devices[0].controlpath_id.cpid_info, args[1]) checks whether the cpid_info string is a substring of itself, since args[1] IS the cpid_info positional argument passed to LOG.warning. This assertion always passes regardless of correctness.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: The test does not actually verify that the correct cpid_info value is passed to LOG.warning. A future bug that passes the wrong cpid_info would not be caught by this assertion. The test still validates the call count and dev_types list, so coverage is not entirely lost.\n\n**Recommendation**:\nReplace assertIn with assertEqual: self.assertEqual(devices[0].controlpath_id.cpid_info, args[1]). This verifies the exact cpid_info value is passed to the warning.","commit_id":"ac169745a1b61a826fb49a3554ea661577b8d2cd"}]}