)]}'
{".zuul.yaml":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3b620f91d52733876e0f92c556353a770b5d1dad","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      devstack_local_conf:"},{"line_number":99,"context_line":"        test-config:"},{"line_number":100,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":101,"context_line":"            cyborg_mdev:"},{"line_number":102,"context_line":"              device_profile_name: pci-sim-cyborgmdev-dp"},{"line_number":103,"context_line":"              vendor_id: 1d55"},{"line_number":104,"context_line":"              product_id: 1000"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8304fe2f_8f25a3bf","line":101,"updated":"2026-07-15 11:08:50.000000000","message":"The cyborg_mdev Tempest config block sets device_profile_name, vendor_id, and product_id but omits mdev_type. The TestMdevDriverLifecycle.skip_checks() method requires all four options to be non-empty; without mdev_type every test raises skipException and none execute.\n\n**Severity**: HIGH | **Confidence**: 1.0\n\n**Risk**: All 10 mdev lifecycle scenario tests will be skipped at collection time, completely defeating the purpose of this CI configuration change. The mdev driver lifecycle tests will never run.\n\n**Priority**: Before merge\n**Why This Matters**: All 10 mdev lifecycle scenario tests will be skipped at collection time, completely defeating the purpose of this CI configuration change. The mdev driver lifecycle tests will never run.\n\n**Recommendation**:\nAdd mdev_type to the cyborg_mdev test-config block. The correct value matching the DevStack default PCI_SIM_MDEV_TYPE is \u0027fake_pci_sriov_pf-sim_accel_small\u0027.","commit_id":"4aa53fad4aa90b42c6aaf3159b25059391ef0046"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3b620f91d52733876e0f92c556353a770b5d1dad","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        test-config:"},{"line_number":100,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":101,"context_line":"            cyborg_mdev:"},{"line_number":102,"context_line":"              device_profile_name: pci-sim-cyborgmdev-dp"},{"line_number":103,"context_line":"              vendor_id: 1d55"},{"line_number":104,"context_line":"              product_id: 1000"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"52cef4a0_2a295177","line":102,"updated":"2026-07-15 11:08:50.000000000","message":"The device_profile_name in the Tempest config is \u0027pci-sim-cyborgmdev-dp\u0027 (no hyphen between cyborg and mdev), but the DevStack plugin default PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME is \u0027pci-sim-cyborg-mdev-dp\u0027 (with a hyphen). No override of this variable exists in the job configuration.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: When the test attempts to create a flavor referencing device profile \u0027pci-sim-cyborgmdev-dp\u0027, Cyborg will reject it because only \u0027pci-sim-cyborg-mdev-dp\u0027 exists. All lifecycle tests will fail at server creation.\n\n**Priority**: Before merge\n**Why This Matters**: When the test attempts to create a flavor referencing device profile \u0027pci-sim-cyborgmdev-dp\u0027, Cyborg will reject it because only \u0027pci-sim-cyborg-mdev-dp\u0027 exists. All lifecycle tests will fail at server creation.\n\n**Recommendation**:\nChange device_profile_name from \u0027pci-sim-cyborgmdev-dp\u0027 to \u0027pci-sim-cyborg-mdev-dp\u0027 to match the DevStack default, or alternatively override PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME in the job\u0027s devstack_localrc to match.","commit_id":"4aa53fad4aa90b42c6aaf3159b25059391ef0046"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"3b620f91d52733876e0f92c556353a770b5d1dad","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            cyborg_mdev:"},{"line_number":102,"context_line":"              device_profile_name: pci-sim-cyborgmdev-dp"},{"line_number":103,"context_line":"              vendor_id: 1d55"},{"line_number":104,"context_line":"              product_id: 1000"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- job:"},{"line_number":107,"context_line":"    name: cyborg-tempest-centos-10-stream"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fae52ae8_4cc37f15","line":104,"updated":"2026-07-15 11:08:50.000000000","message":"The product_id is set to \u00271000\u0027 (0x1000, the PF device ID), but mdev instances created by the pci-sim kernel module use a distinct device ID 0x2000 defined as FAKE_PCI_MDEV_DEVICE_ID. The test asserts the guest-visible PCI vendor:product pair, so this mismatch will cause assertion failures.\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: Even if the mdev_type issue is fixed and tests run, every lifecycle scenario will fail at _assert_guest_has_device because the expected PCI ID 1d55:1000 will not match the actual mdev device 1d55:2000 present in the guest.\n\n**Priority**: Before merge\n**Why This Matters**: Even if the mdev_type issue is fixed and tests run, every lifecycle scenario will fail at _assert_guest_has_device because the expected PCI ID 1d55:1000 will not match the actual mdev device 1d55:2000 present in the guest.\n\n**Recommendation**:\nChange product_id from \u00271000\u0027 to \u00272000\u0027 to match FAKE_PCI_MDEV_DEVICE_ID (0x2000) used by the pci-sim mdev instances.","commit_id":"4aa53fad4aa90b42c6aaf3159b25059391ef0046"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d5112206060e993ec5c563c61774c3e89af18a81","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        test-config:"},{"line_number":100,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":101,"context_line":"            cyborg_mdev:"},{"line_number":102,"context_line":"              device_profile_name: pci-sim-cyborgmdev-dp"},{"line_number":103,"context_line":"              vendor_id: 1d55"},{"line_number":104,"context_line":"              product_id: 1000"},{"line_number":105,"context_line":"              mdev_type: fake_pci_sriov_pf-sim_accel_small"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c998a165_558a4046","line":102,"updated":"2026-07-15 11:38:35.000000000","message":"The device_profile_name value \u0027pci-sim-cyborgmdev-dp\u0027 in the cyborg_mdev test-config does not match the DevStack plugin default \u0027pci-sim-cyborg-mdev-dp\u0027. The test config is missing a hyphen between \u0027cyborg\u0027 and \u0027mdev\u0027. When the test boots a server with a flavor referencing this device profile, Cy...\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: All mdev driver lifecycle scenario tests (test_create_delete_server_with_mdev_driver_device, test_guest_reboot_with_mdev_driver_device, and 8 others) will fail during server creation because the referenced device profile \u0027pci-sim-cyborgmdev-dp\u0027 will not exist in Cyborg. Only \u0027pci-sim-cyborg-mdev-...\n\n**Priority**: Before merge\n**Why This Matters**: All mdev driver lifecycle scenario tests (test_create_delete_server_with_mdev_driver_device, test_guest_reboot_with_mdev_driver_device, and 8 others) will fail during server creation because the referenced device profile \u0027pci-sim-cyborgmdev-dp\u0027 will not exist in Cyborg. Only \u0027pci-sim-cyborg-mdev-...\n\n**Recommendation**:\nChange the device_profile_name value from \u0027pci-sim-cyborgmdev-dp\u0027 to \u0027pci-sim-cyborg-mdev-dp\u0027 to match the DevStack plugin default defined in devstack/settings line 118. Alternatively, set PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME in the job\u0027s devstack_localrc to \u0027pci-sim-cyborgmdev-dp\u0027 so both sides agree, but matching the existing default is simpler.","commit_id":"a3c48fbef94f0e88ac8beaa6a34e907d25cddeaf"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"8cf0182f92b48d1290ecb950d3ca94c7e9fc0e71","unresolved":false,"context_lines":[{"line_number":94,"context_line":"      Cyborg devstack tempest tests job for \u003e\u003dUssuri release"},{"line_number":95,"context_line":"      run on python 3."},{"line_number":96,"context_line":"    parent: cyborg-multinode-tempest"},{"line_number":97,"context_line":"    vars:"},{"line_number":98,"context_line":"      devstack_local_conf:"},{"line_number":99,"context_line":"        test-config:"},{"line_number":100,"context_line":"          $TEMPEST_CONFIG:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2e2c7478_5e2ca578","line":97,"updated":"2026-07-15 12:17:42.000000000","message":"The new cyborg_mdev test config references device_profile_name \u0027pci-sim-cyborg-mdev-dp\u0027, but this profile is never created. PCI_SIM_ENABLE_MDEV is only True in the subnode group-vars, not on the controller. Test resources are created during test-config on the controller where PCI_SIM_CONFIGURE_CY...\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: All mdev lifecycle scenario tests will fail because the device profile \u0027pci-sim-cyborg-mdev-dp\u0027 does not exist. Nova will reject server creation requests referencing it, causing every test in TestMdevDriverLifecycle to error out.\n\n**Priority**: Before merge\n**Why This Matters**: All mdev lifecycle scenario tests will fail because the device profile \u0027pci-sim-cyborg-mdev-dp\u0027 does not exist. Nova will reject server creation requests referencing it, causing every test in TestMdevDriverLifecycle to error out.\n\n**Recommendation**:\nAdd PCI_SIM_ENABLE_MDEV: true to the controller\u0027s devstack_localrc in the cyborg-tempest-py3 job (or cyborg-multinode-tempest base vars). For example, add a devstack_localrc block alongside the new devstack_local_conf in cyborg-tempest-py3 with ENABLE_PCI_SIM: true and PCI_SIM_ENABLE_MDEV: true.","commit_id":"9bb8d97991bdff2fb785c54311b9e0e647177397"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a1389b624ebf8b5dc3ed4e7f149d8186ab8e2407","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    check:"},{"line_number":135,"context_line":"      jobs:"},{"line_number":136,"context_line":"        - cyborg-tempest-py3"},{"line_number":137,"context_line":"        # - cyborg-tempest-ipv6"},{"line_number":138,"context_line":"        # - cyborg-grenade"},{"line_number":139,"context_line":"        # - cyborg-grenade-skip-level-always"},{"line_number":140,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"44afeeb4_bae731fd","line":137,"updated":"2026-07-16 07:44:41.000000000","message":"Three jobs (cyborg-tempest-ipv6, cyborg-grenade, cyborg-grenade-skip-level-always) are commented out in the check pipeline (lines 137-139) but remain uncommented and voting in the gate pipeline (lines 143-145). This asymmetry means patches can be approved without pre-merge feedback from these job...\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Patches may be reviewed and approved without running IPv6, grenade, or grenade-skip-level tests in check. If these jobs are flaky or broken, the failure will only surface in the gate pipeline, wasting CI resources and blocking merges with no prior signal. This can significantly slow down the deve...\n\n**Suggestion**:\nBefore removing the [WIP] status from this patch, either uncomment these jobs in the check pipeline so they provide pre-merge feedback, or also comment them out in the gate pipeline if they are known to be broken. Leaving the check/gate asymmetry risks blocking all merges at gate time.","commit_id":"20e8631f82f8fa87cf3c4ad0e569229656a9061d"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"e1d4340194dcc25ae8f2fc532279a7d6983f3db6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    check:"},{"line_number":135,"context_line":"      jobs:"},{"line_number":136,"context_line":"        - cyborg-tempest-py3"},{"line_number":137,"context_line":"        # - cyborg-tempest-ipv6"},{"line_number":138,"context_line":"        # - cyborg-grenade"},{"line_number":139,"context_line":"        # - cyborg-grenade-skip-level-always"},{"line_number":140,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1e73fe22_2fda824f","line":137,"updated":"2026-07-16 08:33:47.000000000","message":"Three jobs (cyborg-tempest-ipv6, cyborg-grenade, cyborg-grenade-skip-level-always) were commented out in the check pipeline but remain uncommented in the gate pipeline. This means patches could pass the check pipeline without being tested by these jobs, only to fail unexpectedly in the gate pipel...\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: If merged as-is, patches could pass all check jobs but then fail in gate because three jobs (tempest-ipv6, grenade, grenade-skip-level) would only run at gate time. This leads to unpredictable gate breakage and slower merge cycles, since developers would not get early feedback from the check pipe...\n\n**Suggestion**:\nEither also comment out these three jobs in the gate pipeline to match the check pipeline, or re-enable them in check. If the intent is to temporarily disable these jobs during WIP development, the gate pipeline should be updated in the same change before merging.","commit_id":"20e8631f82f8fa87cf3c4ad0e569229656a9061d"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"90dbbdf492dfdfcfe09a2460b254b67f79eb18ff","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        cinder: false"},{"line_number":28,"context_line":"      devstack_localrc:"},{"line_number":29,"context_line":"        ENABLE_PCI_SIM: true"},{"line_number":30,"context_line":"        PCI_SIM_ENABLE_MDEV: true"},{"line_number":31,"context_line":"      tempest_plugins:"},{"line_number":32,"context_line":"        - cyborg-tempest-plugin"},{"line_number":33,"context_line":"      tempest_test_regex: cyborg_tempest_plugin"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e71a294f_e88a8b68","line":30,"updated":"2026-07-23 18:02:45.000000000","message":"Adding PCI_SIM_ENABLE_MDEV: true to the base job\u0027s devstack_localrc causes PF modes to become round-robin [sriov, mdev, ...]. The pre-existing pci_sim_pf_target function splits all PFs by index parity (even→Nova, odd→Cyborg), but it counts mdev PFs in the index. Since round-robin places mdev PFs...\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: Cyborg\u0027s PCI driver will have an empty passthrough_whitelist, so all existing SR-IOV Cyborg tempest tests (covered by tempest_test_regex \u0027cyborg_tempest_plugin\u0027) will fail because no accelerators are discoverable. Nova PCI tests and mdev tests are unaffected, but the combined job will fail on the...\n\n**Priority**: Before merge\n**Why This Matters**: Cyborg\u0027s PCI driver will have an empty passthrough_whitelist, so all existing SR-IOV Cyborg tempest tests (covered by tempest_test_regex \u0027cyborg_tempest_plugin\u0027) will fail because no accelerators are discoverable. Nova PCI tests and mdev tests are unaffected, but the combined job will fail on the...\n\n**Recommendation**:\nFix pci_sim_pf_target in devstack/lib/pci_sim to compute parity only among sriov-mode PFs (e.g., maintain a separate sriov-PF counter) rather than using the global PF index. Alternatively, adjust the PF allocation so that at least one sriov PF is guaranteed for Cyborg when both PCI_SIM_CONFIGURE_CYBORG_PCI and PCI_SIM_ENABLE_MDEV are True. Until the logic is fixed, the comment at .zuul.yaml:90 should be corrected to reflect actual behavior.","commit_id":"bff8b530e382e1b09dcd226aa48f7108fb5ec127"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b6abaa56501e5a040c617ceab6b22db2cd20362a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"          PCI_SIM_CREATE_TEST_FLAVORS: false"},{"line_number":88,"context_line":"          ENABLE_PCI_SIM: true"},{"line_number":89,"context_line":"          PCI_SIM_ENABLE_MDEV: true"},{"line_number":90,"context_line":"          # 2 SRIOV (one for nova, one for cyborg), 1 MDEV"},{"line_number":91,"context_line":"          PCI_SIM_NUM_PFS: 3"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"69e4a7a3_f4919667","line":90,"updated":"2026-07-24 07:11:49.000000000","message":"The comment states \u00272 SRIOV (one for nova, one for cyborg), 1 MDEV\u0027 but the actual PF allocation does not achieve this. With NUM_PFS\u003d3, PF_MODES\u003d[sriov,mdev,sriov]. pci_sim_collect_target_vfs increments pci_index unconditionally for every PF (line 411), including mdev PFs, despite its comment say...\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: On the multinode subnode, nova receives both SRIOV PFs while Cyborg PCI receives zero VFs. Cyborg PCI passthrough tempest tests will fail. The mdev tests are unaffected since configure_pci_sim_cyborg_mdev_service_config uses a separate loop. Adding a third PF does not deliver the intended allocat...\n\n**Priority**: Before merge\n**Why This Matters**: On the multinode subnode, nova receives both SRIOV PFs while Cyborg PCI receives zero VFs. Cyborg PCI passthrough tempest tests will fail. The mdev tests are unaffected since configure_pci_sim_cyborg_mdev_service_config uses a separate loop. Adding a third PF does not deliver the intended allocat...\n\n**Recommendation**:\nFix pci_sim_collect_target_vfs in devstack/lib/pci_sim to only increment pci_index for SRIOV PFs. Add \u0027continue\u0027 after the index skip for non-sriov PFs, matching the pattern in configure_pci_sim_vfs. Alternatively, update the comment if Cyborg PCI passthrough is not intended on these jobs.","commit_id":"8294c08b8fcd857b468cbcd06dfc550d3711052c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"31376ce600ca570717cc7b7c5507e2653676f801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"32e56b22_8c8920ab","updated":"2026-07-15 17:25:31.000000000","message":"recheck","commit_id":"7c2d14d87087373b341ecf9ef98a29f92db14ce8"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"88e3b39513fe837fb7484868cbf53d033e4eaeb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7bf50982_9a9d9115","updated":"2026-07-16 07:07:30.000000000","message":"recheck","commit_id":"7c2d14d87087373b341ecf9ef98a29f92db14ce8"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"6ebb52b5571ca5793249801b56b87e962529393f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3a00cc77_4186d13e","updated":"2026-07-16 07:54:59.000000000","message":"recheck depends-on changed","commit_id":"20e8631f82f8fa87cf3c4ad0e569229656a9061d"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"53279e71f4c1cccef4292fba1d39bdab067afad6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d2bcf9b3_cc9ebc3b","updated":"2026-07-16 10:15:57.000000000","message":"recheck apparently unrelated error","commit_id":"61cb02d32532e567679ae84985f7cce6dd4c2619"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"966b67c4577cca78d3f76ff0ddbe598c830234b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3fad737b_ee87750f","updated":"2026-07-16 15:02:07.000000000","message":"recheck depends-on changed","commit_id":"9f6cb12b774ec9b014bc25cd2e10959b300887dc"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"2a84143f248f7dcf821d4e47831a4c5031e49bd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"05a6b667_108242e8","updated":"2026-07-17 08:48:57.000000000","message":"recheck","commit_id":"6d1147b29353b371059668f20cd17001000f7785"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"2f8cb7322f1d51c88c06e169fed5816d58242279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1def973e_421e9556","updated":"2026-07-17 15:49:52.000000000","message":"recheck","commit_id":"6d1147b29353b371059668f20cd17001000f7785"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"d0b3accd5ad3ac1dafc32426d52053b58d2bf0d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e296711e_fa9e20f6","updated":"2026-07-17 11:56:37.000000000","message":"recheck","commit_id":"6d1147b29353b371059668f20cd17001000f7785"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"bba34a9e6573ae057f18571f951f6d6bfe611dd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3830f7fc_de921524","updated":"2026-07-17 06:46:12.000000000","message":"recheck depends-on changed","commit_id":"6d1147b29353b371059668f20cd17001000f7785"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"eaa19fd48a5eb586ec28cce533d4f90fc8849a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"63a8d2e0_8c7634f6","updated":"2026-07-17 17:27:43.000000000","message":"recheck depends-on changed","commit_id":"6d1147b29353b371059668f20cd17001000f7785"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"3f4a2791765a9f85c60e7df5623f70a31c325cdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a100044e_cfe96cd2","updated":"2026-07-20 10:06:37.000000000","message":"recheck depends-on changed","commit_id":"6d1147b29353b371059668f20cd17001000f7785"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"6caa792e614dd6a89a138518d947aba2e397f0dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"020c2bdd_7a44f86e","updated":"2026-07-22 10:19:06.000000000","message":"recheck","commit_id":"08a8dc77821bbd5094fcb50ecc392b5c4d55cd94"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"c79a58719f17f98183d66e6b866f81a91cc2de45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2227808d_66b6ebb7","updated":"2026-07-22 08:56:40.000000000","message":"recheck","commit_id":"08a8dc77821bbd5094fcb50ecc392b5c4d55cd94"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"9f5b31bed3abcf8749b86206d8d64f635efda663","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"23f7f491_644133cf","updated":"2026-07-21 08:56:31.000000000","message":"recheck","commit_id":"08a8dc77821bbd5094fcb50ecc392b5c4d55cd94"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"4fec8219afcce8ffcf00e2591a2dd3624f4046d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2f8fe14c_20b9c090","updated":"2026-07-20 15:09:24.000000000","message":"recheck","commit_id":"08a8dc77821bbd5094fcb50ecc392b5c4d55cd94"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"c2d98013fd8094580e427cbcdda256d1752782a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"926be088_72a4f958","updated":"2026-07-21 07:55:25.000000000","message":"recheck depends-on changed","commit_id":"08a8dc77821bbd5094fcb50ecc392b5c4d55cd94"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"155c04900b1bd791deb43c3da87d32a1c4b6c356","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a93a4f76_1380b526","updated":"2026-07-21 17:02:54.000000000","message":"recheck depends-on changed","commit_id":"08a8dc77821bbd5094fcb50ecc392b5c4d55cd94"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"71b8e7ef3b89369d530cd809d6f444afc9c25b5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"77f89710_1bcd012e","updated":"2026-07-20 14:02:53.000000000","message":"recheck fishing for failure","commit_id":"08a8dc77821bbd5094fcb50ecc392b5c4d55cd94"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"3e33460d00acbfe2d98c63716315b909e2bb12e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2db23003_eba7d48f","updated":"2026-07-22 13:21:22.000000000","message":"recheck","commit_id":"1fe74b5d74865be41c5d63fba6b18d47d8cd0e5b"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"2169a97d51b4ae3699c75949cb87e5e320034a62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"e60de7c9_4050be1a","updated":"2026-07-24 11:04:36.000000000","message":"recheck","commit_id":"2048f735a70084a5cc3cacd19fe66b92b17fbf30"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"16acf3822d72416f4e27df3bd1489d477d1c6245","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"76d509b6_40bfd73d","updated":"2026-07-28 10:34:01.000000000","message":"recheck depends-on changed","commit_id":"2048f735a70084a5cc3cacd19fe66b92b17fbf30"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"4e791ceacca8a5a75ae8ff8457e31b01b5ed9d18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"c5179eca_846949ef","updated":"2026-07-24 09:33:35.000000000","message":"recheck want to test further stability of the reboot test fix","commit_id":"2048f735a70084a5cc3cacd19fe66b92b17fbf30"}],"devstack/lib/cyborg":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"7281f3f70367605005a9c59ddf6a2cc7590e27fd","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        iniset $TEMPEST_CONFIG cyborg_pci product_id 0003"},{"line_number":287,"context_line":"    fi"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"263fed5f_1a543b19","line":289,"updated":"2026-07-16 10:30:41.000000000","message":"The new cyborg_mdev tempest config block is guarded by PCI_SIM_ENABLE_MDEV \u003d\u003d \"True\". However, that variable is only set in the subnode group-vars (.zuul.yaml line 87), not in the base job vars. Tempest and cyborg_configure_tempest run on the primary/controller, which inherits only ENABLE_PCI_SIM...\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: The stated goal of the patch—configuring tempest to run mdev driver lifecycle tests—will not be achieved. The cyborg_mdev section will be absent from tempest.conf on the controller, so mdev tests will be skipped or fail due to missing configuration.\n\n**Priority**: Before merge\n**Why This Matters**: The stated goal of the patch—configuring tempest to run mdev driver lifecycle tests—will not be achieved. The cyborg_mdev section will be absent from tempest.conf on the controller, so mdev tests will be skipped or fail due to missing configuration.\n\n**Recommendation**:\nAdd PCI_SIM_ENABLE_MDEV: true to the base job devstack_localrc in .zuul.yaml (cyborg_base_vars anchor, around line 28-29) so the controller where tempest runs has this variable set. Alternatively, add it to the cyborg-multinode-tempest job\u0027s top-level vars if it should only apply to multinode jobs.","commit_id":"61cb02d32532e567679ae84985f7cce6dd4c2619"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d0fe222f8d0c1370c49b7e44a17ae63d27962aa5","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        iniset $TEMPEST_CONFIG cyborg_pci product_id 0003"},{"line_number":287,"context_line":"    fi"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"4cbb4576_3dcf1307","line":289,"updated":"2026-07-17 07:24:14.000000000","message":"The cyborg_pci config block includes a multi-line comment explaining that the guest-visible IDs (10a9:0003) differ from host-side IDs due to the vfio_guest_8250_compat overlay. The adjacent cyborg_mdev block also hardcodes IDs (1d55:2000) but provides no comment explaining their origin or why the...\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: A maintainer reading this function may wonder whether mdev-mediated devices are also subject to the vfio_guest_8250_compat overlay and whether 1d55:2000 are guest-visible or host-side values. Without a comment, the values appear as unexplained magic numbers and require kernel-source tracing to va...\n\n**Recommendation**:\nAdd a brief comment above the mdev iniset calls, e.g.: `# mdev synthetic devices expose their own config-space IDs directly (no vfio overlay), matching FAKE_PCI_VENDOR_ID/FAKE_PCI_MDEV_DEVICE_ID from pci-sim/fake_pci_sriov.h.`","commit_id":"6d1147b29353b371059668f20cd17001000f7785"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"974f4f6537cb60b38a550b5731c4251e31464eae","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"},{"line_number":293,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev product_id 2000"},{"line_number":294,"context_line":"    fi"},{"line_number":295,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"469361d5_ccaf693b","line":292,"updated":"2026-07-20 16:50:37.000000000","message":"The new mdev tempest config block hardcodes vendor_id 1d55 and product_id 2000 without any explanation. The adjacent PCI block includes a three-line comment explaining its own hardcoded values and why they differ from host-side IDs. The mdev block should follow the same pattern so future maintain...\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: A future maintainer changing the pci-sim kernel module device IDs (e.g., in fake_pci_sriov.h) would not know they also need to update these devstack values. The lack of a comment makes it unclear whether these are arbitrary test values or must track kernel module definitions.\n\n**Recommendation**:\nAdd a comment before the iniset calls, e.g.: \u0027# Guest-visible mdev PCI IDs. mdev config space is not overlaid like the VF path, so the guest sees the raw FAKE_PCI_VENDOR_ID (1d55) / FAKE_PCI_MDEV_DEVICE_ID (2000) from pci-sim/fake_pci_sriov.h.\u0027","commit_id":"08a8dc77821bbd5094fcb50ecc392b5c4d55cd94"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"4e97e203da692e287e17a7907bbfe7727e806ed9","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"},{"line_number":293,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev product_id 2000"},{"line_number":294,"context_line":"    fi"},{"line_number":295,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"e9164e1f_667cf773","line":292,"updated":"2026-07-22 16:43:41.000000000","message":"The new mdev tempest config block hardcodes vendor_id 1d55 and product_id 2000 without an explanatory comment, unlike the adjacent PCI block which includes a detailed comment about its hardcoded IDs.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Future maintainers will need to trace the hardcoded values back to PCI_SIM_VENDOR_ID and FAKE_PCI_MDEV_DEVICE_ID in the kernel module header without guidance, increasing the risk of incorrect updates if IDs change.\n\n**Recommendation**:\nAdd a brief comment above the iniset calls explaining the source of the values, e.g.: \u0027# mdev vendor/device IDs: vendor matches PCI_SIM_VENDOR_ID (0x1d55), device matches FAKE_PCI_MDEV_DEVICE_ID (0x2000) in pci-sim/fake_pci_sriov.h.\u0027","commit_id":"79436935ce16773318e7757d77dede46f529f10d"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"501e25d251546c5df88256e01efe67396aeced63","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"},{"line_number":293,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev product_id 2000"},{"line_number":294,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"edf176c0_089e199c","line":291,"updated":"2026-07-29 12:30:43.000000000","message":"The new cyborg_configure_tempest block references $PCI_SIM_MDEV_TYPE to set tempest\u0027s [cyborg_mdev] mdev_type, but this variable is never defined in devstack/settings, devstack/lib/pci_sim, or any other file in the project. When the function runs, the variable expands to an empty string, so inise...\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: The tempest cyborg_mdev tests will receive an empty mdev_type value in tempest.conf. When Nova/Cyborg tries to create an mdev instance, it cannot determine which mdev type to allocate, causing the mdev lifecycle tests to fail. This defeats the purpose of the patch.\n\n**Priority**: Before merge\n**Why This Matters**: The tempest cyborg_mdev tests will receive an empty mdev_type value in tempest.conf. When Nova/Cyborg tries to create an mdev instance, it cannot determine which mdev type to allocate, causing the mdev lifecycle tests to fail. This defeats the purpose of the patch.\n\n**Recommendation**:\nAdd a default for PCI_SIM_MDEV_TYPE in devstack/settings alongside the other mdev defaults, e.g.: `PCI_SIM_MDEV_TYPE\u003d${PCI_SIM_MDEV_TYPE:-sim_accel_small}`. This matches the kernel module\u0027s sysfs_name for the small accelerator type (fake_pci_sriov_mdev.c:500) and the default used by the pci-sim smoke test scripts.","commit_id":"e8f51f7bddb2c809e0538fefc78aabbbcd5cf76b"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"fbef6896631b64946ce17bba0b3132f3f157c6a8","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"},{"line_number":293,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev product_id 2000"},{"line_number":294,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":27,"id":"4be79aaa_73d96343","line":291,"updated":"2026-07-29 17:34:43.000000000","message":"The new code in cyborg_configure_tempest references $PCI_SIM_MDEV_TYPE to set the tempest cyborg_mdev mdev_type value, but this variable is never defined in devstack/settings or anywhere else in the codebase. All other PCI_SIM_* variables in the same block are defined in devstack/settings with de...\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: The tempest cyborg_mdev mdev_type configuration will be set to an empty string. The mdev lifecycle tests that depend on this config will not know which mdev type to instantiate and will fail or produce incorrect results. This directly undermines the stated goal of the patch.\n\n**Priority**: Before merge\n**Why This Matters**: The tempest cyborg_mdev mdev_type configuration will be set to an empty string. The mdev lifecycle tests that depend on this config will not know which mdev type to instantiate and will fail or produce incorrect results. This directly undermines the stated goal of the patch.\n\n**Recommendation**:\nDefine PCI_SIM_MDEV_TYPE in devstack/settings with a sensible default. The pci-sim kernel module advertises mdev types \u0027fake_pci_sriov_pf-sim_accel_small\u0027 and \u0027fake_pci_sriov_pf-sim_accel_large\u0027. A reasonable default would be: PCI_SIM_MDEV_TYPE\u003d${PCI_SIM_MDEV_TYPE:-fake_pci_sriov_pf-sim_accel_small}","commit_id":"e068d541f0a4c748f42f71f1417795ef4ac5d7a4"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"98710ae0757eb1649177028e95c880b542cd3408","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"},{"line_number":293,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev product_id 2000"},{"line_number":294,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"bc0ab883_b5b32c96","line":291,"updated":"2026-07-29 18:29:45.000000000","message":"The new line at devstack/lib/cyborg:291 references $PCI_SIM_MDEV_TYPE in an iniset call, but this variable is never defined in devstack/settings or anywhere else in the repository. Every other PCI_SIM_* variable used in cyborg_configure_tempest is defined with a default in devstack/settings. PCI_...\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: When PCI_SIM_ENABLE_MDEV\u003dTrue (as set in .zuul.yaml for CI jobs), the tempest config cyborg_mdev/mdev_type will be set to an empty string, causing the mdev driver lifecycle tests to fail or behave incorrectly because they cannot identify the correct mdev type to allocate.\n\n**Priority**: Before merge\n**Why This Matters**: When PCI_SIM_ENABLE_MDEV\u003dTrue (as set in .zuul.yaml for CI jobs), the tempest config cyborg_mdev/mdev_type will be set to an empty string, causing the mdev driver lifecycle tests to fail or behave incorrectly because they cannot identify the correct mdev type to allocate.\n\n**Recommendation**:\nAdd a default for PCI_SIM_MDEV_TYPE in devstack/settings alongside the other mdev defaults, e.g.: PCI_SIM_MDEV_TYPE\u003d${PCI_SIM_MDEV_TYPE:-fake_pci_sriov_pf-sim_accel_small}. The exact value should match the type name the pci-sim kernel module registers under /sys/class/mdev_bus/*/mdev_supported_types/.","commit_id":"9462b3bb382959fcd9f335129a241e26d52bd88e"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"7f60751bc80ba0fc9caee2d798ef7a604f0c6c68","unresolved":true,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"},{"line_number":293,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev product_id 2000"},{"line_number":294,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"cbef2421_87c81a13","line":291,"in_reply_to":"a3fdf5b1_aadb646f","updated":"2026-07-30 11:05:43.000000000","message":"yes, this was originally added to the previous patch in the devstack settings, but got lost during a rebase, I\u0027ve put it back","commit_id":"9462b3bb382959fcd9f335129a241e26d52bd88e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ee9dcc8bfe83869cb4b4569a47f3006ec3fcef6c","unresolved":true,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"},{"line_number":293,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev product_id 2000"},{"line_number":294,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"a3fdf5b1_aadb646f","line":291,"in_reply_to":"bc0ab883_b5b32c96","updated":"2026-07-30 01:50:50.000000000","message":"This seems valid ... because PCI_SIM_MDEV_TYPE isn\u0027t set to anything in the job run, all of the `TestMdevDriverLifecycle` tests are getting skipped.","commit_id":"9462b3bb382959fcd9f335129a241e26d52bd88e"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"8295f911146900d376c476f62312295df23cab8b","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    if [[ \"$PCI_SIM_ENABLE_MDEV\" \u003d\u003d \"True\" ]]; then"},{"line_number":290,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev device_profile_name $PCI_SIM_CYBORG_MDEV_DEVICE_PROFILE_NAME"},{"line_number":291,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev mdev_type $PCI_SIM_MDEV_TYPE"},{"line_number":292,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev vendor_id 1d55"},{"line_number":293,"context_line":"        iniset $TEMPEST_CONFIG cyborg_mdev product_id 2000"},{"line_number":294,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"bfd87a7e_2f487014","line":291,"in_reply_to":"cbef2421_87c81a13","updated":"2026-07-31 13:09:14.000000000","message":"Done","commit_id":"9462b3bb382959fcd9f335129a241e26d52bd88e"}]}