)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8a07763c7d5baeea391d72df49fbd0fa5a7a29df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cd9d6f02_0c613e5f","updated":"2026-07-20 12:55:37.000000000","message":"recheck","commit_id":"87135166f63159d29c9b9249dad58ca75afdd2b9"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"dea1c975d664f5f0c3b5262f0bd4e8677b5b2a05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74c8e7a5_c3551cae","updated":"2026-07-31 12:46:51.000000000","message":"lgtm now, thanks Chandan!","commit_id":"269df51cbb45e555a251b54002285c6270d8b80e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"10180323cb7d3a42448bfa30a1ba8b6dd76f8d9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a7c39087_8adbe70a","updated":"2026-11-04 12:40:31.000000000","message":"check experimental","commit_id":"575dbe9fe52ea850df03caeb0225b6a6ad81be82"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5c7dc6358ff1833b6f3e2d4a84fd6327db2e624e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2447ac13_1706d6e9","updated":"2026-11-03 10:18:13.000000000","message":"recheck","commit_id":"575dbe9fe52ea850df03caeb0225b6a6ad81be82"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9b9d5547b4644babe0d7e68da2526a37a2b8c87b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"41e8b895_87a03131","updated":"2026-11-04 06:30:11.000000000","message":"recheck","commit_id":"575dbe9fe52ea850df03caeb0225b6a6ad81be82"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c58a69adec876f80e185c410beed3df8081f3fda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"917114fb_9a2a487a","updated":"2026-11-03 12:38:05.000000000","message":"recheck","commit_id":"575dbe9fe52ea850df03caeb0225b6a6ad81be82"}],"cyborg/api/controllers/v2/device_profiles.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"88af99180a78c905f8772d695fbbe0676eacbe47","unresolved":true,"context_lines":[{"line_number":207,"context_line":"                # check trait name and it\u0027s value"},{"line_number":208,"context_line":"                if key.startswith(\"trait:\"):"},{"line_number":209,"context_line":"                    inner_origin_trait \u003d \":\".join(key.split(\":\")[1:])"},{"line_number":210,"context_line":"                    inner_trait \u003d inner_origin_trait.strip(\" \")"},{"line_number":211,"context_line":"                    if value not in TRAIT_VALUES:"},{"line_number":212,"context_line":"                        raise exception.InvalidParameterValue("},{"line_number":213,"context_line":"                            err\u003d\"Unsupported trait value %s, the value must\""}],"source_content_type":"text/x-python","patch_set":3,"id":"d015c2a5_b5f8479e","line":210,"updated":"2026-07-21 16:57:58.000000000","message":"I\u0027m thinking that instead of removing the validation altogether it might be more useful to check that hte specified trait is either a custom trait (with the previous code or https://github.com/openstack/os-traits/blob/ca2ea495a38b87bc87de5aaabad5122c8714a263/os_traits/__init__.py#L144) or a standard trait with https://github.com/openstack/os-traits/blob/ca2ea495a38b87bc87de5aaabad5122c8714a263/os_traits/__init__.py#L129","commit_id":"645e85d07c60704b33c78cfa3c921277b7d78991"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"dea1c975d664f5f0c3b5262f0bd4e8677b5b2a05","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                # check trait name and it\u0027s value"},{"line_number":208,"context_line":"                if key.startswith(\"trait:\"):"},{"line_number":209,"context_line":"                    inner_origin_trait \u003d \":\".join(key.split(\":\")[1:])"},{"line_number":210,"context_line":"                    inner_trait \u003d inner_origin_trait.strip(\" \")"},{"line_number":211,"context_line":"                    if value not in TRAIT_VALUES:"},{"line_number":212,"context_line":"                        raise exception.InvalidParameterValue("},{"line_number":213,"context_line":"                            err\u003d\"Unsupported trait value %s, the value must\""}],"source_content_type":"text/x-python","patch_set":3,"id":"2414d38c_05b72d07","line":210,"in_reply_to":"a56de9f3_97b4d935","updated":"2026-07-31 12:46:51.000000000","message":"Done","commit_id":"645e85d07c60704b33c78cfa3c921277b7d78991"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ee8848f10320f4fef5da066f0204d941243d1231","unresolved":true,"context_lines":[{"line_number":207,"context_line":"                # check trait name and it\u0027s value"},{"line_number":208,"context_line":"                if key.startswith(\"trait:\"):"},{"line_number":209,"context_line":"                    inner_origin_trait \u003d \":\".join(key.split(\":\")[1:])"},{"line_number":210,"context_line":"                    inner_trait \u003d inner_origin_trait.strip(\" \")"},{"line_number":211,"context_line":"                    if value not in TRAIT_VALUES:"},{"line_number":212,"context_line":"                        raise exception.InvalidParameterValue("},{"line_number":213,"context_line":"                            err\u003d\"Unsupported trait value %s, the value must\""}],"source_content_type":"text/x-python","patch_set":3,"id":"a56de9f3_97b4d935","line":210,"in_reply_to":"d015c2a5_b5f8479e","updated":"2026-07-22 13:07:23.000000000","message":"+1 to the suggestion. We need to add os-traits as a dependency in the cyborg. os-resources-class is already dependent on os-traits.\n\nI think it is fine to add os-traits as a dependency. Let me update the patch.","commit_id":"645e85d07c60704b33c78cfa3c921277b7d78991"}],"devstack/lib/cyborg":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"9ff691e2b41e6615c45036fd867529164885e330","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        iniset $TEMPEST_CONFIG cyborg_pci product_id 0003"},{"line_number":269,"context_line":"        # The placement test\u0027s device option uses host-side IDs discovered by"},{"line_number":270,"context_line":"        # the Cyborg agent, unlike vendor_id/product_id above (guest IDs)."},{"line_number":271,"context_line":"        iniset $TEMPEST_CONFIG cyborg_pci device 1d55:1001"},{"line_number":272,"context_line":"    fi"},{"line_number":273,"context_line":"}"},{"line_number":274,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"a93534c4_185f5e67","line":271,"updated":"2026-11-13 03:58:32.000000000","message":"devstack/lib/cyborg now writes `cyborg_pci device 1d55:1001` to tempest.conf as a literal. The same host-side identity is defined, and intentionally overridable, in devstack/lib/pci_sim as PCI_SIM_VENDOR_ID (default 0x1d55) and PCI_SIM_VF_DEVICE_ID (default 0x1001), whose header comment already instructs consumers to keep these IDs in sync. Restating the defaults as a literal gives that invariant one more owner that can be edited separately and silently diverge from the devices the sim actually creates.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: If an operator overrides PCI_SIM_VENDOR_ID or PCI_SIM_VF_DEVICE_ID (both supported via env-var defaults), or the sim module IDs change, the tempest device option stops matching the devices the Cyborg agent reports. The new Cyborg-to-Placement test then skips or mismatches in exactly the environments it was added for, without any error pointing at the stale literal.\n\n**Recommendation**:\nDerive the value from the sourced variables instead of hardcoding, e.g. `iniset $TEMPEST_CONFIG cyborg_pci device \"${PCI_SIM_VENDOR_ID#0x}:${PCI_SIM_VF_DEVICE_ID#0x}\"`. devstack/plugin.sh sources lib/pci_sim before cyborg_configure_tempest runs, so the variables are already set in that shell.","commit_id":"67371e80fae0e404ec24125fcd5606710d0a803f"}]}
