)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c125782e3bbb4ae4e5c53cff6755786434ff213","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also adds oslo-db to test-requirements to ensure the opportunistic mysql"},{"line_number":14,"context_line":"mixin can be used and adds a test-setup script to install and configure"},{"line_number":15,"context_line":"a database if absent."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Remove the logging configuration from the allembic env file that would"},{"line_number":18,"context_line":"prevent adding log calls to the test migrations files, following a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f736ed60_8d261a03","line":15,"updated":"2026-07-22 13:38:14.000000000","message":"oslo.db is a runtime dep and should not be duplicated in test-requirments","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24a318c613de7f72ef78b1c82770bd7ae9d514d7","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also adds oslo-db to test-requirements to ensure the opportunistic mysql"},{"line_number":14,"context_line":"mixin can be used and adds a test-setup script to install and configure"},{"line_number":15,"context_line":"a database if absent."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Remove the logging configuration from the allembic env file that would"},{"line_number":18,"context_line":"prevent adding log calls to the test migrations files, following a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fab1552a_d7df88fa","line":15,"in_reply_to":"17ee4632_481138c9","updated":"2026-07-30 12:07:16.000000000","message":"Acknowledged","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9adf14bc624339569ed32c997362f89f52be291a","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also adds oslo-db to test-requirements to ensure the opportunistic mysql"},{"line_number":14,"context_line":"mixin can be used and adds a test-setup script to install and configure"},{"line_number":15,"context_line":"a database if absent."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Remove the logging configuration from the allembic env file that would"},{"line_number":18,"context_line":"prevent adding log calls to the test migrations files, following a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"17ee4632_481138c9","line":15,"in_reply_to":"6a4f4007_696b0e14","updated":"2026-07-29 18:43:12.000000000","message":"i see\n\nhttps://github.com/openstack/oslo.db/blob/master/pyproject.toml#L36-L44\n\nwhile im tempted to update \n\nhttps://github.com/openstack/cyborg/blob/master/requirements.txt#L18 to depend on mysql since that is the only backedn we curently supprot in production\n\nusign test deps is techinaly more correct.\n\nill thinks about it later but we can use test-depensices for now\n\nim debating if we want to supprot somthign like cyborg[mysql] so that you can do this properly end to end eventually","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"a186e865194ab7847e97c4f45b6d21ca8f7f66cc","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also adds oslo-db to test-requirements to ensure the opportunistic mysql"},{"line_number":14,"context_line":"mixin can be used and adds a test-setup script to install and configure"},{"line_number":15,"context_line":"a database if absent."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Remove the logging configuration from the allembic env file that would"},{"line_number":18,"context_line":"prevent adding log calls to the test migrations files, following a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6a4f4007_696b0e14","line":15,"in_reply_to":"f736ed60_8d261a03","updated":"2026-07-22 14:57:38.000000000","message":"I\u0027ve tried removing, but if I do not add the [mysql] bit in test-requirements the tests get skipped since `Backend \u0027mysql+pymysql\u0027 is unavailable: No DBAPI installed`","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a225730575e03afa748a60f3e8e769f8e75b0dc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26364088_87ed3794","updated":"2026-07-21 09:39:15.000000000","message":"+1 to this addition\n\nHere are the logs of https://e986d218df81820a9f57-db749892da1a15bc69477ce2379d5ff9.ssl.cf2.rackcdn.com/openstack/40b84e53c5274450a340a4eb9fdda486/job-output.txt\n```\n2026-07-20 12:45:31.182528 | TASK [test-setup : Run tools/test-setup.sh]\n2026-07-20 12:45:31.593478 | debian-bookworm | + DB_ROOT_PW\u003dinsecure_slave\n2026-07-20 12:45:31.593652 | debian-bookworm | + DB_USER\u003dopenstack_citest\n2026-07-20 12:45:31.593673 | debian-bookworm | + DB_PW\u003dopenstack_citest\n2026-07-20 12:45:31.593691 | debian-bookworm | + is_rhel9\n2026-07-20 12:45:31.593704 | debian-bookworm | + \u0027[\u0027 -f /usr/bin/dnf \u0027]\u0027\n2026-07-20 12:45:31.593717 | debian-bookworm | + is_rhel10\n2026-07-20 12:45:31.593729 | debian-bookworm | + \u0027[\u0027 -f /usr/bin/dnf \u0027]\u0027\n2026-07-20 12:45:31.593766 | debian-bookworm | + sudo -H mysqladmin -u root password insecure_slave\n2026-07-20 12:45:31.608513 | debian-bookworm | + sudo -H mysql -u root -pinsecure_slave -h localhost -e \u0027\n2026-07-20 12:45:31.608549 | debian-bookworm |     DELETE FROM mysql.user WHERE User\u003d\u0027\\\u0027\u0027\u0027\\\u0027\u0027;\n2026-07-20 12:45:31.608567 | debian-bookworm |     FLUSH PRIVILEGES;\n2026-07-20 12:45:31.608580 | debian-bookworm |     CREATE USER \u0027\\\u0027\u0027openstack_citest\u0027\\\u0027\u0027@\u0027\\\u0027\u0027%\u0027\\\u0027\u0027 IDENTIFIED BY \u0027\\\u0027\u0027openstack_citest\u0027\\\u0027\u0027;\n2026-07-20 12:45:31.608593 | debian-bookworm |     GRANT ALL PRIVILEGES ON *.* TO \u0027\\\u0027\u0027openstack_citest\u0027\\\u0027\u0027@\u0027\\\u0027\u0027%\u0027\\\u0027\u0027 WITH GRANT OPTION;\u0027\n2026-07-20 12:45:31.628368 | debian-bookworm | + mysql -u openstack_citest -popenstack_citest -h 127.0.0.1 -e \u0027\n2026-07-20 12:45:31.628395 | debian-bookworm |     SET default_storage_engine\u003dMYISAM;\n2026-07-20 12:45:31.628408 | debian-bookworm |     DROP DATABASE IF EXISTS openstack_citest;\n2026-07-20 12:45:31.628419 | debian-bookworm |     CREATE DATABASE openstack_citest CHARACTER SET utf8;\u0027\n2026-07-20 12:45:31.821482 | debian-bookworm | ok: Runtime: 0:00:00.050620\n```\nand \nFrom openstack-tox-py311\nFollowing migration tests are running:\n```\n  - TestCyborgMigrationsMySQL.test_walk_versions — 2.06s\n  - TestCyborgMigrationsMySQL.test_upgrade_twice — 1.82s\n  - TestCyborgMigrationsMySQL.test_upgrade_and_version — 1.81s\n  - TestCyborgMigrationsMySQL.test_create_schema_and_version — 1.40s\n  - TestCyborgMigrationsMySQL.test_upgrade_and_create_schema — 0.90s\n```","commit_id":"2172644e73b6175b0a72ef5dd5c8f4baaa6cdc57"}],"bindep.txt":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a227b6b30ae4599f268a8f5cdd867cb41c95159f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mysql-devel [platform:rpm !platform:redhat test]"},{"line_number":23,"context_line":"mysql-server [!platform:redhat !platform:debian test]"},{"line_number":24,"context_line":"mariadb-devel [platform:rpm platform:redhat test]"},{"line_number":25,"context_line":"mariadb-server [platform:rpm platform:redhat platform:debian test]"},{"line_number":26,"context_line":"python3-all [platform:dpkg test]"},{"line_number":27,"context_line":"python3-all-dev [platform:dpkg test]"},{"line_number":28,"context_line":"python3 [platform:rpm test]"}],"source_content_type":"text/plain","patch_set":2,"id":"0eb55a1f_1a469feb","line":25,"updated":"2026-07-22 12:04:39.000000000","message":"The mariadb-server entry uses [platform:rpm platform:redhat platform:debian test] where all platform selectors are AND-ed together. Since platform:rpm/platform:redhat (RPM-based Red Hat family) and platform:debian (Debian-based) are mutually exclusive, no system can satisfy all three conditions s...\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: On RHEL/CentOS/Fedora and Debian platforms, no MySQL or MariaDB server package will be installed via bindep. The test-setup.sh script assumes MariaDB is already installed on RHEL (it runs \u0027sudo systemctl restart mariadb.service\u0027), which would fail. On Ubuntu the bug is masked because mysql-server...\n\n**Suggestion**:\nSplit into two separate lines to cover both intended platforms: \u0027mariadb-server [platform:rpm platform:redhat test]\u0027 for RHEL/CentOS/Fedora, and \u0027mariadb-server [platform:debian test]\u0027 for Debian. Alternatively use \u0027mariadb-server [!platform:ubuntu test]\u0027 to cover all non-Ubuntu platforms in one line.","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"f3a6efe08b16ddc6a8557527ab8042c0cdb53fc4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mysql-devel [platform:rpm !platform:redhat test]"},{"line_number":23,"context_line":"mysql-server [!platform:redhat !platform:debian test]"},{"line_number":24,"context_line":"mariadb-devel [platform:rpm platform:redhat test]"},{"line_number":25,"context_line":"mariadb-server [platform:rpm platform:redhat platform:debian test]"},{"line_number":26,"context_line":"python3-all [platform:dpkg test]"},{"line_number":27,"context_line":"python3-all-dev [platform:dpkg test]"},{"line_number":28,"context_line":"python3 [platform:rpm test]"}],"source_content_type":"text/plain","patch_set":3,"id":"95ee14db_6bbb3c51","line":25,"updated":"2026-07-22 15:14:19.000000000","message":"The mariadb-server bindep rule combines platform:rpm, platform:redhat, and platform:debian in a single rule. Since bindep ANDs platform specifiers and no system is simultaneously redhat and debian, this rule never matches on any platform. Combined with mysql-server excluding both redhat and debia...\n\n**Severity**: HIGH | **Confidence**: 0.9\n\n**Risk**: The MySQL migration tests (TestCyborgMigrationsMySQL) will never actually execute in CI because OpportunisticDBTestMixin skips when the database is unavailable. The entire effort to add migration checks is effectively nullified on the standard CI platforms (Ubuntu, CentOS).\n\n**Priority**: Before merge\n**Why This Matters**: The MySQL migration tests (TestCyborgMigrationsMySQL) will never actually execute in CI because OpportunisticDBTestMixin skips when the database is unavailable. The entire effort to add migration checks is effectively nullified on the standard CI platforms (Ubuntu, CentOS).\n\n**Recommendation**:\nSplit the mariadb-server rule into separate lines for each platform family, e.g.: \u0027mariadb-server [platform:rpm platform:redhat test]\u0027 and \u0027mariadb-server [platform:dpkg platform:debian test]\u0027. Alternatively, simplify to \u0027mysql-server [test]\u0027 for all platforms as Nova and other OpenStack projects do.","commit_id":"c5510230f41574f6ab70ec76c907123c731e6bbd"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"74d12b22177a7f73b45fc910f0c3313e2803eb41","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mysql-devel [platform:rpm !platform:redhat test]"},{"line_number":23,"context_line":"mysql-server [!platform:redhat !platform:debian test]"},{"line_number":24,"context_line":"mariadb-devel [platform:rpm platform:redhat test]"},{"line_number":25,"context_line":"mariadb-server [platform:rpm platform:redhat platform:debian test]"},{"line_number":26,"context_line":"python3-all [platform:dpkg test]"},{"line_number":27,"context_line":"python3-all-dev [platform:dpkg test]"},{"line_number":28,"context_line":"python3 [platform:rpm test]"}],"source_content_type":"text/plain","patch_set":4,"id":"b6e6f18e_e67ef8cc","line":25,"updated":"2026-07-29 10:55:49.000000000","message":"The mariadb-server bindep entry uses platform:rpm, platform:redhat, and platform:debian selectors together. In bindep, multiple platform selectors within a rule are AND-ed, requiring all to match simultaneously. Since rpm and debian are mutually exclusive packaging system families, no platform ca...\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: On RHEL/CentOS, the test-setup.sh script calls \u0027sudo systemctl restart mariadb.service\u0027 (line 26) assuming MariaDB is installed. If the CI image does not pre-install MariaDB, the migration tests will fail at setup time. On Debian/Ubuntu, no database server package is installed via bindep either,...\n\n**Suggestion**:\nSplit into separate rules for each platform family. For example: mariadb-server [platform:rpm platform:redhat test] mariadb-server [platform:dpkg platform:debian test] This ensures MariaDB server is installed on both RHEL/CentOS and Debian/Ubuntu when the test profile is active.","commit_id":"102a0a30df8d6d88c7e128504c2c1778b1379ee4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9adf14bc624339569ed32c997362f89f52be291a","unresolved":true,"context_lines":[{"line_number":22,"context_line":"mysql-devel [platform:rpm !platform:redhat test]"},{"line_number":23,"context_line":"mysql-server [!platform:redhat !platform:debian test]"},{"line_number":24,"context_line":"mariadb-devel [platform:rpm platform:redhat test]"},{"line_number":25,"context_line":"mariadb-server [platform:rpm platform:redhat platform:debian test]"},{"line_number":26,"context_line":"python3-all [platform:dpkg test]"},{"line_number":27,"context_line":"python3-all-dev [platform:dpkg test]"},{"line_number":28,"context_line":"python3 [platform:rpm test]"}],"source_content_type":"text/plain","patch_set":5,"id":"e91b07cd_051986fd","line":25,"updated":"2026-07-29 18:43:12.000000000","message":"https://review.opendev.org/c/openstack/nova/+/951749/14/bindep.txt#30\n\nwhiel it does not allign to what nova currently does it todes allign to the rewrite i started a while a go\n\nso yes thsi looks correct","commit_id":"136fc901ddc6ac942f2fa7cd0e46e0ba875f2c97"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24a318c613de7f72ef78b1c82770bd7ae9d514d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mysql-devel [platform:rpm !platform:redhat test]"},{"line_number":23,"context_line":"mysql-server [!platform:redhat !platform:debian test]"},{"line_number":24,"context_line":"mariadb-devel [platform:rpm platform:redhat test]"},{"line_number":25,"context_line":"mariadb-server [platform:rpm platform:redhat platform:debian test]"},{"line_number":26,"context_line":"python3-all [platform:dpkg test]"},{"line_number":27,"context_line":"python3-all-dev [platform:dpkg test]"},{"line_number":28,"context_line":"python3 [platform:rpm test]"}],"source_content_type":"text/plain","patch_set":5,"id":"67d5fde3_a4e2dfb8","line":25,"in_reply_to":"e91b07cd_051986fd","updated":"2026-07-30 12:07:16.000000000","message":"Acknowledged","commit_id":"136fc901ddc6ac942f2fa7cd0e46e0ba875f2c97"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"80168049acef984b11e3dca47512b624f35b540e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"mysql-devel [platform:rpm !platform:redhat test]"},{"line_number":23,"context_line":"mysql-server [!platform:redhat !platform:debian test]"},{"line_number":24,"context_line":"mariadb-devel [platform:rpm platform:redhat test]"},{"line_number":25,"context_line":"mariadb-server [platform:rpm platform:redhat platform:debian test]"},{"line_number":26,"context_line":"python3-all [platform:dpkg test]"},{"line_number":27,"context_line":"python3-all-dev [platform:dpkg test]"},{"line_number":28,"context_line":"python3 [platform:rpm test]"}],"source_content_type":"text/plain","patch_set":6,"id":"f6effa7f_1375ae0e","line":25,"updated":"2026-07-30 11:18:16.000000000","message":"The bindep.txt entry \u0027mariadb-server [platform:rpm platform:redhat platform:debian test]\u0027 combines platform profiles with AND semantics. Since no system can simultaneously belong to the rpm/redhat family and the debian family, this profile condition can never evaluate to true, so mariadb-server w...\n\n**Severity**: HIGH | **Confidence**: 0.8\n\n**Risk**: On Red Hat family systems (RHEL, CentOS, Fedora), mariadb-server is never installed via bindep despite being the intended database backend. On Debian systems, neither mariadb-server nor mysql-server matches (mysql-server is excluded by \u0027!platform:debian\u0027). This means the test-setup.sh script will...\n\n**Priority**: Before merge\n**Why This Matters**: On Red Hat family systems (RHEL, CentOS, Fedora), mariadb-server is never installed via bindep despite being the intended database backend. On Debian systems, neither mariadb-server nor mysql-server matches (mysql-server is excluded by \u0027!platform:debian\u0027). This means the test-setup.sh script will...\n\n**Recommendation**:\nSplit into two separate bindep lines to achieve OR semantics: mariadb-server [platform:rpm platform:redhat test] mariadb-server [platform:debian test] Alternatively, use a broader pattern like: mariadb-server [platform:redhat test] mariadb-server [platform:debian test]","commit_id":"6379808a235aa262a450782d04a1294788e5e593"}],"cyborg/tests/unit/db/test_migrations.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c125782e3bbb4ae4e5c53cff6755786434ff213","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                    engine, alembic_cfg, version.revision, with_data\u003dTrue"},{"line_number":64,"context_line":"                )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _skippable_migrations(self):"},{"line_number":67,"context_line":"        # Some db scripts are not necessary to check"},{"line_number":68,"context_line":"        special \u003d {"},{"line_number":69,"context_line":"            \"f50980397351\","}],"source_content_type":"text/x-python","patch_set":2,"id":"eea668c5_18fbbbb8","line":66,"updated":"2026-07-22 13:38:14.000000000","message":"why if we skip any we should leave a comment for each","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9adf14bc624339569ed32c997362f89f52be291a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                    engine, alembic_cfg, version.revision, with_data\u003dTrue"},{"line_number":64,"context_line":"                )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _skippable_migrations(self):"},{"line_number":67,"context_line":"        # Some db scripts are not necessary to check"},{"line_number":68,"context_line":"        special \u003d {"},{"line_number":69,"context_line":"            \"f50980397351\","}],"source_content_type":"text/x-python","patch_set":2,"id":"05364fa9_6eb5302d","line":66,"in_reply_to":"a15b19ea_514c7c1c","updated":"2026-07-29 18:43:12.000000000","message":"Acknowledged","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"a186e865194ab7847e97c4f45b6d21ca8f7f66cc","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                    engine, alembic_cfg, version.revision, with_data\u003dTrue"},{"line_number":64,"context_line":"                )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _skippable_migrations(self):"},{"line_number":67,"context_line":"        # Some db scripts are not necessary to check"},{"line_number":68,"context_line":"        special \u003d {"},{"line_number":69,"context_line":"            \"f50980397351\","}],"source_content_type":"text/x-python","patch_set":2,"id":"a15b19ea_514c7c1c","line":66,"in_reply_to":"eea668c5_18fbbbb8","updated":"2026-07-22 14:57:38.000000000","message":"some of them could be tested, but a few are placeholders migrations, I\u0027ll add checks for the relevants and mention it in a comment","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"}],"tools/test-setup.sh":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"4ab71d0776736f86f9727446de6d45cb1707467f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        cat /etc/*release | grep -q \u0027release 10\u0027"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"function set_conf_line { # file regex value"},{"line_number":31,"context_line":"    sudo sh -c \"grep -q -e \u0027$2\u0027 $1 \u0026\u0026 \\"},{"line_number":32,"context_line":"            sed -i \u0027s|$2|$3|g\u0027 $1 || \\"},{"line_number":33,"context_line":"            echo \u0027$3\u0027 \u003e\u003e $1\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"0909b4fe_0a068973","line":30,"updated":"2026-07-20 12:57:30.000000000","message":"The set_conf_line function is defined in tools/test-setup.sh but never called anywhere in the script. It appears to have been copied from a standard OpenStack CI template but is not needed for the current MySQL setup flow.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Future maintainers may waste time understanding an unused function or may incorrectly assume it is part of the test setup flow. It adds cognitive overhead with no functional value.\n\n**Recommendation**:\nRemove the set_conf_line function definition (lines 30-34) from tools/test-setup.sh since it is not called anywhere in the script. If it is intended for future use, add a comment explaining the plan, but removing it is cleaner.","commit_id":"2172644e73b6175b0a72ef5dd5c8f4baaa6cdc57"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c125782e3bbb4ae4e5c53cff6755786434ff213","unresolved":true,"context_lines":[{"line_number":15,"context_line":"DB_USER\u003dopenstack_citest"},{"line_number":16,"context_line":"DB_PW\u003dopenstack_citest"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"function is_rhel9 {"},{"line_number":19,"context_line":"    [ -f /usr/bin/dnf ] \u0026\u0026"},{"line_number":20,"context_line":"        cat /etc/*release | grep -q -e \"Red Hat\" -e \"CentOS\" -e \"CloudLinux\" \u0026\u0026"},{"line_number":21,"context_line":"        cat /etc/*release | grep -q \u0027release 9\u0027"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a36e0b0_c1b1f58d","line":18,"updated":"2026-07-22 13:38:14.000000000","message":"dont cargo cult c9s support. our min rhel/centos suport is 10","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"a186e865194ab7847e97c4f45b6d21ca8f7f66cc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"DB_USER\u003dopenstack_citest"},{"line_number":16,"context_line":"DB_PW\u003dopenstack_citest"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"function is_rhel9 {"},{"line_number":19,"context_line":"    [ -f /usr/bin/dnf ] \u0026\u0026"},{"line_number":20,"context_line":"        cat /etc/*release | grep -q -e \"Red Hat\" -e \"CentOS\" -e \"CloudLinux\" \u0026\u0026"},{"line_number":21,"context_line":"        cat /etc/*release | grep -q \u0027release 9\u0027"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4bc6dec8_1fef7309","line":18,"in_reply_to":"3a36e0b0_c1b1f58d","updated":"2026-07-22 14:57:38.000000000","message":"Done","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a227b6b30ae4599f268a8f5cdd867cb41c95159f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        cat /etc/*release | grep -q \u0027release 10\u0027"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"function set_conf_line { # file regex value"},{"line_number":31,"context_line":"    sudo sh -c \"grep -q -e \u0027$2\u0027 $1 \u0026\u0026 \\"},{"line_number":32,"context_line":"            sed -i \u0027s|$2|$3|g\u0027 $1 || \\"},{"line_number":33,"context_line":"            echo \u0027$3\u0027 \u003e\u003e $1\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"88d8760b_aca4c86e","line":30,"updated":"2026-07-22 12:04:39.000000000","message":"The function \u0027set_conf_line\u0027 is defined in test-setup.sh but is never called anywhere in the script. It appears to have been copied from a template (similar to nova\u0027s test-setup.sh) but the function body is not used in this project\u0027s setup flow.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Minor dead code in a CI setup script. No functional impact but adds confusion for future maintainers who may wonder when and how the function is used.\n\n**Recommendation**:\nRemove the unused \u0027set_conf_line\u0027 function (lines 30-34) from the script, or add a comment explaining that it is reserved for future configuration steps.","commit_id":"30cb5241e270e1df8cda04ea115b7af7ee48517b"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"d0ff1b67d40206f5e62b1b223ff2a7ab80c92765","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Now create our database."},{"line_number":41,"context_line":"mysql -u $DB_USER -p$DB_PW -h 127.0.0.1 -e \""},{"line_number":42,"context_line":"    SET default_storage_engine\u003dMYISAM;"},{"line_number":43,"context_line":"    DROP DATABASE IF EXISTS openstack_citest;"},{"line_number":44,"context_line":"    CREATE DATABASE openstack_citest CHARACTER SET utf8;\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"d759dccb_90d6c753","line":42,"updated":"2026-07-29 16:06:27.000000000","message":"The newly added tools/test-setup.sh sets the MySQL default storage engine to MYISAM. Standard OpenStack CI test-setup.sh scripts use InnoDB because MYISAM silently ignores foreign key constraints and does not support transactions. The Cyborg migrations define numerous ForeignKey constraints. Addi...\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: The MYISAM setting is misleading: it suggests the migration tests run under MYISAM when they actually run under InnoDB (the server default). If the intent was to test under MYISAM, the approach does not work due to session scoping. Either way, the line deviates from established OpenStack CI patte...\n\n**Suggestion**:\nChange `SET default_storage_engine\u003dMYISAM;` to `SET default_storage_engine\u003dInnoDB;` to match the standard OpenStack CI test-setup.sh pattern and ensure consistency with the InnoDB engine used in production.","commit_id":"136fc901ddc6ac942f2fa7cd0e46e0ba875f2c97"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24a318c613de7f72ef78b1c82770bd7ae9d514d7","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Now create our database."},{"line_number":41,"context_line":"mysql -u $DB_USER -p$DB_PW -h 127.0.0.1 -e \""},{"line_number":42,"context_line":"    SET default_storage_engine\u003dMYISAM;"},{"line_number":43,"context_line":"    DROP DATABASE IF EXISTS openstack_citest;"},{"line_number":44,"context_line":"    CREATE DATABASE openstack_citest CHARACTER SET utf8;\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"8e21f251_5e8f356d","line":42,"in_reply_to":"5596e77f_124de626","updated":"2026-07-30 12:07:16.000000000","message":"Done","commit_id":"136fc901ddc6ac942f2fa7cd0e46e0ba875f2c97"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"70bbc7101d483f6c512d74bbe654830bf49b162a","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Now create our database."},{"line_number":41,"context_line":"mysql -u $DB_USER -p$DB_PW -h 127.0.0.1 -e \""},{"line_number":42,"context_line":"    SET default_storage_engine\u003dMYISAM;"},{"line_number":43,"context_line":"    DROP DATABASE IF EXISTS openstack_citest;"},{"line_number":44,"context_line":"    CREATE DATABASE openstack_citest CHARACTER SET utf8;\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5596e77f_124de626","line":42,"in_reply_to":"84493106_24b21d97","updated":"2026-07-30 10:12:44.000000000","message":"done, I copied this from the watcher repo, I\u0027ll check there as well","commit_id":"136fc901ddc6ac942f2fa7cd0e46e0ba875f2c97"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9adf14bc624339569ed32c997362f89f52be291a","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Now create our database."},{"line_number":41,"context_line":"mysql -u $DB_USER -p$DB_PW -h 127.0.0.1 -e \""},{"line_number":42,"context_line":"    SET default_storage_engine\u003dMYISAM;"},{"line_number":43,"context_line":"    DROP DATABASE IF EXISTS openstack_citest;"},{"line_number":44,"context_line":"    CREATE DATABASE openstack_citest CHARACTER SET utf8;\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"84493106_24b21d97","line":42,"in_reply_to":"d759dccb_90d6c753","updated":"2026-07-29 18:43:12.000000000","message":"ya we shoudl be useding InnoDB \nMYISAM does not fully supprot transaction so if we dont use InnoDB its not fully refelctive of reality.\n\nnoone woudl use MYISAM for production","commit_id":"136fc901ddc6ac942f2fa7cd0e46e0ba875f2c97"}]}