)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f6e32e1cfdad94e97f8c20cce349cc20488b7cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"498c32e2_c720ed2d","updated":"2026-08-13 08:05:42.000000000","message":"recheck","commit_id":"68d451878cb8a828f7371a0c14f648b8ec50e339"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fc7111567d2130359d489eaedff6243fccf46be0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0f365409_ca82d6ed","updated":"2026-08-14 15:03:48.000000000","message":"this will need to be rebased once https://review.opendev.org/c/openstack/cyborg/+/997047?usp\u003dmerge-conflict merges which should happen today but the content looks correct","commit_id":"68d451878cb8a828f7371a0c14f648b8ec50e339"}],"cyborg/tests/unit/objects/test_device.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"a7985823d63c3300545915cfa5297b6420d0f085","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                self.assertEqual(self.context, device._context)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_device_type(self):"},{"line_number":162,"context_line":"        for t in [\"GPU\", \"FPGA\", \"AICHIP\", \"NVME\"]:"},{"line_number":163,"context_line":"            device \u003d objects.Device(self.context, type\u003dt)"},{"line_number":164,"context_line":"            self.assertEqual(self.context, device._context)"},{"line_number":165,"context_line":"        # Invalid type will raise ValueError"}],"source_content_type":"text/x-python","patch_set":5,"id":"b4fc1ccf_cc4d5768","line":162,"updated":"2026-08-07 05:57:40.000000000","message":"The test_device_type method iterates over a hardcoded list of device types (now including NVME) rather than deriving the list from constants.DEVICE_TYPE. This means QAT, NIC, and SSD remain untested, and future device type additions will silently lack coverage unless manually added to the list.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Three device types (QAT, NIC, SSD) have no validation test coverage in test_device_type. Future device type additions will require manual updates to the test list or they will also lack coverage.\n\n**Recommendation**:\nReplace the hardcoded list with constants.DEVICE_TYPE to iterate over all valid device types automatically. For example: for t in constants.DEVICE_TYPE:. This ensures full coverage and is self-maintaining.","commit_id":"99126ab6ab95e15933e5aa54440eac993d579342"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"8359382f8e3df16ce733345a2bc6ceb567588ca3","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                self.assertEqual(self.context, device._context)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_device_type(self):"},{"line_number":162,"context_line":"        for t in [\"GPU\", \"FPGA\", \"AICHIP\", \"NVME\"]:"},{"line_number":163,"context_line":"            device \u003d objects.Device(self.context, type\u003dt)"},{"line_number":164,"context_line":"            self.assertEqual(self.context, device._context)"},{"line_number":165,"context_line":"        # Invalid type will raise ValueError"}],"source_content_type":"text/x-python","patch_set":6,"id":"cbcb167e_3c9a1953","line":162,"updated":"2026-08-09 04:21:11.000000000","message":"The test_device_type method in test_device.py was modified to add \u0027NVME\u0027 to a hardcoded list of device types, but still omits QAT, NIC, and SSD. Using constants.DEVICE_TYPE would ensure all device types are covered and keep the test in sync with future additions.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: The test validates only 4 of 7 device types. If the Enum in models.py were accidentally changed to drop QAT, NIC, or SSD, the test would not catch it. Using the constants tuple eliminates this risk permanently.\n\n**Recommendation**:\nReplace the hardcoded list with constants.DEVICE_TYPE, e.g.: for t in constants.DEVICE_TYPE:. This ensures all current and future device types are tested without requiring manual updates to the test.","commit_id":"f4b8f14f4e09f5c88da6b76cebc91288d04447d8"}]}