)]}'
{"requirements.txt":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"5100acf05ee0e7c1a75feb92f8727d30223e0abc","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":6,"context_line":"importlib_metadata\u003e\u003d1.7.0;python_version\u003c\u00273.8\u0027 # Apache-2.0"},{"line_number":7,"context_line":"six\u003e\u003d1.10.0 # MIT"},{"line_number":8,"context_line":"wrapt\u003e\u003d1.7.0 # BSD License"}],"source_content_type":"text/plain","patch_set":1,"id":"955632c1_8145a1f8","line":5,"updated":"2021-04-26 14:31:41.000000000","message":"IS it possible to remove pbr from requirements.txt now, or is there some tool that still requires it to be here?\nIt\u0027s still listed in setup.py under setup_requires, and I would have thought that would be sufficient. Notably, osprofiler (whence this patch was copied) never had pbr listed in its requirements.txt.","commit_id":"75487624e771a63b3c43188610e39a2ce701742a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6bbf49a30162ba89e6d68a3ea93ad098591a95db","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":6,"context_line":"importlib_metadata\u003e\u003d1.7.0;python_version\u003c\u00273.8\u0027 # Apache-2.0"},{"line_number":7,"context_line":"six\u003e\u003d1.10.0 # MIT"},{"line_number":8,"context_line":"wrapt\u003e\u003d1.7.0 # BSD License"}],"source_content_type":"text/plain","patch_set":1,"id":"a771c929_12d49ea6","line":5,"in_reply_to":"955632c1_8145a1f8","updated":"2021-04-26 15:02:51.000000000","message":"Reading https://www.python.org/dev/peps/pep-0518/#rationale, I\u0027m not exactly encouraged to proceed with a complete removal of pbr from requirements. At the very least, it may interfere with pip behavior. At the very least, it won\u0027t respect upper-constraints.","commit_id":"75487624e771a63b3c43188610e39a2ce701742a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7cf73e1bd78d142b2f4d9b924ad995c84bfb5825","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":6,"context_line":"importlib_metadata\u003e\u003d1.7.0;python_version\u003c\u00273.8\u0027 # Apache-2.0"},{"line_number":7,"context_line":"six\u003e\u003d1.10.0 # MIT"},{"line_number":8,"context_line":"wrapt\u003e\u003d1.7.0 # BSD License"}],"source_content_type":"text/plain","patch_set":1,"id":"28c620fe_8f7c415a","line":5,"in_reply_to":"a771c929_12d49ea6","updated":"2021-04-26 16:16:57.000000000","message":"My understanding of this is that you only need to specify pbr in \u0027requirements.txt\u0027 if you\u0027re using it at runtime, but to use it during install you must specify it in the \u0027setup_requires\u0027 argument of \u0027setup\u0027 and assume that \u0027setuptools\u0027 is present and will handle this. That would make sense since it is pbr that knows to translate the contents of \u0027requirements.txt\u0027 and \u0027test-requirements.txt\u0027 files to the \u0027install_requires\u0027 and the \u0027extras[\"test\"]\u0027 arguments of the \u0027setup\u0027 call. Without pbr already present, we wouldn\u0027t know even read this file.\n\nSince we\u0027re no longer using pbr in code, I do think we can remove \u0027pbr\u0027 from here. I\u0027ll look at doing so in a follow-up.","commit_id":"75487624e771a63b3c43188610e39a2ce701742a"}]}